Merge pull request #17048 from opf/chore/remove-unused-sys-actions

Remove unused sys actions

app/controllers/sys_controller.rb

@@ -33,46 +33,6 @@ class SysController < ActionController::Base
 
   before_action :check_enabled
   before_action :require_basic_auth, only: [:repo_auth]
-  before_action :find_project, only: [:update_required_storage]
-  before_action :find_repository_with_storage, only: [:update_required_storage]
-
-  def projects
-    p = Project.active.has_module(:repository)
-        .includes(:repository)
-        .references(:repositories)
-        .order(Arel.sql("identifier"))
-    respond_to do |format|
-      format.json do
-        render json: p.to_json(include: :repository)
-      end
-      format.any(:html, :xml) do
-        render xml: p.to_xml(include: :repository), content_type: Mime[:xml]
-      end
-    end
-  end
-
-  def update_required_storage
-    result = update_storage_information(@repository, params[:force] == "1")
-    render plain: "Updated: #{result}", status: :ok
-  end
-
-  def fetch_changesets
-    projects = []
-    if params[:id]
-      projects << Project.active.has_module(:repository).find_by!(identifier: params[:id])
-    else
-      projects = Project.active.has_module(:repository)
-                 .includes(:repository).references(:repositories)
-    end
-    projects.each do |project|
-      if project.repository
-        project.repository.fetch_changesets
-      end
-    end
-    head :ok
-  rescue ActiveRecord::RecordNotFound
-    head :not_found
-  end
 
   def repo_auth
     project = Project.find_by(identifier: params[:repository])
@@ -104,38 +64,9 @@ def check_enabled
     end
   end
 
-  def update_storage_information(repository, force = false)
-    if force
-      ::SCM::StorageUpdaterJob.perform_later(repository)
-      true
-    else
-      repository.update_required_storage
-    end
-  end
-
-  def find_project
-    @project = Project.find(params[:id])
-  rescue ActiveRecord::RecordNotFound
-    render plain: "Could not find project ##{params[:id]}.", status: :not_found
-  end
-
-  def find_repository_with_storage
-    @repository = @project.repository
-
-    if @repository.nil?
-      render plain: "Project ##{@project.id} does not have a repository.", status: :not_found
-    else
-      return true if @repository.scm.storage_available?
-
-      render plain: "repositories.storage.not_available", status: :bad_request
-    end
-
-    false
-  end
-
   def require_basic_auth
     authenticate_with_http_basic do |username, password|
-      @authenticated_user = cached_user_login(username, password)
+      @authenticated_user = user_login(username, password)
       return true if @authenticated_user
     end
 
@@ -147,21 +78,4 @@ def require_basic_auth
   def user_login(username, password)
     User.try_to_login(username, password)
   end
-
-  def cached_user_login(username, password)
-    unless Setting.repository_authentication_caching_enabled?
-      return user_login(username, password)
-    end
-
-    user = nil
-    user_id = Rails.cache.fetch(OpenProject::RepositoryAuthentication::CACHE_PREFIX + Digest::SHA1.hexdigest("#{username}#{password}"),
-                                expires_in: OpenProject::RepositoryAuthentication::CACHE_EXPIRES_AFTER) do
-      user = user_login(username, password)
-      user ? user.id.to_s : "-1"
-    end
-
-    return nil if user_id.blank? or user_id == "-1"
-
-    user || User.find_by(id: user_id.to_i)
-  end
 end

app/views/admin/settings/repositories_settings/show.html.erb

@@ -101,7 +101,6 @@ See COPYRIGHT and LICENSE files for more details.
     </div>
     <div class="form--field"><%= setting_text_field :repository_log_display_limit, size: 6, container_class: '-xslim' %></div>
     <div class="form--field"><%= setting_text_field :repository_truncate_at, size: 6, container_class: '-xslim' %></div>
-    <div class="form--field"><%= setting_check_box :repository_authentication_caching_enabled %></div>
   </section>
   <%= render partial: 'repositories_checkout' %>
   <fieldset class="form--fieldset">

config/constants/settings/definition.rb

@@ -877,9 +877,6 @@ class Definition
         default: nil,
         format: :string
       },
-      repository_authentication_caching_enabled: {
-        default: true
-      },
       repository_checkout_data: {
         default: {
           "git" => { "enabled" => 0 },

config/locales/en.yml

@@ -3419,7 +3419,6 @@ en:
   setting_registration_footer: "Registration footer"
   setting_repositories_automatic_managed_vendor: "Automatic repository vendor type"
   setting_repositories_encodings: "Repositories encodings"
-  setting_repository_authentication_caching_enabled: "Enable caching for authentication request of version control software"
   setting_repository_storage_cache_minutes: "Repository disk size cache"
   setting_repository_checkout_display: "Show checkout instructions"
   setting_repository_checkout_base_url: "Checkout base URL"

config/routes.rb

@@ -695,9 +695,9 @@
 
   scope controller: "sys" do
     match "/sys/repo_auth", action: "repo_auth", via: %i[get post]
-    get "/sys/projects", action: "projects"
-    get "/sys/fetch_changesets", action: "fetch_changesets"
-    get "/sys/projects/:id/repository/update_storage", action: "update_required_storage"
+    match "/sys/projects", to: proc { [410, {}, [""]] }, via: :all
+    match "/sys/fetch_changesets", to: proc { [410, {}, [""]] }, via: :all
+    match "/sys/projects/:id/repository/update_storage", to: proc { [410, {}, [""]] }, via: :all
   end
 
   # alternate routes for the current user

docs/installation-and-operations/configuration/repositories/README.md

@@ -162,10 +162,6 @@ The total required disk space for a project's its repository and attachments are
 
 This information is refreshed in the same manner that changesets are retrieved: By default, the repository is refreshed when a user visits the repository page. This information is cached for the time configured under the global `administration settings → repositories`.
 
-It could also externally be refreshed by using a cron job using the Sys API. Executing a GET against `/sys/projects/:identifier/repository/update_storage` will cause a refresh when the maximum cache time is expired. If you pass the query `?force=1` to the request above, it will ignore the cache.
-
-For a future release, we are hoping to provide a webhook to update changesets and storage immediately after a change has been committed to the repository.
-
 ## Accessing repositories through Apache
 
 With managed repositories, OpenProject takes care of the lifetime of repositories and their association with projects, however we still need to serve the repositories to the client.

modules/backlogs/app/controllers/rb_application_controller.rb

@@ -32,8 +32,6 @@ class RbApplicationController < ApplicationController
 
   before_action :load_sprint_and_project, :check_if_plugin_is_configured, :authorize
 
-  skip_before_action :verify_authenticity_token, if: -> { Rails.env.test? }
-
   # Use special backlogs layout to initialize stimulus side-loading legacy backlogs scripts
   # and CSS from frontend
   layout "backlogs"