+
<% end %>
diff --git a/modules/two_factor_authentication/config/locales/crowdin/cs.yml b/modules/two_factor_authentication/config/locales/crowdin/cs.yml
index 0c74cb1f2ef9..0d4321082095 100644
--- a/modules/two_factor_authentication/config/locales/crowdin/cs.yml
+++ b/modules/two_factor_authentication/config/locales/crowdin/cs.yml
@@ -114,11 +114,11 @@ cs:
is_default_cannot_delete: "Zařízení je označeno jako výchozí a nemůže být odstraněno z důvodu aktivní bezpečnostní politiky. Před smazáním označte jiné zařízení jako výchozí."
not_existing: "Žádné 2FA zařízení nebylo zaregistrováno pro váš účet."
2fa_from_input: Zadejte prosím kód z Vašeho %{device_name} pro ověření Vaší identity.
- 2fa_from_webauthn: Please provide the WebAuthn device
%{device_name}. If it is USB based make sure to plug it in and touch it. Then click the sign in button.
+ 2fa_from_webauthn: Uveďte prosím zařízení WebAuthn
%{device_name}. Pokud je založeno na USB, nezapomeňte jej připojit a dotknout se jej. Poté klikněte na tlačítko Přihlásit se.
webauthn:
title: "WebAuthn"
description: Use Web Authentication to register a FIDO2 device (like a YubiKey) or the secure enclave of your mobile device as a second factor.
- further_steps: After you have chosen a name, you can click the Continue button. Your browser will prompt you to present your WebAuthn device. When you have done so, you are done registering the device.
+ further_steps: Po zvolení jména můžete kliknout na tlačítko Pokračovat. Váš prohlížeč vás vyzve, abyste prezentovali vaše WebAuthn zařízení. Až tak učiníte, jste zařízení zaregistrovali.
totp:
title: "Použít autentifikátor založený na aplikaci"
provisioning_uri: "Poskytování URI"
diff --git a/modules/two_factor_authentication/config/locales/crowdin/js-pt-BR.yml b/modules/two_factor_authentication/config/locales/crowdin/js-pt-BR.yml
index 7d4f33fa04af..372544c095be 100644
--- a/modules/two_factor_authentication/config/locales/crowdin/js-pt-BR.yml
+++ b/modules/two_factor_authentication/config/locales/crowdin/js-pt-BR.yml
@@ -19,7 +19,7 @@
#Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
#See COPYRIGHT and LICENSE files for more details.
#++
-pt:
+pt-BR:
js:
two_factor_authentication:
errors:
diff --git a/modules/two_factor_authentication/config/locales/crowdin/js-pt-PT.yml b/modules/two_factor_authentication/config/locales/crowdin/js-pt-PT.yml
index dbaec2f1af3a..d51a43480f8f 100644
--- a/modules/two_factor_authentication/config/locales/crowdin/js-pt-PT.yml
+++ b/modules/two_factor_authentication/config/locales/crowdin/js-pt-PT.yml
@@ -19,7 +19,7 @@
#Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
#See COPYRIGHT and LICENSE files for more details.
#++
-pt:
+pt-PT:
js:
two_factor_authentication:
errors:
diff --git a/modules/two_factor_authentication/config/locales/crowdin/pt-BR.yml b/modules/two_factor_authentication/config/locales/crowdin/pt-BR.yml
index c3f99ecebd79..684c982be7ec 100644
--- a/modules/two_factor_authentication/config/locales/crowdin/pt-BR.yml
+++ b/modules/two_factor_authentication/config/locales/crowdin/pt-BR.yml
@@ -1,5 +1,5 @@
#English strings go here for Rails i18n
-pt:
+pt-BR:
plugin_openproject_two_factor_authentication:
name: "Autenticação de dois fatores do OpenProject"
description: >-
diff --git a/modules/two_factor_authentication/config/locales/crowdin/pt-PT.yml b/modules/two_factor_authentication/config/locales/crowdin/pt-PT.yml
index ba45743d6f08..0d0e7ba01d25 100644
--- a/modules/two_factor_authentication/config/locales/crowdin/pt-PT.yml
+++ b/modules/two_factor_authentication/config/locales/crowdin/pt-PT.yml
@@ -1,5 +1,5 @@
#English strings go here for Rails i18n
-pt:
+pt-PT:
plugin_openproject_two_factor_authentication:
name: "Autenticação de dois fatores do OpenProject"
description: >-
@@ -76,7 +76,7 @@ pt:
button_register_mobile_phone_for_user: "Registre o celular"
text_2fa_enabled: "Em cada login, este utilizador será solicitado a inserir um token OTP do seu dispositivo padrão 2FA."
text_2fa_disabled: "O utilizador não configurou um dispositivo 2FA através da sua página \"A minha conta\""
- only_sms_allowed: "Only SMS delivery can be set up for other users."
+ only_sms_allowed: "Apenas o envio de SMS pode ser configurado para outros utilizadores."
upsale:
title: "Autenticação de dois fatores"
description: "Reforce a segurança da sua instância do OpenProject ao oferecer (ou reforçar) a autenticação de dois fatores a todos os membros do projeto."
@@ -114,12 +114,12 @@ pt:
failed_to_delete: "Falha ao excluir o dispositivo 2FA."
is_default_cannot_delete: "O dispositivo está marcado como padrão e não pode ser excluído devido a uma política de segurança ativa. Marque outro dispositivo como padrão antes de excluir."
not_existing: "Nenhum dispositivo 2FA foi registrado para sua conta."
- 2fa_from_input: Please enter the code from your
%{device_name} to verify your identity.
- 2fa_from_webauthn: Please provide the WebAuthn device
%{device_name}. If it is USB based make sure to plug it in and touch it. Then click the sign in button.
+ 2fa_from_input: Introduza o código do seu
%{device_name} para verificar a sua identidade.
+ 2fa_from_webauthn: Indique o dispositivo WebAuthn
%{device_name}. Se for baseado em USB, certifique-se de que o liga e toca nele. Em seguida, clique no botão de início de sessão.
webauthn:
title: "WebAuthn"
- description: Use Web Authentication to register a FIDO2 device (like a YubiKey) or the secure enclave of your mobile device as a second factor.
- further_steps: After you have chosen a name, you can click the Continue button. Your browser will prompt you to present your WebAuthn device. When you have done so, you are done registering the device.
+ description: Utilize a Autenticação Web para registar um dispositivo FIDO2 (como uma YubiKey) ou o enclave seguro do seu dispositivo móvel como um segundo fator.
+ further_steps: Depois de ter escolhido um nome, pode clicar no botão Continuar. O seu navegador irá pedir-lhe para apresentar o seu dispositivo WebAuthn. Quando o tiver feito, o registo do dispositivo está concluído.
totp:
title: "Use o seu autenticador baseado em aplicativos"
provisioning_uri: "URI de provisionamento"
diff --git a/modules/webhooks/config/locales/crowdin/pt-BR.yml b/modules/webhooks/config/locales/crowdin/pt-BR.yml
index 71622189a0f3..0a3c5cba4673 100644
--- a/modules/webhooks/config/locales/crowdin/pt-BR.yml
+++ b/modules/webhooks/config/locales/crowdin/pt-BR.yml
@@ -1,4 +1,4 @@
-pt:
+pt-BR:
plugin_openproject_webhooks:
name: "Webhooks do OpenProject"
description: "Fornece uma API de plug-in para dar suporte aos webhooks do OpenProject para uma melhor integração de terceiros."
diff --git a/modules/webhooks/config/locales/crowdin/pt-PT.yml b/modules/webhooks/config/locales/crowdin/pt-PT.yml
index 8bdf94e64dc9..1496aff7e003 100644
--- a/modules/webhooks/config/locales/crowdin/pt-PT.yml
+++ b/modules/webhooks/config/locales/crowdin/pt-PT.yml
@@ -1,4 +1,4 @@
-pt:
+pt-PT:
plugin_openproject_webhooks:
name: "Webhooks do OpenProject"
description: "Fornece uma API de plug-in para suportar webhooks do OpenProject para uma melhor integração de terceiros."
diff --git a/modules/xls_export/config/locales/crowdin/pt-BR.yml b/modules/xls_export/config/locales/crowdin/pt-BR.yml
index c024d4d7edb0..31bcd6d4053b 100644
--- a/modules/xls_export/config/locales/crowdin/pt-BR.yml
+++ b/modules/xls_export/config/locales/crowdin/pt-BR.yml
@@ -1,4 +1,4 @@
-pt:
+pt-BR:
plugin_openproject_xls_export:
name: "Exportação XLS do OpenProject"
description: "Exportar listas de problemas como planilhas Excel (.xls)."
diff --git a/modules/xls_export/config/locales/crowdin/pt-PT.yml b/modules/xls_export/config/locales/crowdin/pt-PT.yml
index b2691b6ba103..440931f9de6d 100644
--- a/modules/xls_export/config/locales/crowdin/pt-PT.yml
+++ b/modules/xls_export/config/locales/crowdin/pt-PT.yml
@@ -1,4 +1,4 @@
-pt:
+pt-PT:
plugin_openproject_xls_export:
name: "Exportação XLS do OpenProject"
description: "Exportar listas de problemas como folhas de cálculo do Excel (.xls)."
diff --git a/modules/xls_export/spec/models/xls_export/project/exporter/xls_integration_spec.rb b/modules/xls_export/spec/models/xls_export/project/exporter/xls_integration_spec.rb
index f62b664a81f5..21a2a620382d 100644
--- a/modules/xls_export/spec/models/xls_export/project/exporter/xls_integration_spec.rb
+++ b/modules/xls_export/spec/models/xls_export/project/exporter/xls_integration_spec.rb
@@ -1,10 +1,10 @@
-require 'spec_helper'
-require 'spreadsheet'
-require 'models/projects/exporter/exportable_project_context'
+require "spec_helper"
+require "spreadsheet"
+require "models/projects/exporter/exportable_project_context"
RSpec.describe XlsExport::Project::Exporter::XLS do
- include_context 'with a project with an arrangement of custom fields'
- include_context 'with an instance of the described exporter'
+ include_context "with a project with an arrangement of custom fields"
+ include_context "with an instance of the described exporter"
let(:sheet) do
io = StringIO.new output
@@ -14,82 +14,126 @@
let(:header) { sheet.rows.first.compact } # raw values have trailing nil
let(:rows) { sheet.rows.drop(1) }
- describe 'empty result' do
+ describe "empty result" do
before do
allow(instance).to receive(:records).and_return([])
end
- it 'returns an empty XLS' do
+ it "returns an empty XLS" do
expect(sheet.rows.count).to eq 1
expect(rows).to be_empty
end
end
- it 'performs a successful export' do
+ it "performs a successful export" do
expect(rows.count).to eq(1)
expect(sheet.row(1)).to eq [project.id.to_s, project.identifier,
- project.name, project.description, 'Off track', 'false']
+ project.name, project.description, "Off track", "false"]
end
- context 'with project description containing html' do
+ context "with project description containing html" do
before do
- project.update(description: "This is an
html
description.")
+ project.update_column(:description, "This is an
html
description.")
end
- it 'performs a successful export' do
+ it "performs a successful export" do
expect(rows.count).to eq(1)
expect(sheet.row(1)).to eq [project.id.to_s, project.identifier, project.name,
- "This is an html description.", 'Off track', 'false']
+ "This is an html description.", "Off track", "false"]
end
end
- context 'with status_explanation enabled' do
- let(:query_columns) { %w[name description project_status status_explanation public ] }
+ context "with status_explanation enabled" do
+ let(:query_columns) { %w[name description project_status status_explanation public] }
- it 'performs a successful export' do
+ it "performs a successful export" do
expect(rows.count).to eq(1)
expect(sheet.row(1)).to eq [project.id.to_s, project.identifier,
project.name, project.description,
- 'Off track', project.status_explanation, 'false']
+ "Off track", project.status_explanation, "false"]
end
end
- describe 'custom field columns selected' do
- let(:query_columns) { %w[name description project_status public] + custom_fields.map(&:column_name) }
- let(:current_user) { build_stubbed(:admin) }
-
- context 'when ee enabled', with_ee: %i[custom_fields_in_projects_list] do
- it 'renders all those columns' do
- cf_names = custom_fields.map(&:name)
- expect(header).to eq ['ID', 'Identifier', 'Name', 'Description', 'Status', 'Public', *cf_names]
-
- custom_values = custom_fields.map do |cf|
- case cf
- when bool_cf
- 'true'
- when text_cf
- project.typed_custom_value_for(cf)
- else
- project.formatted_custom_value_for(cf)
+ describe "custom field columns selected" do
+ let(:query_columns) { %w[name description project_status public] + global_project_custom_fields.map(&:column_name) }
+
+ context "when ee enabled", with_ee: %i[custom_fields_in_projects_list] do
+ before do
+ project # re-evaluate project to ensure it is created within the desired user context
+ end
+
+ context "with admin permission" do
+ let(:current_user) { build_stubbed(:admin) }
+
+ it "renders all those columns" do
+ cf_names = global_project_custom_fields.map(&:name)
+ expect(header).to eq ["ID", "Identifier", "Name", "Description", "Status", "Public", *cf_names]
+
+ expect(header).to include not_used_string_cf.name
+ expect(header).to include hidden_cf.name
+
+ custom_values = global_project_custom_fields.map do |cf|
+ case cf
+ when bool_cf
+ "true"
+ when text_cf
+ project.typed_custom_value_for(cf)
+ when not_used_string_cf
+ nil
+ else
+ project.formatted_custom_value_for(cf)
+ end
end
+
+ expect(sheet.row(1))
+ .to eq [project.id.to_s, project.identifier, project.name, project.description, "Off track", "false",
+ *custom_values]
+
+ # The column for the project-level-disabled custom field is blank
+ expect(sheet.row(1)[header.index(not_used_string_cf.name)]).to be_nil
end
+ end
+
+ context "without admin permission" do
+ it "renders all visible globally available project custom fields in the header" do
+ cf_names = global_project_custom_fields.map(&:name)
+
+ expect(header).to eq ["ID", "Identifier", "Name", "Description", "Status", "Public", *cf_names]
+
+ expect(header).to include not_used_string_cf.name
+ expect(header).not_to include hidden_cf.name
+
+ custom_values = global_project_custom_fields.map do |cf|
+ case cf
+ when bool_cf
+ "true"
+ when text_cf
+ project.typed_custom_value_for(cf)
+ when not_used_string_cf
+ nil
+ else
+ project.formatted_custom_value_for(cf)
+ end
+ end
- expect(sheet.row(1))
- .to eq [project.id.to_s, project.identifier, project.name, project.description, 'Off track', 'false', *custom_values]
+ expect(sheet.row(1))
+ .to eq [project.id.to_s, project.identifier, project.name, project.description, "Off track", "false",
+ *custom_values]
+ end
end
end
- context 'when ee not enabled' do
- it 'renders only the default columns' do
+ context "when ee not enabled" do
+ it "renders only the default columns" do
expect(header).to eq %w[ID Identifier Name Description Status Public]
end
end
end
- context 'with no project visible' do
+ context "with no project visible" do
let(:current_user) { User.anonymous }
- it 'does not include the project' do
+ it "does not include the project" do
expect(output).not_to include project.identifier
expect(rows).to be_empty
end
diff --git a/script/i18n/fix_crowdin_pt_language_root_key b/script/i18n/fix_crowdin_pt_language_root_key
new file mode 100755
index 000000000000..0237262f1427
--- /dev/null
+++ b/script/i18n/fix_crowdin_pt_language_root_key
@@ -0,0 +1,10 @@
+#!/usr/bin/env bash
+
+echo "Fixing language root key in pt-BR and pt-PT crowdin files to match the filename"
+if [ "$(uname -s)" = "Darwin" ]; then
+ sed -i '' 's/^pt:/pt-BR:/' config/locales/crowdin/*pt-BR*.yml modules/*/config/locales/crowdin/*pt-BR*.yml
+ sed -i '' 's/^pt:/pt-PT:/' config/locales/crowdin/*pt-PT*.yml modules/*/config/locales/crowdin/*pt-PT*.yml
+else
+ sed -i 's/^pt:/pt-BR:/' config/locales/crowdin/*pt-BR*.yml modules/*/config/locales/crowdin/*pt-BR*.yml
+ sed -i 's/^pt:/pt-PT:/' config/locales/crowdin/*pt-PT*.yml modules/*/config/locales/crowdin/*pt-PT*.yml
+fi
diff --git a/spec/contracts/custom_fields/create_contract_spec.rb b/spec/contracts/custom_fields/create_contract_spec.rb
index 3717ea3058a0..5516be552501 100644
--- a/spec/contracts/custom_fields/create_contract_spec.rb
+++ b/spec/contracts/custom_fields/create_contract_spec.rb
@@ -32,7 +32,7 @@
RSpec.describe CustomFields::CreateContract do
include_context "ModelContract shared context"
- let(:cf) { build(:project_custom_field) }
+ let(:cf) { build_stubbed(:project_custom_field) }
let(:contract) do
described_class.new(cf, current_user, options: {})
end
diff --git a/spec/contracts/custom_fields/update_contract_spec.rb b/spec/contracts/custom_fields/update_contract_spec.rb
index 66764dfa422f..714019f4c40a 100644
--- a/spec/contracts/custom_fields/update_contract_spec.rb
+++ b/spec/contracts/custom_fields/update_contract_spec.rb
@@ -32,7 +32,7 @@
RSpec.describe CustomFields::UpdateContract do
include_context "ModelContract shared context"
- let(:cf) { build(:project_custom_field) }
+ let(:cf) { build_stubbed(:project_custom_field) }
let(:contract) do
described_class.new(cf, current_user)
end
diff --git a/spec/contracts/settings/working_days_params_contract_spec.rb b/spec/contracts/settings/working_days_params_contract_spec.rb
index 31f2e46ec8bd..ddd60516a286 100644
--- a/spec/contracts/settings/working_days_params_contract_spec.rb
+++ b/spec/contracts/settings/working_days_params_contract_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'contracts/shared/model_contract_shared_context'
+require "spec_helper"
+require "contracts/shared/model_contract_shared_context"
RSpec.describe Settings::WorkingDaysParamsContract do
- include_context 'ModelContract shared context'
+ include_context "ModelContract shared context"
shared_let(:current_user) { create(:admin) }
let(:setting) { Setting }
let(:params) { { working_days: [1] } }
@@ -38,15 +38,15 @@
described_class.new(setting, current_user, params:)
end
- it_behaves_like 'contract is valid for active admins and invalid for regular users'
+ it_behaves_like "contract is valid for active admins and invalid for regular users"
- context 'without working days' do
+ context "without working days" do
let(:params) { { working_days: [] } }
- include_examples 'contract is invalid', base: :working_days_are_missing
+ include_examples "contract is invalid", base: :working_days_are_missing
end
- context 'with an ApplyWorkingDaysChangeJob already existing',
+ context "with an ApplyWorkingDaysChangeJob already existing",
with_good_job: WorkPackages::ApplyWorkingDaysChangeJob do
let(:params) { { working_days: [1, 2, 3] } }
@@ -58,6 +58,6 @@
previous_working_days: [1, 2, 3, 4])
end
- include_examples 'contract is invalid', base: :previous_working_day_changes_unprocessed
+ include_examples "contract is invalid", base: :previous_working_day_changes_unprocessed
end
end
diff --git a/spec/factories/custom_field_factory.rb b/spec/factories/custom_field_factory.rb
index 3ff573672e70..1c4616222b0e 100644
--- a/spec/factories/custom_field_factory.rb
+++ b/spec/factories/custom_field_factory.rb
@@ -33,24 +33,24 @@
# when using traits. They are not meant to be set externally.
_format_name do
[
- multi_value ? 'multi-' : nil,
+ multi_value ? "multi-" : nil,
field_format
].compact.join
end
_type_name { instance.class.name.underscore.humanize(capitalize: false) }
end
sequence(:name) do |n, _e|
- [_format_name, _type_name, n.to_s].join(' ').capitalize
+ [_format_name, _type_name, n.to_s].join(" ").capitalize
end
- regexp { '' }
+ regexp { "" }
is_required { false }
min_length { false }
- default_value { '' }
+ default_value { "" }
max_length { false }
editable { true }
- possible_values { '' }
+ possible_values { "" }
visible { true }
- field_format { 'bool' }
+ field_format { "bool" }
after(:create) do
# As the request store keeps track of the created custom fields
@@ -58,29 +58,29 @@
end
trait :boolean do
- _format_name { 'boolean' }
- field_format { 'bool' }
+ _format_name { "boolean" }
+ field_format { "bool" }
end
trait :string do
- field_format { 'string' }
+ field_format { "string" }
end
trait :text do
- field_format { 'text' }
+ field_format { "text" }
end
trait :integer do
- _format_name { 'integer' }
- field_format { 'int' }
+ _format_name { "integer" }
+ field_format { "int" }
end
trait :float do
- field_format { 'float' }
+ field_format { "float" }
end
trait :date do
- field_format { 'date' }
+ field_format { "date" }
end
trait :list do
@@ -88,9 +88,9 @@
default_option { nil }
default_options { nil }
end
- field_format { 'list' }
+ field_format { "list" }
multi_value { false }
- possible_values { ['A', 'B', 'C', 'D', 'E', 'F', 'G'] }
+ possible_values { ["A", "B", "C", "D", "E", "F", "G"] }
# update custom options default value from the default_option transient
# field for non-multiselect field
@@ -140,24 +140,42 @@
end
trait :version do
- field_format { 'version' }
+ field_format { "version" }
end
trait :multi_version do
- field_format { 'version' }
+ field_format { "version" }
multi_value { true }
end
trait :user do
- field_format { 'user' }
+ field_format { "user" }
end
trait :multi_user do
- field_format { 'user' }
+ field_format { "user" }
multi_value { true }
end
- factory :project_custom_field, class: 'ProjectCustomField' do
+ factory :project_custom_field, class: "ProjectCustomField" do
+ project_custom_field_section
+
+ transient do
+ projects { [] }
+ end
+
+ # enable the the custom_field for the given projects
+ after(:create) do |custom_field, evaluator|
+ projects = Array(evaluator.projects)
+ next if projects.blank?
+
+ projects.each do |project|
+ unless project.project_custom_fields.include?(custom_field)
+ create(:project_custom_field_project_mapping, project:, project_custom_field: custom_field)
+ end
+ end
+ end
+
factory :boolean_project_custom_field, traits: [:boolean]
factory :string_project_custom_field, traits: [:string]
factory :text_project_custom_field, traits: [:text]
@@ -169,12 +187,12 @@
factory :user_project_custom_field, traits: [:user]
end
- factory :user_custom_field, class: 'UserCustomField'
+ factory :user_custom_field, class: "UserCustomField"
- factory :group_custom_field, class: 'GroupCustomField'
+ factory :group_custom_field, class: "GroupCustomField"
- factory :wp_custom_field, class: 'WorkPackageCustomField' do
- _type_name { 'WP custom field' }
+ factory :wp_custom_field, class: "WorkPackageCustomField" do
+ _type_name { "WP custom field" }
is_filter { true }
transient do
@@ -198,16 +216,16 @@
factory :user_wp_custom_field, traits: [:user]
end
- factory :issue_custom_field, class: 'WorkPackageCustomField' do
- _type_name { 'issue custom field' }
+ factory :issue_custom_field, class: "WorkPackageCustomField" do
+ _type_name { "issue custom field" }
end
- factory :time_entry_custom_field, class: 'TimeEntryCustomField' do
- field_format { 'text' }
+ factory :time_entry_custom_field, class: "TimeEntryCustomField" do
+ field_format { "text" }
end
- factory :version_custom_field, class: 'VersionCustomField' do
- field_format { 'text' }
+ factory :version_custom_field, class: "VersionCustomField" do
+ field_format { "text" }
end
end
end
diff --git a/spec/factories/custom_field_section.rb b/spec/factories/custom_field_section.rb
new file mode 100644
index 000000000000..861b2f049d18
--- /dev/null
+++ b/spec/factories/custom_field_section.rb
@@ -0,0 +1,37 @@
+#-- copyright
+# OpenProject is an open source project management software.
+# Copyright (C) 2012-2023 the OpenProject GmbH
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+#
+# See COPYRIGHT and LICENSE files for more details.
+#++
+
+FactoryBot.define do
+ factory :custom_field_section do
+ sequence(:name) { |n| "Section No. #{n}" }
+ created_at { Time.zone.now }
+ updated_at { Time.zone.now }
+
+ factory :project_custom_field_section, class: 'ProjectCustomFieldSection'
+ end
+end
diff --git a/spec/factories/project_custom_field_project_mapping.rb b/spec/factories/project_custom_field_project_mapping.rb
new file mode 100644
index 000000000000..4564b7668d2c
--- /dev/null
+++ b/spec/factories/project_custom_field_project_mapping.rb
@@ -0,0 +1,34 @@
+#-- copyright
+# OpenProject is an open source project management software.
+# Copyright (C) 2012-2023 the OpenProject GmbH
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+#
+# See COPYRIGHT and LICENSE files for more details.
+#++
+
+FactoryBot.define do
+ factory :project_custom_field_project_mapping do
+ project_custom_field
+ project
+ end
+end
diff --git a/spec/features/admin/project_custom_fields/create_spec.rb b/spec/features/admin/project_custom_fields/create_spec.rb
new file mode 100644
index 000000000000..d6229369c93f
--- /dev/null
+++ b/spec/features/admin/project_custom_fields/create_spec.rb
@@ -0,0 +1,122 @@
+#-- copyright
+# OpenProject is an open source project management software.
+# Copyright (C) 2012-2024 the OpenProject GmbH
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+#
+# See COPYRIGHT and LICENSE files for more details.
+#++
+
+require "spec_helper"
+require_relative "shared_context"
+
+RSpec.describe "Create project custom fields", :js do
+ include_context "with seeded project custom fields"
+
+ context "with insufficient permissions" do
+ it "is not accessible" do
+ login_as(non_admin)
+ visit new_admin_settings_project_custom_field_path
+
+ expect(page).to have_text("You are not authorized to access this page.")
+ end
+ end
+
+ context "with sufficient permissions" do
+ before do
+ login_as(admin)
+ visit new_admin_settings_project_custom_field_path
+ end
+
+ it "shows a correct breadcrumb menu" do
+ within "#breadcrumb" do
+ expect(page).to have_link("Administration")
+ expect(page).to have_link("Project attributes")
+ expect(page).to have_text("New attribute")
+ end
+ end
+
+ it "allows to create a new project custom field with an associated section" do
+ # TODO: reuse specs for classic custom field form in order to test for other attribute settings
+ expect(page).to have_css(".PageHeader-title", text: "New attribute")
+
+ fill_in("custom_field_name", with: "New custom field")
+ select(section_for_select_fields.name, from: "custom_field_custom_field_section_id")
+
+ click_on("Save")
+
+ # redirects to the overview page
+ # the tab parameter is set as the redirect originates from the former custom field controller but does not have an effect
+ expect(page).to have_current_path(admin_settings_project_custom_fields_path(tab: "ProjectCustomField"))
+
+ expect(page).to have_text("New custom field")
+
+ latest_custom_field = ProjectCustomField.reorder(created_at: :asc).last
+
+ expect(latest_custom_field.name).to eq("New custom field")
+ expect(latest_custom_field.project_custom_field_section).to eq(section_for_select_fields)
+ end
+
+ it "allows to create a new project custom field with a prefilled section via url param" do
+ visit new_admin_settings_project_custom_field_path(custom_field_section_id: section_for_multi_select_fields.id)
+
+ fill_in("custom_field_name", with: "New custom field")
+
+ click_on("Save")
+
+ # redirects to the overview page
+ # the tab parameter is set as the redirect originates from the former custom field controller but does not have an effect
+ expect(page).to have_current_path(admin_settings_project_custom_fields_path(tab: "ProjectCustomField"))
+
+ latest_custom_field = ProjectCustomField.reorder(created_at: :asc).last
+
+ expect(latest_custom_field.name).to eq("New custom field")
+ expect(latest_custom_field.project_custom_field_section).to eq(section_for_multi_select_fields)
+ end
+
+ it "prevents creating a new project custom field with an empty name" do
+ click_on("Save")
+
+ expect(page).to have_field "custom_field_name", validation_message: "Please fill out this field."
+
+ # expect no redirect
+ expect(page).to have_no_current_path(admin_settings_project_custom_fields_path(tab: "ProjectCustomField"))
+ expect(page).to have_current_path(new_admin_settings_project_custom_field_path)
+ end
+
+ context "without any existing sections" do
+ before do
+ ProjectCustomFieldSection.destroy_all
+ visit new_admin_settings_project_custom_field_path
+ end
+
+ it "prevents creating a new project custom field with an empty name" do
+ fill_in("custom_field_name", with: "New custom field")
+
+ click_on("Save")
+
+ expect(page).to have_field "custom_field_custom_field_section_id",
+ validation_message: "Please select an item in the list."
+ end
+ end
+ end
+end
diff --git a/spec/features/admin/project_custom_fields/edit_spec.rb b/spec/features/admin/project_custom_fields/edit_spec.rb
new file mode 100644
index 000000000000..3ff90c44b8d0
--- /dev/null
+++ b/spec/features/admin/project_custom_fields/edit_spec.rb
@@ -0,0 +1,95 @@
+#-- copyright
+# OpenProject is an open source project management software.
+# Copyright (C) 2012-2024 the OpenProject GmbH
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+#
+# See COPYRIGHT and LICENSE files for more details.
+#++
+
+require "spec_helper"
+require_relative "shared_context"
+
+RSpec.describe "Edit project custom fields", :js do
+ include_context "with seeded project custom fields"
+
+ context "with insufficient permissions" do
+ it "is not accessible" do
+ login_as(non_admin)
+ visit edit_admin_settings_project_custom_field_path(boolean_project_custom_field)
+
+ expect(page).to have_text("You are not authorized to access this page.")
+ end
+ end
+
+ context "with sufficient permissions" do
+ before do
+ login_as(admin)
+ visit edit_admin_settings_project_custom_field_path(boolean_project_custom_field)
+ end
+
+ it "shows a correct breadcrumb menu" do
+ within "#breadcrumb" do
+ expect(page).to have_link("Administration")
+ expect(page).to have_link("Project attributes")
+ expect(page).to have_text(boolean_project_custom_field.name)
+ end
+ end
+
+ it "allows to change basic attributes and the section of the project custom field" do
+ # TODO: reuse specs for classic custom field form in order to test for other attribute manipulations
+ expect(page).to have_css(".PageHeader-title", text: boolean_project_custom_field.name)
+
+ fill_in("custom_field_name", with: "Updated name")
+ select(section_for_select_fields.name, from: "custom_field_custom_field_section_id")
+
+ click_on("Save")
+
+ expect(page).to have_text("Successful update")
+
+ expect(page).to have_css(".PageHeader-title", text: "Updated name")
+
+ expect(boolean_project_custom_field.reload.name).to eq("Updated name")
+ expect(boolean_project_custom_field.reload.project_custom_field_section).to eq(section_for_select_fields)
+
+ within "#breadcrumb" do
+ expect(page).to have_link("Administration")
+ expect(page).to have_link("Project attributes")
+ expect(page).to have_text("Updated name")
+ end
+ end
+
+ it "prevents saving a project custom field with an empty name" do
+ original_name = boolean_project_custom_field.name
+
+ fill_in("custom_field_name", with: "")
+ click_on("Save")
+
+ expect(page).to have_field "custom_field_name", validation_message: "Please fill out this field."
+
+ expect(page).to have_no_text("Successful update")
+
+ expect(page).to have_css(".PageHeader-title", text: original_name)
+ expect(boolean_project_custom_field.reload.name).to eq(original_name)
+ end
+ end
+end
diff --git a/spec/features/admin/project_custom_fields/list_spec.rb b/spec/features/admin/project_custom_fields/list_spec.rb
new file mode 100644
index 000000000000..b01692b6606a
--- /dev/null
+++ b/spec/features/admin/project_custom_fields/list_spec.rb
@@ -0,0 +1,276 @@
+#-- copyright
+# OpenProject is an open source project management software.
+# Copyright (C) 2012-2024 the OpenProject GmbH
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+#
+# See COPYRIGHT and LICENSE files for more details.
+#++
+
+require 'spec_helper'
+require_relative 'shared_context'
+
+RSpec.describe 'List project custom fields', :js do
+ include_context 'with seeded project custom fields'
+
+ context 'with unsufficient permissions' do
+ it 'is not accessible' do
+ login_as(non_admin)
+ visit admin_settings_project_custom_fields_path
+
+ expect(page).to have_text('You are not authorized to access this page.')
+ end
+ end
+
+ context 'with sufficient permissions' do
+ before do
+ login_as(admin)
+ visit admin_settings_project_custom_fields_path
+ end
+
+ it 'shows all sections in the correct order and allows reordering via menu or drag and drop' do
+ containers = page.all('.op-project-custom-field-section-container')
+
+ expect(containers[0].text).to include(section_for_input_fields.name)
+ expect(containers[1].text).to include(section_for_select_fields.name)
+ expect(containers[2].text).to include(section_for_multi_select_fields.name)
+
+ perform_action_for_project_custom_field_section(section_for_multi_select_fields, "Move up")
+
+ visit admin_settings_project_custom_fields_path
+
+ containers = page.all('.op-project-custom-field-section-container')
+
+ expect(containers[0].text).to include(section_for_input_fields.name)
+ expect(containers[1].text).to include(section_for_multi_select_fields.name)
+ expect(containers[2].text).to include(section_for_select_fields.name)
+
+ # TODO: Add drag and drop test
+ end
+
+ it 'allows to delete a section only if no project custom fields are assigned to it' do
+ within_project_custom_field_section_menu(section_for_multi_select_fields) do
+ expect(page).to have_css("button[aria-disabled='true']", text: 'Delete')
+ end
+
+ multi_list_project_custom_field.destroy
+ multi_user_project_custom_field.destroy
+ multi_version_project_custom_field.destroy
+
+ visit admin_settings_project_custom_fields_path
+
+ within_project_custom_field_section_menu(section_for_multi_select_fields) do
+ expect(page).to have_no_css("button[aria-disabled='true']", text: 'Delete')
+ expect(page).to have_button('Delete')
+
+ accept_confirm do
+ click_on('Delete')
+ end
+ end
+
+ expect(page).to have_no_css("[data-qa-selector='project-custom-field-section-container-#{section_for_multi_select_fields.id}']")
+ end
+
+ it 'allows to edit a section' do
+ within_project_custom_field_section_menu(section_for_input_fields) do
+ click_on('Edit title')
+ end
+
+ fill_in('project_custom_field_section_name', with: 'Updated section name')
+
+ click_on('Save')
+
+ expect(page).to have_no_text(section_for_input_fields.name)
+ expect(page).to have_text('Updated section name')
+ end
+
+ it 'allows to create a new section' do
+ within '#settings-project-custom-fields-header-component' do
+ click_on('dialog-show-project-custom-field-section-dialog')
+ end
+
+ fill_in('project_custom_field_section_name', with: 'New section name')
+
+ click_on('Save')
+
+ expect(page).to have_text('New section name')
+
+ containers = page.all('.op-project-custom-field-section-container')
+
+ expect(containers[0].text).to include('New section name')
+ expect(containers[1].text).to include(section_for_input_fields.name)
+ expect(containers[2].text).to include(section_for_select_fields.name)
+ expect(containers[3].text).to include(section_for_multi_select_fields.name)
+ end
+
+ describe 'managing project custom fields' do
+ it 'shows all custom fields in the correct order within their section and allows reordering via menu or drag and drop' do
+ within_project_custom_field_section_container(section_for_input_fields) do
+ containers = page.all('.op-project-custom-field-container')
+
+ expect(containers[0].text).to include(boolean_project_custom_field.name)
+ expect(containers[1].text).to include(string_project_custom_field.name)
+ expect(containers[2].text).to include(integer_project_custom_field.name)
+ expect(containers[3].text).to include(float_project_custom_field.name)
+ expect(containers[4].text).to include(date_project_custom_field.name)
+ expect(containers[5].text).to include(text_project_custom_field.name)
+ end
+
+ within_project_custom_field_section_container(section_for_select_fields) do
+ containers = page.all('.op-project-custom-field-container')
+
+ expect(containers[0].text).to include(list_project_custom_field.name)
+ expect(containers[1].text).to include(version_project_custom_field.name)
+ expect(containers[2].text).to include(user_project_custom_field.name)
+ end
+
+ within_project_custom_field_section_container(section_for_multi_select_fields) do
+ containers = page.all('.op-project-custom-field-container')
+
+ expect(containers[0].text).to include(multi_list_project_custom_field.name)
+ expect(containers[1].text).to include(multi_version_project_custom_field.name)
+ expect(containers[2].text).to include(multi_user_project_custom_field.name)
+ end
+
+ perform_action_for_project_custom_field(multi_user_project_custom_field, "Move up")
+
+ visit admin_settings_project_custom_fields_path
+
+ within_project_custom_field_section_container(section_for_multi_select_fields) do
+ containers = page.all('.op-project-custom-field-container')
+
+ expect(containers[0].text).to include(multi_list_project_custom_field.name)
+ expect(containers[1].text).to include(multi_user_project_custom_field.name)
+ expect(containers[2].text).to include(multi_version_project_custom_field.name)
+ end
+
+ # TODO: Add drag and drop test
+ end
+
+ it 'shows the number of projects using a custom field' do
+ within_project_custom_field_container(boolean_project_custom_field) do
+ expect(page).to have_text('0 Projects')
+ end
+
+ project = create(:project)
+ project.project_custom_fields << boolean_project_custom_field
+
+ visit admin_settings_project_custom_fields_path
+
+ within_project_custom_field_container(boolean_project_custom_field) do
+ expect(page).to have_text('1 Project')
+ end
+ end
+
+ it 'allows to delete a custom field' do
+ within_project_custom_field_menu(boolean_project_custom_field) do
+ accept_confirm do
+ click_on('Delete')
+ end
+ end
+
+ expect(page).to have_no_css("[data-qa-selector='project-custom-field-container-#{boolean_project_custom_field.id}']")
+ end
+
+ it 'redirects to the custom field edit page via menu item' do
+ within_project_custom_field_menu(boolean_project_custom_field) do
+ click_on('Edit')
+ end
+
+ expect(page).to have_current_path(edit_admin_settings_project_custom_field_path(boolean_project_custom_field))
+ end
+
+ it 'redirects to the custom field edit page via click on the name of the custom field' do
+ within_project_custom_field_container(boolean_project_custom_field) do
+ click_on(boolean_project_custom_field.name)
+ end
+
+ expect(page).to have_current_path(edit_admin_settings_project_custom_field_path(boolean_project_custom_field))
+ end
+
+ it 'redirects to the custom field new page via header menu button' do
+ page.find("[data-qa-selector='new-project-custom-field-button']").click
+
+ expect(page).to have_current_path(new_admin_settings_project_custom_field_path(type: 'ProjectCustomField'))
+ end
+
+ it 'redirects to the custom field new page via button in empty sections' do
+ within_project_custom_field_section_container(section_for_multi_select_fields) do
+ expect(page).to have_no_css("[data-qa-selector='new-project-custom-field-button']")
+ end
+
+ multi_list_project_custom_field.destroy
+ multi_user_project_custom_field.destroy
+ multi_version_project_custom_field.destroy
+
+ visit admin_settings_project_custom_fields_path
+
+ within_project_custom_field_section_container(section_for_multi_select_fields) do
+ page.find("[data-qa-selector='new-project-custom-field-button']").click
+ end
+
+ expect(page).to have_current_path(new_admin_settings_project_custom_field_path(
+ type: 'ProjectCustomField',
+ custom_field_section_id: section_for_multi_select_fields.id
+ ))
+ end
+ end
+ end
+
+ # helper methods:
+
+ def within_project_custom_field_section_container(section, &block)
+ within("[data-qa-selector='project-custom-field-section-container-#{section.id}']", &block)
+ end
+
+ def within_project_custom_field_section_menu(section, &block)
+ within_project_custom_field_section_container(section) do
+ page.find("[data-qa-selector='project-custom-field-section-action-menu']").click
+ within('anchored-position', &block)
+ end
+ end
+
+ def perform_action_for_project_custom_field_section(section, action)
+ within_project_custom_field_section_menu(section) do
+ click_on(action)
+ end
+ sleep 0.5 # quick fix: allow the brower to process the action
+ end
+
+ def within_project_custom_field_container(custom_field, &block)
+ within("[data-qa-selector='project-custom-field-container-#{custom_field.id}']", &block)
+ end
+
+ def within_project_custom_field_menu(section, &block)
+ within_project_custom_field_container(section) do
+ page.find("[data-qa-selector='project-custom-field-action-menu']").click
+ within('anchored-position', &block)
+ end
+ end
+
+ def perform_action_for_project_custom_field(custom_field, action)
+ within_project_custom_field_menu(custom_field) do
+ click_on(action)
+ end
+ sleep 0.5 # quick fix: allow the brower to process the action
+ end
+end
diff --git a/spec/features/admin/project_custom_fields/shared_context.rb b/spec/features/admin/project_custom_fields/shared_context.rb
new file mode 100644
index 000000000000..ee6b3faf084b
--- /dev/null
+++ b/spec/features/admin/project_custom_fields/shared_context.rb
@@ -0,0 +1,128 @@
+#-- copyright
+# OpenProject is an open source project management software.
+# Copyright (C) 2012-2023 the OpenProject GmbH
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+#
+# See COPYRIGHT and LICENSE files for more details.
+#++
+
+RSpec.shared_context 'with seeded project custom fields' do
+ shared_let(:admin) { create(:admin) }
+ shared_let(:non_admin) { create(:user) }
+
+ shared_let(:section_for_input_fields) { create(:project_custom_field_section, name: 'Input fields') }
+ shared_let(:section_for_select_fields) { create(:project_custom_field_section, name: 'Select fields') }
+ shared_let(:section_for_multi_select_fields) { create(:project_custom_field_section, name: 'Multi select fields') }
+
+ let!(:boolean_project_custom_field) do
+ create(:boolean_project_custom_field, name: 'Boolean field',
+ project_custom_field_section: section_for_input_fields)
+ end
+
+ let!(:string_project_custom_field) do
+ create(:string_project_custom_field, name: 'String field',
+ project_custom_field_section: section_for_input_fields)
+ end
+
+ let!(:integer_project_custom_field) do
+ create(:integer_project_custom_field, name: 'Integer field',
+ project_custom_field_section: section_for_input_fields)
+ end
+
+ let!(:float_project_custom_field) do
+ create(:float_project_custom_field, name: 'Float field',
+ project_custom_field_section: section_for_input_fields)
+ end
+
+ let!(:date_project_custom_field) do
+ create(:date_project_custom_field, name: 'Date field',
+ project_custom_field_section: section_for_input_fields)
+ end
+
+ let!(:text_project_custom_field) do
+ create(:text_project_custom_field, name: 'Text field',
+ project_custom_field_section: section_for_input_fields)
+ end
+
+ let!(:list_project_custom_field) do
+ create(:list_project_custom_field, name: 'List field',
+ project_custom_field_section: section_for_select_fields,
+ possible_values: ['Option 1', 'Option 2', 'Option 3'])
+ end
+
+ let!(:version_project_custom_field) do
+ create(:version_project_custom_field, name: 'Version field',
+ project_custom_field_section: section_for_select_fields)
+ end
+
+ let!(:user_project_custom_field) do
+ create(:user_project_custom_field, name: 'User field',
+ project_custom_field_section: section_for_select_fields)
+ end
+
+ let!(:multi_list_project_custom_field) do
+ create(:list_project_custom_field, name: 'Multi list field',
+ project_custom_field_section: section_for_multi_select_fields,
+ possible_values: ['Option 1', 'Option 2', 'Option 3'],
+ multi_value: true)
+ end
+
+ let!(:multi_version_project_custom_field) do
+ create(:version_project_custom_field, name: 'Multi version field',
+ project_custom_field_section: section_for_multi_select_fields,
+ multi_value: true)
+ end
+
+ let!(:multi_user_project_custom_field) do
+ create(:user_project_custom_field, name: 'Multi user field',
+ project_custom_field_section: section_for_multi_select_fields,
+ multi_value: true)
+ end
+
+ let!(:input_fields) do
+ [
+ boolean_project_custom_field,
+ string_project_custom_field,
+ integer_project_custom_field,
+ float_project_custom_field,
+ date_project_custom_field,
+ text_project_custom_field
+ ]
+ end
+
+ let!(:select_fields) do
+ [
+ list_project_custom_field,
+ version_project_custom_field,
+ user_project_custom_field
+ ]
+ end
+
+ let!(:multi_select_fields) do
+ [
+ multi_list_project_custom_field,
+ multi_version_project_custom_field,
+ multi_user_project_custom_field
+ ]
+ end
+end
diff --git a/spec/features/custom_fields/custom_fields_spec.rb b/spec/features/custom_fields/custom_fields_spec.rb
index eafa5778e4a8..ee07c28bde2e 100644
--- a/spec/features/custom_fields/custom_fields_spec.rb
+++ b/spec/features/custom_fields/custom_fields_spec.rb
@@ -183,10 +183,6 @@ def expect_page_not_to_have_texts(*text)
end
end
- describe 'projects' do
- it_behaves_like "creating a new custom field", 'Projects'
- end
-
describe 'work packages' do
it_behaves_like "creating a new custom field", 'Work packages'
end
diff --git a/spec/features/members/invitation_spec.rb b/spec/features/members/invitation_spec.rb
index 8a6ac7c17b24..09e8017613f8 100644
--- a/spec/features/members/invitation_spec.rb
+++ b/spec/features/members/invitation_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'invite user via email', :js do
- let!(:project) { create(:project, name: 'Project 1', identifier: 'project1', members: project_members) }
- let!(:developer) { create(:project_role, name: 'Developer') }
+RSpec.describe "invite user via email", :js, :with_cuprite do
+ let!(:project) { create(:project, name: "Project 1", identifier: "project1", members: project_members) }
+ let!(:developer) { create(:project_role, name: "Developer") }
let(:project_members) { {} }
let(:members_page) { Pages::Members.new project.identifier }
@@ -41,7 +41,7 @@
member_with_permissions: { project => %i[view_members manage_members] })
end
- context 'with a new user' do
+ context "with a new user" do
before do
@old_value = Capybara.raise_server_errors
Capybara.raise_server_errors = false
@@ -51,27 +51,27 @@
Capybara.raise_server_errors = @old_value
end
- it 'adds the invited user to the project' do
+ it "adds the invited user to the project" do
members_page.visit!
members_page.open_new_member!
- members_page.search_and_select_principal! 'finkelstein@openproject.com',
- 'Send invite to finkelstein@openproject.com'
- members_page.select_role! 'Developer'
- expect(members_page).to have_selected_new_principal('finkelstein@openproject.com')
+ members_page.search_and_select_principal! "finkelstein@openproject.com",
+ "Send invite to finkelstein@openproject.com"
+ members_page.select_role! "Developer"
+ expect(members_page).to have_selected_new_principal("finkelstein@openproject.com")
- click_on 'Add'
+ click_on "Add"
- expect(members_page).to have_added_user('finkelstein @openproject.com')
+ expect(members_page).to have_added_user("finkelstein @openproject.com")
- expect(members_page).to have_user 'finkelstein @openproject.com'
+ expect(members_page).to have_user "finkelstein @openproject.com"
# Should show the invited user on the default filter as well
members_page.visit!
- expect(members_page).to have_user 'finkelstein @openproject.com'
+ expect(members_page).to have_user "finkelstein @openproject.com"
end
- context 'with an instance with a user limit (regression)' do
+ context "with an instance with a user limit (regression)" do
before do
allow(OpenProject::Enterprise).to receive_messages(
user_limit: 10,
@@ -79,18 +79,18 @@
)
end
- it 'shows a warning when the limit is reached' do
+ it "shows a warning when the limit is reached" do
members_page.visit!
members_page.open_new_member!
- members_page.search_and_select_principal! 'finkelstein@openproject.com',
- 'Send invite to finkelstein@openproject.com'
+ members_page.search_and_select_principal! "finkelstein@openproject.com",
+ "Send invite to finkelstein@openproject.com"
expect(members_page).to have_no_text sanitize_string(I18n.t(:warning_user_limit_reached)),
normalize_ws: true
- members_page.search_and_select_principal! 'frankenstein@openproject.com',
- 'Send invite to frankenstein@openproject.com'
+ members_page.search_and_select_principal! "frankenstein@openproject.com",
+ "Send invite to frankenstein@openproject.com"
expect(members_page).to have_text sanitize_string(I18n.t(:warning_user_limit_reached)),
normalize_ws: true
@@ -98,44 +98,44 @@
end
end
- context 'with a registered user' do
+ context "with a registered user" do
let!(:user) do
- create(:user, mail: 'hugo@openproject.com',
- login: 'hugo@openproject.com',
- firstname: 'Hugo',
- lastname: 'Hurried')
+ create(:user, mail: "hugo@openproject.com",
+ login: "hugo@openproject.com",
+ firstname: "Hugo",
+ lastname: "Hurried")
end
- it 'user lookup by email' do
+ it "user lookup by email" do
members_page.visit!
retry_block do
members_page.open_new_member!
- find_by_id('members_add_form')
+ find_by_id("members_add_form")
end
- members_page.search_and_select_principal! 'hugo@openproject.com',
- 'Hugo Hurried'
- members_page.select_role! 'Developer'
+ members_page.search_and_select_principal! "hugo@openproject.com",
+ "Hugo Hurried"
+ members_page.select_role! "Developer"
- click_on 'Add'
- expect(members_page).to have_added_user 'Hugo Hurried'
+ click_on "Add"
+ expect(members_page).to have_added_user "Hugo Hurried"
end
- context 'who is already a member' do
+ context "who is already a member" do
let(:project_members) { { user => developer } }
- shared_examples 'no user to invite is found' do
- it 'no matches found' do
+ shared_examples "no user to invite is found" do
+ it "no matches found" do
members_page.visit!
members_page.open_new_member!
- members_page.search_principal! 'hugo@openproject.com'
+ members_page.search_principal! "hugo@openproject.com"
expect(members_page).to have_no_search_results
end
end
- it_behaves_like 'no user to invite is found'
+ it_behaves_like "no user to invite is found"
##
# This is a edge case where the email address to be invited is free in principle
@@ -143,13 +143,13 @@
# cannot be used after all as the login is the same as the email address for new users
# which means the login for this invited user will already by taken.
# Accordingly it should not be offered to invite a user with that email address.
- context 'with different email but email as login' do
+ context "with different email but email as login" do
before do
- user.mail = 'foo@bar.de'
+ user.mail = "foo@bar.de"
user.save!
end
- it_behaves_like 'no user to invite is found'
+ it_behaves_like "no user to invite is found"
end
end
end
diff --git a/spec/features/menu_items/admin_menu_item_spec.rb b/spec/features/menu_items/admin_menu_item_spec.rb
index 6067eb2bcb4a..d3e624593564 100644
--- a/spec/features/menu_items/admin_menu_item_spec.rb
+++ b/spec/features/menu_items/admin_menu_item_spec.rb
@@ -45,8 +45,8 @@
context 'without having any menu items hidden in configuration' do
it 'must display all menu items' do
expect(page).to have_test_selector('menu-blocks--container')
- expect(page).to have_test_selector('menu-block', count: 21)
- expect(page).to have_test_selector('op-menu--item-action', count: 22) # All plus 'overview'
+ expect(page).to have_test_selector('menu-block', count: 22)
+ expect(page).to have_test_selector('op-menu--item-action', count: 23) # All plus 'overview'
end
end
@@ -56,10 +56,10 @@
} do
it 'must not display the hidden menu items and blocks' do
expect(page).to have_test_selector('menu-blocks--container')
- expect(page).to have_test_selector('menu-block', count: 20)
+ expect(page).to have_test_selector('menu-block', count: 21)
expect(page).not_to have_test_selector('menu-block', text: I18n.t(:label_color_plural))
- expect(page).to have_test_selector('op-menu--item-action', count: 21) # All plus 'overview'
+ expect(page).to have_test_selector('op-menu--item-action', count: 22) # All plus 'overview'
expect(page).not_to have_test_selector('op-menu--item-action', text: I18n.t(:label_color_plural))
end
end
diff --git a/spec/features/projects/copy_spec.rb b/spec/features/projects/copy_spec.rb
index 4fe5acde4afe..63bc9606f8bb 100644
--- a/spec/features/projects/copy_spec.rb
+++ b/spec/features/projects/copy_spec.rb
@@ -35,7 +35,12 @@
parent: parent_project,
types: active_types,
members: { user => role },
- custom_field_values: { project_custom_field.id => "some text cf" }).tap do |p|
+ # custom_fields which are not used below are not activated for this project
+ custom_field_values: {
+ project_custom_field.id => "some text cf",
+ optional_project_custom_field.id => "some optional text cf",
+ optional_project_custom_field_with_default.id => "foo"
+ }).tap do |p|
p.work_package_custom_fields << wp_custom_field
p.types.first.custom_fields << wp_custom_field
@@ -53,8 +58,15 @@
roles: [role])
project
end
+ let!(:project_custom_field_section) { create(:project_custom_field_section, name: "Section A") }
let!(:project_custom_field) do
- create(:text_project_custom_field, is_required: true)
+ create(:text_project_custom_field, is_required: true, project_custom_field_section:)
+ end
+ let!(:optional_project_custom_field) do
+ create(:text_project_custom_field, is_required: false, project_custom_field_section:)
+ end
+ let!(:optional_project_custom_field_with_default) do
+ create(:text_project_custom_field, is_required: false, default_value: "foo", project_custom_field_section:)
end
let!(:wp_custom_field) do
create(:text_wp_custom_field)
@@ -140,6 +152,203 @@
clear_performed_jobs
end
+ context "with correct project custom field activations" do
+ before do
+ original_settings_page = Pages::Projects::Settings.new(project)
+ original_settings_page.visit!
+
+ find(".toolbar a", text: "Copy").click
+
+ expect(page).to have_text "Copy project \"#{project.name}\""
+
+ fill_in "Name", with: "Copied project"
+ end
+
+ it "enables the same project custom fields as activated on the source project if untouched" do
+ expect(project.project_custom_field_ids).to contain_exactly(
+ project_custom_field.id,
+ optional_project_custom_field.id,
+ optional_project_custom_field_with_default.id
+ )
+
+ click_button "Save"
+
+ wait_for_copy_to_finish
+
+ copied_project = Project.find_by(name: "Copied project")
+
+ expect(copied_project.project_custom_field_ids).to contain_exactly(
+ project_custom_field.id,
+ optional_project_custom_field.id,
+ optional_project_custom_field_with_default.id
+ )
+ end
+
+ it "does not disable optional project custom fields if explicitly set to blank" do
+ # Expand advanced settings
+ click_on "Advanced settings"
+
+ editor = Components::WysiwygEditor.new "[data-qa-field-name='customField#{optional_project_custom_field.id}']"
+ editor.clear
+
+ click_button "Save"
+
+ wait_for_copy_to_finish
+
+ copied_project = Project.find_by(name: "Copied project")
+
+ expect(copied_project.project_custom_field_ids).to contain_exactly(
+ project_custom_field.id,
+ optional_project_custom_field.id,
+ optional_project_custom_field_with_default.id
+ )
+
+ # the optional custom field is activated, but set to blank value
+ expect(copied_project.custom_value_for(optional_project_custom_field).typed_value).to eq("")
+ end
+
+ it "does enable project custom fields if set to blank in source project" do
+ project.update!(custom_field_values: {
+ optional_project_custom_field.id => "",
+ optional_project_custom_field_with_default.id => ""
+ })
+
+ # the optional custom fields are activated, but set to blank values
+ expect(project.project_custom_field_ids).to contain_exactly(
+ project_custom_field.id,
+ optional_project_custom_field.id,
+ optional_project_custom_field_with_default.id
+ )
+
+ original_settings_page = Pages::Projects::Settings.new(project)
+ original_settings_page.visit!
+
+ find(".toolbar a", text: "Copy").click
+
+ expect(page).to have_text "Copy project \"#{project.name}\""
+
+ fill_in "Name", with: "Copied project"
+
+ click_button "Save"
+
+ wait_for_copy_to_finish
+
+ copied_project = Project.find_by(name: "Copied project")
+
+ expect(copied_project.project_custom_field_ids).to contain_exactly(
+ project_custom_field.id,
+ optional_project_custom_field.id,
+ optional_project_custom_field_with_default.id
+ )
+
+ # the optional custom fields are activated, but set to blank values as seen in source project
+ expect(copied_project.custom_value_for(optional_project_custom_field).typed_value).to eq("")
+ expect(copied_project.custom_value_for(optional_project_custom_field_with_default).typed_value).to eq("")
+ end
+
+ context "with project custom fields with default values, which are disabled in source project" do
+ let!(:optional_boolean_project_custom_field_with_default) do
+ create(:boolean_project_custom_field, is_required: false, default_value: true, project_custom_field_section:)
+ end
+ let!(:optional_boolean_project_custom_field_with_no_default) do
+ create(:boolean_project_custom_field, is_required: false, project_custom_field_section:)
+ end
+ let!(:optional_string_project_custom_field_with_default) do
+ create(:string_project_custom_field, is_required: false, default_value: "bar", project_custom_field_section:)
+ end
+
+ it "does not enable optional project custom fields with default values when not enabled in source project" do
+ # the optional boolean and string fields are not activated in the source project
+ expect(project.project_custom_field_ids).to contain_exactly(
+ project_custom_field.id,
+ optional_project_custom_field.id,
+ optional_project_custom_field_with_default.id
+ )
+
+ click_button "Save"
+
+ wait_for_copy_to_finish
+
+ copied_project = Project.find_by(name: "Copied project")
+
+ # the optional boolean and string fields are not activated in the target project, although they have a default value
+ expect(copied_project.project_custom_field_ids).to contain_exactly(
+ project_custom_field.id,
+ optional_project_custom_field.id,
+ optional_project_custom_field_with_default.id
+ )
+ end
+ end
+ end
+
+ context "with correct handling of invisible values" do
+ let!(:invisible_field) do
+ create(:string_project_custom_field, name: "Text for Admins only",
+ visible: false,
+ project_custom_field_section:,
+ projects: [project])
+ end
+ let!(:source_custom_value_for_invisible_field) do
+ create(:custom_value, customized: project, custom_field: invisible_field, value: "foo")
+ end
+
+ before do
+ original_settings_page = Pages::Projects::Settings.new(project)
+ original_settings_page.visit!
+
+ find(".toolbar a", text: "Copy").click
+
+ expect(page).to have_text "Copy project \"#{project.name}\""
+
+ fill_in "Name", with: "Copied project"
+ click_on "Advanced settings"
+ end
+
+ context "with an admin user" do
+ let(:user) { create(:admin) }
+
+ it "shows invisible fields in the form and allows their activation" do
+ expect(page).to have_content "Text for Admins only"
+
+ # don't touch the source value
+
+ click_button "Save"
+
+ wait_for_copy_to_finish
+
+ copied_project = Project.find_by(name: "Copied project")
+
+ expect(copied_project.project_custom_field_ids).to contain_exactly(
+ project_custom_field.id,
+ optional_project_custom_field.id,
+ optional_project_custom_field_with_default.id,
+ invisible_field.id
+ )
+
+ expect(copied_project.custom_value_for(invisible_field).typed_value).to eq("foo")
+ end
+ end
+
+ context "with non-admin user" do
+ it "does not show invisible fields in the form and but still activates them" do
+ expect(page).to have_no_content "Text for Admins only"
+
+ click_button "Save"
+
+ wait_for_copy_to_finish
+
+ copied_project = Project.find_by(name: "Copied project")
+
+ expect(copied_project.project_custom_field_ids).to contain_exactly(
+ project_custom_field.id,
+ optional_project_custom_field.id,
+ optional_project_custom_field_with_default.id,
+ invisible_field.id
+ )
+ end
+ end
+ end
+
it "copies projects and the associated objects" do
original_settings_page = Pages::Projects::Settings.new(project)
original_settings_page.visit!
@@ -159,11 +368,7 @@
click_on "Save"
- expect(page).to have_text "The job has been queued and will be processed shortly."
-
- # ensure all jobs are run especially emails which might be sent later on
- while perform_enqueued_jobs > 0
- end
+ wait_for_copy_to_finish
copied_project = Project.find_by(name: "Copied project")
@@ -300,4 +505,12 @@
wp_table.expect_work_package_order *order
end
end
+
+ def wait_for_copy_to_finish
+ expect(page).to have_text "The job has been queued and will be processed shortly."
+
+ # ensure all jobs are run especially emails which might be sent later on
+ while perform_enqueued_jobs > 0
+ end
+ end
end
diff --git a/spec/features/projects/create_spec.rb b/spec/features/projects/create_spec.rb
index dea5ad1e81ff..286077a6c56f 100644
--- a/spec/features/projects/create_spec.rb
+++ b/spec/features/projects/create_spec.rb
@@ -32,6 +32,7 @@
:js,
:with_cuprite do
shared_let(:name_field) { FormFields::InputFormField.new :name }
+ shared_let(:project_custom_field_section) { create(:project_custom_field_section, name: 'Section A') }
current_user { create(:admin) }
@@ -74,7 +75,9 @@
end
context 'with a multi-select custom field' do
- let!(:list_custom_field) { create(:list_project_custom_field, name: 'List CF', multi_value: true) }
+ let!(:list_custom_field) do
+ create(:list_project_custom_field, name: 'List CF', multi_value: true, project_custom_field_section:)
+ end
let(:list_field) { FormFields::SelectFormField.new list_custom_field }
it 'can create a project' do
@@ -110,15 +113,17 @@
context 'with optional and required custom fields' do
let!(:optional_custom_field) do
- create(:custom_field, name: 'Optional Foo',
- type: ProjectCustomField,
- is_for_all: true)
+ create(:project_custom_field, name: 'Optional Foo',
+ field_format: 'string',
+ is_for_all: true,
+ project_custom_field_section:)
end
let!(:required_custom_field) do
- create(:custom_field, name: 'Required Foo',
- type: ProjectCustomField,
- is_for_all: true,
- is_required: true)
+ create(:project_custom_field, name: 'Required Foo',
+ field_format: 'string',
+ is_for_all: true,
+ is_required: true,
+ project_custom_field_section:)
end
it 'separates optional and required custom fields for new' do
@@ -133,5 +138,256 @@
expect(page).to have_no_text 'Required Foo'
end
end
+
+ context 'with correct validations' do
+ before do
+ visit new_project_path
+ end
+
+ it 'requires the required custom field' do
+ click_on 'Save'
+
+ expect(page).to have_content "Required Foo can't be blank"
+ expect(page).to have_no_content "Optional Foo can't be blank"
+ end
+ end
+
+ context 'with correct custom field activation' do
+ let!(:unused_custom_field) do
+ create(:project_custom_field, name: 'Unused Foo',
+ field_format: 'string',
+ project_custom_field_section:)
+ end
+
+ before do
+ visit new_project_path
+ fill_in 'Name', with: 'Foo bar'
+ fill_in 'Required Foo', with: 'Required value'
+
+ click_on 'Advanced settings'
+ end
+
+ it 'enables custom fields with provided values for this project' do
+ fill_in 'Optional Foo', with: 'Optional value'
+ fill_in 'Unused Foo', with: ''
+
+ click_on 'Save'
+
+ expect(page).to have_current_path /\/projects\/foo-bar\/?/
+
+ project = Project.last
+
+ # unused custom field should not be activated
+ expect(project.project_custom_field_ids).to contain_exactly(
+ optional_custom_field.id, required_custom_field.id
+ )
+ end
+
+ context 'with correct handling of default values' do
+ let!(:custom_field_with_default_value) do
+ create(:project_custom_field, name: 'Foo with default value',
+ field_format: 'string',
+ default_value: 'Default value',
+ project_custom_field_section:)
+ end
+
+ before do
+ visit new_project_path
+ fill_in 'Name', with: 'Foo bar'
+ fill_in 'Required Foo', with: 'Required value'
+
+ click_on 'Advanced settings'
+ end
+
+ it 'enables custom fields with default values if not set to blank explicitly' do
+ # don't touch the default value
+ click_on 'Save'
+
+ expect(page).to have_current_path /\/projects\/foo-bar\/?/
+
+ project = Project.last
+
+ # custom_field_with_default_value should be activated and contain the default value
+ expect(project.project_custom_field_ids).to contain_exactly(
+ custom_field_with_default_value.id, required_custom_field.id
+ )
+
+ expect(project.custom_value_for(custom_field_with_default_value).value).to eq('Default value')
+ end
+
+ it 'does not enable custom fields with default values if set to blank explicitly' do
+ # native blank input does not work with this input, using support class here
+ field = FormFields::InputFormField.new(custom_field_with_default_value)
+ field.set_value("")
+
+ click_on 'Save'
+
+ expect(page).to have_current_path /\/projects\/foo-bar\/?/
+
+ project = Project.last
+
+ # custom_field_with_default_value should not be activated
+ expect(project.project_custom_field_ids).to contain_exactly(
+ required_custom_field.id
+ )
+ end
+
+ it 'does enable custom fields with default values if overwritten with a new value' do
+ fill_in 'Foo with default value', with: 'foo'
+
+ click_on 'Save'
+
+ expect(page).to have_current_path /\/projects\/foo-bar\/?/
+
+ project = Project.last
+
+ # custom_field_with_default_value should be activated and contain the overwritten value
+ expect(project.project_custom_field_ids).to contain_exactly(
+ custom_field_with_default_value.id, required_custom_field.id
+ )
+
+ expect(project.custom_value_for(custom_field_with_default_value).value).to eq('foo')
+ end
+ end
+
+ context 'with correct handling of optional boolean values' do
+ let!(:custom_boolean_field_default_true) do
+ create(:project_custom_field, name: 'Boolean with default true',
+ field_format: 'bool',
+ default_value: true,
+ project_custom_field_section:)
+ end
+
+ let!(:custom_boolean_field_default_false) do
+ create(:project_custom_field, name: 'Boolean with default false',
+ field_format: 'bool',
+ default_value: false,
+ project_custom_field_section:)
+ end
+
+ let!(:custom_boolean_field_with_no_default) do
+ create(:project_custom_field, name: 'Boolean with no default',
+ field_format: 'bool',
+ project_custom_field_section:)
+ end
+
+ before do
+ visit new_project_path
+ fill_in 'Name', with: 'Foo bar'
+ fill_in 'Required Foo', with: 'Required value'
+
+ click_on 'Advanced settings'
+ end
+
+ it 'only enables boolean custom fields with default values if untouched' do
+ # do not touch any of the boolean fields
+ click_on 'Save'
+
+ expect(page).to have_current_path /\/projects\/foo-bar\/?/
+
+ project = Project.last
+
+ expect(project.project_custom_field_ids).to contain_exactly(
+ required_custom_field.id,
+ custom_boolean_field_default_true.id,
+ custom_boolean_field_default_false.id
+ )
+
+ expect(project.custom_value_for(custom_boolean_field_default_true).typed_value).to be_truthy
+ expect(project.custom_value_for(custom_boolean_field_default_false).typed_value).to be_falsy
+ end
+
+ it 'enables boolean custom fields without default values if set to true explicitly' do
+ check 'Boolean with no default'
+
+ click_on 'Save'
+
+ expect(page).to have_current_path /\/projects\/foo-bar\/?/
+
+ project = Project.last
+
+ expect(project.project_custom_field_ids).to contain_exactly(
+ required_custom_field.id,
+ custom_boolean_field_default_true.id,
+ custom_boolean_field_default_false.id,
+ custom_boolean_field_with_no_default.id
+ )
+
+ expect(project.custom_value_for(custom_boolean_field_with_no_default).typed_value).to be_truthy
+ end
+
+ it 'enables boolean custom fields with default values if set to false explicitly' do
+ uncheck 'Boolean with default true'
+
+ click_on 'Save'
+
+ expect(page).to have_current_path /\/projects\/foo-bar\/?/
+
+ project = Project.last
+
+ expect(project.project_custom_field_ids).to contain_exactly(
+ required_custom_field.id,
+ custom_boolean_field_default_true.id,
+ custom_boolean_field_default_false.id
+ )
+
+ expect(project.custom_value_for(custom_boolean_field_default_true).typed_value).to be_falsy
+ end
+ end
+ end
+
+ context 'with correct handling of invisible values' do
+ let!(:invisible_field) do
+ create(:string_project_custom_field, name: 'Text for Admins only',
+ visible: false,
+ project_custom_field_section:)
+ end
+
+ before do
+ visit new_project_path
+ fill_in 'Name', with: 'Foo bar'
+ fill_in 'Required Foo', with: 'Required value'
+
+ click_on 'Advanced settings'
+ end
+
+ context 'with an admin user' do
+ it 'shows invisible fields in the form and allows their activation' do
+ expect(page).to have_content 'Text for Admins only'
+
+ fill_in 'Text for Admins only', with: 'foo'
+
+ click_on 'Save'
+
+ expect(page).to have_current_path /\/projects\/foo-bar\/?/
+
+ project = Project.last
+
+ expect(project.project_custom_field_ids).to contain_exactly(
+ required_custom_field.id, invisible_field.id
+ )
+
+ expect(project.custom_value_for(invisible_field).typed_value).to eq('foo')
+ end
+ end
+
+ context 'with a non-admin user' do
+ current_user { create(:user, global_permissions: %i[add_project]) }
+
+ it 'does not show invisible fields in the form and thus not activates the invisible field' do
+ expect(page).to have_no_content 'Text for Admins only'
+
+ click_on 'Save'
+
+ expect(page).to have_current_path /\/projects\/foo-bar\/?/
+
+ project = Project.last
+
+ expect(project.project_custom_field_ids).to contain_exactly(
+ required_custom_field.id
+ )
+ end
+ end
+ end
end
end
diff --git a/spec/features/projects/edit_settings_spec.rb b/spec/features/projects/edit_settings_spec.rb
index f6be75da0e2b..a30791f83dec 100644
--- a/spec/features/projects/edit_settings_spec.rb
+++ b/spec/features/projects/edit_settings_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Projects', 'editing settings', :js, :with_cuprite do
+RSpec.describe "Projects", "editing settings", :js, :with_cuprite do
let(:name_field) { FormFields::InputFormField.new :name }
let(:parent_field) { FormFields::SelectFormField.new :parent }
let(:permissions) { %i(edit_project) }
@@ -38,170 +38,189 @@
end
shared_let(:project) do
- create(:project, name: 'Foo project', identifier: 'foo-project')
+ create(:project, name: "Foo project", identifier: "foo-project")
end
- it 'hides the field whose functionality is presented otherwise' do
+ it "hides the field whose functionality is presented otherwise" do
visit project_settings_general_path(project.id)
- expect(page).to have_no_text :all, 'Active'
- expect(page).to have_no_text :all, 'Identifier'
+ expect(page).to have_no_text :all, "Active"
+ expect(page).to have_no_text :all, "Identifier"
end
- describe 'identifier edit' do
- it 'updates the project identifier' do
+ describe "identifier edit" do
+ it "updates the project identifier" do
visit projects_path
click_on project.name
- click_on 'Project settings'
- click_on 'Change identifier'
+ click_on "Project settings"
+ click_on "Change identifier"
expect(page).to have_content "Change the project's identifier".upcase
- expect(page).to have_current_path '/projects/foo-project/identifier'
+ expect(page).to have_current_path "/projects/foo-project/identifier"
- fill_in 'project[identifier]', with: 'foo-bar'
- click_on 'Update'
+ fill_in "project[identifier]", with: "foo-bar"
+ click_on "Update"
- expect(page).to have_content 'Successful update.'
+ expect(page).to have_content "Successful update."
expect(page)
.to have_current_path %r{/projects/foo-bar/settings/general}
- expect(Project.first.identifier).to eq 'foo-bar'
+ expect(Project.first.identifier).to eq "foo-bar"
end
- it 'displays error messages on invalid input' do
+ it "displays error messages on invalid input" do
visit project_identifier_path(project)
- fill_in 'project[identifier]', with: 'FOOO'
- click_on 'Update'
+ fill_in "project[identifier]", with: "FOOO"
+ click_on "Update"
- expect(page).to have_content 'Identifier is invalid.'
- expect(page).to have_current_path '/projects/foo-project/identifier'
+ expect(page).to have_content "Identifier is invalid."
+ expect(page).to have_current_path "/projects/foo-project/identifier"
end
end
- context 'with optional and required custom fields' do
+ context "with optional and required custom fields" do
let!(:optional_custom_field) do
- create(:custom_field, name: 'Optional Foo',
- type: ProjectCustomField,
- is_for_all: true)
+ create(:project_custom_field, name: "Optional Foo",
+ is_for_all: true,
+ projects: [project])
end
let!(:required_custom_field) do
- create(:custom_field, name: 'Required Foo',
- type: ProjectCustomField,
- is_for_all: true,
- is_required: true)
+ create(:project_custom_field, name: "Required Foo",
+ is_for_all: true,
+ is_required: true,
+ projects: [project])
end
- it 'shows optional and required custom fields for edit without a separation' do
- project.custom_field_values.last.value = 'FOO'
+ it "shows optional and required custom fields for edit without a separation" do
+ project.custom_field_values.last.value = "FOO"
project.save!
visit project_settings_general_path(project.id)
- expect(page).to have_text 'Optional Foo'
- expect(page).to have_text 'Required Foo'
+ expect(page).to have_text "Optional Foo"
+ expect(page).to have_text "Required Foo"
end
end
- context 'with a length restricted custom field' do
+ context "with a length restricted custom field" do
let!(:required_custom_field) do
create(:string_project_custom_field,
- name: 'Foo',
- type: ProjectCustomField,
+ name: "Foo",
min_length: 1,
max_length: 2,
- is_for_all: true)
+ is_for_all: true,
+ projects: [project])
end
let(:foo_field) { FormFields::InputFormField.new required_custom_field }
- it 'shows the errors of that field when saving (Regression #33766)' do
+ it "shows the errors of that field when saving (Regression #33766)" do
visit project_settings_general_path(project.id)
- expect(page).to have_content 'Foo'
+ expect(page).to have_content "Foo"
# Enter something too long
- foo_field.set_value '1234'
+ foo_field.set_value "1234"
# It should cut of that remaining value
- foo_field.expect_value '12'
+ foo_field.expect_value "12"
- click_button 'Save'
+ click_button "Save"
- expect(page).to have_text 'Successful update.'
+ expect(page).to have_text "Successful update."
end
end
- context 'with a multi-select custom field' do
- include_context 'ng-select-autocomplete helpers'
+ context "with a multi-select custom field" do
+ include_context "ng-select-autocomplete helpers"
- let!(:list_custom_field) { create(:list_project_custom_field, name: 'List CF', multi_value: true) }
+ let!(:list_custom_field) { create(:list_project_custom_field, name: "List CF", multi_value: true, projects: [project]) }
let(:form_field) { FormFields::SelectFormField.new list_custom_field }
- it 'can select multiple values' do
+ it "can select multiple values" do
visit project_settings_general_path(project.id)
- form_field.select_option 'A', 'B'
+ form_field.select_option "A", "B"
- click_on 'Save'
+ click_on "Save"
- expect(page).to have_content 'Successful update.'
+ expect(page).to have_content "Successful update."
- form_field.expect_selected 'A', 'B'
+ form_field.expect_selected "A", "B"
cvs = project.reload.custom_value_for(list_custom_field)
expect(cvs.count).to eq 2
- expect(cvs.map(&:typed_value)).to contain_exactly 'A', 'B'
+ expect(cvs.map(&:typed_value)).to contain_exactly "A", "B"
end
end
- context 'with a date custom field' do
- let!(:date_custom_field) { create(:date_project_custom_field, name: 'Date') }
+ context "with a date custom field" do
+ let!(:date_custom_field) { create(:date_project_custom_field, name: "Date", projects: [project]) }
let(:form_field) { FormFields::InputFormField.new date_custom_field }
- it 'can save and remove the date (Regression #37459)' do
+ it "can save and remove the date (Regression #37459)" do
visit project_settings_general_path(project.id)
- form_field.set_value '2021-05-26'
+ form_field.set_value "2021-05-26"
form_field.send_keys :enter
- click_on 'Save'
+ click_on "Save"
- expect(page).to have_content 'Successful update.'
+ expect(page).to have_content "Successful update."
- form_field.expect_value '2021-05-26'
+ form_field.expect_value "2021-05-26"
cv = project.reload.custom_value_for(date_custom_field)
- expect(cv.typed_value).to eq '2021-05-26'.to_date
+ expect(cv.typed_value).to eq "2021-05-26".to_date
end
end
- context 'with a user not allowed to see the parent project' do
- include_context 'ng-select-autocomplete helpers'
+ context "with a user not allowed to see the parent project" do
+ include_context "ng-select-autocomplete helpers"
let(:parent_project) { create(:project) }
- let(:parent_field) { FormFields::SelectFormField.new 'parent' }
+ let(:parent_field) { FormFields::SelectFormField.new "parent" }
before do
project.update_attribute(:parent, parent_project)
end
- it 'can update the project without destroying the relation to the parent' do
+ it "can update the project without destroying the relation to the parent" do
visit project_settings_general_path(project.id)
- fill_in 'Name', with: 'New project name'
+ fill_in "Name", with: "New project name"
- parent_field.expect_selected I18n.t(:'api_v3.undisclosed.parent')
+ parent_field.expect_selected I18n.t(:"api_v3.undisclosed.parent")
- click_on 'Save'
+ click_on "Save"
- expect(page).to have_content 'Successful update.'
+ expect(page).to have_content "Successful update."
project.reload
expect(project.name)
- .to eql 'New project name'
+ .to eql "New project name"
expect(project.parent)
.to eql parent_project
end
end
+
+ context "with correct scoping of project custom fields" do
+ let!(:optional_custom_field_activated_in_project) do
+ create(:project_custom_field, name: "Optional Foo",
+ is_for_all: true,
+ projects: [project])
+ end
+ let!(:optional_custom_field_not_activated_in_project) do
+ create(:project_custom_field, name: "Optional Bar",
+ is_for_all: true)
+ end
+
+ it "shows only the custom fields that are activated in the project" do
+ visit project_settings_general_path(project.id)
+
+ expect(page).to have_text "Optional Foo"
+ expect(page).to have_no_text "Optional Bar"
+ end
+ end
end
diff --git a/spec/features/projects/project_custom_fields/overview_page/dialog/inputs_spec.rb b/spec/features/projects/project_custom_fields/overview_page/dialog/inputs_spec.rb
new file mode 100644
index 000000000000..0d4b5f53637d
--- /dev/null
+++ b/spec/features/projects/project_custom_fields/overview_page/dialog/inputs_spec.rb
@@ -0,0 +1,681 @@
+#-- copyright
+# OpenProject is an open source project management software.
+# Copyright (C) 2012-2023 the OpenProject GmbH
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+#
+# See COPYRIGHT and LICENSE files for more details.
+#++
+
+require "spec_helper"
+require_relative "../shared_context"
+
+RSpec.describe "Edit project custom fields on project overview page", :js do
+ include_context "with seeded projects, members and project custom fields"
+
+ let(:overview_page) { Pages::Projects::Show.new(project) }
+
+ before do
+ login_as member_with_project_edit_permissions
+ overview_page.visit_page
+ end
+
+ describe "with correct initialization and input behaviour" do
+ describe "with input fields" do
+ let(:section) { section_for_input_fields }
+ let(:dialog) { Components::Projects::ProjectCustomFields::EditDialog.new(project, section) }
+
+ shared_examples "a custom field checkbox" do
+ it "shows the correct value if given" do
+ overview_page.open_edit_dialog_for_section(section)
+
+ dialog.within_async_content(close_after_yield: true) do
+ if expected_initial_value
+ expect(page).to have_checked_field(custom_field.name)
+ else
+ expect(page).to have_no_checked_field(custom_field.name)
+ end
+ end
+ end
+
+ it "is unchecked if no value and no default value is given" do
+ custom_field.custom_values.destroy_all
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ dialog.within_async_content(close_after_yield: true) do
+ expect(page).to have_no_checked_field(custom_field.name)
+ end
+ end
+
+ it "shows default value if no value is given" do
+ custom_field.custom_values.destroy_all
+
+ custom_field.update!(default_value: true)
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ dialog.within_async_content(close_after_yield: true) do
+ expect(page).to have_checked_field(custom_field.name)
+ end
+
+ custom_field.update!(default_value: false)
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ dialog.within_async_content(close_after_yield: true) do
+ expect(page).to have_no_checked_field(custom_field.name)
+ end
+ end
+ end
+
+ shared_examples "a custom field input" do
+ it "shows the correct value if given" do
+ overview_page.open_edit_dialog_for_section(section)
+
+ dialog.within_async_content(close_after_yield: true) do
+ expect(page).to have_field(custom_field.name, with: expected_initial_value)
+ end
+ end
+
+ it "shows a blank input if no value or default value is given" do
+ custom_field.custom_values.destroy_all
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ dialog.within_async_content(close_after_yield: true) do
+ expect(page).to have_field(custom_field.name, with: expected_blank_value)
+ end
+ end
+
+ it "shows the default value if no value is given" do
+ custom_field.custom_values.destroy_all
+ custom_field.update!(default_value:)
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ dialog.within_async_content(close_after_yield: true) do
+ expect(page).to have_field(custom_field.name, with: default_value)
+ end
+ end
+ end
+
+ shared_examples "a rich text custom field input" do
+ it "shows the correct value if given" do
+ overview_page.open_edit_dialog_for_section(section)
+
+ dialog.within_async_content(close_after_yield: true) do
+ field.expect_value(expected_initial_value)
+ end
+ end
+
+ it "shows a blank input if no value or default value is given" do
+ custom_field.custom_values.destroy_all
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ dialog.within_async_content(close_after_yield: true) do
+ field.expect_value(expected_blank_value)
+ end
+ end
+
+ it "shows the default value if no value is given" do
+ custom_field.custom_values.destroy_all
+ custom_field.update!(default_value:)
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ dialog.within_async_content(close_after_yield: true) do
+ field.expect_value(default_value)
+ end
+ end
+ end
+
+ describe "with boolean CF" do
+ let(:custom_field) { boolean_project_custom_field }
+ let(:expected_initial_value) { true }
+
+ it_behaves_like "a custom field checkbox"
+ end
+
+ describe "with string CF" do
+ let(:custom_field) { string_project_custom_field }
+ let(:default_value) { "Default value" }
+ let(:expected_blank_value) { "" }
+ let(:expected_initial_value) { "Foo" }
+
+ it_behaves_like "a custom field input"
+ end
+
+ describe "with integer CF" do
+ let(:custom_field) { integer_project_custom_field }
+ let(:default_value) { 789 }
+ let(:expected_blank_value) { "" }
+ let(:expected_initial_value) { 123 }
+
+ it_behaves_like "a custom field input"
+ end
+
+ describe "with float CF" do
+ let(:custom_field) { float_project_custom_field }
+ let(:default_value) { 789.123 }
+ let(:expected_blank_value) { "" }
+ let(:expected_initial_value) { 123.456 }
+
+ it_behaves_like "a custom field input"
+ end
+
+ describe "with date CF" do
+ let(:custom_field) { date_project_custom_field }
+ let(:default_value) { Date.new(2026, 1, 1) }
+ let(:expected_blank_value) { "" }
+ let(:expected_initial_value) { Date.new(2024, 1, 1) }
+
+ it_behaves_like "a custom field input"
+ end
+
+ describe "with text CF" do
+ let(:custom_field) { text_project_custom_field }
+ let(:field) { FormFields::Primerized::EditorFormField.new(custom_field) }
+ let(:default_value) { "Default value" }
+ let(:expected_blank_value) { "" }
+ let(:expected_initial_value) { "Lorem\nipsum" } # TBD: why is the second newline missing?
+
+ it_behaves_like "a rich text custom field input"
+ end
+ end
+
+ describe "with single select fields" do
+ let(:section) { section_for_select_fields }
+ let(:dialog) { Components::Projects::ProjectCustomFields::EditDialog.new(project, section) }
+
+ shared_examples "a autocomplete single select field" do
+ it "shows the correct value if given" do
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.expect_selected(expected_initial_value)
+ end
+
+ it "shows a blank input if no value or default value is given" do
+ custom_field.custom_values.destroy_all
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.expect_blank
+ end
+
+ it "filters the list based on the input" do
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.search(second_option)
+
+ field.expect_option(second_option)
+ field.expect_no_option(first_option)
+ field.expect_no_option(third_option)
+ end
+
+ it "enables the user to select a single value from a list" do
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.search(second_option)
+ field.select_option(second_option)
+
+ field.expect_selected(second_option)
+
+ field.search(third_option)
+ field.select_option(third_option)
+
+ field.expect_selected(third_option)
+ field.expect_not_selected(second_option)
+ end
+
+ it "clears the input if clicked on the clear button" do
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.clear
+
+ field.expect_blank
+ end
+ end
+
+ describe "with single select list CF" do
+ let(:custom_field) { list_project_custom_field }
+ let(:field) { FormFields::Primerized::AutocompleteField.new(custom_field) }
+
+ let(:expected_initial_value) { custom_field.custom_options.first.value }
+
+ let(:first_option) { custom_field.custom_options.first.value }
+ let(:second_option) { custom_field.custom_options.second.value }
+ let(:third_option) { custom_field.custom_options.third.value }
+
+ it_behaves_like "a autocomplete single select field"
+
+ it "shows the default value if no value is given" do
+ custom_field.custom_values.destroy_all
+
+ custom_field.custom_options.first.update!(default_value: true)
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.expect_selected(custom_field.custom_options.first.value)
+ end
+ end
+
+ describe "with single version select list CF" do
+ let(:custom_field) { version_project_custom_field }
+ let(:field) { FormFields::Primerized::AutocompleteField.new(custom_field) }
+
+ let(:expected_initial_value) { first_version.name }
+
+ let(:first_option) { first_version.name }
+ let(:second_option) { second_version.name }
+ let(:third_option) { third_version.name }
+
+ it_behaves_like "a autocomplete single select field"
+
+ describe "with correct version scoping" do
+ context "with a version on a different project" do
+ let!(:version_in_other_project) do
+ create(:version, name: "Version 1 in other project", project: other_project)
+ end
+
+ it "shows only versions that are associated with this project" do
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.search("Version 1")
+
+ field.expect_option(first_version.name)
+ field.expect_no_option(version_in_other_project.name)
+ end
+ end
+
+ context "with a closed version" do
+ let!(:closed_version) { create(:version, name: "Closed version", project:, status: "closed") }
+
+ before do
+ custom_field.update(allow_non_open_versions:)
+ end
+
+ context "when non-open versions are not allowed" do
+ let(:allow_non_open_versions) { false }
+
+ it "does not shows closed version option" do
+ overview_page.open_edit_dialog_for_section(section)
+ field.open_options
+
+ field.expect_option(first_version.name)
+ field.expect_no_option(closed_version.name)
+ end
+ end
+
+ context "when non-open versions are allowed" do
+ let(:allow_non_open_versions) { true }
+
+ it "shows closed version option" do
+ overview_page.open_edit_dialog_for_section(section)
+ field.open_options
+
+ field.expect_option(first_version.name)
+ field.expect_option(closed_version.name)
+ end
+ end
+ end
+ end
+ end
+
+ describe "with single user select list CF" do
+ let(:custom_field) { user_project_custom_field }
+ let(:field) { FormFields::Primerized::AutocompleteField.new(custom_field) }
+
+ let(:expected_initial_value) { member_in_project.name }
+
+ let(:first_option) { member_in_project.name }
+ let(:second_option) { another_member_in_project.name }
+ let(:third_option) { one_more_member_in_project.name }
+
+ it_behaves_like "a autocomplete single select field"
+
+ describe "with correct user scoping" do
+ let!(:member_in_other_project) do
+ create(:user,
+ firstname: "Member 1",
+ lastname: "In other Project",
+ member_with_roles: { other_project => reader_role })
+ end
+
+ it "shows only users that are members of the project" do
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.search("Member 1")
+
+ field.expect_option(member_in_project.name)
+ field.expect_no_option(member_in_other_project.name)
+ end
+ end
+
+ describe "with support for user groups" do
+ let!(:member_in_other_project) do
+ create(:user,
+ firstname: "Member 1",
+ lastname: "In other Project",
+ member_with_roles: { other_project => reader_role })
+ end
+ let!(:group) do
+ create(:group, name: "Group 1 in project",
+ member_with_roles: { project => reader_role })
+ end
+ let!(:group_in_other_project) do
+ create(:group, name: "Group 1 in other project", members: [member_in_other_project],
+ member_with_roles: { other_project => reader_role })
+ end
+
+ it "shows only groups that are associated with this project" do
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.search("Group 1")
+
+ field.expect_option(group.name)
+ field.expect_no_option(group_in_other_project.name)
+ end
+ end
+
+ describe "with support for placeholder users" do
+ let!(:placeholder_user) do
+ create(:placeholder_user, name: "Placeholder User",
+ member_with_roles: { project => reader_role })
+ end
+
+ it "shows the placeholder user" do
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.search("Placeholder User")
+
+ field.expect_option(placeholder_user.name)
+ end
+ end
+ end
+ end
+
+ describe "with multi select fields" do
+ let(:section) { section_for_multi_select_fields }
+ let(:dialog) { Components::Projects::ProjectCustomFields::EditDialog.new(project, section) }
+
+ shared_examples "a autocomplete multi select field" do
+ it "shows the correct value if given" do
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.expect_selected(*expected_initial_value)
+ end
+
+ it "shows a blank input if no value or default value is given" do
+ custom_field.custom_values.destroy_all
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.expect_blank
+ end
+
+ it "filters the list based on the input" do
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.search(second_option)
+
+ field.expect_option(second_option)
+ field.expect_no_option(first_option)
+ field.expect_no_option(third_option)
+ end
+
+ it "allows to select multiple values" do
+ custom_field.custom_values.destroy_all
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.select_option(second_option)
+ field.select_option(third_option)
+
+ field.expect_selected(second_option)
+ field.expect_selected(third_option)
+ end
+
+ it "allows to remove selected values" do
+ custom_field.custom_values.destroy_all
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.select_option(second_option)
+ field.select_option(third_option)
+
+ field.deselect_option(third_option)
+
+ field.expect_selected(second_option)
+ field.expect_not_selected(third_option)
+ end
+
+ it "allows to remove all selected values at once" do
+ custom_field.custom_values.destroy_all
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.select_option(second_option)
+ field.select_option(third_option)
+
+ field.clear
+
+ field.expect_not_selected(second_option)
+ field.expect_not_selected(third_option)
+ end
+ end
+
+ describe "with multi select list CF" do
+ let(:custom_field) { multi_list_project_custom_field }
+ let(:field) { FormFields::Primerized::AutocompleteField.new(custom_field) }
+
+ let(:expected_initial_value) { [custom_field.custom_options.first.value, custom_field.custom_options.second.value] }
+
+ let(:first_option) { custom_field.custom_options.first.value }
+ let(:second_option) { custom_field.custom_options.second.value }
+ let(:third_option) { custom_field.custom_options.third.value }
+
+ it_behaves_like "a autocomplete multi select field"
+
+ it "shows the default value if no value is given" do
+ multi_list_project_custom_field.custom_values.destroy_all
+
+ multi_list_project_custom_field.custom_options.first.update!(default_value: true)
+ multi_list_project_custom_field.custom_options.second.update!(default_value: true)
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.expect_selected(multi_list_project_custom_field.custom_options.first.value)
+ field.expect_selected(multi_list_project_custom_field.custom_options.second.value)
+ end
+ end
+
+ describe "with multi version select list CF" do
+ let(:custom_field) { multi_version_project_custom_field }
+ let(:field) { FormFields::Primerized::AutocompleteField.new(custom_field) }
+
+ let(:expected_initial_value) { [first_version.name, second_version.name] }
+
+ let(:first_option) { first_version.name }
+ let(:second_option) { second_version.name }
+ let(:third_option) { third_version.name }
+
+ it_behaves_like "a autocomplete multi select field"
+
+ describe "with correct version scoping" do
+ context "with a version on a different project" do
+ let!(:version_in_other_project) do
+ create(:version, name: "Version 1 in other project", project: other_project)
+ end
+
+ it "shows only versions that are associated with this project" do
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.search("Version 1")
+
+ field.expect_option(first_version.name)
+ field.expect_no_option(version_in_other_project.name)
+ end
+ end
+
+ context "with a closed version" do
+ let!(:closed_version) { create(:version, name: "Closed version", project:, status: "closed") }
+
+ before do
+ custom_field.update(allow_non_open_versions:)
+ end
+
+ context "when non-open versions are not allowed" do
+ let(:allow_non_open_versions) { false }
+
+ it "does not shows closed version option" do
+ overview_page.open_edit_dialog_for_section(section)
+ field.open_options
+
+ field.expect_option(first_version.name)
+ field.expect_no_option(closed_version.name)
+ end
+ end
+
+ context "when non-open versions are allowed" do
+ let(:allow_non_open_versions) { true }
+
+ it "shows closed version option" do
+ overview_page.open_edit_dialog_for_section(section)
+ field.open_options
+
+ field.expect_option(first_version.name)
+ field.expect_option(closed_version.name)
+ end
+ end
+ end
+ end
+ end
+
+ describe "with multi user select list CF" do
+ let(:custom_field) { multi_user_project_custom_field }
+ let(:field) { FormFields::Primerized::AutocompleteField.new(custom_field) }
+
+ let(:expected_initial_value) { [member_in_project.name, another_member_in_project.name] }
+
+ let(:first_option) { member_in_project.name }
+ let(:second_option) { another_member_in_project.name }
+ let(:third_option) { one_more_member_in_project.name }
+
+ it_behaves_like "a autocomplete multi select field"
+
+ describe "with correct user scoping" do
+ let!(:member_in_other_project) do
+ create(:user,
+ firstname: "Member 1",
+ lastname: "In other Project",
+ member_with_roles: { other_project => reader_role })
+ end
+
+ it "shows only users that are members of the project" do
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.search("Member 1")
+
+ field.expect_option(member_in_project.name)
+ field.expect_no_option(member_in_other_project.name)
+ end
+ end
+
+ describe "with support for user groups" do
+ let!(:member_in_other_project) do
+ create(:user,
+ firstname: "Member 1",
+ lastname: "In other Project",
+ member_with_roles: { other_project => reader_role })
+ end
+ let!(:group) do
+ create(:group, name: "Group 1 in project",
+ member_with_roles: { project => reader_role })
+ end
+ let!(:another_group) do
+ create(:group, name: "Group 2 in project",
+ member_with_roles: { project => reader_role })
+ end
+ let!(:group_in_other_project) do
+ create(:group, name: "Group 1 in other project", members: [member_in_other_project],
+ member_with_roles: { other_project => reader_role })
+ end
+
+ it "shows only groups that are associated with this project" do
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.search("Group 1")
+ field.expect_option(group.name)
+ field.expect_no_option(group_in_other_project.name)
+ end
+
+ it "enables to select multiple user groups" do
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.select_option("Group 1 in project")
+ field.select_option("Group 2 in project")
+
+ field.expect_selected("Group 1 in project")
+ field.expect_selected("Group 2 in project")
+ end
+ end
+
+ describe "with support for placeholder users" do
+ let!(:placeholder_user) do
+ create(:placeholder_user, name: "Placeholder user",
+ member_with_roles: { project => reader_role })
+ end
+ let!(:another_placeholder_user) do
+ create(:placeholder_user, name: "Another placeholder User",
+ member_with_roles: { project => reader_role })
+ end
+ let!(:placeholder_user_in_other_project) do
+ create(:placeholder_user, name: "Placeholder user in other project",
+ member_with_roles: { other_project => reader_role })
+ end
+
+ it "shows only placeholder users from this project" do
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.search("Placeholder User")
+
+ field.expect_option(placeholder_user.name)
+ field.expect_option(another_placeholder_user.name)
+ field.expect_no_option(placeholder_user_in_other_project.name)
+ end
+
+ it "enables to select multiple placeholder users" do
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.select_option(placeholder_user.name)
+ field.select_option(another_placeholder_user.name)
+
+ field.expect_selected(placeholder_user.name)
+ field.expect_selected(another_placeholder_user.name)
+ end
+ end
+ end
+ end
+ end
+end
diff --git a/spec/features/projects/project_custom_fields/overview_page/dialog/permission_spec.rb b/spec/features/projects/project_custom_fields/overview_page/dialog/permission_spec.rb
new file mode 100644
index 000000000000..60c7414eaf94
--- /dev/null
+++ b/spec/features/projects/project_custom_fields/overview_page/dialog/permission_spec.rb
@@ -0,0 +1,65 @@
+#-- copyright
+# OpenProject is an open source project management software.
+# Copyright (C) 2012-2023 the OpenProject GmbH
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+#
+# See COPYRIGHT and LICENSE files for more details.
+#++
+
+require 'spec_helper'
+require_relative '../shared_context'
+
+RSpec.describe 'Edit project custom fields on project overview page', :js do
+ include_context 'with seeded projects, members and project custom fields'
+
+ let(:overview_page) { Pages::Projects::Show.new(project) }
+
+ describe 'with insufficient permissions' do
+ # turboframe sidebar request is covered by a controller spec checking for 403
+ # async dialog content request is be covered by a controller spec checking for 403
+ # via spec/permissions/manage_project_custom_values_spec.rb
+ before do
+ login_as member_without_project_edit_permissions
+ overview_page.visit_page
+ end
+
+ it 'does not show the edit buttons' do
+ overview_page.within_async_loaded_sidebar do
+ expect(page).to have_no_css("[data-qa-selector='project-custom-field-section-edit-button']")
+ end
+ end
+ end
+
+ describe 'with sufficient permissions' do
+ before do
+ login_as member_with_project_edit_permissions
+ overview_page.visit_page
+ end
+
+ it 'shows the edit buttons' do
+ overview_page.within_async_loaded_sidebar do
+ expect(page).to have_css("[data-qa-selector='project-custom-field-section-edit-button']", count: 3)
+ end
+ end
+ end
+end
diff --git a/spec/features/projects/project_custom_fields/overview_page/dialog/render_spec.rb b/spec/features/projects/project_custom_fields/overview_page/dialog/render_spec.rb
new file mode 100644
index 000000000000..8bf00e23429c
--- /dev/null
+++ b/spec/features/projects/project_custom_fields/overview_page/dialog/render_spec.rb
@@ -0,0 +1,196 @@
+#-- copyright
+# OpenProject is an open source project management software.
+# Copyright (C) 2012-2023 the OpenProject GmbH
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+#
+# See COPYRIGHT and LICENSE files for more details.
+#++
+
+require 'spec_helper'
+require_relative '../shared_context'
+
+RSpec.describe 'Edit project custom fields on project overview page', :js do
+ include_context 'with seeded projects, members and project custom fields'
+
+ let(:overview_page) { Pages::Projects::Show.new(project) }
+ let(:dialog) { Components::Projects::ProjectCustomFields::EditDialog.new(project, section_for_input_fields) }
+
+ before do
+ login_as member_with_project_edit_permissions
+ overview_page.visit_page
+ end
+
+ it 'opens a dialog showing inputs for project custom fields of a specific section' do
+ overview_page.open_edit_dialog_for_section(section_for_input_fields)
+
+ dialog.expect_open
+ end
+
+ it 'renders the dialog body asynchronically' do
+ expect(page).to have_no_css(dialog.async_content_container_css_selector, visible: :all)
+
+ overview_page.open_edit_dialog_for_section(section_for_input_fields)
+
+ expect(page).to have_css(dialog.async_content_container_css_selector, visible: :visible)
+ end
+
+ it 'can be closed via close icon or cancel button' do
+ overview_page.open_edit_dialog_for_section(section_for_input_fields)
+
+ dialog.close_via_icon
+
+ dialog.expect_closed
+
+ overview_page.open_edit_dialog_for_section(section_for_input_fields)
+
+ dialog.close_via_button
+
+ dialog.expect_closed
+ end
+
+ it 'shows only the project custom fields of the specific section within the dialog' do
+ overview_page.open_edit_dialog_for_section(section_for_input_fields)
+
+ dialog.within_async_content(close_after_yield: true) do
+ (input_fields + select_fields + multi_select_fields).each do |project_custom_field|
+ if input_fields.include?(project_custom_field)
+ expect(page).to have_content(project_custom_field.name)
+ else
+ expect(page).to have_no_content(project_custom_field.name)
+ end
+ end
+ end
+
+ dialog = Components::Projects::ProjectCustomFields::EditDialog.new(project, section_for_select_fields)
+
+ overview_page.open_edit_dialog_for_section(section_for_select_fields)
+
+ dialog.within_async_content(close_after_yield: true) do
+ (input_fields + select_fields + multi_select_fields).each do |project_custom_field|
+ if select_fields.include?(project_custom_field)
+ expect(page).to have_content(project_custom_field.name)
+ else
+ expect(page).to have_no_content(project_custom_field.name)
+ end
+ end
+ end
+
+ dialog = Components::Projects::ProjectCustomFields::EditDialog.new(project, section_for_multi_select_fields)
+
+ overview_page.open_edit_dialog_for_section(section_for_multi_select_fields)
+
+ dialog.within_async_content(close_after_yield: true) do
+ (input_fields + select_fields + multi_select_fields).each do |project_custom_field|
+ if multi_select_fields.include?(project_custom_field)
+ expect(page).to have_content(project_custom_field.name)
+ else
+ expect(page).to have_no_content(project_custom_field.name)
+ end
+ end
+ end
+ end
+
+ it 'shows the inputs in the correct order defined by the position of project custom field in a section' do
+ overview_page.open_edit_dialog_for_section(section_for_input_fields)
+
+ dialog.within_async_content(close_after_yield: true) do
+ containers = dialog.input_containers
+
+ expect(containers[0].text).to include('Boolean field')
+ expect(containers[1].text).to include('String field')
+ expect(containers[2].text).to include('Integer field')
+ expect(containers[3].text).to include('Float field')
+ expect(containers[4].text).to include('Date field')
+ expect(containers[5].text).to include('Text field')
+ end
+
+ boolean_project_custom_field.move_to_bottom
+
+ overview_page.open_edit_dialog_for_section(section_for_input_fields)
+
+ dialog.within_async_content(close_after_yield: true) do
+ containers = dialog.input_containers
+
+ expect(containers[0].text).to include('String field')
+ expect(containers[1].text).to include('Integer field')
+ expect(containers[2].text).to include('Float field')
+ expect(containers[3].text).to include('Date field')
+ expect(containers[4].text).to include('Text field')
+ expect(containers[5].text).to include('Boolean field')
+ end
+ end
+
+ context 'with visibility of project custom fields' do
+ let!(:section_with_invisible_fields) { create(:project_custom_field_section, name: 'Section with invisible fields') }
+
+ let!(:visible_project_custom_field) do
+ create(:project_custom_field,
+ name: 'Normal field',
+ visible: true,
+ projects: [project],
+ project_custom_field_section: section_with_invisible_fields)
+ end
+
+ let!(:invisible_project_custom_field) do
+ create(:project_custom_field,
+ name: 'Admin only field',
+ visible: false,
+ projects: [project],
+ project_custom_field_section: section_with_invisible_fields)
+ end
+
+ let(:dialog) { Components::Projects::ProjectCustomFields::EditDialog.new(project, section_with_invisible_fields) }
+
+ context 'with admin permissions' do
+ before do
+ login_as admin
+ overview_page.visit_page
+ end
+
+ it 'shows all project custom fields' do
+ overview_page.open_edit_dialog_for_section(section_with_invisible_fields)
+
+ dialog.within_async_content(close_after_yield: true) do
+ expect(page).to have_content('Normal field')
+ expect(page).to have_content('Admin only field')
+ end
+ end
+ end
+
+ context 'with non-admin permissions' do
+ before do
+ login_as member_with_project_edit_permissions
+ overview_page.visit_page
+ end
+
+ it 'shows only visible project custom fields' do
+ overview_page.open_edit_dialog_for_section(section_with_invisible_fields)
+
+ dialog.within_async_content(close_after_yield: true) do
+ expect(page).to have_content('Normal field')
+ expect(page).to have_no_content('Admin only field')
+ end
+ end
+ end
+ end
+end
diff --git a/spec/features/projects/project_custom_fields/overview_page/dialog/update_spec.rb b/spec/features/projects/project_custom_fields/overview_page/dialog/update_spec.rb
new file mode 100644
index 000000000000..15f61de8bbe9
--- /dev/null
+++ b/spec/features/projects/project_custom_fields/overview_page/dialog/update_spec.rb
@@ -0,0 +1,655 @@
+#-- copyright
+# OpenProject is an open source project management software.
+# Copyright (C) 2012-2023 the OpenProject GmbH
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+#
+# See COPYRIGHT and LICENSE files for more details.
+#++
+
+require "spec_helper"
+require_relative "../shared_context"
+
+RSpec.describe "Edit project custom fields on project overview page", :js do
+ include_context "with seeded projects, members and project custom fields"
+
+ let(:overview_page) { Pages::Projects::Show.new(project) }
+
+ before do
+ login_as member_with_project_edit_permissions
+ overview_page.visit_page
+ end
+
+ describe "with correct updating behaviour" do
+ describe "with input fields" do
+ let(:section) { section_for_input_fields }
+ let(:dialog) { Components::Projects::ProjectCustomFields::EditDialog.new(project, section) }
+
+ shared_examples "a custom field checkbox" do
+ it "sets the value to true if checked" do
+ custom_field.custom_values.destroy_all
+
+ overview_page.visit_page
+
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_content I18n.t("placeholders.default")
+ end
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.check
+
+ dialog.submit
+ dialog.expect_closed
+
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_content "Yes"
+ end
+ end
+
+ it "sets the value to false if unchecked" do
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_content "Yes"
+ end
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.uncheck
+
+ dialog.submit
+ dialog.expect_closed
+
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_content "No"
+ end
+ end
+
+ it "does not change the value if untouched" do
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_content "Yes"
+ end
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ # don't touch the input
+
+ dialog.submit
+ dialog.expect_closed
+
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_content "Yes"
+ end
+ end
+ end
+
+ shared_examples "a custom field input" do
+ it "saves the value properly" do
+ custom_field.custom_values.destroy_all
+
+ overview_page.visit_page
+
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_content I18n.t("placeholders.default")
+ end
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.fill_in(with: update_value)
+
+ dialog.submit
+ dialog.expect_closed
+
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_content expected_updated_value
+ end
+ end
+
+ it "does not change the value if untouched" do
+ overview_page.visit_page
+
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_content expected_initial_value
+ end
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ # don't touch the input
+
+ dialog.submit
+ dialog.expect_closed
+
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_content expected_initial_value
+ end
+ end
+
+ it "removes the value properly" do
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_content expected_initial_value
+ end
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.fill_in(with: "")
+
+ dialog.submit
+ dialog.expect_closed
+
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_content I18n.t("placeholders.default")
+ end
+ end
+ end
+
+ shared_examples "a rich text custom field input" do
+ it "saves the value properly" do
+ custom_field.custom_values.destroy_all
+
+ overview_page.visit_page
+
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_no_text(expected_updated_value)
+ end
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.set_value(update_value)
+
+ dialog.submit
+ dialog.expect_closed
+
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_text(expected_updated_value)
+ end
+ end
+
+ it "does not change the value if untouched" do
+ overview_page.visit_page
+
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_content expected_initial_value
+ end
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ # don't touch the input
+
+ dialog.submit
+ dialog.expect_closed
+
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_content expected_initial_value
+ end
+ end
+
+ it "removes the value properly" do
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_text(expected_initial_value)
+ end
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.set_value("")
+
+ dialog.submit
+ dialog.expect_closed
+
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_no_text(expected_initial_value)
+ end
+ end
+ end
+
+ describe "with boolean CF" do
+ let(:custom_field) { boolean_project_custom_field }
+ let(:field) { FormFields::Primerized::InputField.new(custom_field) }
+
+ it_behaves_like "a custom field checkbox"
+ end
+
+ describe "with string CF" do
+ let(:custom_field) { string_project_custom_field }
+ let(:field) { FormFields::Primerized::InputField.new(custom_field) }
+ let(:expected_initial_value) { "Foo" }
+ let(:update_value) { "Bar" }
+ let(:expected_updated_value) { update_value }
+
+ it_behaves_like "a custom field input"
+ end
+
+ describe "with integer CF" do
+ let(:custom_field) { integer_project_custom_field }
+ let(:field) { FormFields::Primerized::InputField.new(custom_field) }
+ let(:expected_initial_value) { 123 }
+ let(:update_value) { 456 }
+ let(:expected_updated_value) { update_value }
+
+ it_behaves_like "a custom field input"
+ end
+
+ describe "with float CF" do
+ let(:custom_field) { float_project_custom_field }
+ let(:field) { FormFields::Primerized::InputField.new(custom_field) }
+ let(:expected_initial_value) { 123.456 }
+ let(:update_value) { 456.789 }
+ let(:expected_updated_value) { update_value }
+
+ it_behaves_like "a custom field input"
+ end
+
+ describe "with date CF" do
+ let(:custom_field) { date_project_custom_field }
+ let(:field) { FormFields::Primerized::InputField.new(custom_field) }
+ let(:expected_initial_value) { "01/01/2024" }
+ let(:update_value) { Date.new(2024, 1, 2) }
+ let(:expected_updated_value) { "01/02/2024" }
+
+ it_behaves_like "a custom field input"
+ end
+
+ describe "with text CF" do
+ let(:custom_field) { text_project_custom_field }
+ let(:field) { FormFields::Primerized::EditorFormField.new(custom_field) }
+ let(:expected_initial_value) { "Lorem\nipsum" } # TBD: why is the second newline missing?
+ let(:update_value) { "Dolor\n\nsit" }
+ let(:expected_updated_value) { "Dolor\nsit" }
+
+ it_behaves_like "a rich text custom field input"
+ end
+ end
+
+ describe "with select fields" do
+ let(:section) { section_for_select_fields }
+ let(:dialog) { Components::Projects::ProjectCustomFields::EditDialog.new(project, section) }
+
+ shared_examples "a select field" do
+ it "saves the value properly" do
+ custom_field.custom_values.destroy_all
+
+ overview_page.visit_page
+
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_no_text first_option
+ end
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.select_option(first_option)
+
+ dialog.submit
+ dialog.expect_closed
+
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_text first_option
+ end
+ end
+
+ it "does not change the value if untouched" do
+ overview_page.visit_page
+
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_text first_option
+ end
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.expect_selected(first_option) # wait for proper initialization
+ # don't touch the input
+
+ dialog.submit
+ dialog.expect_closed
+
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_text first_option
+ end
+ end
+
+ it "removes the value properly" do
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_text first_option
+ end
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.clear
+
+ dialog.submit
+ dialog.expect_closed
+
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_no_text first_option
+ end
+ end
+ end
+
+ describe "with list CF" do
+ let(:custom_field) { list_project_custom_field }
+ let(:field) { FormFields::Primerized::AutocompleteField.new(custom_field) }
+
+ let(:first_option) { custom_field.custom_options.first.value }
+
+ it_behaves_like "a select field"
+ end
+
+ describe "with version select CF" do
+ let(:custom_field) { version_project_custom_field }
+ let(:field) { FormFields::Primerized::AutocompleteField.new(custom_field) }
+
+ let(:first_option) { first_version.name }
+
+ it_behaves_like "a select field"
+ end
+
+ describe "with user select CF" do
+ let(:custom_field) { user_project_custom_field }
+ let(:field) { FormFields::Primerized::AutocompleteField.new(custom_field) }
+
+ let(:first_option) { member_in_project.name }
+
+ it_behaves_like "a select field"
+
+ describe "with support for user groups" do
+ let!(:group) do
+ create(:group, name: "Group 1 in project",
+ member_with_roles: { project => reader_role })
+ end
+
+ it "saves selected user group properly" do
+ custom_field.custom_values.destroy_all
+
+ overview_page.visit_page
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.select_option(group.name)
+
+ dialog.submit
+ dialog.expect_closed
+
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_text group.name
+ end
+ end
+ end
+
+ describe "with support for placeholder users" do
+ let!(:placeholder_user) do
+ create(:placeholder_user, name: "Placeholder user",
+ member_with_roles: { project => reader_role })
+ end
+
+ it "saves selected placeholer user properly" do
+ custom_field.custom_values.destroy_all
+
+ overview_page.visit_page
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.select_option(placeholder_user.name)
+
+ dialog.submit
+ dialog.expect_closed
+
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_text placeholder_user.name
+ end
+ end
+ end
+ end
+ end
+
+ describe "with multi select fields" do
+ let(:section) { section_for_multi_select_fields }
+ let(:dialog) { Components::Projects::ProjectCustomFields::EditDialog.new(project, section) }
+
+ shared_examples "a autocomplete multi select field" do
+ it "saves single selected values properly" do
+ custom_field.custom_values.destroy_all
+
+ overview_page.visit_page
+
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_no_text first_option
+ end
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.select_option(first_option)
+
+ dialog.submit
+ dialog.expect_closed
+
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_text first_option
+ end
+ end
+
+ it "saves multi selected values properly" do
+ custom_field.custom_values.destroy_all
+
+ overview_page.visit_page
+
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_no_text first_option
+ expect(page).to have_no_text second_option
+ end
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.select_option(first_option)
+ field.select_option(second_option)
+
+ dialog.submit
+ dialog.expect_closed
+
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_text first_option
+ expect(page).to have_text second_option
+ end
+ end
+
+ it "removes deselected values properly" do
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_text first_option
+ expect(page).to have_text second_option
+ end
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.deselect_option(first_option)
+
+ dialog.submit
+ dialog.expect_closed
+
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_no_text first_option
+ expect(page).to have_text second_option
+ end
+ end
+
+ it "does not remove values when not touching the init values" do
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_text first_option
+ expect(page).to have_text second_option
+ end
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.expect_selected(first_option, second_option) # wait for proper initialization
+ # don't touch the values
+
+ dialog.submit
+ dialog.expect_closed
+
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_text first_option
+ expect(page).to have_text second_option
+ end
+ end
+
+ it "removes all values when clearing the input" do
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_text first_option
+ expect(page).to have_text second_option
+ end
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.clear
+
+ dialog.submit
+ dialog.expect_closed
+
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_no_text first_option
+ expect(page).to have_no_text second_option
+ end
+ end
+
+ it "adds values properly to init values" do
+ custom_field.custom_values.destroy_all
+
+ overview_page.visit_page
+
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_no_text first_option
+ expect(page).to have_no_text second_option
+ end
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.select_option(first_option)
+
+ dialog.submit
+ dialog.expect_closed
+
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_text first_option
+ expect(page).to have_no_text second_option
+ end
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.select_option(second_option)
+
+ dialog.submit
+ dialog.expect_closed
+
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_text first_option
+ expect(page).to have_text second_option
+ end
+ end
+ end
+
+ describe "with multi select list CF" do
+ let(:custom_field) { multi_list_project_custom_field }
+ let(:field) { FormFields::Primerized::AutocompleteField.new(custom_field) }
+
+ let(:first_option) { custom_field.custom_options.first.value }
+ let(:second_option) { custom_field.custom_options.second.value }
+
+ it_behaves_like "a autocomplete multi select field"
+ end
+
+ describe "with multi version select list CF" do
+ let(:custom_field) { multi_version_project_custom_field }
+ let(:field) { FormFields::Primerized::AutocompleteField.new(custom_field) }
+
+ let(:first_option) { first_version.name }
+ let(:second_option) { second_version.name }
+
+ it_behaves_like "a autocomplete multi select field"
+ end
+
+ describe "with multi user select list CF" do
+ let(:custom_field) { multi_user_project_custom_field }
+ let(:field) { FormFields::Primerized::AutocompleteField.new(custom_field) }
+
+ let(:first_option) { member_in_project.name }
+ let(:second_option) { another_member_in_project.name }
+
+ it_behaves_like "a autocomplete multi select field"
+
+ describe "with support for user groups" do
+ let!(:group) do
+ create(:group, name: "Group 1 in project",
+ member_with_roles: { project => reader_role })
+ end
+ let!(:another_group) do
+ create(:group, name: "Group 2 in project",
+ member_with_roles: { project => reader_role })
+ end
+
+ it "saves selected user groups properly" do
+ custom_field.custom_values.destroy_all
+
+ overview_page.visit_page
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.select_option(group.name)
+ field.select_option(another_group.name)
+
+ dialog.submit
+ dialog.expect_closed
+
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_text group.name
+ expect(page).to have_text another_group.name
+ end
+ end
+ end
+
+ describe "with support for placeholder users" do
+ let!(:placeholder_user) do
+ create(:placeholder_user, name: "Placeholder user",
+ member_with_roles: { project => reader_role })
+ end
+ let!(:another_placeholder_user) do
+ create(:placeholder_user, name: "Another placeholder User",
+ member_with_roles: { project => reader_role })
+ end
+
+ it "shows only placeholder users from this project" do
+ custom_field.custom_values.destroy_all
+
+ overview_page.visit_page
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ field.select_option(placeholder_user.name)
+ field.select_option(another_placeholder_user.name)
+
+ dialog.submit
+ dialog.expect_closed
+
+ overview_page.within_custom_field_container(custom_field) do
+ expect(page).to have_text placeholder_user.name
+ expect(page).to have_text another_placeholder_user.name
+ end
+ end
+ end
+ end
+ end
+ end
+end
diff --git a/spec/features/projects/project_custom_fields/overview_page/dialog/validation_spec.rb b/spec/features/projects/project_custom_fields/overview_page/dialog/validation_spec.rb
new file mode 100644
index 000000000000..833cc8063f63
--- /dev/null
+++ b/spec/features/projects/project_custom_fields/overview_page/dialog/validation_spec.rb
@@ -0,0 +1,412 @@
+#-- copyright
+# OpenProject is an open source project management software.
+# Copyright (C) 2012-2023 the OpenProject GmbH
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+#
+# See COPYRIGHT and LICENSE files for more details.
+#++
+
+require "spec_helper"
+require_relative "../shared_context"
+
+RSpec.describe "Edit project custom fields on project overview page", :js do
+ include_context "with seeded projects, members and project custom fields"
+
+ let(:overview_page) { Pages::Projects::Show.new(project) }
+
+ before do
+ login_as member_with_project_edit_permissions
+ overview_page.visit_page
+ end
+
+ describe "with correct validation behaviour" do
+ describe "after validation" do
+ let(:section) { section_for_input_fields }
+ let(:dialog) { Components::Projects::ProjectCustomFields::EditDialog.new(project, section) }
+
+ it "keeps showing only activated custom fields (tricky regression)" do
+ custom_field = string_project_custom_field
+ custom_field.update!(is_required: true)
+ field = FormFields::Primerized::InputField.new(custom_field)
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ dialog.within_async_content do
+ containers = dialog.input_containers
+
+ expect(containers[0].text).to include("Boolean field")
+ expect(containers[1].text).to include("String field")
+ expect(containers[2].text).to include("Integer field")
+ expect(containers[3].text).to include("Float field")
+ expect(containers[4].text).to include("Date field")
+ expect(containers[5].text).to include("Text field")
+
+ expect(page).to have_no_text(boolean_project_custom_field_activated_in_other_project.name)
+ end
+
+ field.fill_in(with: "") # this will trigger the validation
+
+ dialog.submit
+
+ field.expect_error(I18n.t("activerecord.errors.messages.blank"))
+
+ dialog.within_async_content do
+ containers = dialog.input_containers
+
+ expect(containers[0].text).to include("Boolean field")
+ expect(containers[1].text).to include("String field")
+ expect(containers[2].text).to include("Integer field")
+ expect(containers[3].text).to include("Float field")
+ expect(containers[4].text).to include("Date field")
+ expect(containers[5].text).to include("Text field")
+
+ expect(page).to have_no_text(boolean_project_custom_field_activated_in_other_project.name)
+ end
+ end
+
+ describe "does not loose the unpersisted values of the custom fields" do
+ context "with input fields" do
+ let(:section) { section_for_input_fields }
+
+ let(:invalid_custom_field) { string_project_custom_field }
+ let(:valid_custom_field) { integer_project_custom_field }
+ let(:invalid_field) { FormFields::Primerized::InputField.new(invalid_custom_field) }
+ let(:valid_field) { FormFields::Primerized::InputField.new(valid_custom_field) }
+
+ it "keeps the value" do
+ invalid_custom_field.update!(is_required: true)
+ overview_page.open_edit_dialog_for_section(section)
+
+ invalid_field.fill_in(with: "")
+ valid_field.fill_in(with: "123")
+
+ dialog.submit
+
+ invalid_field.expect_error(I18n.t("activerecord.errors.messages.blank"))
+
+ invalid_field.expect_value("")
+ valid_field.expect_value("123")
+ end
+ end
+
+ context "with select fields" do
+ let(:section) { section_for_select_fields }
+
+ context "with version selected" do
+ let(:invalid_custom_field) { list_project_custom_field }
+ let(:valid_custom_field) { version_project_custom_field }
+ let(:invalid_field) { FormFields::Primerized::AutocompleteField.new(invalid_custom_field) }
+ let(:valid_field) { FormFields::Primerized::AutocompleteField.new(valid_custom_field) }
+
+ it "keeps the value" do
+ invalid_custom_field.update!(is_required: true)
+ overview_page.open_edit_dialog_for_section(section)
+
+ invalid_field.clear
+ valid_field.select_option(third_version.name)
+
+ dialog.submit
+
+ invalid_field.expect_error(I18n.t("activerecord.errors.messages.blank"))
+
+ invalid_field.expect_blank
+ valid_field.expect_selected(third_version.name)
+ end
+ end
+
+ context "with user selected" do
+ let(:invalid_custom_field) { list_project_custom_field }
+ let(:valid_custom_field) { user_project_custom_field }
+ let(:invalid_field) { FormFields::Primerized::AutocompleteField.new(invalid_custom_field) }
+ let(:valid_field) { FormFields::Primerized::AutocompleteField.new(valid_custom_field) }
+
+ it "keeps the value" do
+ invalid_custom_field.update!(is_required: true)
+ overview_page.open_edit_dialog_for_section(section)
+
+ invalid_field.clear
+ valid_field.select_option(another_member_in_project.name)
+
+ dialog.submit
+
+ invalid_field.expect_error(I18n.t("activerecord.errors.messages.blank"))
+
+ invalid_field.expect_blank
+ valid_field.expect_selected(another_member_in_project.name)
+ end
+ end
+
+ context "with list selected" do
+ let(:invalid_custom_field) { user_project_custom_field }
+ let(:valid_custom_field) { list_project_custom_field }
+ let(:invalid_field) { FormFields::Primerized::AutocompleteField.new(invalid_custom_field) }
+ let(:valid_field) { FormFields::Primerized::AutocompleteField.new(valid_custom_field) }
+
+ it "keeps the value" do
+ invalid_custom_field.update!(is_required: true)
+ overview_page.open_edit_dialog_for_section(section)
+
+ invalid_field.clear
+ valid_field.select_option("Option 3")
+
+ dialog.submit
+
+ invalid_field.expect_error(I18n.t("activerecord.errors.messages.blank"))
+
+ invalid_field.expect_blank
+ valid_field.expect_selected("Option 3")
+ end
+ end
+ end
+
+ context "with multi select fields" do
+ let(:section) { section_for_multi_select_fields }
+
+ context "with multi version selected" do
+ let(:invalid_custom_field) { multi_list_project_custom_field }
+ let(:valid_custom_field) { multi_version_project_custom_field }
+ let(:invalid_field) { FormFields::Primerized::AutocompleteField.new(invalid_custom_field) }
+ let(:valid_field) { FormFields::Primerized::AutocompleteField.new(valid_custom_field) }
+
+ it "keeps the values" do
+ invalid_custom_field.update!(is_required: true)
+ overview_page.open_edit_dialog_for_section(section)
+
+ invalid_field.clear
+ valid_field.clear
+ valid_field.select_option(first_version.name, third_version.name)
+
+ dialog.submit
+
+ invalid_field.expect_error(I18n.t("activerecord.errors.messages.blank"))
+
+ invalid_field.expect_blank
+ valid_field.expect_selected(first_version.name, third_version.name)
+ end
+ end
+
+ context "with multi user selected" do
+ let(:invalid_custom_field) { multi_list_project_custom_field }
+ let(:valid_custom_field) { multi_user_project_custom_field }
+ let(:invalid_field) { FormFields::Primerized::AutocompleteField.new(invalid_custom_field) }
+ let(:valid_field) { FormFields::Primerized::AutocompleteField.new(valid_custom_field) }
+
+ it "keeps the values" do
+ invalid_custom_field.update!(is_required: true)
+ overview_page.open_edit_dialog_for_section(section)
+
+ invalid_field.clear
+ valid_field.clear
+ valid_field.select_option(member_in_project.name, one_more_member_in_project.name)
+
+ dialog.submit
+
+ invalid_field.expect_error(I18n.t("activerecord.errors.messages.blank"))
+
+ invalid_field.expect_blank
+ valid_field.expect_selected(member_in_project.name, one_more_member_in_project.name)
+ end
+ end
+
+ context "with multi list selected" do
+ let(:invalid_custom_field) { multi_user_project_custom_field }
+ let(:valid_custom_field) { multi_list_project_custom_field }
+ let(:invalid_field) { FormFields::Primerized::AutocompleteField.new(invalid_custom_field) }
+ let(:valid_field) { FormFields::Primerized::AutocompleteField.new(valid_custom_field) }
+
+ it "keeps the value" do
+ invalid_custom_field.update!(is_required: true)
+ overview_page.open_edit_dialog_for_section(section)
+
+ invalid_field.clear
+ valid_field.clear
+ valid_field.select_option("Option 1", "Option 3")
+
+ dialog.submit
+
+ invalid_field.expect_error(I18n.t("activerecord.errors.messages.blank"))
+
+ invalid_field.expect_blank
+ valid_field.expect_selected("Option 1", "Option 3")
+ end
+ end
+ end
+ end
+ end
+
+ describe "editing multiple sections" do
+ let(:input_fields_dialog) do
+ Components::Projects::ProjectCustomFields::EditDialog.new(project, section_for_input_fields)
+ end
+ let(:select_fields_dialog) do
+ Components::Projects::ProjectCustomFields::EditDialog.new(project, section_for_select_fields)
+ end
+ let(:field) { FormFields::Primerized::AutocompleteField.new(list_project_custom_field) }
+
+ it "displays validation errors, when the previous section modal was canceled (Regression)" do
+ list_project_custom_field.update!(is_required: true)
+ list_project_custom_field.custom_values.destroy_all
+
+ overview_page.open_edit_dialog_for_section(section_for_input_fields)
+ input_fields_dialog.close
+ overview_page.open_edit_dialog_for_section(section_for_select_fields)
+ select_fields_dialog.submit
+
+ field.expect_error(I18n.t("activerecord.errors.messages.blank"))
+ end
+ end
+
+ describe "with input fields" do
+ let(:section) { section_for_input_fields }
+ let(:dialog) { Components::Projects::ProjectCustomFields::EditDialog.new(project, section) }
+
+ shared_examples "a custom field input" do
+ it "shows an error if the value is invalid" do
+ custom_field.update!(is_required: true)
+ custom_field.custom_values.destroy_all
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ dialog.submit
+
+ field.expect_error(I18n.t("activerecord.errors.messages.blank"))
+ end
+ end
+
+ # boolean CFs can not be validated
+
+ describe "with string CF" do
+ let(:custom_field) { string_project_custom_field }
+ let(:field) { FormFields::Primerized::InputField.new(custom_field) }
+
+ it_behaves_like "a custom field input"
+ end
+
+ describe "with integer CF" do
+ let(:custom_field) { integer_project_custom_field }
+ let(:field) { FormFields::Primerized::InputField.new(custom_field) }
+
+ it_behaves_like "a custom field input"
+ end
+
+ describe "with float CF" do
+ let(:custom_field) { float_project_custom_field }
+ let(:field) { FormFields::Primerized::InputField.new(custom_field) }
+
+ it_behaves_like "a custom field input"
+ end
+
+ describe "with date CF" do
+ let(:custom_field) { date_project_custom_field }
+ let(:field) { FormFields::Primerized::InputField.new(custom_field) }
+
+ it_behaves_like "a custom field input"
+ end
+
+ describe "with text CF" do
+ let(:custom_field) { text_project_custom_field }
+ let(:field) { FormFields::Primerized::EditorFormField.new(custom_field) }
+
+ it_behaves_like "a custom field input"
+ end
+ end
+
+ describe "with select fields" do
+ let(:section) { section_for_select_fields }
+ let(:dialog) { Components::Projects::ProjectCustomFields::EditDialog.new(project, section) }
+
+ shared_examples "a custom field select" do
+ it "shows an error if the value is invalid" do
+ custom_field.update!(is_required: true)
+ custom_field.custom_values.destroy_all
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ dialog.submit
+
+ field.expect_error(I18n.t("activerecord.errors.messages.blank"))
+ end
+ end
+
+ describe "with list CF" do
+ let(:custom_field) { list_project_custom_field }
+ let(:field) { FormFields::Primerized::AutocompleteField.new(custom_field) }
+
+ it_behaves_like "a custom field select"
+ end
+
+ describe "with version CF" do
+ let(:custom_field) { version_project_custom_field }
+ let(:field) { FormFields::Primerized::AutocompleteField.new(custom_field) }
+
+ it_behaves_like "a custom field select"
+ end
+
+ describe "with user CF" do
+ let(:custom_field) { user_project_custom_field }
+ let(:field) { FormFields::Primerized::AutocompleteField.new(custom_field) }
+
+ it_behaves_like "a custom field select"
+ end
+ end
+
+ describe "with multi select fields" do
+ let(:section) { section_for_multi_select_fields }
+ let(:dialog) { Components::Projects::ProjectCustomFields::EditDialog.new(project, section) }
+
+ shared_examples "a custom field multi select" do
+ it "shows an error if the value is invalid" do
+ custom_field.update!(is_required: true)
+ custom_field.custom_values.destroy_all
+
+ overview_page.open_edit_dialog_for_section(section)
+
+ dialog.submit
+
+ field.expect_error(I18n.t("activerecord.errors.messages.blank"))
+ end
+ end
+
+ describe "with multi list CF" do
+ let(:custom_field) { multi_list_project_custom_field }
+ let(:field) { FormFields::Primerized::AutocompleteField.new(custom_field) }
+
+ it_behaves_like "a custom field multi select"
+ end
+
+ describe "with multi version CF" do
+ let(:custom_field) { multi_version_project_custom_field }
+ let(:field) { FormFields::Primerized::AutocompleteField.new(custom_field) }
+
+ it_behaves_like "a custom field multi select"
+ end
+
+ describe "with multi user CF" do
+ let(:custom_field) { multi_user_project_custom_field }
+ let(:field) { FormFields::Primerized::AutocompleteField.new(custom_field) }
+
+ it_behaves_like "a custom field multi select"
+ end
+ end
+ end
+end
diff --git a/spec/features/projects/project_custom_fields/overview_page/shared_context.rb b/spec/features/projects/project_custom_fields/overview_page/shared_context.rb
new file mode 100644
index 000000000000..5cfb258b2434
--- /dev/null
+++ b/spec/features/projects/project_custom_fields/overview_page/shared_context.rb
@@ -0,0 +1,232 @@
+#-- copyright
+# OpenProject is an open source project management software.
+# Copyright (C) 2012-2023 the OpenProject GmbH
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+#
+# See COPYRIGHT and LICENSE files for more details.
+#++
+
+RSpec.shared_context 'with seeded projects, members and project custom fields' do
+ let(:project) { create(:project, name: 'Foo project', identifier: 'foo-project') }
+ let(:other_project) { create(:project, name: 'Bar project', identifier: 'bar-project') }
+
+ let!(:first_version) { create(:version, name: 'Version 1', project:) }
+ let!(:second_version) { create(:version, name: 'Version 2', project:) }
+ let!(:third_version) { create(:version, name: 'Version 3', project:) }
+
+ shared_let(:reader_role) do
+ create(:project_role, permissions: %i[view_work_packages])
+ end
+
+ shared_let(:edit_role) do
+ create(:project_role, permissions: %i[view_work_packages edit_project])
+ end
+
+ let!(:admin) do
+ create(:admin)
+ end
+
+ let!(:member_in_project) do
+ create(:user,
+ firstname: 'Member 1',
+ lastname: 'In Project',
+ member_with_roles: { project => reader_role })
+ end
+
+ let!(:another_member_in_project) do
+ create(:user,
+ firstname: 'Member 2',
+ lastname: 'In Project',
+ member_with_roles: { project => reader_role })
+ end
+
+ let!(:one_more_member_in_project) do
+ create(:user,
+ firstname: 'Member 3',
+ lastname: 'In Project',
+ member_with_roles: { project => reader_role })
+ end
+
+ let!(:member_with_project_edit_permissions) do
+ create(:user,
+ firstname: 'Member',
+ lastname: 'With Project Edit Permissions',
+ member_with_roles: { project => edit_role })
+ end
+
+ let!(:member_without_project_edit_permissions) do
+ member_in_project
+ end
+
+ let!(:section_for_input_fields) { create(:project_custom_field_section, name: 'Input fields') }
+ let!(:section_for_select_fields) { create(:project_custom_field_section, name: 'Select fields') }
+ let!(:section_for_multi_select_fields) { create(:project_custom_field_section, name: 'Multi select fields') }
+
+ let!(:boolean_project_custom_field) do
+ field = create(:boolean_project_custom_field, projects: [project], name: 'Boolean field',
+ project_custom_field_section: section_for_input_fields)
+
+ create(:custom_value, customized: project, custom_field: field, value: true)
+
+ field
+ end
+
+ let!(:string_project_custom_field) do
+ field = create(:string_project_custom_field, projects: [project], name: 'String field',
+ project_custom_field_section: section_for_input_fields)
+
+ create(:custom_value, customized: project, custom_field: field, value: 'Foo')
+
+ field
+ end
+
+ let!(:integer_project_custom_field) do
+ field = create(:integer_project_custom_field, projects: [project], name: 'Integer field',
+ project_custom_field_section: section_for_input_fields)
+
+ create(:custom_value, customized: project, custom_field: field, value: 123)
+
+ field
+ end
+
+ let!(:float_project_custom_field) do
+ field = create(:float_project_custom_field, projects: [project], name: 'Float field',
+ project_custom_field_section: section_for_input_fields)
+
+ create(:custom_value, customized: project, custom_field: field, value: 123.456)
+
+ field
+ end
+
+ let!(:date_project_custom_field) do
+ field = create(:date_project_custom_field, projects: [project], name: 'Date field',
+ project_custom_field_section: section_for_input_fields)
+
+ create(:custom_value, customized: project, custom_field: field, value: Date.new(2024, 1, 1))
+
+ field
+ end
+
+ let!(:text_project_custom_field) do
+ field = create(:text_project_custom_field, projects: [project], name: 'Text field',
+ project_custom_field_section: section_for_input_fields)
+
+ create(:custom_value, customized: project, custom_field: field, value: "Lorem\n\nipsum")
+
+ field
+ end
+
+ let!(:list_project_custom_field) do
+ field = create(:list_project_custom_field, projects: [project], name: 'List field',
+ project_custom_field_section: section_for_select_fields,
+ possible_values: ['Option 1', 'Option 2', 'Option 3'])
+
+ create(:custom_value, customized: project, custom_field: field, value: field.custom_options.first)
+
+ field
+ end
+
+ let!(:version_project_custom_field) do
+ field = create(:version_project_custom_field, projects: [project], name: 'Version field',
+ project_custom_field_section: section_for_select_fields)
+
+ create(:custom_value, customized: project, custom_field: field, value: first_version.id)
+
+ field
+ end
+
+ let!(:user_project_custom_field) do
+ field = create(:user_project_custom_field, projects: [project], name: 'User field',
+ project_custom_field_section: section_for_select_fields)
+
+ create(:custom_value, customized: project, custom_field: field, value: member_in_project.id)
+
+ field
+ end
+
+ let!(:multi_list_project_custom_field) do
+ field = create(:list_project_custom_field, projects: [project], name: 'Multi list field',
+ project_custom_field_section: section_for_multi_select_fields,
+ possible_values: ['Option 1', 'Option 2', 'Option 3'],
+ multi_value: true)
+
+ create(:custom_value, customized: project, custom_field: field, value: field.custom_options.first.id)
+ create(:custom_value, customized: project, custom_field: field, value: field.custom_options.second.id)
+
+ field
+ end
+
+ let!(:multi_version_project_custom_field) do
+ field = create(:version_project_custom_field, projects: [project], name: 'Multi version field',
+ project_custom_field_section: section_for_multi_select_fields,
+ multi_value: true)
+
+ create(:custom_value, customized: project, custom_field: field, value: first_version.id)
+ create(:custom_value, customized: project, custom_field: field, value: second_version.id)
+
+ field
+ end
+
+ let!(:multi_user_project_custom_field) do
+ field = create(:user_project_custom_field, projects: [project], name: 'Multi user field',
+ project_custom_field_section: section_for_multi_select_fields,
+ multi_value: true)
+
+ create(:custom_value, customized: project, custom_field: field, value: member_in_project.id)
+ create(:custom_value, customized: project, custom_field: field, value: another_member_in_project.id)
+
+ field
+ end
+
+ let!(:input_fields) do
+ [
+ boolean_project_custom_field,
+ string_project_custom_field,
+ integer_project_custom_field,
+ float_project_custom_field,
+ date_project_custom_field,
+ text_project_custom_field
+ ]
+ end
+
+ let!(:select_fields) do
+ [
+ list_project_custom_field,
+ version_project_custom_field,
+ user_project_custom_field
+ ]
+ end
+
+ let!(:multi_select_fields) do
+ [
+ multi_list_project_custom_field,
+ multi_version_project_custom_field,
+ multi_user_project_custom_field
+ ]
+ end
+
+ let!(:boolean_project_custom_field_activated_in_other_project) do
+ create(:boolean_project_custom_field, projects: [other_project], name: 'Other Boolean field',
+ project_custom_field_section: section_for_input_fields)
+ end
+end
diff --git a/spec/features/projects/project_custom_fields/overview_page/sidebar_spec.rb b/spec/features/projects/project_custom_fields/overview_page/sidebar_spec.rb
new file mode 100644
index 000000000000..4eae8b7909e2
--- /dev/null
+++ b/spec/features/projects/project_custom_fields/overview_page/sidebar_spec.rb
@@ -0,0 +1,843 @@
+#-- copyright
+# OpenProject is an open source project management software.
+# Copyright (C) 2012-2023 the OpenProject GmbH
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+#
+# See COPYRIGHT and LICENSE files for more details.
+#++
+
+require "spec_helper"
+require_relative "shared_context"
+
+RSpec.describe "Show project custom fields on project overview page", :js, :with_cuprite do
+ include_context "with seeded projects, members and project custom fields"
+
+ let(:overview_page) { Pages::Projects::Show.new(project) }
+
+ before do
+ login_as admin
+ end
+
+ it "does show the project attributes sidebar" do
+ overview_page.visit_page
+
+ within ".op-grid-page" do
+ expect(page).to have_css("#project-custom-fields-sidebar")
+ end
+ end
+
+ describe "with correct order and scoping" do
+ it "shows the project custom field sections in the correct order" do
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ sections = page.all(".op-project-custom-field-section-container")
+
+ expect(sections.size).to eq(3)
+
+ expect(sections[0].text).to include("Input fields")
+ expect(sections[1].text).to include("Select fields")
+ expect(sections[2].text).to include("Multi select fields")
+ end
+
+ section_for_input_fields.move_to_bottom
+
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ sections = page.all(".op-project-custom-field-section-container")
+
+ expect(sections.size).to eq(3)
+
+ expect(sections[0].text).to include("Select fields")
+ expect(sections[1].text).to include("Multi select fields")
+ expect(sections[2].text).to include("Input fields")
+ end
+ end
+
+ it "shows the project custom fields in the correct order within the sections" do
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_section_container(section_for_input_fields) do
+ fields = page.all(".op-project-custom-field-container")
+
+ expect(fields.size).to eq(6)
+
+ expect(fields[0].text).to include("Boolean field")
+ expect(fields[1].text).to include("String field")
+ expect(fields[2].text).to include("Integer field")
+ expect(fields[3].text).to include("Float field")
+ expect(fields[4].text).to include("Date field")
+ expect(fields[5].text).to include("Text field")
+ end
+
+ overview_page.within_custom_field_section_container(section_for_select_fields) do
+ fields = page.all(".op-project-custom-field-container")
+
+ expect(fields.size).to eq(3)
+
+ expect(fields[0].text).to include("List field")
+ expect(fields[1].text).to include("Version field")
+ expect(fields[2].text).to include("User field")
+ end
+
+ overview_page.within_custom_field_section_container(section_for_multi_select_fields) do
+ fields = page.all(".op-project-custom-field-container")
+
+ expect(fields.size).to eq(3)
+
+ expect(fields[0].text).to include("Multi list field")
+ expect(fields[1].text).to include("Multi version field")
+ expect(fields[2].text).to include("Multi user field")
+ end
+ end
+
+ string_project_custom_field.move_to_bottom
+
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_section_container(section_for_input_fields) do
+ fields = page.all(".op-project-custom-field-container")
+
+ expect(fields.size).to eq(6)
+
+ expect(fields[0].text).to include("Boolean field")
+ expect(fields[1].text).to include("Integer field")
+ expect(fields[2].text).to include("Float field")
+ expect(fields[3].text).to include("Date field")
+ expect(fields[4].text).to include("Text field")
+ expect(fields[5].text).to include("String field")
+ end
+ end
+ end
+
+ it "does not show project custom fields not enabled for this project in a sidebar" do
+ create(:string_project_custom_field, projects: [other_project], name: "String field enabled for other project")
+
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ expect(page).to have_no_text "String field enabled for other project"
+ end
+ end
+ end
+
+ describe "with correct values" do
+ describe "with boolean CF" do
+ # it_behaves_like 'a project custom field' do
+ # let(subject) { boolean_project_custom_field }
+ # end
+
+ describe "with value set by user" do
+ it "shows the correct value for the project custom field if given" do
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(boolean_project_custom_field) do
+ expect(page).to have_text "Boolean field"
+ expect(page).to have_text "Yes"
+ end
+ end
+ end
+ end
+
+ describe "with value unset by user" do
+ # A boolean cannot be completely unset via UI, only toggle between true and false, no blank value possible
+ before do
+ boolean_project_custom_field.custom_values.where(customized: project).first.update!(value: false)
+ end
+
+ it "shows the correct value for the project custom field if given" do
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(boolean_project_custom_field) do
+ expect(page).to have_text "Boolean field"
+ expect(page).to have_text "No"
+ end
+ end
+ end
+ end
+
+ describe "with no value set by user" do
+ before do
+ boolean_project_custom_field.custom_values.where(customized: project).destroy_all
+ end
+
+ it "shows an N/A text for the project custom field if no value given" do
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(boolean_project_custom_field) do
+ expect(page).to have_text "Boolean field"
+ expect(page).to have_text I18n.t("placeholders.default")
+ end
+ end
+ end
+
+ it "does not show the default value for the project custom field if no value given" do
+ boolean_project_custom_field.update!(default_value: true)
+
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(boolean_project_custom_field) do
+ expect(page).to have_text "Boolean field"
+ expect(page).to have_text I18n.t("placeholders.default")
+ end
+ end
+
+ boolean_project_custom_field.update!(default_value: false)
+
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(boolean_project_custom_field) do
+ expect(page).to have_text "Boolean field"
+ expect(page).to have_text I18n.t("placeholders.default")
+ end
+ end
+ end
+ end
+ end
+
+ describe "with string CF" do
+ describe "with value set by user" do
+ it "shows the correct value for the project custom field if given" do
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(string_project_custom_field) do
+ expect(page).to have_text "String field"
+ expect(page).to have_text "Foo"
+ end
+ end
+ end
+ end
+
+ describe "with value unset by user" do
+ before do
+ string_project_custom_field.custom_values.where(customized: project).first.update!(value: "")
+ end
+
+ it "shows the correct value for the project custom field if given" do
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(string_project_custom_field) do
+ expect(page).to have_text "String field"
+ expect(page).to have_text I18n.t("placeholders.default")
+ end
+ end
+ end
+ end
+
+ describe "with no value set by user" do
+ before do
+ string_project_custom_field.custom_values.where(customized: project).destroy_all
+ end
+
+ it "shows an N/A text for the project custom field if no value given" do
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(string_project_custom_field) do
+ expect(page).to have_text "String field"
+ expect(page).to have_text I18n.t("placeholders.default")
+ end
+ end
+ end
+
+ it "does not show the default value for the project custom field if no value given" do
+ string_project_custom_field.update!(default_value: "Bar")
+
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(string_project_custom_field) do
+ expect(page).to have_text "String field"
+ expect(page).to have_text I18n.t("placeholders.default")
+ end
+ end
+ end
+ end
+ end
+
+ describe "with integer CF" do
+ describe "with value set by user" do
+ it "shows the correct value for the project custom field if given" do
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(integer_project_custom_field) do
+ expect(page).to have_text "Integer field"
+ expect(page).to have_text "123"
+ end
+ end
+ end
+ end
+
+ describe "with value unset by user" do
+ before do
+ integer_project_custom_field.custom_values.where(customized: project).first.update!(value: "")
+ end
+
+ it "shows the correct value for the project custom field if given" do
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(integer_project_custom_field) do
+ expect(page).to have_text "Integer field"
+ expect(page).to have_text I18n.t("placeholders.default")
+ end
+ end
+ end
+ end
+
+ describe "with no value set by user" do
+ before do
+ integer_project_custom_field.custom_values.where(customized: project).destroy_all
+ end
+
+ it "shows an N/A text for the project custom field if no value given" do
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(integer_project_custom_field) do
+ expect(page).to have_text "Integer field"
+ expect(page).to have_text I18n.t("placeholders.default")
+ end
+ end
+ end
+
+ it "does not show the default value for the project custom field if no value given" do
+ integer_project_custom_field.update!(default_value: 456)
+
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(integer_project_custom_field) do
+ expect(page).to have_text "Integer field"
+ expect(page).to have_text I18n.t("placeholders.default")
+ end
+ end
+ end
+ end
+ end
+
+ describe "with date CF" do
+ describe "with value set by user" do
+ it "shows the correct value for the project custom field if given" do
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(date_project_custom_field) do
+ expect(page).to have_text "Date field"
+ expect(page).to have_text "01/01/2024"
+ end
+ end
+ end
+ end
+
+ describe "with value unset by user" do
+ before do
+ date_project_custom_field.custom_values.where(customized: project).first.update!(value: "")
+ end
+
+ it "shows the correct value for the project custom field if given" do
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(date_project_custom_field) do
+ expect(page).to have_text "Date field"
+ expect(page).to have_text I18n.t("placeholders.default")
+ end
+ end
+ end
+ end
+
+ describe "with no value set by user" do
+ before do
+ date_project_custom_field.custom_values.where(customized: project).destroy_all
+ end
+
+ it "shows an N/A text for the project custom field if no value given" do
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(date_project_custom_field) do
+ expect(page).to have_text "Date field"
+ expect(page).to have_text I18n.t("placeholders.default")
+ end
+ end
+ end
+
+ it "does not show the default value for the project custom field if no value given" do
+ date_project_custom_field.update!(default_value: Date.new(2024, 2, 2))
+
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(date_project_custom_field) do
+ expect(page).to have_text "Date field"
+ expect(page).to have_text I18n.t("placeholders.default")
+ end
+ end
+ end
+ end
+ end
+
+ describe "with float CF" do
+ describe "with value set by user" do
+ it "shows the correct value for the project custom field if given" do
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(float_project_custom_field) do
+ expect(page).to have_text "Float field"
+ expect(page).to have_text "123.456"
+ end
+ end
+ end
+ end
+
+ describe "with value unset by user" do
+ before do
+ float_project_custom_field.custom_values.where(customized: project).first.update!(value: "")
+ end
+
+ it "shows the correct value for the project custom field if given" do
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(float_project_custom_field) do
+ expect(page).to have_text "Float field"
+ expect(page).to have_text I18n.t("placeholders.default")
+ end
+ end
+ end
+ end
+
+ describe "with no value set by user" do
+ before do
+ float_project_custom_field.custom_values.where(customized: project).destroy_all
+ end
+
+ it "shows an N/A text for the project custom field if no value given" do
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(float_project_custom_field) do
+ expect(page).to have_text "Float field"
+ expect(page).to have_text I18n.t("placeholders.default")
+ end
+ end
+ end
+
+ it "dies not show the default value for the project custom field if no value given" do
+ float_project_custom_field.update!(default_value: 456.789)
+
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(float_project_custom_field) do
+ expect(page).to have_text "Float field"
+ expect(page).to have_text I18n.t("placeholders.default")
+ end
+ end
+ end
+ end
+ end
+
+ describe "with text CF" do
+ describe "with value set by user" do
+ context "with a value that is shorter than 100 characters" do
+ it "shows the correct value for the project custom field if given without truncation and dialog button" do
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(text_project_custom_field) do
+ expect(page).to have_text "Text field"
+ expect(page).to have_text "Lorem\nipsum"
+ end
+ end
+ end
+ end
+
+ context "with a value that is longer than 100 characters" do
+ before do
+ text_project_custom_field.custom_values.where(customized: project).first.update!(value: "a" * 101)
+ end
+
+ it "shows the correct value for the project custom field if given with truncation and dialog button" do
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(text_project_custom_field) do
+ expect(page).to have_text "Text field"
+ expect(page).to have_text ("#{'a' * 97}...")
+ expect(page).to have_text "Expand"
+
+ click_on "Expand"
+
+ within "dialog" do
+ expect(page).to have_text "a" * 101
+ end
+ end
+ end
+ end
+ end
+ end
+
+ describe "with value unset by user" do
+ before do
+ text_project_custom_field.custom_values.where(customized: project).first.update!(value: "")
+ end
+
+ it "shows the correct value for the project custom field if given" do
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(text_project_custom_field) do
+ expect(page).to have_text "Text field"
+ expect(page).to have_text I18n.t("placeholders.default")
+ end
+ end
+ end
+ end
+
+ describe "with no value set by user" do
+ before do
+ text_project_custom_field.custom_values.where(customized: project).destroy_all
+ end
+
+ it "shows an N/A text for the project custom field if no value given" do
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(text_project_custom_field) do
+ expect(page).to have_text "Text field"
+ expect(page).to have_text I18n.t("placeholders.default")
+ end
+ end
+ end
+
+ it "does not show the default value for the project custom field if no value given" do
+ text_project_custom_field.update!(default_value: "Dolor sit amet")
+
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(text_project_custom_field) do
+ expect(page).to have_text "Text field"
+ expect(page).to have_text I18n.t("placeholders.default")
+ end
+ end
+ end
+ end
+ end
+
+ describe "with list CF" do
+ describe "with value set by user" do
+ it "shows the correct value for the project custom field if given" do
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(list_project_custom_field) do
+ expect(page).to have_text "List field"
+ expect(page).to have_text "Option 1"
+ end
+ end
+ end
+ end
+
+ describe "with value unset by user" do
+ before do
+ list_project_custom_field.custom_values.where(customized: project).first.update!(value: "")
+ end
+
+ it "shows the correct value for the project custom field if given" do
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(list_project_custom_field) do
+ expect(page).to have_text "List field"
+ expect(page).to have_text I18n.t("placeholders.default")
+ end
+ end
+ end
+ end
+
+ describe "with no value set by user" do
+ before do
+ list_project_custom_field.custom_values.where(customized: project).destroy_all
+ end
+
+ it "shows an N/A text for the project custom field if no value given" do
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(list_project_custom_field) do
+ expect(page).to have_text "List field"
+ expect(page).to have_text I18n.t("placeholders.default")
+ end
+ end
+ end
+
+ it "does not show the default value for the project custom field if no value given" do
+ list_project_custom_field.custom_options.first.update!(default_value: true)
+
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(list_project_custom_field) do
+ expect(page).to have_text "List field"
+ expect(page).to have_text I18n.t("placeholders.default")
+ end
+ end
+ end
+ end
+ end
+
+ describe "with version CF" do
+ describe "with value set by user" do
+ it "shows the correct value for the project custom field if given" do
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(version_project_custom_field) do
+ expect(page).to have_text "Version field"
+ expect(page).to have_text "Version 1"
+ end
+ end
+ end
+ end
+
+ describe "with value unset by user" do
+ before do
+ version_project_custom_field.custom_values.where(customized: project).first.update!(value: "")
+ end
+
+ it "shows the correct value for the project custom field if given" do
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(version_project_custom_field) do
+ expect(page).to have_text "Version field"
+ expect(page).to have_text I18n.t("placeholders.default")
+ end
+ end
+ end
+ end
+
+ describe "with no value set by user" do
+ before do
+ version_project_custom_field.custom_values.where(customized: project).destroy_all
+ end
+
+ it "shows an N/A text for the project custom field if no value given" do
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(version_project_custom_field) do
+ expect(page).to have_text "Version field"
+ expect(page).to have_text I18n.t("placeholders.default")
+ end
+ end
+ end
+ end
+ end
+
+ describe "with user CF" do
+ describe "with value set by user" do
+ it "shows the correct value for the project custom field if given" do
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(user_project_custom_field) do
+ expect(page).to have_text "User field"
+ expect(page).to have_css("opce-principal")
+ expect(page).to have_text "Member 1 In Project"
+ end
+ end
+ end
+ end
+
+ describe "with value unset by user" do
+ before do
+ user_project_custom_field.custom_values.where(customized: project).first.update!(value: "")
+ end
+
+ it "shows the correct value for the project custom field if given" do
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(user_project_custom_field) do
+ expect(page).to have_text "User field"
+ expect(page).to have_text I18n.t("placeholders.default")
+ end
+ end
+ end
+ end
+
+ describe "with no value set by user" do
+ before do
+ user_project_custom_field.custom_values.where(customized: project).destroy_all
+ end
+
+ it "shows an N/A text for the project custom field if no value given" do
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(user_project_custom_field) do
+ expect(page).to have_text "User field"
+ expect(page).to have_text I18n.t("placeholders.default")
+ end
+ end
+ end
+ end
+
+ describe "with support for user groups" do
+ # TODO
+ end
+
+ describe "with support for user placeholders" do
+ # TODO
+ end
+ end
+
+ describe "with multi list CF" do
+ describe "with value set by user" do
+ it "shows the correct values for the project custom field if given" do
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(multi_list_project_custom_field) do
+ expect(page).to have_text "Multi list field"
+ expect(page).to have_text "Option 1, Option 2"
+ end
+ end
+ end
+ end
+
+ describe "with no value set by user" do
+ before do
+ multi_list_project_custom_field.custom_values.where(customized: project).destroy_all
+ end
+
+ it "shows an N/A text for the project custom field if no value given" do
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(multi_list_project_custom_field) do
+ expect(page).to have_text "Multi list field"
+ expect(page).to have_text I18n.t("placeholders.default")
+ end
+ end
+ end
+
+ it "does not show the default value(s) for the project custom field if no value given" do
+ multi_list_project_custom_field.custom_options.first.update!(default_value: true)
+ multi_list_project_custom_field.custom_options.second.update!(default_value: true)
+
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(multi_list_project_custom_field) do
+ expect(page).to have_text "Multi list field"
+ expect(page).to have_text I18n.t("placeholders.default")
+ end
+ end
+ end
+ end
+ end
+
+ describe "with multi version CF" do
+ describe "with value set by user" do
+ it "shows the correct values for the project custom field if given" do
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(multi_version_project_custom_field) do
+ expect(page).to have_text "Multi version field"
+ expect(page).to have_text "Version 1, Version 2"
+ end
+ end
+ end
+ end
+
+ describe "with no value set by user" do
+ before do
+ multi_version_project_custom_field.custom_values.where(customized: project).destroy_all
+ end
+
+ it "shows an N/A text for the project custom field if no value given" do
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(multi_version_project_custom_field) do
+ expect(page).to have_text "Multi version field"
+ expect(page).to have_text I18n.t("placeholders.default")
+ end
+ end
+ end
+ end
+ end
+
+ describe "with multi user CF" do
+ describe "with value set by user" do
+ it "shows the correct values for the project custom field if given" do
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(multi_user_project_custom_field) do
+ expect(page).to have_text "Multi user field"
+ expect(page).to have_css "opce-principal", count: 2
+ expect(page).to have_text "Member 1 In Project"
+ expect(page).to have_text "Member 2 In Project"
+ end
+ end
+ end
+ end
+
+ describe "with no value set by user" do
+ before do
+ multi_user_project_custom_field.custom_values.where(customized: project).destroy_all
+ end
+
+ it "shows an N/A text for the project custom field if no value given" do
+ overview_page.visit_page
+
+ overview_page.within_async_loaded_sidebar do
+ overview_page.within_custom_field_container(multi_user_project_custom_field) do
+ expect(page).to have_text "Multi user field"
+ expect(page).to have_text I18n.t("placeholders.default")
+ end
+ end
+ end
+ end
+ end
+ end
+end
diff --git a/spec/features/projects/project_custom_fields/settings/mapping_spec.rb b/spec/features/projects/project_custom_fields/settings/mapping_spec.rb
new file mode 100644
index 000000000000..61db89df1e04
--- /dev/null
+++ b/spec/features/projects/project_custom_fields/settings/mapping_spec.rb
@@ -0,0 +1,448 @@
+#-- copyright
+# OpenProject is an open source project management software.
+# Copyright (C) 2012-2023 the OpenProject GmbH
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+#
+# See COPYRIGHT and LICENSE files for more details.
+#++
+
+require 'spec_helper'
+
+RSpec.describe 'Projects custom fields mapping via project settings', :js, :with_cuprite do
+ let(:project) { create(:project, name: 'Foo project', identifier: 'foo-project') }
+ let(:other_project) { create(:project, name: 'Bar project', identifier: 'bar-project') }
+
+ let!(:user_with_sufficient_permissions) do
+ create(:user,
+ firstname: 'Project',
+ lastname: 'Admin',
+ member_with_permissions: {
+ project => %w[
+ view_work_packages
+ edit_project
+ select_project_custom_fields
+ ],
+ other_project => %w[
+ view_work_packages
+ edit_project
+ select_project_custom_fields
+ ]
+ })
+ end
+
+ let!(:member_in_project) do
+ create(:user,
+ firstname: 'Member 1',
+ lastname: 'In Project',
+ member_with_permissions: { project => %w[
+ edit_project
+ view_work_packages
+ ] })
+ end
+
+ let!(:another_member_in_project) do
+ create(:user,
+ firstname: 'Member 2',
+ lastname: 'In Project',
+ member_with_permissions: { project => %w[
+ view_work_packages
+ ] })
+ end
+
+ let!(:section_for_input_fields) { create(:project_custom_field_section, name: 'Input fields') }
+ let!(:section_for_select_fields) { create(:project_custom_field_section, name: 'Select fields') }
+ let!(:section_for_multi_select_fields) { create(:project_custom_field_section, name: 'Multi select fields') }
+
+ let!(:boolean_project_custom_field) do
+ create(:boolean_project_custom_field, name: 'Boolean field',
+ project_custom_field_section: section_for_input_fields)
+ end
+
+ let!(:string_project_custom_field) do
+ create(:string_project_custom_field, name: 'String field',
+ project_custom_field_section: section_for_input_fields)
+ end
+
+ let!(:list_project_custom_field) do
+ create(:list_project_custom_field, name: 'List field',
+ project_custom_field_section: section_for_select_fields,
+ possible_values: ['Option 1', 'Option 2', 'Option 3'])
+ end
+
+ let!(:multi_list_project_custom_field) do
+ create(:list_project_custom_field, name: 'Multi list field',
+ project_custom_field_section: section_for_multi_select_fields,
+ possible_values: ['Option 1', 'Option 2', 'Option 3'],
+ multi_value: true)
+ end
+
+ describe 'with insufficient permissions' do
+ before do
+ login_as member_in_project # can edit project but is not allowed to select project custom fields
+ end
+
+ it 'does not show the menu entry in the project settings menu' do
+ visit project_settings_general_path(project)
+
+ within '#menu-sidebar' do
+ expect(page).to have_no_css("li[data-name='settings_project_custom_fields']")
+ end
+ end
+
+ it 'does not show the project custom fields page' do
+ visit project_settings_project_custom_fields_path(project)
+
+ expect(page).to have_content('You are not authorized to access this page.')
+ end
+ end
+
+ describe 'with sufficient permissions' do
+ before do
+ login_as user_with_sufficient_permissions
+ end
+
+ it 'does show the menu entry in the project settings menu' do
+ visit project_settings_general_path(project)
+
+ within '#menu-sidebar' do
+ expect(page).to have_css("li[data-name='settings_project_custom_fields']")
+ end
+ end
+
+ it 'shows all available project custom fields with their correct mapping state' do
+ visit project_settings_project_custom_fields_path(project)
+
+ within_custom_field_section_container(section_for_input_fields) do
+ within_custom_field_container(boolean_project_custom_field) do
+ expect(page).to have_content('Boolean field')
+ expect_type("Bool")
+ expect_unchecked_state
+ end
+ within_custom_field_container(string_project_custom_field) do
+ expect(page).to have_content('String field')
+ expect_type("String")
+ expect_unchecked_state
+ end
+ end
+
+ within_custom_field_section_container(section_for_select_fields) do
+ within_custom_field_container(list_project_custom_field) do
+ expect(page).to have_content('List field')
+ expect_type("List")
+ expect_unchecked_state
+ end
+ end
+
+ within_custom_field_section_container(section_for_multi_select_fields) do
+ within_custom_field_container(multi_list_project_custom_field) do
+ expect(page).to have_content('Multi list field')
+ expect_type("List")
+ expect_unchecked_state
+ end
+ end
+ end
+
+ it 'toggles the mapping state of a project custom field for a specific project when clicked' do
+ visit project_settings_project_custom_fields_path(project)
+
+ within_custom_field_section_container(section_for_input_fields) do
+ within_custom_field_container(boolean_project_custom_field) do
+ expect_unchecked_state
+
+ page.find("[data-qa-selector='toggle-project-custom-field-mapping-#{boolean_project_custom_field.id}'] > button").click
+
+ expect_checked_state # without reloading the page
+ end
+ end
+
+ # propely persisted and visible after full page reload
+ visit project_settings_project_custom_fields_path(project)
+
+ within_custom_field_container(boolean_project_custom_field) do
+ expect_checked_state
+ end
+
+ # only for this project
+ visit project_settings_project_custom_fields_path(other_project)
+
+ within_custom_field_container(boolean_project_custom_field) do
+ expect_unchecked_state
+ end
+ end
+
+ it 'enables all mapping states of a section for a specific project when bulk action button clicked' do
+ visit project_settings_project_custom_fields_path(project)
+
+ within_custom_field_section_container(section_for_input_fields) do
+ page.find("[data-qa-selector='enable-all-project-custom-field-mappings-#{section_for_input_fields.id}']").click
+
+ within_custom_field_container(boolean_project_custom_field) do
+ expect_checked_state
+ end
+ within_custom_field_container(string_project_custom_field) do
+ expect_checked_state
+ end
+ end
+
+ within_custom_field_section_container(section_for_select_fields) do
+ within_custom_field_container(list_project_custom_field) do
+ expect_unchecked_state
+ end
+ end
+
+ within_custom_field_section_container(section_for_multi_select_fields) do
+ within_custom_field_container(multi_list_project_custom_field) do
+ expect_unchecked_state
+ end
+ end
+ end
+
+ it 'disables all mapping states of a section for a specific project when bulk action button clicked' do
+ visit project_settings_project_custom_fields_path(project)
+
+ within_custom_field_section_container(section_for_input_fields) do
+ page.find("[data-qa-selector='enable-all-project-custom-field-mappings-#{section_for_input_fields.id}']").click
+
+ within_custom_field_container(boolean_project_custom_field) do
+ expect_checked_state
+ end
+ within_custom_field_container(string_project_custom_field) do
+ expect_checked_state
+ end
+ end
+
+ within_custom_field_section_container(section_for_select_fields) do
+ within_custom_field_container(list_project_custom_field) do
+ expect_unchecked_state
+ end
+ end
+
+ within_custom_field_section_container(section_for_multi_select_fields) do
+ within_custom_field_container(multi_list_project_custom_field) do
+ expect_unchecked_state
+ end
+ end
+
+ within_custom_field_section_container(section_for_input_fields) do
+ page.find("[data-qa-selector='disable-all-project-custom-field-mappings-#{section_for_input_fields.id}']").click
+
+ within_custom_field_container(boolean_project_custom_field) do
+ expect_unchecked_state
+ end
+ within_custom_field_container(string_project_custom_field) do
+ expect_unchecked_state
+ end
+ end
+ end
+
+ it 'filters the project custom fields by name with given user input' do
+ visit project_settings_project_custom_fields_path(project)
+
+ fill_in 'project-custom-fields-mapping-filter', with: 'Boolean'
+
+ within_custom_field_section_container(section_for_input_fields) do
+ expect(page).to have_content('Boolean field')
+ expect(page).to have_no_content('String field')
+ end
+
+ within_custom_field_section_container(section_for_select_fields) do
+ expect(page).to have_no_content('List field')
+ end
+
+ within_custom_field_section_container(section_for_multi_select_fields) do
+ expect(page).to have_no_content('Multi list field')
+ end
+ end
+
+ it 'shows the project custom field sections in the correct order' do
+ visit project_settings_project_custom_fields_path(project)
+
+ sections = page.all('.op-project-custom-field-section')
+
+ expect(sections.size).to eq(3)
+
+ expect(sections[0].text).to include('Input fields')
+ expect(sections[1].text).to include('Select fields')
+ expect(sections[2].text).to include('Multi select fields')
+
+ section_for_input_fields.move_to_bottom
+
+ visit project_settings_project_custom_fields_path(project)
+
+ sections = page.all('.op-project-custom-field-section')
+
+ expect(sections.size).to eq(3)
+
+ expect(sections[0].text).to include('Select fields')
+ expect(sections[1].text).to include('Multi select fields')
+ expect(sections[2].text).to include('Input fields')
+ end
+
+ it 'shows the project custom fields in the correct order within the sections' do
+ visit project_settings_project_custom_fields_path(project)
+
+ within_custom_field_section_container(section_for_input_fields) do
+ custom_fields = page.all('.op-project-custom-field')
+
+ expect(custom_fields.size).to eq(2)
+
+ expect(custom_fields[0].text).to include('Boolean field')
+ expect(custom_fields[1].text).to include('String field')
+ end
+
+ boolean_project_custom_field.move_to_bottom
+
+ visit project_settings_project_custom_fields_path(project)
+
+ within_custom_field_section_container(section_for_input_fields) do
+ custom_fields = page.all('.op-project-custom-field')
+
+ expect(custom_fields.size).to eq(2)
+
+ expect(custom_fields[0].text).to include('String field')
+ expect(custom_fields[1].text).to include('Boolean field')
+ end
+ end
+
+ context 'with visibility of project custom fields' do
+ let!(:section_with_invisible_fields) { create(:project_custom_field_section, name: 'Section with invisible fields') }
+
+ let!(:visible_project_custom_field) do
+ create(:project_custom_field,
+ name: 'Normal field',
+ visible: true,
+ projects: [project],
+ project_custom_field_section: section_with_invisible_fields)
+ end
+
+ let!(:invisible_project_custom_field) do
+ create(:project_custom_field,
+ name: 'Admin only field',
+ visible: false,
+ projects: [project],
+ project_custom_field_section: section_with_invisible_fields)
+ end
+
+ context 'with admin permissions' do
+ let!(:admin) do
+ create(:admin)
+ end
+
+ before do
+ login_as admin
+ visit project_settings_project_custom_fields_path(project)
+ end
+
+ it 'shows the invisible project custom fields' do
+ within_custom_field_section_container(section_with_invisible_fields) do
+ expect(page).to have_content('Normal field')
+ expect(page).to have_content('Admin only field')
+ end
+ end
+
+ it 'includeds the invisible project custom fields in the bulk actions' do
+ within_custom_field_section_container(section_with_invisible_fields) do
+ page.find("[data-qa-selector='disable-all-project-custom-field-mappings-#{section_with_invisible_fields.id}']").click
+
+ within_custom_field_container(visible_project_custom_field) do
+ expect_unchecked_state
+ end
+ within_custom_field_container(invisible_project_custom_field) do
+ expect_unchecked_state
+ end
+
+ page.find("[data-qa-selector='enable-all-project-custom-field-mappings-#{section_with_invisible_fields.id}']").click
+
+ within_custom_field_container(visible_project_custom_field) do
+ expect_checked_state
+ end
+ within_custom_field_container(invisible_project_custom_field) do
+ expect_checked_state
+ end
+ end
+ end
+ end
+
+ context 'with non-admin permissions' do
+ before do
+ login_as user_with_sufficient_permissions
+ visit project_settings_project_custom_fields_path(project)
+ end
+
+ it 'does not show the invisible project custom fields' do
+ within_custom_field_section_container(section_with_invisible_fields) do
+ expect(page).to have_content('Normal field')
+ expect(page).to have_no_content('Admin only field')
+ end
+ end
+
+ it 'does not include the invisible project custom fields in the bulk actions' do
+ within_custom_field_section_container(section_with_invisible_fields) do
+ page.find("[data-qa-selector='disable-all-project-custom-field-mappings-#{section_with_invisible_fields.id}']").click
+
+ within_custom_field_container(visible_project_custom_field) do
+ expect_unchecked_state
+ end
+
+ # the invisible field is not affected by the bulk action
+ expect(project.project_custom_fields).to include(invisible_project_custom_field)
+
+ # disable manually
+ project.project_custom_field_project_mappings.find_by(custom_field_id: invisible_project_custom_field.id).destroy!
+
+ page.find("[data-qa-selector='enable-all-project-custom-field-mappings-#{section_with_invisible_fields.id}']").click
+
+ within_custom_field_container(visible_project_custom_field) do
+ expect_checked_state
+ end
+
+ # the invisible field is not affected by the bulk action
+ expect(project.project_custom_fields).not_to include(invisible_project_custom_field)
+ end
+ end
+ end
+ end
+ end
+
+ def expect_type(type)
+ within "[data-qa-selector='custom-field-type']" do
+ expect(page).to have_content(type)
+ end
+ end
+
+ def expect_checked_state
+ expect(page).to have_css('.ToggleSwitch-statusOn')
+ end
+
+ def expect_unchecked_state
+ expect(page).to have_css('.ToggleSwitch-statusOff')
+ end
+
+ def within_custom_field_section_container(section, &)
+ within("[data-qa-selector='project-custom-field-section-#{section.id}']", &)
+ end
+
+ def within_custom_field_container(custom_field, &)
+ within("[data-qa-selector='project-custom-field-#{custom_field.id}']", &)
+ end
+end
diff --git a/spec/features/projects/projects_custom_fields_spec.rb b/spec/features/projects/projects_custom_fields_spec.rb
index 856274324bd5..60aba1edbcd2 100644
--- a/spec/features/projects/projects_custom_fields_spec.rb
+++ b/spec/features/projects/projects_custom_fields_spec.rb
@@ -96,7 +96,10 @@
default_int_field.expect_value default_int_custom_field.default_value.to_s
default_string_field.expect_value 'Overwritten'
- no_default_string_field.expect_value ''
+
+ # The custom field without default value should not be shown
+ # as it didn't got activated with a value during project creation
+ expect(page).to have_no_css("[data-qa-field-name='customField#{no_default_string_custom_field.id}']")
end
end
@@ -106,6 +109,11 @@
end
let(:editor) { Components::WysiwygEditor.new "[data-qa-field-name='customField#{custom_field.id}']" }
+ before do
+ # enable the custom field for the project
+ project.project_custom_fields << custom_field
+ end
+
it 'allows settings the project boolean CF (regression #26313)' do
visit project_settings_general_path(project.id)
@@ -196,6 +204,11 @@
create(:boolean_project_custom_field)
end
+ before do
+ # enable the custom field for the project
+ project.project_custom_fields << custom_field
+ end
+
it 'allows settings the project boolean CF (regression #26313)' do
visit project_settings_general_path(project.id)
field = page.find(identifier)
@@ -256,6 +269,8 @@
end
it 'allows inviting a new user immediately (regression #39166)' do
+ project.project_custom_fields << custom_field # enable the custom field for the project
+
visit project_settings_general_path(project.id)
cf_field.expect_visible
diff --git a/spec/features/projects/projects_index_spec.rb b/spec/features/projects/projects_index_spec.rb
index 1e3095b6e6e0..ab09bd73b957 100644
--- a/spec/features/projects/projects_index_spec.rb
+++ b/spec/features/projects/projects_index_spec.rb
@@ -822,6 +822,15 @@ def expect_projects_in_order(*projects)
expect(page).to have_text(project_created_on_today.name)
expect(page).to have_no_text(project_created_on_fixed_date.name)
+
+ # Disabling a CF in the project should remove the project from results
+
+ project_created_on_today.project_custom_field_project_mappings.destroy_all
+ click_on 'Apply'
+ wait_for_reload
+
+ expect(page).to have_no_text(project_created_on_today.name, wait: 1)
+ expect(page).to have_no_text(project_created_on_fixed_date.name)
end
pending "NOT WORKING YET: Date vs. DateTime issue: Selecting same date for from and to value shows projects of that date"
diff --git a/spec/features/work_packages/attachments/attachment_upload_spec.rb b/spec/features/work_packages/attachments/attachment_upload_spec.rb
index 274ba35ff1e7..d4e6516473d5 100644
--- a/spec/features/work_packages/attachments/attachment_upload_spec.rb
+++ b/spec/features/work_packages/attachments/attachment_upload_spec.rb
@@ -26,26 +26,26 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'features/page_objects/notification'
+require "spec_helper"
+require "features/page_objects/notification"
-RSpec.describe 'Upload attachment to work package', :js, :with_cuprite do
+RSpec.describe "Upload attachment to work package", :js, :with_cuprite do
let(:role) do
create(:project_role,
permissions: %i[view_work_packages add_work_packages edit_work_packages add_work_package_notes])
end
let(:dev) do
create(:user,
- firstname: 'Dev',
- lastname: 'Guy',
+ firstname: "Dev",
+ lastname: "Guy",
member_with_roles: { project => role })
end
let(:project) { create(:project) }
- let(:work_package) { create(:work_package, project:, description: 'Initial description') }
+ let(:work_package) { create(:work_package, project:, description: "Initial description") }
let(:wp_page) { Pages::FullWorkPackage.new(work_package, project) }
let(:attachments) { Components::Attachments.new }
- let(:field) { TextEditorField.new wp_page, 'description' }
- let(:image_fixture) { UploadedFile.load_from('spec/fixtures/files/image.png') }
+ let(:field) { TextEditorField.new wp_page, "description" }
+ let(:image_fixture) { UploadedFile.load_from("spec/fixtures/files/image.png") }
let(:editor) { Components::WysiwygEditor.new }
before do
@@ -54,78 +54,78 @@
wp_page.ensure_page_loaded
end
- describe 'wysiwyg editor' do
- context 'when on an existing page' do
+ describe "wysiwyg editor" do
+ context "when on an existing page" do
before do
wp_page.visit!
wp_page.ensure_page_loaded
end
- it 'can upload an image via drag & drop' do
+ it "can upload an image via drag & drop" do
# Activate the edit field
field.activate!
- editor.expect_button 'Upload image from computer'
+ editor.expect_button "Upload image from computer"
- editor.drag_attachment image_fixture.path, 'Some image caption'
+ editor.drag_attachment image_fixture.path, "Some image caption"
field.submit_by_click
- expect(field.display_element).to have_css('img')
- expect(field.display_element).to have_content('Some image caption')
+ expect(field.display_element).to have_css("img")
+ expect(field.display_element).to have_content("Some image caption")
end
- context 'when editing comment' do
- let(:selector) { '.work-packages--activity--add-comment' }
+ context "when editing comment" do
+ let(:selector) { ".work-packages--activity--add-comment" }
let(:comment_field) do
TextEditorField.new wp_page,
- 'comment',
+ "comment",
selector:
end
- let(:editor) { Components::WysiwygEditor.new '.work-packages--activity--add-comment' }
+ let(:editor) { Components::WysiwygEditor.new ".work-packages--activity--add-comment" }
- context 'with a user that is not allowed to add images (Regression #28541)' do
+ context "with a user that is not allowed to add images (Regression #28541)" do
let(:role) do
create(:project_role,
permissions: %i[view_work_packages add_work_packages add_work_package_notes])
end
- it 'can open the editor to add an image, but image upload is not shown' do
+ it "can open the editor to add an image, but image upload is not shown" do
# Add comment
comment_field.activate!
# Button should be hidden
- editor.expect_no_button 'Upload image from computer'
+ editor.expect_no_button "Upload image from computer"
- editor.click_and_type_slowly 'this is a comment!1'
+ editor.click_and_type_slowly "this is a comment!1"
comment_field.submit_by_click
- wp_page.expect_comment text: 'this is a comment!1'
+ wp_page.expect_comment text: "this is a comment!1"
end
end
- context 'with a user that is allowed add attachments but not edit WP (#29203)' do
+ context "with a user that is allowed add attachments but not edit WP (#29203)" do
let(:role) do
create(:project_role,
permissions: %i[view_work_packages add_work_package_attachments add_work_package_notes])
end
- it 'can open the editor and image upload is shown' do
+ it "can open the editor and image upload is shown" do
comment_field.activate!
- editor.expect_button 'Upload image from computer'
+ editor.expect_button "Upload image from computer"
- editor.click_and_type_slowly 'this is a comment!2'
- editor.drag_attachment image_fixture.path, 'Some image caption'
+ editor.click_and_type_slowly "this is a comment!2"
+ editor.drag_attachment image_fixture.path, "Some image caption"
comment_field.submit_by_click
- wp_page.expect_comment text: 'this is a comment!2'
+ wp_page.expect_comment text: "this is a comment!2"
end
end
end
end
- context 'when on a split page' do
+ context "when on a split page" do
let!(:type) { create(:type_task) }
let!(:status) { create(:status, is_default: true) }
let!(:priority) { create(:priority, is_default: true) }
@@ -134,13 +134,13 @@
end
let!(:table) { Pages::WorkPackagesTable.new project }
- it 'can add two work packages in a row when uploading (Regression #42933)' do |example|
+ it "can add two work packages in a row when uploading (Regression #42933)" do |example|
table.visit!
new_page = table.create_wp_by_button type
subject = new_page.edit_field :subject
- subject.set_value 'My subject'
+ subject.set_value "My subject"
- target = find('.ck-content')
+ target = find(".ck-content")
attachments.drag_and_drop_file(target, image_fixture.path)
sleep 2 unless example.metadata[:with_cuprite]
@@ -148,39 +148,39 @@
editor.in_editor do |_container, editable|
expect(editable).to have_css('img[src*="/api/v3/attachments/"]', wait: 20)
- expect(editable).to have_no_css('.ck-upload-placeholder-loader')
+ expect(editable).to have_no_css(".ck-upload-placeholder-loader")
end
sleep 2 unless example.metadata[:with_cuprite]
- scroll_to_and_click find_by_id('work-packages--edit-actions-save')
+ scroll_to_and_click find_by_id("work-packages--edit-actions-save")
new_page.expect_and_dismiss_toaster(
- message: 'Successful creation.'
+ message: "Successful creation."
)
split_view = Pages::SplitWorkPackage.new(WorkPackage.last)
field = split_view.edit_field :description
- expect(field.display_element).to have_css('img')
+ expect(field.display_element).to have_css("img")
wp = WorkPackage.last
- expect(wp.subject).to eq('My subject')
+ expect(wp.subject).to eq("My subject")
expect(wp.attachments.count).to eq(1)
# create another one
new_page = table.create_wp_by_button type
subject = new_page.edit_field :subject
- subject.set_value 'A second task'
+ subject.set_value "A second task"
- scroll_to_and_click find_by_id('work-packages--edit-actions-save')
+ scroll_to_and_click find_by_id("work-packages--edit-actions-save")
new_page.expect_toast(
- message: 'Successful creation.'
+ message: "Successful creation."
)
last = WorkPackage.last
- expect(last.subject).to eq('A second task')
+ expect(last.subject).to eq("A second task")
expect(last.attachments.count).to eq(0)
wp.reload
@@ -188,8 +188,8 @@
end
end
- context 'when on a new page' do
- shared_examples 'it supports image uploads via drag & drop' do
+ context "when on a new page" do
+ shared_examples "it supports image uploads via drag & drop" do
let!(:new_page) { Pages::FullWorkPackageCreate.new }
let!(:type) { create(:type_task) }
let!(:status) { create(:status, is_default: true) }
@@ -204,11 +204,11 @@
visit new_project_work_packages_path(project.identifier, type: type.id)
end
- it 'can upload an image via drag & drop (Regression #28189)' do |example|
+ it "can upload an image via drag & drop (Regression #28189)" do |example|
subject = new_page.edit_field :subject
- subject.set_value 'My subject'
+ subject.set_value "My subject"
- target = find('.ck-content')
+ target = find(".ck-content")
attachments.drag_and_drop_file(target, image_fixture.path)
sleep 2 unless example.metadata[:with_cuprite]
@@ -216,29 +216,29 @@
editor.in_editor do |_container, editable|
expect(editable).to have_css('img[src*="/api/v3/attachments/"]', wait: 20)
- expect(editable).to have_no_css('.ck-upload-placeholder-loader')
+ expect(editable).to have_no_css(".ck-upload-placeholder-loader")
end
sleep 2 unless example.metadata[:with_cuprite]
- scroll_to_and_click find_by_id('work-packages--edit-actions-save')
+ scroll_to_and_click find_by_id("work-packages--edit-actions-save")
wp_page.expect_toast(
- message: 'Successful creation.'
+ message: "Successful creation."
)
field = wp_page.edit_field :description
- expect(field.display_element).to have_css('img')
+ expect(field.display_element).to have_css("img")
wp = WorkPackage.last
- expect(wp.subject).to eq('My subject')
+ expect(wp.subject).to eq("My subject")
expect(wp.attachments.count).to eq(1)
post_conditions
end
end
- it_behaves_like 'it supports image uploads via drag & drop'
+ it_behaves_like "it supports image uploads via drag & drop"
# We do a complete integration test for direct uploads on this example.
# If this works all parts in the backend and frontend work properly together.
@@ -247,12 +247,12 @@
# everywhere so if this works it should work everywhere else too.
# TODO: Add better_cuprite_billy. I'm not sure what needs to be set up so the request to AWS passes.
# Need help
- context 'with direct uploads', :with_direct_uploads, with_cuprite: false do
+ context "with direct uploads", :with_direct_uploads, with_cuprite: false do
before do
allow_any_instance_of(Attachment).to receive(:diskfile).and_return Struct.new(:path).new(image_fixture.path.to_s)
end
- it_behaves_like 'it supports image uploads via drag & drop' do
+ it_behaves_like "it supports image uploads via drag & drop" do
let(:post_conditions) do
# check the attachment was created successfully
expect(Attachment.count).to eq 1
@@ -267,58 +267,58 @@
end
end
- describe 'attachment dropzone' do
- shared_examples 'attachment dropzone common' do
- it 'can drag something to the files tab and have it open' do
- wp_page.expect_tab 'Activity'
- attachments.drag_and_drop_file test_selector('op-attachments--drop-box'),
+ describe "attachment dropzone" do
+ shared_examples "attachment dropzone common" do
+ it "can drag something to the files tab and have it open" do
+ wp_page.expect_tab "Activity"
+ attachments.drag_and_drop_file test_selector("op-attachments--drop-box"),
image_fixture.path,
:center,
page.find('[data-qa-tab-id="files"]'),
delay_dragleave: true
- expect(page).to have_test_selector('op-files-tab--file-list-item-title', text: 'image.png', wait: 10)
+ expect(page).to have_test_selector("op-files-tab--file-list-item-title", text: "image.png", wait: 10)
editor.wait_until_upload_progress_toaster_cleared
- wp_page.expect_tab 'Files'
+ wp_page.expect_tab "Files"
end
- it 'can drag something from the files tab and create a comment with it' do
- wp_page.switch_to_tab(tab: 'files')
+ it "can drag something from the files tab and create a comment with it" do
+ wp_page.switch_to_tab(tab: "files")
- attachments.drag_and_drop_file '.work-package-comment',
+ attachments.drag_and_drop_file ".work-package-comment",
image_fixture.path,
:center,
page.find('[data-qa-tab-id="activity"]'),
delay_dragleave: true
- wp_page.expect_tab 'Activity'
+ wp_page.expect_tab "Activity"
end
end
- include_examples 'attachment dropzone common'
+ include_examples "attachment dropzone common"
- context 'with a user that is allowed to add attachments but not edit WP (#29203)' do
+ context "with a user that is allowed to add attachments but not edit WP (#29203)" do
let(:role) do
create(:project_role,
permissions: %i[view_work_packages add_work_package_attachments add_work_package_notes])
end
- include_examples 'attachment dropzone common'
+ include_examples "attachment dropzone common"
end
# This one is not shared, because it requires edit WP
- it 'can upload an image via attaching and drag & drop' do
- wp_page.switch_to_tab(tab: 'files')
- container = page.find_test_selector('op-attachments--drop-box')
+ it "can upload an image via attaching and drag & drop" do
+ wp_page.switch_to_tab(tab: "files")
+ container = page.find_test_selector("op-attachments--drop-box")
##
# Attach file manually
- expect(page).not_to have_test_selector('op-files-tab--file-list-item-title')
+ expect(page).not_to have_test_selector("op-files-tab--file-list-item-title")
attachments.attach_file_on_input(image_fixture.path)
editor.wait_until_upload_progress_toaster_cleared
expect(page)
- .to have_test_selector('op-files-tab--file-list-item-title',
- text: 'image.png',
+ .to have_test_selector("op-files-tab--file-list-item-title",
+ text: "image.png",
wait: 5)
# Drop zone should become hidden again
@@ -332,8 +332,8 @@
attachments.drag_and_drop_file(container, image_fixture.path)
editor.wait_until_upload_progress_toaster_cleared
expect(page)
- .to have_test_selector('op-files-tab--file-list-item-title',
- text: 'image.png',
+ .to have_test_selector("op-files-tab--file-list-item-title",
+ text: "image.png",
count: 2,
wait: 5)
@@ -345,12 +345,12 @@
attachments.drag_and_drop_file container,
image_fixture.path,
:center,
- ["#{field.selector} #{field.display_selector}", '.work-package--single-view']
+ ["#{field.selector} #{field.display_selector}", ".work-package--single-view"]
editor.wait_until_upload_progress_toaster_cleared
expect(page)
- .to have_test_selector('op-files-tab--file-list-item-title',
- text: 'image.png',
+ .to have_test_selector("op-files-tab--file-list-item-title",
+ text: "image.png",
count: 3,
wait: 5)
@@ -368,8 +368,8 @@
editor.wait_until_upload_progress_toaster_cleared
expect(page)
- .to have_test_selector('op-files-tab--file-list-item-title',
- text: 'image.png',
+ .to have_test_selector("op-files-tab--file-list-item-title",
+ text: "image.png",
count: 3,
wait: 5)
diff --git a/spec/features/work_packages/details/markdown/todolist_spec.rb b/spec/features/work_packages/details/markdown/todolist_spec.rb
index c78914665e16..4e03179a6f03 100644
--- a/spec/features/work_packages/details/markdown/todolist_spec.rb
+++ b/spec/features/work_packages/details/markdown/todolist_spec.rb
@@ -26,117 +26,117 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Todolists in CKEditor', :js do
+RSpec.describe "Todolists in CKEditor", :js do
let(:user) { create(:admin) }
before do
login_as user
end
- describe 'with an existing work package' do
+ describe "with an existing work package" do
let(:work_package) { create(:work_package) }
let(:wp_page) { Pages::FullWorkPackage.new(work_package) }
let(:field) { wp_page.edit_field :description }
let(:ckeditor) { field.ckeditor }
- it 'can add task list and edit them again' do
+ it "can add task list and edit them again" do
wp_page.visit!
wp_page.ensure_page_loaded
field.activate!
ckeditor.clear
- ckeditor.click_toolbar_button 'To-do List'
- ckeditor.type_slowly 'Todo item 1'
+ ckeditor.click_toolbar_button "To-do List"
+ ckeditor.type_slowly "Todo item 1"
ckeditor.type_slowly :enter
- ckeditor.type_slowly 'Todo item 2'
+ ckeditor.type_slowly "Todo item 2"
ckeditor.type_slowly :enter
# Indent
ckeditor.type_slowly :tab
- ckeditor.type_slowly 'Nested item 1'
+ ckeditor.type_slowly "Nested item 1"
ckeditor.type_slowly :enter
- ckeditor.type_slowly 'Nested item 2'
+ ckeditor.type_slowly "Nested item 2"
ckeditor.type_slowly :enter
# Outdent
ckeditor.type_slowly %i[shift tab]
- ckeditor.type_slowly 'Todo item 3'
+ ckeditor.type_slowly "Todo item 3"
# Select first and first nested item
ckeditor.in_editor do |_container, editable|
- first_item = editable.all('.todo-list li')[0]
- first_item.find('input[type=checkbox]', visible: :all).set true
+ first_item = editable.all(".todo-list li")[0]
+ first_item.find("input[type=checkbox]", visible: :all).set true
# First nested
- first_nested_item = editable.all('.todo-list .todo-list li')[0]
- first_nested_item.find('input[type=checkbox]', visible: :all).set true
+ first_nested_item = editable.all(".todo-list .todo-list li")[0]
+ first_nested_item.find("input[type=checkbox]", visible: :all).set true
sleep 0.5
end
field.submit_by_click
- wp_page.expect_and_dismiss_toaster message: 'Successful update.'
+ wp_page.expect_and_dismiss_toaster message: "Successful update."
within(field.display_element) do
- expect(page).to have_css('.op-uc-list--task-checkbox', count: 5)
- expect(page).to have_css('.op-uc-list--task-checkbox[checked]', count: 2)
+ expect(page).to have_css(".op-uc-list--task-checkbox", count: 5)
+ expect(page).to have_css(".op-uc-list--task-checkbox[checked]", count: 2)
- expect(page).to have_css('.op-uc-list--item', text: 'Todo item 1')
- expect(page).to have_css('.op-uc-list--item', text: 'Todo item 2')
- expect(page).to have_css('.op-uc-list--item', text: 'Todo item 3')
+ expect(page).to have_css(".op-uc-list--item", text: "Todo item 1")
+ expect(page).to have_css(".op-uc-list--item", text: "Todo item 2")
+ expect(page).to have_css(".op-uc-list--item", text: "Todo item 3")
- expect(page).to have_css('.op-uc-list .op-uc-list .op-uc-list--item', text: 'Nested item 1')
- expect(page).to have_css('.op-uc-list .op-uc-list .op-uc-list--item', text: 'Nested item 2')
+ expect(page).to have_css(".op-uc-list .op-uc-list .op-uc-list--item", text: "Nested item 1")
+ expect(page).to have_css(".op-uc-list .op-uc-list .op-uc-list--item", text: "Nested item 2")
- first_item = page.find('.op-uc-list--item', text: 'Todo item 1')
- expect(first_item).to have_css('.op-uc-list--task-checkbox[checked]')
- first_nested_item = page.find('.op-uc-list .op-uc-list .op-uc-list--item', text: 'Nested item 1')
- expect(first_nested_item).to have_css('.op-uc-list--task-checkbox[checked]')
+ first_item = page.find(".op-uc-list--item", text: "Todo item 1")
+ expect(first_item).to have_css(".op-uc-list--task-checkbox[checked]")
+ first_nested_item = page.find(".op-uc-list .op-uc-list .op-uc-list--item", text: "Nested item 1")
+ expect(first_nested_item).to have_css(".op-uc-list--task-checkbox[checked]")
end
# Expect still the same when editing again
field.activate!
ckeditor.in_editor do |_container, editable|
- expect(editable).to have_css('.op-uc-list li', count: 5)
+ expect(editable).to have_css(".op-uc-list li", count: 5)
- first_item = editable.all('.op-uc-list li')[0].find('input[type=checkbox]', visible: :all)
+ first_item = editable.all(".op-uc-list li")[0].find("input[type=checkbox]", visible: :all)
expect(first_item).to be_checked
# First nested
- first_nested_item = editable.all('.op-uc-list .op-uc-list li')[0].find('input[type=checkbox]', visible: :all)
+ first_nested_item = editable.all(".op-uc-list .op-uc-list li")[0].find("input[type=checkbox]", visible: :all)
expect(first_nested_item).to be_checked
# Check last item
- last_item = editable.all('.op-uc-list li').last
- last_item.find('input[type=checkbox]', visible: :all).set true
+ last_item = editable.all(".op-uc-list li").last
+ last_item.find("input[type=checkbox]", visible: :all).set true
sleep 0.5
end
field.submit_by_click
- wp_page.expect_and_dismiss_toaster message: 'Successful update.'
+ wp_page.expect_and_dismiss_toaster message: "Successful update."
within(field.display_element) do
- expect(page).to have_css('.op-uc-list--task-checkbox', count: 5)
- expect(page).to have_css('.op-uc-list--task-checkbox[checked]', count: 3)
+ expect(page).to have_css(".op-uc-list--task-checkbox", count: 5)
+ expect(page).to have_css(".op-uc-list--task-checkbox[checked]", count: 3)
- first_item = page.find('.op-uc-list--item', text: 'Todo item 1')
- expect(first_item).to have_css('.op-uc-list--task-checkbox[checked]')
- first_nested_item = page.find('.op-uc-list .op-uc-list .op-uc-list--item', text: 'Nested item 1')
- expect(first_nested_item).to have_css('.op-uc-list--task-checkbox[checked]')
+ first_item = page.find(".op-uc-list--item", text: "Todo item 1")
+ expect(first_item).to have_css(".op-uc-list--task-checkbox[checked]")
+ first_nested_item = page.find(".op-uc-list .op-uc-list .op-uc-list--item", text: "Nested item 1")
+ expect(first_nested_item).to have_css(".op-uc-list--task-checkbox[checked]")
- last_item = page.find('.op-uc-list .op-uc-list--item', text: 'Todo item 3')
- expect(last_item).to have_css('.op-uc-list--task-checkbox[checked]')
+ last_item = page.find(".op-uc-list .op-uc-list--item", text: "Todo item 3")
+ expect(last_item).to have_css(".op-uc-list--task-checkbox[checked]")
end
end
end
- describe 'creating a new work package' do
+ describe "creating a new work package" do
let!(:status) { create(:default_status) }
let!(:priority) { create(:default_priority) }
let!(:type) { create(:type_task) }
@@ -148,45 +148,45 @@
before do
wp_page.visit!
- wp_page.edit_field(:subject).set_value 'Title'
+ wp_page.edit_field(:subject).set_value "Title"
field.expect_active!
ckeditor.clear
end
- it 'can add a task list with links in them (Regression #30920)' do
- ckeditor.click_toolbar_button 'To-do List'
- ckeditor.type_slowly 'Todo item 1'
+ it "can add a task list with links in them (Regression #30920)" do
+ ckeditor.click_toolbar_button "To-do List"
+ ckeditor.type_slowly "Todo item 1"
ckeditor.type_slowly :enter
- ckeditor.insert_link 'https://community.openproject.com'
+ ckeditor.insert_link "https://community.openproject.com"
ckeditor.type_slowly :enter
ckeditor.type_slowly :tab
- ckeditor.insert_link 'https://community.openproject.com/nested'
+ ckeditor.insert_link "https://community.openproject.com/nested"
# Update the link text, no idea how to do this differently
ckeditor.in_editor do |_container, editable|
- link = editable.find('.todo-list .todo-list a')
- link.set('This is a link')
+ link = editable.find(".todo-list .todo-list a")
+ link.set("This is a link")
sleep 0.5
end
# Select nested item
ckeditor.in_editor do |_container, editable|
- editable.find('.todo-list .todo-list input[type=checkbox]', visible: :all).set true
+ editable.find(".todo-list .todo-list input[type=checkbox]", visible: :all).set true
sleep 0.5
end
wp_page.save!
- wp_page.expect_and_dismiss_toaster message: 'Successful creation.'
+ wp_page.expect_and_dismiss_toaster message: "Successful creation."
- expect(page).to have_css('.op-uc-list--task-checkbox', count: 3)
- expect(page).to have_css('.op-uc-list--task-checkbox[checked]', count: 1)
+ expect(page).to have_css(".op-uc-list--task-checkbox", count: 3)
+ expect(page).to have_css(".op-uc-list--task-checkbox[checked]", count: 1)
expect(page).to have_css('.op-uc-list--item a[href="https://community.openproject.com/"]')
nested_link = page.find('.op-uc-list--item .op-uc-list--item a[href="https://community.openproject.com/nested"]')
- expect(nested_link.text).to eq 'This is a link'
+ expect(nested_link.text).to eq "This is a link"
description = WorkPackage.last.description
expected = <<~EOS
@@ -198,61 +198,61 @@
expect(description.strip).to eq expected.strip
end
- it 'can add task list and edit them again' do
- ckeditor.click_toolbar_button 'To-do List'
- ckeditor.type_slowly 'Todo item 1'
+ it "can add task list and edit them again" do
+ ckeditor.click_toolbar_button "To-do List"
+ ckeditor.type_slowly "Todo item 1"
ckeditor.type_slowly :enter
- ckeditor.type_slowly 'Todo item 2'
+ ckeditor.type_slowly "Todo item 2"
# Select first item
ckeditor.in_editor do |_container, editable|
- first_item = editable.all('.todo-list li')[0]
- first_item.find('input[type=checkbox]', visible: :all).set true
+ first_item = editable.all(".todo-list li")[0]
+ first_item.find("input[type=checkbox]", visible: :all).set true
sleep 0.5
end
wp_page.save!
- wp_page.expect_and_dismiss_toaster message: 'Successful creation.'
+ wp_page.expect_and_dismiss_toaster message: "Successful creation."
within(field.display_element) do
- expect(page).to have_css('.op-uc-list--task-checkbox', count: 2)
- expect(page).to have_css('.op-uc-list--task-checkbox[checked]', count: 1)
+ expect(page).to have_css(".op-uc-list--task-checkbox", count: 2)
+ expect(page).to have_css(".op-uc-list--task-checkbox[checked]", count: 1)
- expect(page).to have_css('.op-uc-list--item', text: 'Todo item 1')
- expect(page).to have_css('.op-uc-list--item', text: 'Todo item 2')
+ expect(page).to have_css(".op-uc-list--item", text: "Todo item 1")
+ expect(page).to have_css(".op-uc-list--item", text: "Todo item 2")
- first_item = page.find('.op-uc-list--item', text: 'Todo item 1')
- expect(first_item).to have_css('.op-uc-list--task-checkbox[checked]')
+ first_item = page.find(".op-uc-list--item", text: "Todo item 1")
+ expect(first_item).to have_css(".op-uc-list--task-checkbox[checked]")
end
# Expect still the same when editing again
field.activate!
ckeditor.in_editor do |_container, editable|
- expect(editable).to have_css('.todo-list li', count: 2)
+ expect(editable).to have_css(".todo-list li", count: 2)
- first_item = editable.all('.todo-list li')[0].find('input[type=checkbox]', visible: :all)
+ first_item = editable.all(".todo-list li")[0].find("input[type=checkbox]", visible: :all)
expect(first_item).to be_checked
# Check last item
- last_item = editable.all('.todo-list li').last
- last_item.find('input[type=checkbox]', visible: :all).set true
+ last_item = editable.all(".todo-list li").last
+ last_item.find("input[type=checkbox]", visible: :all).set true
sleep 0.5
end
field.submit_by_click
- wp_page.expect_and_dismiss_toaster message: 'Successful update.'
+ wp_page.expect_and_dismiss_toaster message: "Successful update."
within(field.display_element) do
- expect(page).to have_css('.op-uc-list--task-checkbox', count: 2)
- expect(page).to have_css('.op-uc-list--task-checkbox[checked]', count: 2)
+ expect(page).to have_css(".op-uc-list--task-checkbox", count: 2)
+ expect(page).to have_css(".op-uc-list--task-checkbox[checked]", count: 2)
- first_item = page.find('.op-uc-list--item', text: 'Todo item 1')
- expect(first_item).to have_css('.op-uc-list--task-checkbox[checked]')
+ first_item = page.find(".op-uc-list--item", text: "Todo item 1")
+ expect(first_item).to have_css(".op-uc-list--task-checkbox[checked]")
- last_item = page.find('.op-uc-list .op-uc-list--item', text: 'Todo item 2')
- expect(last_item).to have_css('.op-uc-list--task-checkbox[checked]')
+ last_item = page.find(".op-uc-list .op-uc-list--item", text: "Todo item 2")
+ expect(last_item).to have_css(".op-uc-list--task-checkbox[checked]")
end
end
end
diff --git a/spec/fixtures/ldap/users.ldif b/spec/fixtures/ldap/users.ldif
index e369e7cd773f..1daaeed36865 100644
--- a/spec/fixtures/ldap/users.ldif
+++ b/spec/fixtures/ldap/users.ldif
@@ -182,3 +182,17 @@ mail: xara@example.org
uid: xx396
userpassword:: e1NIQX1ZYzJFbjJSL3NiZGpsRU9pdGtMbGt3WTRqQVk9
+dn: uid=bölle,ou=people,dc=example,dc=com
+objectClass: inetOrgPerson
+objectClass: simulatedMicrosoftSecurityPrincipal
+objectClass: organizationalPerson
+objectClass: person
+objectClass: top
+cn: Bölle Büllendorf
+sn: Büllendorf
+givenName: Bölle
+mail: boelle@example.org
+uid: bölle
+samAccountName: bölle
+# Password is "bólle"
+userpassword:: e1NIQX1rNDBGWHRYQ3RFL3l2cENhblRpQmZ2cE1ON1k9Cg==
diff --git a/spec/lib/open_project/appsignal_spec.rb b/spec/lib/open_project/appsignal_spec.rb
new file mode 100644
index 000000000000..3cf4c8d4f1a5
--- /dev/null
+++ b/spec/lib/open_project/appsignal_spec.rb
@@ -0,0 +1,70 @@
+# frozen_string_literal: true
+
+#-- copyright
+# OpenProject is an open source project management software.
+# Copyright (C) 2012-2024 the OpenProject GmbH
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+#
+# See COPYRIGHT and LICENSE files for more details.
+#++
+
+require "spec_helper"
+require "appsignal"
+
+RSpec.describe OpenProject::Appsignal do
+ describe ".exception_handler" do
+ let(:exception) { StandardError.new("I am a fake exception") }
+
+ before do
+ allow(Appsignal).to receive(:active?).and_return(true)
+ allow(Appsignal).to receive(:send_error)
+ end
+
+ it "does nothing if there is no exception in the log context" do
+ described_class.exception_handler("message")
+ expect(Appsignal).not_to have_received(:send_error)
+ end
+
+ it "stores the exception in current appsignal transaction if one is available" do
+ transaction = Appsignal::Transaction.create(
+ SecureRandom.uuid,
+ Appsignal::Transaction::BACKGROUND_JOB,
+ Appsignal::Transaction::GenericRequest.new({})
+ )
+ allow(transaction).to receive(:set_error)
+ described_class.exception_handler("message", exception:)
+
+ expect(transaction).to have_received(:set_error).with(exception)
+ expect(Appsignal).not_to have_received(:send_error)
+ ensure
+ Appsignal::Transaction.complete_current!
+ end
+
+ it "sends an error through Appsignal if no current appsignal transaction available" do
+ allow(Appsignal).to receive(:send_error)
+ described_class.exception_handler("message", exception:)
+
+ expect(Appsignal).to have_received(:send_error).with(exception)
+ end
+ end
+end
diff --git a/spec/models/custom_value_spec.rb b/spec/models/custom_value_spec.rb
index 873e9139b87a..47966bc810ff 100644
--- a/spec/models/custom_value_spec.rb
+++ b/spec/models/custom_value_spec.rb
@@ -126,7 +126,7 @@
end
context 'for a boolean custom field without default value' do
- shared_let(:custom_field) { create(:project_custom_field, :boolean) }
+ shared_let(:custom_field) { create(:project_custom_field, :boolean, projects: [project]) }
include_examples 'returns true for generated custom value'
include_examples 'returns false for custom value with value', value: false
@@ -150,7 +150,7 @@
end
context "for a string custom field without default value" do
- shared_let(:custom_field) { create(:project_custom_field, :string) }
+ shared_let(:custom_field) { create(:project_custom_field, :string, projects: [project]) }
include_examples 'returns true for generated custom value'
include_examples 'returns false for custom value with value', value: 'Hello world!'
@@ -159,8 +159,8 @@
context 'for a string custom field with default value' do
describe 'for a generated custom value' do
it 'returns true' do
- create(:project_custom_field, :string, default_value: 'Hello world!')
- create(:project_custom_field, :string, default_value: '')
+ create(:project_custom_field, :string, default_value: 'Hello world!', projects: [project])
+ create(:project_custom_field, :string, default_value: '', projects: [project])
custom_values = project.custom_field_values
@@ -170,7 +170,7 @@
end
context 'for a text custom field without default value' do
- shared_let(:custom_field) { create(:project_custom_field, :text) }
+ shared_let(:custom_field) { create(:project_custom_field, :text, projects: [project]) }
include_examples 'returns true for generated custom value'
include_examples 'returns false for custom value with value', value: "Hello world!"
@@ -180,8 +180,8 @@
context 'for a text custom field with default value' do
describe 'for a generated custom value' do
it 'returns true' do
- create(:project_custom_field, :text, default_value: 'Hello world!')
- create(:project_custom_field, :text, default_value: '')
+ create(:project_custom_field, :text, default_value: 'Hello world!', projects: [project])
+ create(:project_custom_field, :text, default_value: '', projects: [project])
custom_values = project.custom_field_values
@@ -191,7 +191,7 @@
end
context 'for an integer custom field without default value' do
- shared_let(:custom_field) { create(:project_custom_field, :integer) }
+ shared_let(:custom_field) { create(:project_custom_field, :integer, projects: [project]) }
include_examples 'returns true for generated custom value'
include_examples 'returns false for custom value with value', value: 123
@@ -202,11 +202,11 @@
context 'for an integer custom field with default value' do
describe 'for a generated custom value' do
it 'returns true' do
- create(:project_custom_field, :integer, default_value: 0)
- create(:project_custom_field, :integer, default_value: 123)
- create(:project_custom_field, :integer, default_value: '456')
- create(:project_custom_field, :integer, default_value: -987)
- create(:project_custom_field, :integer, default_value: '-678')
+ create(:project_custom_field, :integer, default_value: 0, projects: [project])
+ create(:project_custom_field, :integer, default_value: 123, projects: [project])
+ create(:project_custom_field, :integer, default_value: '456', projects: [project])
+ create(:project_custom_field, :integer, default_value: -987, projects: [project])
+ create(:project_custom_field, :integer, default_value: '-678', projects: [project])
custom_values = project.custom_field_values
@@ -216,7 +216,7 @@
end
context 'for a float custom field without default value' do
- shared_let(:custom_field) { create(:project_custom_field, :float) }
+ shared_let(:custom_field) { create(:project_custom_field, :float, projects: [project]) }
include_examples 'returns true for generated custom value'
include_examples 'returns false for custom value with value', value: 3.14
@@ -227,11 +227,11 @@
context 'for a float custom field with default value' do
describe 'for a generated custom value' do
it 'returns true' do
- create(:project_custom_field, :float, default_value: 0.0)
- create(:project_custom_field, :float, default_value: 12.3)
- create(:project_custom_field, :float, default_value: '45.6')
- create(:project_custom_field, :float, default_value: -98.7)
- create(:project_custom_field, :float, default_value: '-67')
+ create(:project_custom_field, :float, default_value: 0.0, projects: [project])
+ create(:project_custom_field, :float, default_value: 12.3, projects: [project])
+ create(:project_custom_field, :float, default_value: '45.6', projects: [project])
+ create(:project_custom_field, :float, default_value: -98.7, projects: [project])
+ create(:project_custom_field, :float, default_value: '-67', projects: [project])
custom_values = project.custom_field_values
@@ -241,7 +241,7 @@
end
context 'for a date custom field' do
- shared_let(:custom_field) { create(:project_custom_field, :date) }
+ shared_let(:custom_field) { create(:project_custom_field, :date, projects: [project]) }
include_examples 'returns true for generated custom value'
include_examples 'returns false for custom value with value', value: "2023-08-08"
@@ -249,7 +249,7 @@
end
context 'for a list custom field without default value' do
- shared_let(:custom_field) { create(:project_custom_field, :list) }
+ shared_let(:custom_field) { create(:project_custom_field, :list, projects: [project]) }
include_examples 'returns true for generated custom value'
@@ -266,7 +266,7 @@
context 'for a list custom field with default value' do
describe 'for a generated custom value' do
it 'returns true' do
- create(:project_custom_field, :list, default_option: 'B')
+ create(:project_custom_field, :list, default_option: 'B', projects: [project])
custom_values = project.custom_field_values
@@ -277,7 +277,7 @@
end
context 'for a multi-value list custom field without default value' do
- shared_let(:custom_field) { create(:project_custom_field, :multi_list) }
+ shared_let(:custom_field) { create(:project_custom_field, :multi_list, projects: [project]) }
include_examples 'returns true for generated custom value'
@@ -294,8 +294,8 @@
context 'for a multi-value list custom field with default value' do
describe 'for a generated custom value' do
it 'returns true' do
- create(:project_custom_field, :multi_list, default_options: ['B'])
- create(:project_custom_field, :multi_list, default_options: ['G', 'B', 'C'])
+ create(:project_custom_field, :multi_list, default_options: ['B'], projects: [project])
+ create(:project_custom_field, :multi_list, default_options: ['G', 'B', 'C'], projects: [project])
custom_values = project.custom_field_values
@@ -307,7 +307,7 @@
end
context 'for a version custom field' do
- shared_let(:custom_field) { create(:project_custom_field, :version) }
+ shared_let(:custom_field) { create(:project_custom_field, :version, projects: [project]) }
include_examples 'returns true for generated custom value'
@@ -325,7 +325,7 @@
end
context 'for a multi version custom field' do
- shared_let(:custom_field) { create(:project_custom_field, :multi_version) }
+ shared_let(:custom_field) { create(:project_custom_field, :multi_version, projects: [project]) }
include_examples 'returns true for generated custom value'
@@ -343,7 +343,7 @@
end
context 'for a user custom field' do
- shared_let(:custom_field) { create(:project_custom_field, :user) }
+ shared_let(:custom_field) { create(:project_custom_field, :user, projects: [project]) }
include_examples 'returns true for generated custom value'
@@ -363,7 +363,7 @@
end
context 'for a multi user custom field' do
- shared_let(:custom_field) { create(:project_custom_field, :multi_user) }
+ shared_let(:custom_field) { create(:project_custom_field, :multi_user, projects: [project]) }
include_examples 'returns true for generated custom value'
@@ -397,7 +397,9 @@
end
describe '#valid?' do
- let(:custom_field) { build_stubbed(:custom_field, field_format:, is_required:, min_length:, max_length:, regexp:) }
+ let(:custom_field) do
+ build_stubbed(:custom_field, field_format:, is_required:, min_length:, max_length:, regexp:)
+ end
let(:custom_value) { described_class.new(custom_field:, value:) }
let(:is_required) { false }
let(:min_length) { 0 }
@@ -551,7 +553,9 @@
context 'for a list custom field' do
let(:custom_option1) { build_stubbed(:custom_option, value: 'value1') }
let(:custom_option2) { build_stubbed(:custom_option, value: 'value1') }
- let(:custom_field) { build_stubbed(:custom_field, field_format: 'list', custom_options: [custom_option1, custom_option2]) }
+ let(:custom_field) do
+ build_stubbed(:custom_field, field_format: 'list', custom_options: [custom_option1, custom_option2])
+ end
context 'with a value from the list' do
let(:value) { custom_option1.id }
@@ -729,4 +733,66 @@
expect(custom_value.value).to eql parsed_value
end
end
+
+ describe '#activate_custom_field_in_customized_project' do
+ let(:project) { create(:project) }
+
+ context 'with a given default value' do
+ let(:custom_field) { create(:string_project_custom_field, default_value: "foo") }
+
+ context 'when a value other than the default value is set' do
+ let(:custom_value) { build(:custom_value, custom_field:, customized: project, value: "bar") }
+
+ it 'activates the custom field in the project after create if missing' do
+ expect(project.project_custom_fields).not_to include(custom_field)
+ custom_value.save!
+ expect(project.reload.project_custom_fields).to include(custom_field)
+ end
+ end
+
+ context 'when a value equal to the default value is set' do
+ let(:custom_value) { build(:custom_value, custom_field:, customized: project, value: "foo") }
+
+ it 'activates the custom field in the project after create if missing' do
+ expect(project.project_custom_fields).not_to include(custom_field)
+ custom_value.save!
+ expect(project.reload.project_custom_fields).not_to include(custom_field)
+ end
+ end
+
+ context 'when a value is not set' do
+ let(:custom_value) { build(:custom_value, custom_field:, customized: project) }
+
+ it 'does not activate the custom field in the project after create if missing' do
+ expect(project.project_custom_fields).not_to include(custom_field)
+ custom_value.save!
+ expect(project.reload.project_custom_fields).not_to include(custom_field)
+ end
+ end
+ end
+
+ context 'with no default value given' do
+ let(:custom_field) { create(:string_project_custom_field) }
+
+ context 'when a value is set' do
+ let(:custom_value) { build(:custom_value, custom_field:, customized: project, value: "bar") }
+
+ it 'activates the custom field in the project after create if missing' do
+ expect(project.project_custom_fields).not_to include(custom_field)
+ custom_value.save!
+ expect(project.reload.project_custom_fields).to include(custom_field)
+ end
+ end
+
+ context 'when a value is not set' do
+ let(:custom_value) { build(:custom_value, custom_field:, customized: project) }
+
+ it 'does not activate the custom field in the project after create if missing' do
+ expect(project.project_custom_fields).not_to include(custom_field)
+ custom_value.save!
+ expect(project.reload.project_custom_fields).not_to include(custom_field)
+ end
+ end
+ end
+ end
end
diff --git a/spec/models/project_custom_field_project_mapping_spec.rb b/spec/models/project_custom_field_project_mapping_spec.rb
new file mode 100644
index 000000000000..f7baa6fc572d
--- /dev/null
+++ b/spec/models/project_custom_field_project_mapping_spec.rb
@@ -0,0 +1,47 @@
+#-- copyright
+# OpenProject is an open source project management software.
+# Copyright (C) 2012-2024 the OpenProject GmbH
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+#
+# See COPYRIGHT and LICENSE files for more details.
+#++
+
+require 'spec_helper'
+
+RSpec.describe ProjectCustomFieldProjectMapping do
+ describe 'uniqueness by project' do
+ let!(:project) { create(:project) }
+ let!(:project_custom_field) { create(:project_custom_field) }
+
+ it 'a project custom field can only be mapped to a project once' do
+ project.project_custom_fields << project_custom_field
+
+ expect(described_class).to exist(custom_field_id: project_custom_field.id,
+ project_id: project.id)
+
+ expect do
+ project.project_custom_fields << project_custom_field
+ end.to raise_error(ActiveRecord::RecordInvalid, /Custom field has already been taken/)
+ end
+ end
+end
diff --git a/spec/models/project_custom_field_spec.rb b/spec/models/project_custom_field_spec.rb
new file mode 100644
index 000000000000..376bfd811bad
--- /dev/null
+++ b/spec/models/project_custom_field_spec.rb
@@ -0,0 +1,104 @@
+#-- copyright
+# OpenProject is an open source project management software.
+# Copyright (C) 2012-2024 the OpenProject GmbH
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+#
+# See COPYRIGHT and LICENSE files for more details.
+#++
+
+require 'spec_helper'
+
+RSpec.describe ProjectCustomField do
+ describe 'activation in projects' do
+ context 'when creating a new required project custom field' do
+ let!(:project) { create(:project) }
+ let!(:another_project) { create(:project) }
+
+ it 'activates the required project custom fields in all projects' do
+ project_custom_field = create(:project_custom_field, is_required: true)
+
+ expect(ProjectCustomFieldProjectMapping).to exist(custom_field_id: project_custom_field.id,
+ project_id: project.id)
+ expect(ProjectCustomFieldProjectMapping).to exist(custom_field_id: project_custom_field.id,
+ project_id: another_project.id)
+ end
+ end
+
+ context 'when setting an existing project custom field to required' do
+ let!(:project_custom_field) { create(:string_project_custom_field) } # optional now
+ let!(:project) do
+ create(:project, custom_field_values: { "#{project_custom_field.id}": "foo" })
+ end
+ let!(:another_project) { create(:project) } # not using the custom field
+
+ it 'activates the required project custom fields in all projects where it is not already activated' do
+ expect(ProjectCustomFieldProjectMapping).to exist(custom_field_id: project_custom_field.id,
+ project_id: project.id)
+ expect(ProjectCustomFieldProjectMapping).not_to exist(custom_field_id: project_custom_field.id,
+ project_id: another_project.id)
+
+ project_custom_field.update!(is_required: true) # required now
+
+ expect(ProjectCustomFieldProjectMapping).to exist(custom_field_id: project_custom_field.id,
+ project_id: project.id)
+ expect(ProjectCustomFieldProjectMapping).to exist(custom_field_id: project_custom_field.id,
+ project_id: another_project.id)
+ end
+
+ it 'does not disabled project custom fields when set to optional' do
+ project_custom_field.update!(is_required: true) # required now
+ project_custom_field.update!(is_required: false) # optional again
+
+ expect(ProjectCustomFieldProjectMapping).to exist(custom_field_id: project_custom_field.id,
+ project_id: project.id)
+ expect(ProjectCustomFieldProjectMapping).to exist(custom_field_id: project_custom_field.id,
+ project_id: another_project.id)
+ end
+
+ it 'does not create duplicate mappings' do
+ project_custom_field.update!(is_required: true) # required now
+
+ # mapping existed before, should not be duplicated
+ expect(ProjectCustomFieldProjectMapping.where(project_id: project.id,
+ custom_field_id: project_custom_field.id).count).to eq(1)
+ end
+ end
+
+ context 'when deleting a project custom field' do
+ let!(:project_custom_field) { create(:string_project_custom_field) }
+ let!(:project) do
+ create(:project, custom_field_values: { "#{project_custom_field.id}": "foo" })
+ end
+
+ it 'deletes the project custom field mappings' do
+ expect(ProjectCustomFieldProjectMapping).to exist(custom_field_id: project_custom_field.id,
+ project_id: project.id)
+
+ project_custom_field.destroy
+
+ expect(ProjectCustomFieldProjectMapping).not_to exist(custom_field_id: project_custom_field.id,
+ project_id: project.id)
+ end
+ end
+ end
+end
diff --git a/spec/models/projects/customizable_spec.rb b/spec/models/projects/customizable_spec.rb
index ce203305ace6..6dc4d64fe222 100644
--- a/spec/models/projects/customizable_spec.rb
+++ b/spec/models/projects/customizable_spec.rb
@@ -26,93 +26,448 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
+RSpec.describe Project, "customizable" do
+ let!(:section) { create(:project_custom_field_section) }
-RSpec.describe Project, 'customizable' do
- let(:project) do
- build_stubbed(:project,
- custom_values:)
+ let!(:bool_custom_field) do
+ create(:boolean_project_custom_field, project_custom_field_section: section)
end
- let(:stub_available_custom_fields) do
- custom_fields_stub = double('custom fields stub')
- allow(CustomField)
- .to receive(:where)
- .with(type: "ProjectCustomField")
- .and_return(custom_fields_stub)
-
- allow(custom_fields_stub)
- .to receive(:order)
- .with(:position)
- .and_return(available_custom_fields)
+ let!(:text_custom_field) do
+ create(:text_project_custom_field, project_custom_field_section: section)
end
- let(:custom_values) { [] }
- let(:bool_custom_field) { build_stubbed(:boolean_project_custom_field) }
- let(:text_custom_field) { build_stubbed(:text_project_custom_field) }
- let(:list_custom_field) { build_stubbed(:list_project_custom_field) }
+ let!(:list_custom_field) do
+ create(:list_project_custom_field, project_custom_field_section: section)
+ end
+
+ context "when not persisted" do
+ let(:project) { build(:project) }
- before do
- stub_available_custom_fields
+ describe "#available_custom_fields" do
+ it "returns all existing project custom fields as available custom fields" do
+ expect(project.project_custom_field_project_mappings)
+ .to be_empty
+ expect(project.project_custom_fields)
+ .to be_empty
+ # but:
+ expect(project.available_custom_fields)
+ .to contain_exactly(bool_custom_field, text_custom_field, list_custom_field)
+ end
+ end
end
- describe '#custom_value_for' do
- subject { project.custom_value_for(custom_field) }
+ context "when persisted" do
+ let(:project) { create(:project) }
- context 'for a boolean custom field' do
- let(:custom_field) { bool_custom_field }
- let(:available_custom_fields) { [custom_field] }
+ describe "#available_custom_fields" do
+ it "returns only mapped project custom fields as available custom fields" do
+ expect(project.project_custom_field_project_mappings)
+ .to be_empty
+ expect(project.project_custom_fields)
+ .to be_empty
+ # and thus:
+ expect(project.available_custom_fields)
+ .to be_empty
- context 'with no value set' do
- it 'returns a custom value' do
- expect(subject)
- .to be_present
- end
+ project.project_custom_fields << bool_custom_field
- it 'is unpersisted' do
- expect(subject)
- .to be_new_record
- end
+ expect(project.available_custom_fields)
+ .to contain_exactly(bool_custom_field)
+ end
+ end
- it 'has nil as its value' do
- expect(subject.value)
+ describe "#custom_field_values and #custom_value_for" do
+ context "when no custom fields are mapped to this project" do
+ it "#custom_value_for returns nil" do
+ expect(project.custom_value_for(text_custom_field))
.to be_nil
+ expect(project.custom_value_for(bool_custom_field))
+ .to be_nil
+ expect(project.custom_value_for(list_custom_field))
+ .to be_nil
+ end
+
+ it "#custom_field_values returns an empty hash" do
+ expect(project.custom_field_values)
+ .to be_empty
end
end
- context 'with a value set' do
- let(:custom_value) do
- build_stubbed(:custom_value,
- custom_field:,
- value: true)
+ context "when custom fields are mapped to this project" do
+ before do
+ project.project_custom_fields << [text_custom_field, bool_custom_field]
+ end
+
+ it "#custom_field_values returns a hash of mapped custom fields with nil values" do
+ text_custom_field_custom_field_value = project.custom_field_values.find do |custom_value|
+ custom_value.custom_field_id == text_custom_field.id
+ end
+
+ expect(text_custom_field_custom_field_value).to be_present
+ expect(text_custom_field_custom_field_value.value).to be_nil
+
+ bool_custom_field_custom_field_value = project.custom_field_values.find do |custom_value|
+ custom_value.custom_field_id == bool_custom_field.id
+ end
+
+ expect(bool_custom_field_custom_field_value).to be_present
+ expect(bool_custom_field_custom_field_value.value).to be_nil
end
- let(:custom_values) { [custom_value] }
- it 'returns the custom value' do
- expect(subject)
- .to eql custom_value
+ context "when values are set for mapped custom fields" do
+ before do
+ project.custom_field_values = {
+ text_custom_field.id => "foo",
+ bool_custom_field.id => true
+ }
+ end
+
+ it "#custom_value_for returns the set custom values" do
+ expect(project.custom_value_for(text_custom_field).typed_value)
+ .to eq("foo")
+ expect(project.custom_value_for(bool_custom_field).typed_value)
+ .to be_truthy
+ expect(project.custom_value_for(list_custom_field).typed_value)
+ .to be_nil
+ end
+
+ it "#custom_field_values returns a hash of mapped custom fields with their set values" do
+ expect(project.custom_field_values.find do |custom_value|
+ custom_value.custom_field_id == text_custom_field.id
+ end.typed_value)
+ .to eq("foo")
+
+ expect(project.custom_field_values.find do |custom_value|
+ custom_value.custom_field_id == bool_custom_field.id
+ end.typed_value)
+ .to be_truthy
+ end
end
end
end
end
- describe '#custom_value_attributes' do
- let(:available_custom_fields) { [bool_custom_field, list_custom_field, text_custom_field] }
- let(:text_custom_value) do
- build_stubbed(:custom_value,
- custom_field: text_custom_field,
- value: 'blubs')
+ context "when creating with custom field values" do
+ let(:project) do
+ create(:project, custom_field_values: {
+ text_custom_field.id => "foo",
+ bool_custom_field.id => true
+ })
+ end
+
+ it "saves the custom field values properly" do
+ expect(project.custom_value_for(text_custom_field).typed_value)
+ .to eq("foo")
+ expect(project.custom_value_for(bool_custom_field).typed_value)
+ .to be_truthy
+ end
+
+ it "enables fields with provided values and disables fields with none" do
+ # list_custom_field is not provided, thus it should not be enabled
+ expect(project.project_custom_field_project_mappings.pluck(:custom_field_id))
+ .to contain_exactly(text_custom_field.id, bool_custom_field.id)
+ expect(project.project_custom_fields)
+ .to contain_exactly(text_custom_field, bool_custom_field)
+ end
+
+ context "with correct validation" do
+ let(:another_section) { create(:project_custom_field_section) }
+
+ let!(:required_text_custom_field) do
+ create(:text_project_custom_field,
+ is_required: true,
+ project_custom_field_section: another_section)
+ end
+
+ it "validates all custom values if not scoped to a section" do
+ project = build(:project, custom_field_values: {
+ text_custom_field.id => "foo",
+ bool_custom_field.id => true
+ })
+
+ expect(project).not_to be_valid
+
+ expect { project.save! }.to raise_error(ActiveRecord::RecordInvalid)
+ end
+
+ it "rejects section validation scoping for project creation" do
+ project = build(:project, custom_field_values: {
+ text_custom_field.id => "foo",
+ bool_custom_field.id => true
+ },
+ _limit_custom_fields_validation_to_section_id: section.id)
+
+ expect { project.save! }.to raise_error(ArgumentError)
+ end
+
+ it "temporarly validates only custom values of a section if section scope is provided while updating" do
+ project = create(:project, custom_field_values: {
+ text_custom_field.id => "foo",
+ bool_custom_field.id => true,
+ required_text_custom_field.id => "bar"
+ })
+
+ expect(project).to be_valid
+
+ # after a project is created, a new required custom field is added
+ # which gets automatically activated for all projects
+ create(:text_project_custom_field,
+ is_required: true,
+ project_custom_field_section: another_section)
+
+ # thus, the project is invalid in total
+ expect(project.reload).not_to be_valid
+ expect { project.save! }.to raise_error(ActiveRecord::RecordInvalid)
+
+ # but we still want to allow updating other sections without invalid required custom field values
+ # by limiting the validation scope to a section temporarily
+ project._limit_custom_fields_validation_to_section_id = section.id
+
+ expect(project).to be_valid
+
+ expect { project.save! }.not_to raise_error
+
+ # section scope is resetted after each update
+ expect { project.save! }.to raise_error(ActiveRecord::RecordInvalid)
+ end
+ end
+
+ context "with correct handling of custom fields with default values" do
+ let!(:text_custom_field_with_default) do
+ create(:text_project_custom_field,
+ default_value: "default",
+ project_custom_field_section: section)
+ end
+
+ it "activates custom fields with default values if not explicitly set to blank" do
+ project = create(:project, custom_field_values: {
+ text_custom_field.id => "foo",
+ bool_custom_field.id => true
+ })
+ expect(project.project_custom_field_project_mappings.pluck(:custom_field_id))
+ .to contain_exactly(text_custom_field.id, bool_custom_field.id, text_custom_field_with_default.id)
+ end
+
+ it "does not activate custom fields with default values if explicitly set to blank" do
+ project = create(:project, custom_field_values: {
+ text_custom_field.id => "foo",
+ bool_custom_field.id => true,
+ text_custom_field_with_default.id => ""
+ })
+ expect(project.project_custom_field_project_mappings.pluck(:custom_field_id))
+ .to contain_exactly(text_custom_field.id, bool_custom_field.id)
+ end
+ end
+ end
+
+ context "when updating with custom field values" do
+ let!(:project) { create(:project) }
+
+ shared_examples "implicitly enabled and saved custom values" do
+ it "enables fields with provided values" do
+ # list_custom_field is not provided, thus it should not be enabled
+ expect(project.project_custom_field_project_mappings.pluck(:custom_field_id))
+ .to contain_exactly(text_custom_field.id, bool_custom_field.id)
+ expect(project.project_custom_fields)
+ .to contain_exactly(text_custom_field, bool_custom_field)
+ end
+
+ it "saves the custom field values properly" do
+ expect(project.custom_value_for(text_custom_field).typed_value)
+ .to eq("foo")
+ expect(project.custom_value_for(bool_custom_field).typed_value)
+ .to be_truthy
+ end
+ end
+
+ context "with #update method" do
+ before do
+ project.update(custom_field_values: {
+ text_custom_field.id => "foo",
+ bool_custom_field.id => true
+ })
+ end
+
+ it_behaves_like "implicitly enabled and saved custom values"
+ end
+
+ context "with #update! method" do
+ before do
+ project.update!(custom_field_values: {
+ text_custom_field.id => "foo",
+ bool_custom_field.id => true
+ })
+ end
+
+ it_behaves_like "implicitly enabled and saved custom values"
+ end
+
+ context "with #custom_field_values= method" do
+ before do
+ project.custom_field_values = {
+ text_custom_field.id => "foo",
+ bool_custom_field.id => true
+ }
+
+ project.save!
+ end
+
+ it_behaves_like "implicitly enabled and saved custom values"
+ end
+
+ it "does not re-enable fields without new value which have been disabled in the past (regression)" do
+ project.update!(custom_field_values: {
+ text_custom_field.id => "foo",
+ bool_custom_field.id => true
+ })
+
+ expect(project.reload.project_custom_fields)
+ .to contain_exactly(text_custom_field, bool_custom_field)
+
+ project.project_custom_field_project_mappings.find_by(custom_field_id: text_custom_field.id).destroy
+
+ expect(project.reload.project_custom_fields)
+ .to contain_exactly(bool_custom_field)
+
+ project.update!(custom_field_values: {
+ bool_custom_field.id => true
+ })
+
+ expect(project.reload.project_custom_fields)
+ .to contain_exactly(bool_custom_field)
+ end
+
+ context "with correct handling of custom fields with default values" do
+ let!(:text_custom_field_with_default) do
+ create(:text_project_custom_field,
+ default_value: "default",
+ project_custom_field_section: section)
+ end
+
+ it "does not activate custom fields with default values if not explicitly set to a value" do
+ project.update!(custom_field_values: {
+ text_custom_field.id => "bar",
+ bool_custom_field.id => false
+ })
+
+ # text_custom_field_with_default is not provided, thus it should not be enabled (in contrast to creation)
+ expect(project.project_custom_field_project_mappings.pluck(:custom_field_id))
+ .to contain_exactly(text_custom_field.id, bool_custom_field.id)
+ end
+
+ it "does activate custom fields with default values if explicitly set to a value" do
+ project.update!(custom_field_values: {
+ text_custom_field.id => "bar",
+ bool_custom_field.id => false,
+ text_custom_field_with_default.id => "overwritten default"
+ })
+
+ # text_custom_field_with_default is not provided, thus it should not be enabled (in contrast to creation)
+ expect(project.project_custom_field_project_mappings.pluck(:custom_field_id))
+ .to contain_exactly(text_custom_field.id, bool_custom_field.id, text_custom_field_with_default.id)
+ end
+ end
+
+ it "does re-enable fields with new value which have been disabled in the past" do
+ project.update!(custom_field_values: {
+ text_custom_field.id => "foo",
+ bool_custom_field.id => true
+ })
+
+ expect(project.reload.project_custom_fields)
+ .to contain_exactly(text_custom_field, bool_custom_field)
+
+ project.project_custom_field_project_mappings.find_by(custom_field_id: text_custom_field.id).destroy
+
+ expect(project.reload.project_custom_fields)
+ .to contain_exactly(bool_custom_field)
+
+ project.update!(custom_field_values: {
+ text_custom_field.id => "bar"
+ })
+
+ expect(project.reload.project_custom_fields)
+ .to contain_exactly(text_custom_field, bool_custom_field)
+
+ expect(project.custom_value_for(text_custom_field).typed_value)
+ .to eq("bar")
+ end
+ end
+
+ context "when updating with custom field setter methods (API approach)" do
+ let(:project) { create(:project) }
+
+ shared_examples "implicitly enabled and saved custom values" do
+ it "enables fields with provided values" do
+ # list_custom_field is not provided, thus it should not be enabled
+ expect(project.project_custom_field_project_mappings.pluck(:custom_field_id))
+ .to contain_exactly(text_custom_field.id, bool_custom_field.id)
+ expect(project.project_custom_fields)
+ .to contain_exactly(text_custom_field, bool_custom_field)
+ end
+
+ it "saves the custom field values properly" do
+ expect(project.custom_value_for(text_custom_field).typed_value)
+ .to eq("foo")
+ expect(project.custom_value_for(bool_custom_field).typed_value)
+ .to be_truthy
+
+ # or via getter methods:
+
+ expect(project.send(:"custom_field_#{text_custom_field.id}")).to eq("foo")
+ expect(project.send(:"custom_field_#{bool_custom_field.id}")).to be_truthy
+ end
+ end
+
+ context "when setting a value for a disabled custom field" do
+ before do
+ project.send(:"custom_field_#{text_custom_field.id}=", "foo")
+ project.send(:"custom_field_#{bool_custom_field.id}=", true)
+ project.save!
+ end
+
+ it_behaves_like "implicitly enabled and saved custom values"
+ end
+ end
+
+ context "with hidden custom fields" do
+ let!(:hidden_custom_field) do
+ create(:text_project_custom_field, project_custom_field_section: section, visible: false)
end
- let(:bool_custom_value) do
- build_stubbed(:custom_value,
- custom_field: bool_custom_field,
- value: true)
+ let(:project) do
+ create(:project, custom_field_values: {
+ text_custom_field.id => "foo",
+ bool_custom_field.id => true,
+ hidden_custom_field.id => "hidden"
+ })
+ end
+
+ before do
+ User.current = user # needs to be executed before project creation!
end
- let(:custom_values) { [bool_custom_value, text_custom_value] }
- subject { project.custom_value_attributes }
+ context "with admin permission" do
+ let(:user) { create(:admin) }
- it 'returns a hash with all the custom values available' do
- expect(subject)
- .to eql(text_custom_field.id => 'blubs', bool_custom_field.id => 't', list_custom_field.id => nil)
+ it "does activate hidden custom fields" do
+ # project creation happens with an admin user as let(:project) called after setting the current user to an admin
+ expect(project.project_custom_field_project_mappings.pluck(:custom_field_id))
+ .to contain_exactly(text_custom_field.id, bool_custom_field.id, hidden_custom_field.id)
+
+ expect(project.custom_value_for(hidden_custom_field).typed_value).to eq("hidden")
+ end
+ end
+
+ context "without admin permission" do
+ let(:user) { create(:user) }
+
+ it "does not activate hidden custom fields" do
+ # project creation happens with an non-admin user as let(:project) called after setting the current user to an non-admin
+ expect(project.project_custom_field_project_mappings.pluck(:custom_field_id))
+ .to contain_exactly(text_custom_field.id, bool_custom_field.id)
+
+ expect(project.custom_value_for(hidden_custom_field)).to be_nil
+ end
end
end
end
diff --git a/spec/models/projects/exporter/csv_integration_spec.rb b/spec/models/projects/exporter/csv_integration_spec.rb
index 325c1a363014..464e77efa57d 100644
--- a/spec/models/projects/exporter/csv_integration_spec.rb
+++ b/spec/models/projects/exporter/csv_integration_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'exportable_project_context'
+require "spec_helper"
+require_relative "exportable_project_context"
-RSpec.describe Projects::Exports::CSV, 'integration' do
- include_context 'with a project with an arrangement of custom fields'
- include_context 'with an instance of the described exporter'
+RSpec.describe Projects::Exports::CSV, "integration" do
+ include_context "with a project with an arrangement of custom fields"
+ include_context "with an instance of the described exporter"
let(:parsed) do
CSV.parse(output)
@@ -41,62 +41,112 @@
let(:rows) { parsed.drop(1) }
- it 'performs a successful export' do
+ it "performs a successful export" do
expect(parsed.size).to eq(2)
expect(parsed.last).to eq [project.id.to_s, project.identifier,
- project.name, project.description, 'Off track', 'false']
+ project.name, project.description, "Off track", "false"]
end
- context 'with status_explanation enabled' do
+ context "with status_explanation enabled" do
let(:query_columns) { %w[name description project_status status_explanation public] }
- it 'performs a successful export' do
+ it "performs a successful export" do
expect(parsed.size).to eq(2)
expect(parsed.last).to eq [project.id.to_s, project.identifier,
project.name, project.description,
- 'Off track', 'some explanation', 'false']
+ "Off track", "some explanation", "false"]
end
end
- describe 'custom field columns selected' do
+ describe "custom field columns selected" do
let(:query_columns) do
- %w[name description project_status public] + custom_fields.map(&:column_name)
+ %w[name description project_status public] + global_project_custom_fields.map(&:column_name)
end
- context 'when ee enabled', with_ee: %i[custom_fields_in_projects_list] do
- it 'renders all those columns' do
- expect(parsed.size).to eq 2
-
- cf_names = custom_fields.map(&:name)
- expect(header).to eq ['id', 'Identifier', 'Name', 'Description', 'Status', 'Public', *cf_names]
-
- custom_values = custom_fields.map do |cf|
- case cf
- when bool_cf
- 'true'
- when text_cf
- project.typed_custom_value_for(cf)
- else
- project.formatted_custom_value_for(cf)
+ context "when ee enabled", with_ee: %i[custom_fields_in_projects_list] do
+ before do
+ project # re-evaluate project to ensure it is created within the desired user context
+ parsed
+ end
+
+ context "without admin permission" do
+ it "renders all visible globally available project custom fields in the header" do
+ expect(parsed.size).to eq 2
+
+ cf_names = global_project_custom_fields.map(&:name)
+
+ expect(cf_names).to include(not_used_string_cf.name)
+ expect(cf_names).not_to include(hidden_cf.name)
+
+ expect(header).to eq ["id", "Identifier", "Name", "Description", "Status", "Public", *cf_names]
+ end
+
+ it "renders the custom field values in the rows if enabled for a project" do
+ custom_values = global_project_custom_fields.map do |cf|
+ case cf
+ when bool_cf
+ "true"
+ when text_cf
+ project.typed_custom_value_for(cf)
+ when not_used_string_cf
+ ""
+ else
+ project.formatted_custom_value_for(cf)
+ end
+ end
+ expect(rows.first)
+ .to eq [project.id.to_s, project.identifier, project.name,
+ project.description, "Off track", "false", *custom_values]
+ end
+ end
+
+ context "with admin permission" do
+ let(:current_user) { create(:admin) }
+
+ it "renders all globally available project custom fields including hidden ones in the header" do
+ expect(parsed.size).to eq 3
+
+ cf_names = global_project_custom_fields.map(&:name)
+
+ expect(cf_names).to include(not_used_string_cf.name)
+ expect(cf_names).to include(hidden_cf.name)
+
+ expect(header).to eq ["id", "Identifier", "Name", "Description", "Status", "Public", *cf_names]
+ end
+
+ it "renders the custom field values in the rows if enabled for a project" do
+ custom_values = global_project_custom_fields.map do |cf|
+ case cf
+ when bool_cf
+ "true"
+ when hidden_cf
+ "hidden"
+ when not_used_string_cf
+ ""
+ when text_cf
+ project.typed_custom_value_for(cf)
+ else
+ project.formatted_custom_value_for(cf)
+ end
end
+ expect(rows.first)
+ .to eq [project.id.to_s, project.identifier, project.name,
+ project.description, "Off track", "false", *custom_values]
end
- expect(rows.first)
- .to eq [project.id.to_s, project.identifier, project.name,
- project.description, 'Off track', 'false', *custom_values]
end
end
- context 'when ee not enabled' do
- it 'renders only the default columns' do
+ context "when ee not enabled" do
+ it "renders only the default columns" do
expect(header).to eq %w[id Identifier Name Description Status Public]
end
end
end
- context 'with no project visible' do
+ context "with no project visible" do
let(:current_user) { User.anonymous }
- it 'does not include the project' do
+ it "does not include the project" do
expect(output).not_to include project.identifier
expect(parsed.size).to eq(1)
end
diff --git a/spec/models/projects/exporter/exportable_project_context.rb b/spec/models/projects/exporter/exportable_project_context.rb
index 68151bf381c7..77960e542566 100644
--- a/spec/models/projects/exporter/exportable_project_context.rb
+++ b/spec/models/projects/exporter/exportable_project_context.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-RSpec.shared_context 'with a project with an arrangement of custom fields' do
+RSpec.shared_context "with a project with an arrangement of custom fields" do
shared_let(:version_cf) { create(:version_project_custom_field, position: 1) }
shared_let(:bool_cf) { create(:boolean_project_custom_field, position: 2) }
shared_let(:user_cf) { create(:user_project_custom_field, position: 3) }
@@ -35,8 +35,11 @@
shared_let(:text_cf) { create(:text_project_custom_field, position: 6) }
shared_let(:string_cf) { create(:string_project_custom_field, position: 7) }
shared_let(:date_cf) { create(:date_project_custom_field, position: 8) }
+ shared_let(:hidden_cf) { create(:string_project_custom_field, position: 9, visible: false) }
- shared_let(:system_version) { create(:version, sharing: 'system') }
+ let!(:not_used_string_cf) { create(:string_project_custom_field, position: 10) }
+
+ shared_let(:system_version) { create(:version, sharing: "system") }
shared_let(:role) do
create(:project_role)
@@ -44,31 +47,36 @@
shared_let(:other_user) do
create(:user,
- firstname: 'Other',
- lastname: 'User')
+ firstname: "Other",
+ lastname: "User")
end
- shared_let(:project) do
- create(:project,
- status_code: 'off_track',
- status_explanation: 'some explanation',
- members: { other_user => role }).tap do |p|
- p.description = "The description of the project"
- p.send(int_cf.attribute_setter, 5)
- p.send(bool_cf.attribute_setter, true)
- p.send(version_cf.attribute_setter, system_version)
- p.send(float_cf.attribute_setter, 4.5)
- p.send(text_cf.attribute_setter, 'Some **long** text')
- p.send(string_cf.attribute_setter, 'Some small text')
- p.send(date_cf.attribute_setter, Time.zone.today)
- p.send(user_cf.attribute_setter, other_user)
+ # project needs to be reevaluted before every example as the creation behaves differently from different user contexts
+ # shared_let cannot be used here as it would create the project only once
+ let(:project) do
+ project = build(:project,
+ status_code: "off_track",
+ status_explanation: "some explanation",
+ members: { other_user => role },
+ description: "The description of the project",
+ custom_field_values: {
+ int_cf.id => 5,
+ bool_cf.id => true,
+ version_cf.id => system_version,
+ float_cf.id => 4.5,
+ text_cf.id => "Some **long** text",
+ string_cf.id => "Some small text",
+ date_cf.id => Time.zone.today,
+ user_cf.id => other_user.id,
+ hidden_cf.id => "hidden"
+ })
+ project.save!(validate: false)
- p.save!(validate: false)
- end
+ project
end
end
-RSpec.shared_context 'with an instance of the described exporter' do
+RSpec.shared_context "with an instance of the described exporter" do
before do
login_as current_user
end
@@ -85,7 +93,8 @@
described_class.new(query)
end
- let(:custom_fields) { project.available_custom_fields }
+ let(:global_project_custom_fields) { ProjectCustomField.visible }
+ let(:custom_fields_of_project) { project.available_custom_fields }
let(:output) do
instance.export!.content
diff --git a/spec/models/queries/projects/factory_spec.rb b/spec/models/queries/projects/factory_spec.rb
index bea1ddad631a..e43930ea6642 100644
--- a/spec/models/queries/projects/factory_spec.rb
+++ b/spec/models/queries/projects/factory_spec.rb
@@ -50,6 +50,24 @@
query.select(:project_status, :name, :created_at)
end
end
+ let(:custom_field) do
+ build_stubbed(:project_custom_field, id: 1) do |cf|
+ scope = instance_double(ActiveRecord::Relation)
+
+ allow(ProjectCustomField)
+ .to receive(:visible)
+ .and_return(scope)
+
+ allow(scope)
+ .to receive(:find_by)
+ .and_return nil
+
+ allow(scope)
+ .to receive(:find_by)
+ .with(id: cf.id.to_s)
+ .and_return(cf)
+ end
+ end
let(:id) { nil }
let(:params) { {} }
@@ -80,7 +98,7 @@
.to eq([["lft", :asc]])
end
- it "has the enabled project columns columns as selects" do
+ it "has the enabled_project_columns columns as selects" do
expect(find.selects.map(&:attribute))
.to eq(Setting.enabled_projects_columns.map(&:to_sym))
end
@@ -91,7 +109,11 @@
with_settings: { enabled_projects_columns: %w[name created_at cf_1] } do
current_user { build_stubbed(:admin) }
- it "has the enabled project columns columns as selects" do
+ before do
+ custom_field
+ end
+
+ it "has the enabled_project_columns columns as selects" do
expect(find.selects.map(&:attribute))
.to eq(Setting.enabled_projects_columns.map(&:to_sym))
end
@@ -120,7 +142,7 @@
.to eq([["lft", :asc]])
end
- it "has the enabled project columns columns as selects" do
+ it "has the enabled_project_columns columns as selects" do
expect(find.selects.map(&:attribute))
.to eq(Setting.enabled_projects_columns.map(&:to_sym))
end
@@ -149,7 +171,7 @@
.to eq([["lft", :asc]])
end
- it "has the enabled project columns columns as selects" do
+ it "has the enabled_project_columns columns as selects" do
expect(find.selects.map(&:attribute))
.to eq(Setting.enabled_projects_columns.map(&:to_sym))
end
@@ -178,7 +200,7 @@
.to eq([["lft", :asc]])
end
- it "has the enabled project columns columns as selects" do
+ it "has the enabled_project_columns columns as selects" do
expect(find.selects.map(&:attribute))
.to eq(Setting.enabled_projects_columns.map(&:to_sym))
end
@@ -207,7 +229,7 @@
.to eq([["lft", :asc]])
end
- it "has the enabled project columns columns as selects" do
+ it "has the enabled_project_columns columns as selects" do
expect(find.selects.map(&:attribute))
.to eq(Setting.enabled_projects_columns.map(&:to_sym))
end
@@ -236,7 +258,7 @@
.to eq([["lft", :asc]])
end
- it "has the enabled project columns columns as selects" do
+ it "has the enabled_project_columns columns as selects" do
expect(find.selects.map(&:attribute))
.to eq(Setting.enabled_projects_columns.map(&:to_sym))
end
@@ -265,7 +287,7 @@
.to eq([["lft", :asc]])
end
- it "has the enabled project columns columns as selects" do
+ it "has the enabled_project_columns columns as selects" do
expect(find.selects.map(&:attribute))
.to eq(Setting.enabled_projects_columns.map(&:to_sym))
end
@@ -383,7 +405,7 @@
.to eq([["id", :asc], ["name", :desc]])
end
- it "has the enabled project columns columns as selects" do
+ it "has the enabled_project_columns columns as selects" do
expect(find.selects.map(&:attribute))
.to eq(Setting.enabled_projects_columns.map(&:to_sym))
end
@@ -428,7 +450,7 @@
.to eq([%i[lft asc]])
end
- it "has the enabled project columns columns as selects" do
+ it "has the enabled_project_columns columns as selects" do
expect(find.selects.map(&:attribute))
.to eq(Setting.enabled_projects_columns.map(&:to_sym))
end
@@ -625,6 +647,19 @@
.to be_nil
end
end
+
+ context "without id, as non admin and with a non existing custom field id",
+ with_ee: %i[custom_fields_in_projects_list],
+ with_settings: { enabled_projects_columns: %w[name created_at cf_1 cf_42] } do
+ before do
+ custom_field
+ end
+
+ it "has only the available fields (non admin only and only existing cf)" do
+ expect(find.selects.map(&:attribute))
+ .to eq(%i[name cf_1]) # rubocop:disable Naming/VariableNumber
+ end
+ end
end
describe ".static_query_active" do
@@ -650,7 +685,7 @@
.to eq([["lft", :asc]])
end
- it "has the enabled project columns columns as selects" do
+ it "has the enabled_project_columns columns as selects" do
expect(find.selects.map(&:attribute))
.to eq(Setting.enabled_projects_columns.map(&:to_sym))
end
@@ -679,7 +714,7 @@
.to eq([["lft", :asc]])
end
- it "has the enabled project columns columns as selects" do
+ it "has the enabled_project_columns columns as selects" do
expect(find.selects.map(&:attribute))
.to eq(Setting.enabled_projects_columns.map(&:to_sym))
end
@@ -708,7 +743,7 @@
.to eq([["lft", :asc]])
end
- it "has the enabled project columns columns as selects" do
+ it "has the enabled_project_columns columns as selects" do
expect(find.selects.map(&:attribute))
.to eq(Setting.enabled_projects_columns.map(&:to_sym))
end
@@ -737,7 +772,7 @@
.to eq([["lft", :asc]])
end
- it "has the enabled project columns columns as selects" do
+ it "has the enabled_project_columns columns as selects" do
expect(find.selects.map(&:attribute))
.to eq(Setting.enabled_projects_columns.map(&:to_sym))
end
@@ -766,7 +801,7 @@
.to eq([["lft", :asc]])
end
- it "has the enabled project columns columns as selects" do
+ it "has the enabled_project_columns columns as selects" do
expect(find.selects.map(&:attribute))
.to eq(Setting.enabled_projects_columns.map(&:to_sym))
end
@@ -795,7 +830,7 @@
.to eq([["lft", :asc]])
end
- it "has the enabled project columns columns as selects" do
+ it "has the enabled_project_columns columns as selects" do
expect(find.selects.map(&:attribute))
.to eq(Setting.enabled_projects_columns.map(&:to_sym))
end
diff --git a/spec/models/user_spec.rb b/spec/models/user_spec.rb
index 9bbcb97d49f5..121b8bdce4fc 100644
--- a/spec/models/user_spec.rb
+++ b/spec/models/user_spec.rb
@@ -143,6 +143,18 @@
end
end
+ context 'with other letter char classes' do
+ let(:login) { "célîneüberölig" }
+
+ it 'is valid' do
+ expect(user).to be_valid
+ end
+
+ it 'may be stored in the database' do
+ expect(user.save).to be_truthy
+ end
+ end
+
context "with tabs" do
let(:login) { 'ab\tc' }
@@ -172,7 +184,7 @@
end
context "with combination thereof" do
- let(:login) { "the+boss-is@the_house." }
+ let(:login) { "the+boss-is-über@the_house." }
it "is valid" do
expect(user).to be_valid
diff --git a/spec/permissions/manage_project_custom_field_mappings_spec.rb b/spec/permissions/manage_project_custom_field_mappings_spec.rb
new file mode 100644
index 000000000000..5920cf562918
--- /dev/null
+++ b/spec/permissions/manage_project_custom_field_mappings_spec.rb
@@ -0,0 +1,40 @@
+#-- copyright
+# OpenProject is an open source project management software.
+# Copyright (C) 2012-2024 the OpenProject GmbH
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+#
+# See COPYRIGHT and LICENSE files for more details.
+#++
+
+require 'spec_helper'
+require File.expand_path('../support/permission_specs', __dir__)
+
+RSpec.describe Projects::Settings::ProjectCustomFieldsController, 'manage_project_custom_field mappings permission',
+ type: :controller do
+ include PermissionSpecs
+
+ check_permission_required_for('projects/settings/project_custom_fields#show', :select_project_custom_fields)
+ check_permission_required_for('projects/settings/project_custom_fields#toggle', :select_project_custom_fields)
+ check_permission_required_for('projects/settings/project_custom_fields#enable_all_of_section', :select_project_custom_fields)
+ check_permission_required_for('projects/settings/project_custom_fields#disable_all_of_section', :select_project_custom_fields)
+end
diff --git a/spec/permissions/manage_project_custom_values_spec.rb b/spec/permissions/manage_project_custom_values_spec.rb
new file mode 100644
index 000000000000..4aa31a852cf7
--- /dev/null
+++ b/spec/permissions/manage_project_custom_values_spec.rb
@@ -0,0 +1,50 @@
+#-- copyright
+# OpenProject is an open source project management software.
+# Copyright (C) 2012-2024 the OpenProject GmbH
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+#
+# See COPYRIGHT and LICENSE files for more details.
+#++
+
+require 'spec_helper'
+require File.expand_path('../support/permission_specs', __dir__)
+
+RSpec.describe Overviews::OverviewsController, 'manage_project_custom_values permission',
+ type: :controller do
+ include PermissionSpecs
+
+ # render sidebar on project overview page with view_project permission
+ # TODO: prevents calling overviews/overviews#project_custom_fields_sidebar when not having the permission view_project (FAILED - 1)
+ it 'prevents calling overviews/overviews#project_custom_fields_sidebar when not having the permission view_project' do
+ pending 'spec failing, reason unknown'
+ # wrapping the check_permission_required_for in a block to mark it as pending
+ # spec should not be executed in this block, but standalone, will fail then with real error
+ check_permission_required_for('overviews/overviews#project_custom_fields_sidebar', :view_project)
+ end
+
+ # render dialog with inputs for editing project attributes with edit_project permission
+ check_permission_required_for('overviews/overviews#project_custom_field_section_dialog', :edit_project)
+
+ # update project attributes with edit_project permission, deeper permission check via contract in place
+ check_permission_required_for('overviews/overviews#update_project_custom_values', :edit_project)
+end
diff --git a/spec/requests/api/v3/projects/create_resource_spec.rb b/spec/requests/api/v3/projects/create_resource_spec.rb
index 67df535c2ec3..0ff82ecfcbd0 100644
--- a/spec/requests/api/v3/projects/create_resource_spec.rb
+++ b/spec/requests/api/v3/projects/create_resource_spec.rb
@@ -36,6 +36,9 @@
let(:custom_field) do
create(:text_project_custom_field)
end
+ let(:invisible_custom_field) do
+ create(:text_project_custom_field, visible: false)
+ end
let(:custom_value) do
CustomValue.create(custom_field:,
value: '1234',
@@ -113,7 +116,7 @@
end
end
- context 'with a custom field' do
+ context 'with a visible custom field' do
let(:body) do
{
identifier: 'new_project_identifier',
@@ -129,6 +132,50 @@
.to be_json_eql("CF text".to_json)
.at_path("customField#{custom_field.id}/raw")
end
+
+ it 'automatically activates the cf for project if the value was provided' do
+ expect(Project.last.project_custom_fields)
+ .to contain_exactly(custom_field)
+ end
+ end
+
+ context 'with an invisible custom field' do
+ let(:body) do
+ {
+ identifier: 'new_project_identifier',
+ name: 'Project name',
+ invisible_custom_field.attribute_name(:camel_case) => {
+ raw: "CF text"
+ }
+ }.to_json
+ end
+
+ context 'with admin permissions' do
+ current_user { create(:admin) }
+
+ it 'sets the cf value' do
+ expect(last_response.body)
+ .to be_json_eql("CF text".to_json)
+ .at_path("customField#{invisible_custom_field.id}/raw")
+ end
+
+ it 'automatically activates the cf for project if the value was provided' do
+ expect(Project.last.project_custom_fields)
+ .to contain_exactly(invisible_custom_field)
+ end
+ end
+
+ context 'with non-admin permissions' do
+ it 'does not set the cf value' do
+ expect(last_response.body)
+ .not_to have_json_path("customField#{invisible_custom_field.id}/raw")
+ end
+
+ it 'does not activate the cf for project' do
+ expect(Project.last.project_custom_fields)
+ .to be_empty
+ end
+ end
end
context 'without permission to create projects' do
diff --git a/spec/requests/api/v3/projects/show_resource_spec.rb b/spec/requests/api/v3/projects/show_resource_spec.rb
index a27fd4958c87..7fe2ac10cab9 100644
--- a/spec/requests/api/v3/projects/show_resource_spec.rb
+++ b/spec/requests/api/v3/projects/show_resource_spec.rb
@@ -53,6 +53,14 @@
value: '1234',
customized: project)
end
+ let(:invisible_custom_field) do
+ create(:text_project_custom_field, visible: false)
+ end
+ let(:invisible_custom_value) do
+ CustomValue.create(custom_field: invisible_custom_field,
+ value: '1234',
+ customized: project)
+ end
let(:get_path) { api_v3_paths.project project.id }
let!(:parent_project) do
@@ -96,12 +104,33 @@
.at_path('_links/ancestors/0/href')
end
- it 'includes custom fields' do
+ it 'includes only visible custom fields' do
custom_value
+ invisible_custom_value
expect(subject.body)
.to be_json_eql(custom_value.value.to_json)
.at_path("customField#{custom_field.id}/raw")
+
+ expect(subject.body)
+ .not_to have_json_path("customField#{invisible_custom_field.id}/raw")
+ end
+
+ context 'with admin permissions' do
+ current_user { admin }
+
+ it 'includes invisible custom fields' do
+ custom_value
+ invisible_custom_value
+
+ expect(subject.body)
+ .to be_json_eql(custom_value.value.to_json)
+ .at_path("customField#{custom_field.id}/raw")
+
+ expect(subject.body)
+ .to be_json_eql(invisible_custom_value.value.to_json)
+ .at_path("customField#{invisible_custom_field.id}/raw")
+ end
end
it 'includes the project status' do
diff --git a/spec/requests/api/v3/projects/update_resource_spec.rb b/spec/requests/api/v3/projects/update_resource_spec.rb
index 23df8bc06406..fe1a05c6b21f 100644
--- a/spec/requests/api/v3/projects/update_resource_spec.rb
+++ b/spec/requests/api/v3/projects/update_resource_spec.rb
@@ -44,6 +44,9 @@
let(:custom_field) do
create(:text_project_custom_field)
end
+ let(:invisible_custom_field) do
+ create(:text_project_custom_field, visible: false)
+ end
let(:custom_value) do
CustomValue.create(custom_field:,
value: '1234',
@@ -89,7 +92,7 @@
.at_path('name')
end
- context 'with a custom field' do
+ context 'with a visible custom field' do
let(:body) do
{
custom_field.attribute_name(:camel_case) => {
@@ -106,6 +109,56 @@
expect(project.reload.send(custom_field.attribute_getter))
.to eql("CF text")
end
+
+ it 'automatically activates the cf for project if the value was provided' do
+ expect(project.project_custom_fields)
+ .to contain_exactly(custom_field)
+ end
+ end
+
+ context 'with an invisible custom field' do
+ let(:body) do
+ {
+ invisible_custom_field.attribute_name(:camel_case) => {
+ raw: "CF text"
+ }
+ }
+ end
+
+ context 'with admin permissions' do
+ let(:current_user) { create(:admin) }
+
+ it 'responds with 200 OK' do
+ expect(last_response.status).to eq(200)
+ end
+
+ it 'sets the cf value' do
+ expect(project.reload.send(invisible_custom_field.attribute_getter))
+ .to eql("CF text")
+ end
+
+ it 'automatically activates the cf for project if the value was provided' do
+ expect(project.reload.project_custom_fields)
+ .to contain_exactly(invisible_custom_field)
+ end
+ end
+
+ context 'with non-admin permissions' do
+ it 'responds with 200 OK' do
+ # TBD: trying to set a not accessible custom field is silently ignored
+ expect(last_response.status).to eq(200)
+ end
+
+ it 'does not set the cf value' do
+ expect(project.reload.custom_values)
+ .to be_empty
+ end
+
+ it 'does not activate the cf for project' do
+ expect(project.reload.project_custom_fields)
+ .to be_empty
+ end
+ end
end
context 'without permission to patch projects' do
diff --git a/spec/requests/auth/ldap_sso_spec.rb b/spec/requests/auth/ldap_sso_spec.rb
index 5d2858a013a6..d1367a9fc0c9 100644
--- a/spec/requests/auth/ldap_sso_spec.rb
+++ b/spec/requests/auth/ldap_sso_spec.rb
@@ -58,6 +58,23 @@
expect(subject).to redirect_to "/?first_time_user=true"
end
+ context 'with a user that has umlauts in their name' do
+ let(:username) { 'bölle' }
+ let(:password) { 'bólle' }
+
+ it 'creates a user with umlauts on the fly' do
+ expect(User.find_by(login: 'bölle')).to be_nil
+
+ expect { subject }.to change(User.not_builtin.active, :count).by(1)
+
+ user = User.find_by(login: 'bölle')
+ expect(user).to be_present
+ expect(user).to be_active
+ expect(session[:user_id]).to eq user.id
+ expect(subject).to redirect_to '/?first_time_user=true'
+ end
+ end
+
context "when not all attributes present" do
let(:attr_mail) { nil }
diff --git a/spec/requests/oauth_clients/ensure_connection_flow_spec.rb b/spec/requests/oauth_clients/ensure_connection_flow_spec.rb
index fcc3b3fc854e..eced9e187b6e 100644
--- a/spec/requests/oauth_clients/ensure_connection_flow_spec.rb
+++ b/spec/requests/oauth_clients/ensure_connection_flow_spec.rb
@@ -27,13 +27,20 @@
#++
require "spec_helper"
-require_module_spec_helper
+require_relative "../../../modules/storages/spec/spec_helper"
RSpec.describe "/oauth_clients/:oauth_client_id/ensure_connection endpoint", :webmock do
shared_let(:user) { create(:user) }
shared_let(:storage) { create(:nextcloud_storage, :with_oauth_client) }
shared_let(:oauth_client) { storage.oauth_client }
+ before do
+ Storages::Peripherals::Registry.stub(
+ "#{storage.short_provider_type}.queries.auth_check",
+ ->(_) { ServiceResult.success }
+ )
+ end
+
describe "#ensure_connection" do
context "when user is not logged in" do
it "requires login" do
@@ -52,10 +59,15 @@
end
context "when storage_id parameter is present" do
- context 'when user is not "connected"' do
+ context "when user is not 'connected'" do
let(:nonce) { "57a17c3f-b2ed-446e-9dd8-651ba3aec37d" }
before do
+ Storages::Peripherals::Registry.stub(
+ "#{storage.short_provider_type}.queries.auth_check",
+ ->(_) { ServiceResult.failure(errors: Storages::StorageError.new(code: :unauthorized)) }
+ )
+
allow(SecureRandom).to receive(:uuid).and_call_original.ordered
allow(SecureRandom).to receive(:uuid).and_return(nonce).ordered
end
@@ -72,7 +84,9 @@
"%2Foauth_clients%2F#{oauth_client.client_id}%2F" \
"callback&response_type=code&state=#{nonce}"
)
- expect(last_response.cookies["oauth_state_#{nonce}"]).to eq(["%7B%22href%22%3A%22http%3A%2F%2Fwww.example.com%2F%22%2C%22storageId%22%3A%22#{storage.id}%22%7D"])
+ expect(last_response.cookies["oauth_state_#{nonce}"])
+ .to eq(["%7B%22href%22%3A%22http%3A%2F%2Fwww.example.com" \
+ "%2F%22%2C%22storageId%22%3A%22#{storage.id}%22%7D"])
end
end
@@ -91,7 +105,9 @@
"%2Foauth_clients%2F#{oauth_client.client_id}%2F" \
"callback&response_type=code&state=#{nonce}"
)
- expect(last_response.cookies["oauth_state_#{nonce}"]).to eq(["%7B%22href%22%3A%22http%3A%2F%2Fwww.example.com%2F123%22%2C%22storageId%22%3A%22#{storage.id}%22%7D"])
+ expect(last_response.cookies["oauth_state_#{nonce}"])
+ .to eq(["%7B%22href%22%3A%22http%3A%2F%2Fwww.example.com" \
+ "%2F123%22%2C%22storageId%22%3A%22#{storage.id}%22%7D"])
end
end
@@ -109,13 +125,15 @@
"%2Foauth_clients%2F#{oauth_client.client_id}%2F" \
"callback&response_type=code&state=#{nonce}"
)
- expect(last_response.cookies["oauth_state_#{nonce}"]).to eq(["%7B%22href%22%3A%22http%3A%2F%2Fwww.example.com%2F%22%2C%22storageId%22%3A%22#{storage.id}%22%7D"])
+ expect(last_response.cookies["oauth_state_#{nonce}"])
+ .to eq(["%7B%22href%22%3A%22http%3A%2F%2Fwww.example.com" \
+ "%2F%22%2C%22storageId%22%3A%22#{storage.id}%22%7D"])
end
end
end
end
- context 'when user is "connected"' do
+ context "when user is 'connected'" do
let!(:oauth_client_token) do
create(:oauth_client_token, oauth_client:, user:)
end
diff --git a/spec/services/oauth_clients/connection_manager_spec.rb b/spec/services/oauth_clients/connection_manager_spec.rb
index b89a424a7196..a707b7ee3ef7 100644
--- a/spec/services/oauth_clients/connection_manager_spec.rb
+++ b/spec/services/oauth_clients/connection_manager_spec.rb
@@ -28,7 +28,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OAuthClients::ConnectionManager, :webmock, type: :model do
using Storages::Peripherals::ServiceResultRefinements
@@ -45,78 +45,24 @@
let(:instance) { described_class.new(user:, configuration:) }
- # The get_authorization_uri method returns the OAuth2 authorization URI as a string. That URI is the starting point for
- # a user to grant OpenProject access to Nextcloud.
- describe '#get_authorization_uri' do
- let(:scope) { nil }
- let(:state) { nil }
-
- subject { instance.get_authorization_uri(state:) }
-
- context 'with empty state and scope' do
- shared_examples_for 'returns the authorization URI relative to the host' do
- it 'returns the authorization URI' do
- expect(subject).to be_a String
- expect(subject).to include oauth_client.integration.host
- expect(subject).not_to include "scope"
- expect(subject).not_to include "state"
- end
- end
-
- context 'when Nextcloud is installed in the server root' do
- it_behaves_like 'returns the authorization URI relative to the host'
- end
-
- context 'when Nextcloud is installed in a sub-directory' do
- let(:host) { "https://example.org/nextcloud" }
-
- it_behaves_like 'returns the authorization URI relative to the host'
- end
- end
-
- context 'with state but empty scope' do
- let(:state) { "https://example.com/page" }
-
- it 'returns the redirect URL' do
- expect(subject).to be_a String
- expect(subject).to include oauth_client.integration.host
- expect(subject).not_to include "scope"
- expect(subject).to include "&state=https"
- end
- end
-
- context 'with multiple scopes but empty state' do
- let(:scope) { %i(email profile) }
-
- it 'returns the redirect URL' do
- allow(configuration).to receive(:scope).and_return(scope)
-
- expect(subject).to be_a String
- expect(subject).to include oauth_client.integration.host
- expect(subject).not_to include "state"
- expect(subject).to include "&scope=email%20profile"
- end
- end
- end
-
# The first step in the OAuth2 flow is to produce a URL for the
# user to authenticate and authorize access at the OAuth2 provider
# (Nextcloud).
- describe '#get_access_token' do
+ describe "#get_access_token" do
subject { instance.get_access_token }
- context 'with no OAuthClientToken present' do
- it 'returns a redirection URL' do
+ context "with no OAuthClientToken present" do
+ it "returns a redirection URL" do
expect(subject.success).to be_falsy
expect(subject.result).to be_a String
# Details of string are tested above in section #get_authorization_uri
end
end
- context 'with no OAuthClientToken present and state parameters' do
+ context "with no OAuthClientToken present and state parameters" do
subject { instance.get_access_token(state: "some_state") }
- it 'returns the redirect URL' do
+ it "returns the redirect URL" do
allow(configuration).to receive(:scope).and_return(%w[email])
expect(subject.success).to be_falsy
@@ -127,12 +73,12 @@
end
end
- context 'with an OAuthClientToken present' do
+ context "with an OAuthClientToken present" do
before do
oauth_client_token
end
- it 'returns the OAuthClientToken' do
+ it "returns the OAuthClientToken" do
expect(subject).to be_truthy
expect(subject.result).to be_a OAuthClientToken # The one and only...
expect(subject.result).to eql oauth_client_token
@@ -147,12 +93,12 @@
# The callback endpoint calls `code_to_token(code)` with the code
# received and exchanges the code for a bearer+refresh token
# using a HTTP request.
- describe '#code_to_token', :webmock do
+ describe "#code_to_token", :webmock do
let(:code) { "7kRGJ...jG3KZ" }
subject { instance.code_to_token(code) }
- context 'with happy path' do
+ context "with happy path" do
before do
# Simulate a successful authorization returning the tokens
response_body = {
@@ -162,11 +108,11 @@
refresh_token: "UwFp...1FROJ",
user_id: "admin"
}.to_json
- stub_request(:any, File.join(host, '/index.php/apps/oauth2/api/v1/token'))
+ stub_request(:any, File.join(host, "/index.php/apps/oauth2/api/v1/token"))
.to_return(status: 200, body: response_body, headers: { "content-type" => "application/json; charset=utf-8" })
end
- it 'returns a valid ClientToken object and issues an appropriate event' do
+ it "returns a valid ClientToken object and issues an appropriate event" do
expect(OpenProject::Notifications)
.to(receive(:send))
.with(OpenProject::Events::OAUTH_CLIENT_TOKEN_CREATED, integration_type: "Storages::Storage")
@@ -174,156 +120,156 @@
expect(subject.result).to be_a OAuthClientToken
end
- it 'fills in the origin_user_id' do
+ it "fills in the origin_user_id" do
expect { subject }.to change(OAuthClientToken, :count).by(1)
- last_token = OAuthClientToken.where(access_token: 'yjTDZ...RYvRH').last
+ last_token = OAuthClientToken.where(access_token: "yjTDZ...RYvRH").last
- expect(last_token.origin_user_id).to eq('admin')
+ expect(last_token.origin_user_id).to eq("admin")
end
end
- context 'with known error' do
+ context "with known error" do
before do
- stub_request(:post, File.join(host, '/index.php/apps/oauth2/api/v1/token'))
+ stub_request(:post, File.join(host, "/index.php/apps/oauth2/api/v1/token"))
.to_return(status: 400,
body: { error: error_message }.to_json,
headers: { "content-type" => "application/json; charset=utf-8" })
end
- shared_examples 'OAuth2 error response' do
- it 'returns a specific error message' do
+ shared_examples "OAuth2 error response" do
+ it "returns a specific error message" do
expect(subject.success).to be_falsy
expect(subject.result).to eq(:bad_request)
expect(subject.error_payload[:error]).to eq(error_message)
end
end
- context 'when "invalid_request"' do
- let(:error_message) { 'invalid_request' }
+ context "when 'invalid_request'" do
+ let(:error_message) { "invalid_request" }
- it_behaves_like 'OAuth2 error response'
+ it_behaves_like "OAuth2 error response"
end
- context 'when "invalid_grant"' do
- let(:error_message) { 'invalid_grant' }
+ context "when 'invalid_grant'" do
+ let(:error_message) { "invalid_grant" }
- it_behaves_like 'OAuth2 error response'
+ it_behaves_like "OAuth2 error response"
end
end
- context 'with unknown reply' do
+ context "with unknown reply" do
before do
- stub_request(:post, File.join(host, '/index.php/apps/oauth2/api/v1/token'))
+ stub_request(:post, File.join(host, "/index.php/apps/oauth2/api/v1/token"))
.to_return(status: 400,
body: { error: "invalid_requesttt" }.to_json,
headers: { "content-type" => "application/json; charset=utf-8" })
end
- it 'returns an error wrapping the unknown response' do
+ it "returns an error wrapping the unknown response" do
expect(subject.success).to be_falsy
expect(subject.result).to eq(:bad_request)
- expect(subject.error_payload[:error]).to eq('invalid_requesttt')
+ expect(subject.error_payload[:error]).to eq("invalid_requesttt")
expect(subject.error_source).to be_a(described_class)
- expect(subject.errors.log_message).to include I18n.t('oauth_client.errors.oauth_returned_error')
+ expect(subject.errors.log_message).to include I18n.t("oauth_client.errors.oauth_returned_error")
end
end
- context 'with reply including JSON syntax error' do
+ context "with reply including JSON syntax error" do
before do
- stub_request(:post, File.join(host, '/index.php/apps/oauth2/api/v1/token'))
+ stub_request(:post, File.join(host, "/index.php/apps/oauth2/api/v1/token"))
.to_return(
status: 400,
- headers: { 'Content-Type' => 'application/json; charset=utf-8' },
+ headers: { "Content-Type" => "application/json; charset=utf-8" },
body: "some: very, invalid>
"application/json; charset=utf-8" })
end
- it 'returns a valid ClientToken object', :webmock do
+ it "returns a valid ClientToken object", :webmock do
expect(subject.success).to be_truthy
expect(subject.result).to be_a OAuthClientToken
expect(subject.result.access_token).to eq("xyjTDZ...RYvRH")
@@ -346,7 +292,7 @@
end
end
- context 'with invalid access_token data' do
+ context "with invalid access_token data" do
before do
# Simulate a token too long
response_body = {
@@ -356,11 +302,11 @@
refresh_token: "xUwFp...1FROJ",
user_id: "admin"
}.to_json
- stub_request(:any, File.join(host, '/index.php/apps/oauth2/api/v1/token'))
+ stub_request(:any, File.join(host, "/index.php/apps/oauth2/api/v1/token"))
.to_return(status: 200, body: response_body, headers: { "content-type" => "application/json; charset=utf-8" })
end
- it 'returns dependent error from model validation', :webmock do
+ it "returns dependent error from model validation", :webmock do
expect(subject.success).to be_falsy
expect(subject.result).to eq(:error)
expect(subject.error_payload.class).to be(AttrRequired::AttrMissing)
@@ -368,38 +314,38 @@
end
end
- context 'with server error from OAuth2 provider' do
+ context "with server error from OAuth2 provider" do
before do
- stub_request(:any, File.join(host, '/index.php/apps/oauth2/api/v1/token'))
+ stub_request(:any, File.join(host, "/index.php/apps/oauth2/api/v1/token"))
.to_return(status: 400,
body: { error: "invalid_request" }.to_json,
headers: { "content-type" => "application/json; charset=utf-8" })
end
- it 'returns a server error', :webmock do
+ it "returns a server error", :webmock do
expect(subject.success).to be_falsy
expect(subject.result).to eq(:bad_request)
- expect(subject.error_payload[:error]).to eq('invalid_request')
+ expect(subject.error_payload[:error]).to eq("invalid_request")
end
end
- context 'with successful response but invalid data' do
+ context "with successful response but invalid data" do
before do
# Simulate timeout
- stub_request(:any, File.join(host, '/index.php/apps/oauth2/api/v1/token'))
+ stub_request(:any, File.join(host, "/index.php/apps/oauth2/api/v1/token"))
.to_timeout
end
- it 'returns an error wrapping a timeout', :webmock do
+ it "returns an error wrapping a timeout", :webmock do
expect(subject.success).to be_falsy
expect(subject.result).to eq(:internal_server_error)
expect(subject.error_payload.class).to be(Faraday::ConnectionFailed)
expect(subject.error_source).to be_a(described_class)
- expect(subject.errors.log_message).to include('Faraday::ConnectionFailed: execution expired')
+ expect(subject.errors.log_message).to include("Faraday::ConnectionFailed: execution expired")
end
end
- context 'with parallel requests for refresh', :aggregate_failures do
+ context "with parallel requests for refresh", :aggregate_failures do
after do
Storages::Storage.destroy_all
User.destroy_all
@@ -407,7 +353,7 @@
OAuthClient.destroy_all
end
- it 'requests token only once and other thread uses new token' do
+ it "requests token only once and other thread uses new token" do
response_body1 = {
access_token: "xyjTDZ...RYvRH",
token_type: "Bearer",
@@ -417,7 +363,7 @@
}
response_body2 = response_body1.dup
response_body2[:access_token] = "differ...RYvRH"
- request_url = File.join(host, '/index.php/apps/oauth2/api/v1/token')
+ request_url = File.join(host, "/index.php/apps/oauth2/api/v1/token")
stub_request(:any, request_url).to_return(
{ status: 200, body: response_body1.to_json, headers: { "content-type" => "application/json; charset=utf-8" } },
{ status: 200, body: response_body2.to_json, headers: { "content-type" => "application/json; charset=utf-8" } }
@@ -443,7 +389,7 @@
expect(WebMock).to have_requested(:any, request_url).once
end
- it 'requests token refresh twice if enough time passes between requests' do
+ it "requests token refresh twice if enough time passes between requests" do
stub_const("OAuthClients::ConnectionManager::TOKEN_IS_FRESH_DURATION", 2.seconds)
response_body1 = {
access_token: "xyjTDZ...RYvRH",
@@ -454,7 +400,7 @@
}
response_body2 = response_body1.dup
response_body2[:access_token] = "differ...RYvRH"
- request_url = File.join(host, '/index.php/apps/oauth2/api/v1/token')
+ request_url = File.join(host, "/index.php/apps/oauth2/api/v1/token")
headers = { "content-type" => "application/json; charset=utf-8" }
stub_request(:any, request_url)
.to_return(status: 200, body: response_body1.to_json, headers:).then
@@ -483,8 +429,8 @@
end
end
- context 'when token is fresh' do
- it 'does not send refresh request and respond with existing token', :webmock do
+ context "when token is fresh" do
+ it "does not send refresh request and respond with existing token", :webmock do
expect(subject.success).to be_truthy
expect(subject.result).to eq(oauth_client_token)
expect { subject }.not_to change(oauth_client_token, :access_token)
@@ -493,93 +439,7 @@
end
end
- describe '#authorization_state' do
- subject { instance.authorization_state }
-
- context 'without access token present' do
- it 'returns :failed_authorization' do
- expect(subject).to eq :failed_authorization
- expect(instance).to be_authorization_state_failed_authorization
- end
- end
-
- context 'with access token present', :webmock do
- before do
- oauth_client_token
- end
-
- context 'with access token valid' do
- context 'without other errors or exceptions' do
- before do
- allow(configuration).to receive(:authorization_state_check).and_return(:success)
- end
-
- it 'returns :connected' do
- expect(subject).to eq :connected
- expect(instance).to be_authorization_state_connected
- end
- end
-
- context 'with some other error or exception' do
- before do
- allow(configuration).to receive(:authorization_state_check).and_return(:error)
- end
-
- it 'returns :error' do
- expect(subject).to eq :error
- expect(instance).to be_authorization_state_error
- end
- end
- end
-
- context 'with outdated access token' do
- let(:new_oauth_client_token) { create(:oauth_client_token) }
- let(:refresh_service_result) { ServiceResult.success }
-
- before do
- allow(configuration).to receive(:authorization_state_check).and_return(:refresh_needed)
- allow(instance).to receive(:refresh_token).and_return(refresh_service_result)
- end
-
- context 'with valid refresh token' do
- it 'refreshes the access token and returns :connected' do
- expect(subject).to eq :connected
- expect(instance).to have_received(:refresh_token)
- end
- end
-
- context 'with invalid refresh token' do
- let(:refresh_service_result) do
- data = Storages::StorageErrorData.new(source: nil, payload: { error: 'invalid_request' })
- ServiceResult.failure(result: :bad_request,
- errors: Storages::StorageError.new(code: :bad_request, data:))
- end
-
- it 'refreshes the access token and returns :failed_authorization' do
- expect(subject).to eq :failed_authorization
- expect(instance).to have_received(:refresh_token)
- end
- end
-
- context 'with some other error while refreshing access token' do
- let(:refresh_service_result) { ServiceResult.failure }
-
- it 'returns :error' do
- expect(subject).to eq :error
- expect(instance).to have_received(:refresh_token)
- end
- end
- end
- end
-
- context 'with both invalid access token and refresh token', :webmock do
- it 'returns :failed_authorization' do
- expect(subject).to eq :failed_authorization
- end
- end
- end
-
- describe '#request_with_token_refresh' do
+ describe "#request_with_token_refresh" do
let(:yield_service_result) { ServiceResult.success }
let(:refresh_service_result) { ServiceResult.success }
@@ -592,18 +452,18 @@
allow(oauth_client_token).to receive(:reload)
end
- context 'with yield returning :success' do
- it 'returns a ServiceResult with success, without refreshing the token' do
+ context "with yield returning :success" do
+ it "returns a ServiceResult with success, without refreshing the token" do
expect(subject.success).to be_truthy
expect(instance).not_to have_received(:refresh_token)
expect(oauth_client_token).not_to have_received(:reload)
end
end
- context 'with yield returning :error' do
+ context "with yield returning :error" do
let(:yield_service_result) { ServiceResult.failure(result: :error) }
- it 'returns a ServiceResult with success, without refreshing the token' do
+ it "returns a ServiceResult with success, without refreshing the token" do
expect(subject.success).to be_falsy
expect(subject.result).to be :error
expect(instance).not_to have_received(:refresh_token)
@@ -611,10 +471,10 @@
end
end
- context 'with yield returning :unauthorized and the refresh returning a with a success' do
+ context "with yield returning :unauthorized and the refresh returning a with a success" do
let(:yield_service_result) { ServiceResult.failure(result: :unauthorized) }
- it 'returns a ServiceResult with success, without refresh' do
+ it "returns a ServiceResult with success, without refresh" do
expect(subject.success).to be_falsy
expect(subject.result).to be :unauthorized
expect(instance).to have_received(:refresh_token)
@@ -622,15 +482,15 @@
end
end
- context 'with yield returning :unauthorized and the refresh returning with a :failure' do
+ context "with yield returning :unauthorized and the refresh returning with a :failure" do
let(:yield_service_result) { ServiceResult.failure(result: :unauthorized) }
let(:refresh_service_result) do
- data = Storages::StorageErrorData.new(source: nil, payload: { error: 'invalid_request' })
+ data = Storages::StorageErrorData.new(source: nil, payload: { error: "invalid_request" })
ServiceResult.failure(result: :error,
errors: Storages::StorageError.new(code: :error, data:))
end
- it 'returns a ServiceResult with success, without refresh' do
+ it "returns a ServiceResult with success, without refresh" do
expect(subject.success).to be_falsy
expect(subject.result).to be :error
expect(instance).to have_received(:refresh_token)
@@ -638,7 +498,7 @@
end
end
- context 'with yield returning :unauthorized first time and :success the second time' do
+ context "with yield returning :unauthorized first time and :success the second time" do
let(:yield_double_object) { Object.new }
let(:yield_service_result1) { ServiceResult.failure(result: :unauthorized) }
let(:yield_service_result2) { ServiceResult.success }
@@ -658,7 +518,7 @@
)
end
- it 'returns a ServiceResult with success, without refresh' do
+ it "returns a ServiceResult with success, without refresh" do
expect(subject.success).to be_truthy
expect(subject).to be yield_service_result2
expect(instance).to have_received(:refresh_token)
diff --git a/spec/services/oauth_clients/one_drive_connection_manager_spec.rb b/spec/services/oauth_clients/one_drive_connection_manager_spec.rb
index 9f530e21b350..b04fa5de908a 100644
--- a/spec/services/oauth_clients/one_drive_connection_manager_spec.rb
+++ b/spec/services/oauth_clients/one_drive_connection_manager_spec.rb
@@ -28,19 +28,19 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OAuthClients::ConnectionManager, :webmock, type: :model do
let(:user) { create(:user) }
- let(:storage) { create(:one_drive_storage, :with_oauth_client, tenant_id: 'consumers') }
+ let(:storage) { create(:one_drive_storage, :with_oauth_client, tenant_id: "consumers") }
let(:token) { create(:oauth_client_token, oauth_client: storage.oauth_client, user:) }
subject(:connection_manager) do
described_class.new(user:, configuration: storage.oauth_configuration)
end
- describe '#code_to_token' do
- let(:code) { 'wow.such.code.much.token' }
+ describe "#code_to_token" do
+ let(:code) { "wow.such.code.much.token" }
let(:code_to_token_response) do
{
access_token: "eyJ0eXAiOiJKV1QiLCJhbGciOiJSUzI1NiIsIng1dCI6Ik5HVEZ2ZEstZnl0aEV1Q...",
@@ -69,200 +69,55 @@
end
before do
- stub_request(:post, 'https://login.microsoftonline.com/consumers/oauth2/v2.0/token')
- .to_return(status: 200, body: code_to_token_response, headers: { 'Content-Type' => 'application/json' })
+ stub_request(:post, "https://login.microsoftonline.com/consumers/oauth2/v2.0/token")
+ .to_return(status: 200, body: code_to_token_response, headers: { "Content-Type" => "application/json" })
- stub_request(:get, 'https://graph.microsoft.com/v1.0/me')
+ stub_request(:get, "https://graph.microsoft.com/v1.0/me")
.with(headers: { Authorization: "Bearer eyJ0eXAiOiJKV1QiLCJhbGciOiJSUzI1NiIsIng1dCI6Ik5HVEZ2ZEstZnl0aEV1Q..." })
- .to_return(status: 200, body: me_response, headers: { 'Content-Type' => 'application/json' })
+ .to_return(status: 200, body: me_response, headers: { "Content-Type" => "application/json" })
end
- it 'fills in the origin_user_id' do
+ it "fills in the origin_user_id" do
expect { subject.code_to_token(code) }.to change(OAuthClientToken, :count).by(1)
last_token = OAuthClientToken
.where(access_token: "eyJ0eXAiOiJKV1QiLCJhbGciOiJSUzI1NiIsIng1dCI6Ik5HVEZ2ZEstZnl0aEV1Q...")
.last
- expect(last_token.origin_user_id).to eq('87d349ed-44d7-43e1-9a83-5f2406dee5bd')
+ expect(last_token.origin_user_id).to eq("87d349ed-44d7-43e1-9a83-5f2406dee5bd")
end
- context 'when the identification request fails' do
+ context "when the identification request fails" do
before do
- stub_request(:get, 'https://graph.microsoft.com/v1.0/me')
+ stub_request(:get, "https://graph.microsoft.com/v1.0/me")
.with(headers: { Authorization: "Bearer eyJ0eXAiOiJKV1QiLCJhbGciOiJSUzI1NiIsIng1dCI6Ik5HVEZ2ZEstZnl0aEV1Q..." })
.to_return(status: 404)
end
- it 'raises an error' do
+ it "raises an error" do
expect { subject.code_to_token(code) }.to raise_error(HTTPX::HTTPError)
end
end
end
- describe '#get_authorization_uri' do
- it 'always add the necessary scopes' do
- uri = connection_manager.get_authorization_uri(state: nil)
-
- expect(uri).to include CGI.escape(storage.oauth_configuration.scope.join(' '))
- end
-
- it 'adds the state if present' do
- uri = connection_manager.get_authorization_uri(state: 'https://some.site.com')
- expect(uri).to include "&state=https"
- end
- end
-
- describe '#get_access_token' do
+ describe "#get_access_token" do
subject(:access_token_result) { connection_manager.get_access_token }
- context 'with no OAuthClientToken present' do
- it 'returns a redirection URL' do
+ context "with no OAuthClientToken present" do
+ it "returns a redirection URL" do
expect(access_token_result).to be_failure
- expect(access_token_result.result).to eq(connection_manager.get_authorization_uri)
+ expect(access_token_result.result).to eq(storage.oauth_configuration.authorization_uri)
end
end
- context 'with an OAuthClientToken present' do
+ context "with an OAuthClientToken present" do
before { token }
- it 'returns the OAuthClientToken' do
+ it "returns the OAuthClientToken" do
expect(access_token_result).to be_truthy
expect(access_token_result.result).to be_a OAuthClientToken # The one and only...
expect(access_token_result.result).to eql token
end
end
end
-
- describe '#authorization_state' do
- subject(:authorization_state) { connection_manager.authorization_state }
-
- context 'without access token present' do
- it 'returns :failed_authorization' do
- expect(authorization_state).to eq :failed_authorization
- end
- end
-
- context 'with access token present', :webmock do
- before { token }
-
- context 'with access token valid' do
- context 'without other errors or exceptions' do
- before { stub_request(:get, 'https://graph.microsoft.com/v1.0/me').to_return(status: 200) }
-
- it 'returns :connected' do
- expect(authorization_state).to eq :connected
- end
- end
-
- context 'with some other error or exception' do
- before { stub_request(:get, 'https://graph.microsoft.com/v1.0/me').to_timeout }
-
- it 'returns :error' do
- expect(authorization_state).to eq :error
- end
- end
- end
-
- context 'with outdated access token' do
- shared_examples 'refresh' do |_code|
- before do
- stub_request(:get, 'https://graph.microsoft.com/v1.0/me').to_return(status: 401)
- end
-
- context 'with valid refresh token' do
- it 'refreshes the access token and returns :connected' do
- expect(authorization_state).to eq :connected
- end
- end
-
- context 'with invalid refresh token' do
- it 'refreshes the access token and returns :failed_authorization' do
- allow(token).to receive(:updated_at).and_return(3.months.ago)
- expect(authorization_state).to eq :failed_authorization
- end
- end
-
- context 'with some other error while refreshing access token' do
- it 'returns :error' do
- expect(authorization_state).to eq :error
- end
- end
- end
-
- context 'when Unauthorized is returned' do
- before do
- stub_request(:get, 'https://graph.microsoft.com/v1.0/me').to_return(status: 401)
- end
-
- context 'with valid refresh token' do
- before do
- stub_request(:post, 'https://login.microsoftonline.com/consumers/oauth2/v2.0/token')
- .to_return(status: 200,
- body: { access_token: 'ThereIsNoPeaceOnlyPassion' }.to_json,
- headers: { 'Content-Type' => 'application/json' })
- end
-
- it 'refreshes the access token and returns :connected' do
- expect(authorization_state).to eq :connected
- end
- end
-
- context 'with invalid refresh token' do
- before do
- token.update!(updated_at: 3.months.ago)
- stub_request(:post, 'https://login.microsoftonline.com/consumers/oauth2/v2.0/token')
- .to_return(status: 400,
- body: { error: 'invalid_request', error_message: 'nope. not happening' }.to_json,
- headers: { 'Content-Type' => 'application/json' })
- end
-
- it 'refreshes the access token and returns :failed_authorization' do
- expect(authorization_state).to eq :failed_authorization
- end
- end
-
- context 'with some other error while refreshing access token' do
- it 'returns :error' do
- token.update!(updated_at: 3.months.ago)
-
- stub_request(:get, 'https://graph.microsoft.com/v1.0/me').to_return(status: 401)
- stub_request(:post, 'https://login.microsoftonline.com/consumers/oauth2/v2.0/token')
- .to_return(status: 400,
- body: { error: 'you_error', error_message: 'it is not me, it is you' }.to_json,
- headers: { 'Content-Type' => 'application/json' })
-
- expect(authorization_state).to eq :error
- end
- end
- end
-
- context 'when Forbidden is returned' do
- before do
- stub_request(:get, 'https://graph.microsoft.com/v1.0/me').to_return(status: 403)
- end
-
- context 'with valid refresh token' do
- it 'refreshes the access token and returns :connected' do
- expect(authorization_state).to eq :connected
- end
- end
-
- context 'with invalid refresh token' do
- before do
- token.update!(updated_at: 3.months.ago)
- stub_request(:post, 'https://login.microsoftonline.com/consumers/oauth2/v2.0/token')
- .to_return(status: 400,
- body: { error: 'invalid_request', error_message: 'nope. not happening' }.to_json,
- headers: { 'Content-Type' => 'application/json' })
- end
-
- it 'refreshes the access token and returns :failed_authorization' do
- expect(authorization_state).to eq :failed_authorization
- end
- end
- end
- end
- end
- end
end
diff --git a/spec/services/project_custom_field_project_mappings/bulk_update_service_spec.rb b/spec/services/project_custom_field_project_mappings/bulk_update_service_spec.rb
new file mode 100644
index 000000000000..799403ac4498
--- /dev/null
+++ b/spec/services/project_custom_field_project_mappings/bulk_update_service_spec.rb
@@ -0,0 +1,145 @@
+#-- copyright
+# OpenProject is an open source project management software.
+# Copyright (C) 2012-2024 the OpenProject GmbH
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+#
+# See COPYRIGHT and LICENSE files for more details.
+#++
+
+require 'spec_helper'
+
+RSpec.describe ProjectCustomFieldProjectMappings::BulkUpdateService do
+ let!(:project) { create(:project) }
+ let!(:section_with_invisible_fields) { create(:project_custom_field_section, name: 'Section with invisible fields') }
+
+ let!(:visible_project_custom_field) do
+ create(:project_custom_field,
+ name: 'Visible field',
+ visible: true,
+ project_custom_field_section: section_with_invisible_fields)
+ end
+
+ let!(:visible_required_project_custom_field) do
+ create(:project_custom_field,
+ name: 'Visible required field',
+ visible: true,
+ is_required: true,
+ project_custom_field_section: section_with_invisible_fields)
+ end
+
+ let!(:invisible_project_custom_field) do
+ create(:project_custom_field,
+ name: 'Admin only field',
+ visible: false,
+ project_custom_field_section: section_with_invisible_fields)
+ end
+
+ let(:instance) { described_class.new(user:, project:, project_custom_field_section: section_with_invisible_fields) }
+
+ context 'with admin permissions' do
+ let(:user) { create(:admin) }
+
+ it 'bulk enables/disables all (non-required) fields of the section, including invisible ones' do
+ expect(project.project_custom_fields).to contain_exactly(
+ visible_required_project_custom_field
+ )
+
+ expect(instance.call(action: :enable)).to be_success
+
+ expect(project.reload.project_custom_fields).to contain_exactly(
+ visible_required_project_custom_field, visible_project_custom_field, invisible_project_custom_field
+ )
+
+ expect(instance.call(action: :disable)).to be_success
+
+ # required fields cannot be disabled, even not by admins
+ expect(project.reload.project_custom_fields).to contain_exactly(
+ visible_required_project_custom_field
+ )
+ end
+ end
+
+ context 'with non-admin but sufficient permissions' do
+ let(:user) do
+ create(:user,
+ firstname: 'Project',
+ lastname: 'Admin',
+ member_with_permissions: {
+ project => %w[
+ view_work_packages
+ edit_project
+ select_project_custom_fields
+ ]
+ })
+ end
+
+ it 'bulk enables/disables all fields of the section, excluding invisible ones' do
+ expect(project.project_custom_fields).to contain_exactly(
+ visible_required_project_custom_field
+ )
+
+ expect(instance.call(action: :enable)).to be_success
+
+ expect(project.reload.project_custom_fields).to contain_exactly(
+ visible_required_project_custom_field, visible_project_custom_field
+ )
+
+ project.project_custom_fields << invisible_project_custom_field
+
+ expect(instance.call(action: :disable)).to be_success
+
+ # required fields cannot be disabled, invisible fields are not affected by non-admins
+ expect(project.reload.project_custom_fields).to contain_exactly(
+ visible_required_project_custom_field, invisible_project_custom_field
+ )
+ end
+ end
+
+ context 'with insufficient permissions' do
+ let(:user) do
+ create(:user,
+ firstname: 'Project',
+ lastname: 'Editor',
+ member_with_permissions: {
+ project => %w[
+ view_work_packages
+ edit_project
+ ]
+ })
+ end
+
+ it 'cannot bulk enable/disable project custom fields' do
+ expect(project.project_custom_fields).to contain_exactly(
+ visible_required_project_custom_field
+ )
+
+ expect(instance.call(action: :enable)).to be_failure
+
+ expect(project.reload.project_custom_fields).to contain_exactly(
+ visible_required_project_custom_field
+ )
+
+ expect(instance.call(action: :disable)).to be_failure
+ end
+ end
+end
diff --git a/spec/services/project_custom_field_project_mappings/toggle_service_spec.rb b/spec/services/project_custom_field_project_mappings/toggle_service_spec.rb
new file mode 100644
index 000000000000..929514c70038
--- /dev/null
+++ b/spec/services/project_custom_field_project_mappings/toggle_service_spec.rb
@@ -0,0 +1,217 @@
+#-- copyright
+# OpenProject is an open source project management software.
+# Copyright (C) 2012-2024 the OpenProject GmbH
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+#
+# See COPYRIGHT and LICENSE files for more details.
+#++
+
+require 'spec_helper'
+
+RSpec.describe ProjectCustomFieldProjectMappings::ToggleService do
+ let!(:project) { create(:project) }
+ let!(:section_with_invisible_fields) { create(:project_custom_field_section, name: 'Section with invisible fields') }
+
+ let!(:visible_project_custom_field) do
+ create(:project_custom_field,
+ name: 'Visible field',
+ visible: true,
+ project_custom_field_section: section_with_invisible_fields)
+ end
+
+ let!(:visible_required_project_custom_field) do
+ create(:project_custom_field,
+ name: 'Visible required field',
+ visible: true,
+ is_required: true,
+ project_custom_field_section: section_with_invisible_fields)
+ end
+
+ let!(:invisible_project_custom_field) do
+ create(:project_custom_field,
+ name: 'Admin only field',
+ visible: false,
+ project_custom_field_section: section_with_invisible_fields)
+ end
+
+ let(:instance) { described_class.new(user:) }
+
+ context 'with admin permissions' do
+ let(:user) { create(:admin) }
+
+ it 'toggles visible, non-required fields' do
+ expect(project.project_custom_fields).to contain_exactly(
+ visible_required_project_custom_field
+ )
+
+ expect(instance.call(project_id: project.id, custom_field_id: visible_project_custom_field.id)).to be_success
+
+ expect(project.reload.project_custom_fields).to contain_exactly(
+ visible_required_project_custom_field, visible_project_custom_field
+ )
+
+ expect(instance.call(project_id: project.id, custom_field_id: visible_project_custom_field.id)).to be_success
+
+ expect(project.reload.project_custom_fields).to contain_exactly(
+ visible_required_project_custom_field
+ )
+ end
+
+ it 'toggles invisible, non-required fields' do
+ expect(project.project_custom_fields).to contain_exactly(
+ visible_required_project_custom_field
+ )
+
+ expect(instance.call(project_id: project.id, custom_field_id: invisible_project_custom_field.id)).to be_success
+
+ expect(project.reload.project_custom_fields).to contain_exactly(
+ visible_required_project_custom_field, invisible_project_custom_field
+ )
+
+ expect(instance.call(project_id: project.id, custom_field_id: invisible_project_custom_field.id)).to be_success
+
+ expect(project.reload.project_custom_fields).to contain_exactly(
+ visible_required_project_custom_field
+ )
+ end
+
+ it 'does not toggle required fields' do
+ expect(project.project_custom_fields).to contain_exactly(
+ visible_required_project_custom_field
+ )
+
+ expect(instance.call(project_id: project.id, custom_field_id: visible_required_project_custom_field.id)).to be_failure
+
+ expect(project.reload.project_custom_fields).to contain_exactly(
+ visible_required_project_custom_field
+ )
+ end
+ end
+
+ context 'with non-admin but sufficient permissions' do
+ let(:user) do
+ create(:user,
+ firstname: 'Project',
+ lastname: 'Admin',
+ member_with_permissions: {
+ project => %w[
+ view_work_packages
+ edit_project
+ select_project_custom_fields
+ ]
+ })
+ end
+
+ it 'toggles visible, non-required fields' do
+ expect(project.project_custom_fields).to contain_exactly(
+ visible_required_project_custom_field
+ )
+
+ expect(instance.call(project_id: project.id, custom_field_id: visible_project_custom_field.id)).to be_success
+
+ expect(project.reload.project_custom_fields).to contain_exactly(
+ visible_required_project_custom_field, visible_project_custom_field
+ )
+
+ expect(instance.call(project_id: project.id, custom_field_id: visible_project_custom_field.id)).to be_success
+
+ expect(project.reload.project_custom_fields).to contain_exactly(
+ visible_required_project_custom_field
+ )
+ end
+
+ it 'does not toggle invisible, non-required fields' do
+ expect(project.project_custom_fields).to contain_exactly(
+ visible_required_project_custom_field
+ )
+
+ expect(instance.call(project_id: project.id, custom_field_id: invisible_project_custom_field.id)).to be_failure
+
+ expect(project.reload.project_custom_fields).to contain_exactly(
+ visible_required_project_custom_field
+ )
+ end
+
+ it 'does not toggle required fields' do
+ expect(project.project_custom_fields).to contain_exactly(
+ visible_required_project_custom_field
+ )
+
+ expect(instance.call(project_id: project.id, custom_field_id: visible_required_project_custom_field.id)).to be_failure
+
+ expect(project.reload.project_custom_fields).to contain_exactly(
+ visible_required_project_custom_field
+ )
+ end
+ end
+
+ context 'with insufficient permissions' do
+ let(:user) do
+ create(:user,
+ firstname: 'Project',
+ lastname: 'Editor',
+ member_with_permissions: {
+ project => %w[
+ view_work_packages
+ edit_project
+ ]
+ })
+ end
+
+ it 'does not toggle visible, non-required fields' do
+ expect(project.project_custom_fields).to contain_exactly(
+ visible_required_project_custom_field
+ )
+
+ expect(instance.call(project_id: project.id, custom_field_id: visible_project_custom_field.id)).to be_failure
+
+ expect(project.reload.project_custom_fields).to contain_exactly(
+ visible_required_project_custom_field
+ )
+ end
+
+ it 'does not toggle invisible, non-required fields' do
+ expect(project.project_custom_fields).to contain_exactly(
+ visible_required_project_custom_field
+ )
+
+ expect(instance.call(project_id: project.id, custom_field_id: invisible_project_custom_field.id)).to be_failure
+
+ expect(project.reload.project_custom_fields).to contain_exactly(
+ visible_required_project_custom_field
+ )
+ end
+
+ it 'does not toggle required fields' do
+ expect(project.project_custom_fields).to contain_exactly(
+ visible_required_project_custom_field
+ )
+
+ expect(instance.call(project_id: project.id, custom_field_id: visible_required_project_custom_field.id)).to be_failure
+
+ expect(project.reload.project_custom_fields).to contain_exactly(
+ visible_required_project_custom_field
+ )
+ end
+ end
+end
diff --git a/spec/services/projects/copy_service_integration_spec.rb b/spec/services/projects/copy_service_integration_spec.rb
index d48b613d147f..c95a328eb85e 100644
--- a/spec/services/projects/copy_service_integration_spec.rb
+++ b/spec/services/projects/copy_service_integration_spec.rb
@@ -157,6 +157,8 @@
it 'copies the custom_field' do
expect(subject).to be_success
+ expect(project_copy.project_custom_fields).to contain_exactly(user_custom_field)
+
cv = project_copy.custom_values.reload.find_by(custom_field: user_custom_field)
expect(cv).to be_present
expect(cv.value).to eq user_value.id.to_s
@@ -177,6 +179,8 @@
it 'copies the custom_field' do
expect(subject).to be_success
+ expect(project_copy.project_custom_fields).to contain_exactly(list_custom_field)
+
cv = project_copy.custom_values.reload.where(custom_field: list_custom_field).to_a
expect(cv).to be_a Array
expect(cv.count).to eq 2
@@ -184,6 +188,17 @@
end
end
+ context 'with disabled project custom fields with default value' do
+ it 'is still disabled in the copy' do
+ create(:text_project_custom_field, default_value: 'default value')
+
+ expect(subject).to be_success
+
+ expect(source.project_custom_fields).to eq([])
+ expect(project_copy.project_custom_fields).to match_array(source.project_custom_fields)
+ end
+ end
+
context 'with disabled work package custom field' do
it 'is still disabled in the copy' do
custom_field = create(:text_wp_custom_field)
diff --git a/spec/services/queries/projects/project_queries/set_attributes_service_spec.rb b/spec/services/queries/projects/project_queries/set_attributes_service_spec.rb
index 9f91c06434d8..eea42daa4992 100644
--- a/spec/services/queries/projects/project_queries/set_attributes_service_spec.rb
+++ b/spec/services/queries/projects/project_queries/set_attributes_service_spec.rb
@@ -30,6 +30,20 @@
RSpec.describe Queries::Projects::ProjectQueries::SetAttributesService, type: :model do
let(:current_user) { build_stubbed(:user) }
+ let!(:custom_field) do
+ build_stubbed(:project_custom_field, id: 1) do |cf|
+ scope = instance_double(ActiveRecord::Relation)
+
+ allow(ProjectCustomField)
+ .to receive(:visible)
+ .and_return(scope)
+
+ allow(scope)
+ .to receive(:find_by)
+ .with(id: cf.id.to_s)
+ .and_return(cf)
+ end
+ end
let(:contract_instance) do
contract = instance_double(Queries::Projects::ProjectQueries::CreateContract)
diff --git a/spec/support/components/projects/project_custom_fields/edit_dialog.rb b/spec/support/components/projects/project_custom_fields/edit_dialog.rb
new file mode 100644
index 000000000000..3db7c11bbb03
--- /dev/null
+++ b/spec/support/components/projects/project_custom_fields/edit_dialog.rb
@@ -0,0 +1,113 @@
+# -- copyright
+# OpenProject is an open source project management software.
+# Copyright (C) 2010-2023 the OpenProject GmbH
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+#
+# See COPYRIGHT and LICENSE files for more details.
+# ++
+
+require 'support/components/common/modal'
+require 'support/components/autocompleter/ng_select_autocomplete_helpers'
+
+module Components
+ module Projects
+ module ProjectCustomFields
+ class EditDialog < Components::Common::Modal
+ include Components::Autocompleter::NgSelectAutocompleteHelpers
+
+ attr_reader :project, :project_custom_field_section, :title
+
+ def initialize(project, project_custom_field_section)
+ super()
+
+ @project = project
+ @project_custom_field_section = project_custom_field_section
+ @title = @project_custom_field_section.name
+ end
+
+ def dialog_css_selector
+ "dialog#edit-project-custom-fields-dialog-#{@project_custom_field_section.id}"
+ end
+
+ def async_content_container_css_selector
+ "#{dialog_css_selector} [data-qa-selector='async-dialog-content']"
+ end
+
+ def within_dialog(&)
+ within(dialog_css_selector, &)
+ end
+
+ def within_async_content(close_after_yield: false, &)
+ within(async_content_container_css_selector, &)
+ close if close_after_yield
+ end
+
+ def close
+ within_dialog do
+ page.find(".close-button").click
+ end
+ end
+ alias_method :close_via_icon, :close
+
+ def close_via_button
+ within(dialog_css_selector) do
+ click_link_or_button 'Cancel'
+ end
+ end
+
+ def submit
+ within(dialog_css_selector) do
+ page.find("[data-qa-selector='save-project-attributes-button']").click
+ end
+ end
+
+ def expect_open
+ expect(page).to have_css(dialog_css_selector)
+ end
+
+ def expect_closed
+ expect(page).to have_no_css(dialog_css_selector)
+ end
+
+ def expect_async_content_loaded
+ expect(page).to have_css(async_content_container_css_selector)
+ end
+
+ ###
+
+ def input_containers
+ within '.Overlay-body > .FormControl-spacingWrapper' do
+ page.all('.FormControl-spacingWrapper')
+ end
+ end
+
+ def within_custom_field_input_container(custom_field, &)
+ # wrapping in `within_async_content` to make sure the container is properly loaded
+ within_async_content do
+ within("[data-qa-selector='project-custom-field-input-container-#{custom_field.id}']", &)
+ end
+ end
+ end
+ end
+ end
+end
diff --git a/spec/support/form_fields/primerized/autocomplete_field.rb b/spec/support/form_fields/primerized/autocomplete_field.rb
new file mode 100644
index 000000000000..8e4b0bf37e01
--- /dev/null
+++ b/spec/support/form_fields/primerized/autocomplete_field.rb
@@ -0,0 +1,77 @@
+require_relative 'form_field'
+
+module FormFields
+ module Primerized
+ class AutocompleteField < FormField
+ ### actions
+
+ def select_option(*values)
+ values.each do |val|
+ field_container.find('.ng-select-container').click
+ expect(page).to have_css('.ng-option', text: val, visible: :all)
+ page.find('.ng-option', text: val, visible: :all).click
+ sleep 0.25 # still required?
+ end
+ end
+
+ def deselect_option(*values)
+ values.each do |val|
+ field_container.find('.ng-select-container').click
+ page.find('.ng-value', text: val, visible: :all).find('.ng-value-icon').click
+ sleep 0.25 # still required?
+ end
+ field_container.find('.ng-arrow-wrapper').click # close dropdown
+ sleep 0.25
+ end
+
+ def search(text)
+ field_container.find('.ng-select-container input').set text
+ end
+
+ def open_options
+ field_container.find('.ng-select-container').click
+ end
+
+ def clear
+ field_container.find('.ng-clear-wrapper', visible: :all).click
+ end
+
+ ### expectations
+
+ def expect_selected(*values)
+ values.each do |val|
+ expect(field_container).to have_css('.ng-value', text: val)
+ end
+ end
+
+ def expect_not_selected(*values)
+ values.each do |val|
+ expect(field_container).to have_no_css('.ng-value', text: val, wait: 1)
+ end
+ end
+
+ def expect_blank
+ expect(field_container).to have_css('.ng-value', count: 0)
+ end
+
+ def expect_no_option(option)
+ expect(page)
+ .to have_no_css('.ng-option', text: option, visible: :all, wait: 1)
+ end
+
+ def expect_option(option)
+ expect(page)
+ .to have_css('.ng-option', text: option, visible: :visible)
+ end
+
+ def expect_visible
+ expect(field_container).to have_css('ng-select')
+ end
+
+ def expect_error(string = nil)
+ expect(field_container).to have_css('.FormControl-inlineValidation')
+ expect(field_container).to have_content(string) if string
+ end
+ end
+ end
+end
diff --git a/spec/support/form_fields/primerized/editor_form_field.rb b/spec/support/form_fields/primerized/editor_form_field.rb
new file mode 100644
index 000000000000..6f6b59705642
--- /dev/null
+++ b/spec/support/form_fields/primerized/editor_form_field.rb
@@ -0,0 +1,45 @@
+require_relative 'form_field'
+
+module FormFields
+ module Primerized
+ class EditorFormField < FormField
+ attr_reader :editor
+
+ delegate :expect_value, to: :editor
+
+ def initialize(property, selector: nil)
+ super
+
+ @editor = ::Components::WysiwygEditor.new(selector)
+ end
+
+ def field_container
+ augmented_textarea = page.find("[data-textarea-selector='\"#project_custom_field_values_#{property.id}\"']")
+ augmented_textarea.first(:xpath, ".//..")
+ end
+
+ ##
+ # Set or select the given value.
+ # For fields of type select, will check for an option with that value.
+ def set_value(content)
+ editor.set_markdown(content)
+ end
+
+ def input_element
+ editor.editor_element
+ end
+
+ # expectations
+
+ def expect_visible
+ !!editor.container
+ end
+
+ def expect_error(string = nil)
+ sleep 2 # quick fix for stale element error
+ expect(field_container).to have_css('.FormControl-inlineValidation')
+ expect(field_container).to have_content(string) if string
+ end
+ end
+ end
+end
diff --git a/spec/support/form_fields/primerized/form_field.rb b/spec/support/form_fields/primerized/form_field.rb
new file mode 100644
index 000000000000..a97c67b7aefe
--- /dev/null
+++ b/spec/support/form_fields/primerized/form_field.rb
@@ -0,0 +1,13 @@
+module FormFields
+ module Primerized
+ class FormField < FormFields::FormField
+ def property_name
+ if property.is_a? CustomField
+ property.attribute_name(:kebab_case)
+ else
+ property.to_s
+ end
+ end
+ end
+ end
+end
diff --git a/spec/support/form_fields/primerized/input_field.rb b/spec/support/form_fields/primerized/input_field.rb
new file mode 100644
index 000000000000..6b7d87db7dab
--- /dev/null
+++ b/spec/support/form_fields/primerized/input_field.rb
@@ -0,0 +1,33 @@
+require_relative 'form_field'
+
+module FormFields
+ module Primerized
+ class InputField < FormField
+ delegate :fill_in, :check, :uncheck, to: :input_element
+
+ def field_container
+ page.find(selector).first(:xpath, ".//..").first(:xpath, ".//..")
+ end
+
+ def input_element
+ field_container
+ end
+
+ def send_keys(*)
+ input_element.send_keys(*)
+ end
+
+ # expectations
+
+ def expect_error(string = nil)
+ expect(page).to have_css("#{selector}[invalid='true']")
+ expect(field_container).to have_content(string) if string
+ end
+
+ def expect_value(value)
+ scroll_to_element(field_container)
+ expect(field_container).to have_css('input') { |el| el.value == value }
+ end
+ end
+ end
+end
diff --git a/spec/support/pages/projects/show.rb b/spec/support/pages/projects/show.rb
index 8d685e8c514f..5ad63c542823 100644
--- a/spec/support/pages/projects/show.rb
+++ b/spec/support/pages/projects/show.rb
@@ -50,6 +50,36 @@ def within_sidebar(&)
def toast_type
:rails
end
+
+ def visit_page
+ visit path
+ end
+
+ def within_async_loaded_sidebar(&)
+ within '#project-custom-fields-sidebar' do
+ expect(page).to have_css("[data-qa-selector='project-custom-fields-sidebar-async-content']")
+ yield
+ end
+ end
+
+ def within_custom_field_section_container(section, &)
+ within("[data-qa-selector='project-custom-field-section-#{section.id}']", &)
+ end
+
+ def within_custom_field_container(custom_field, &)
+ within("[data-qa-selector='project-custom-field-#{custom_field.id}']", &)
+ end
+
+ def open_edit_dialog_for_section(section)
+ within_async_loaded_sidebar do
+ scroll_to_element(page.find("[data-qa-selector='project-custom-field-section-#{section.id}']"))
+ within_custom_field_section_container(section) do
+ page.find("[data-qa-selector='project-custom-field-section-edit-button']").click
+ end
+ end
+
+ expect(page).to have_css("[data-qa-selector='async-dialog-content']", wait: 5)
+ end
end
end
end
diff --git a/spec/support/shared/with_good_job.rb b/spec/support/shared/with_good_job.rb
index 1cdf84367ae7..3d72211e3033 100644
--- a/spec/support/shared/with_good_job.rb
+++ b/spec/support/shared/with_good_job.rb
@@ -43,7 +43,6 @@
classes.each(&:disable_test_adapter)
ActiveJob::Base.queue_adapter = good_job_adapter
example.run
-
ensure
ActiveJob::Base.queue_adapter = original_adapter
classes.each { |cls| cls.enable_test_adapter(original_adapter) }
diff --git a/spec/support/shared/with_test_ldap.rb b/spec/support/shared/with_test_ldap.rb
index caa9b02e2314..bc0916e9a2fe 100644
--- a/spec/support/shared/with_test_ldap.rb
+++ b/spec/support/shared/with_test_ldap.rb
@@ -25,22 +25,20 @@
#
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'ladle'
+require "ladle"
-RSpec.shared_context 'with temporary LDAP' do
- # rubocop:disable RSpec/InstanceVariable
+RSpec.shared_context "with temporary LDAP" do
before(:all) do
- ldif = Rails.root.join('spec/fixtures/ldap/users.ldif')
+ ldif = Rails.root.join("spec/fixtures/ldap/users.ldif")
@ldap_server = Ladle::Server.new(quiet: false,
port: ParallelHelper.port_for_ldap.to_s,
- domain: 'dc=example,dc=com',
+ domain: "dc=example,dc=com",
ldif:).start
end
after(:all) do
@ldap_server.stop
end
- # rubocop:enable RSpec/InstanceVariable
# Ldap has:
# three users aa729, bb459, cc414
@@ -48,12 +46,12 @@
let!(:ldap_auth_source) do
create(:ldap_auth_source,
port: ParallelHelper.port_for_ldap.to_s,
- account: 'uid=admin,ou=system',
- account_password: 'secret',
- base_dn: 'ou=people,dc=example,dc=com',
+ account: "uid=admin,ou=system",
+ account_password: "secret",
+ base_dn: "ou=people,dc=example,dc=com",
onthefly_register:,
filter_string: ldap_filter,
- attr_login: 'uid',
+ attr_login: "uid",
attr_firstname:,
attr_lastname:,
attr_mail:,
@@ -62,8 +60,8 @@
let(:onthefly_register) { false }
let(:ldap_filter) { nil }
- let(:attr_firstname) { 'givenName' }
- let(:attr_lastname) { 'sn' }
- let(:attr_mail) { 'mail' }
- let(:attr_admin) { 'isAdmin' }
+ let(:attr_firstname) { "givenName" }
+ let(:attr_lastname) { "sn" }
+ let(:attr_mail) { "mail" }
+ let(:attr_admin) { "isAdmin" }
end