From f832395a1fd8976705115eb268518b688f8f6720 Mon Sep 17 00:00:00 2001 From: Henriette Darge Date: Fri, 29 Nov 2024 08:08:59 +0100 Subject: [PATCH] Correct form definition to ensure enough space between the elements --- .../new_custom_field_projects_form_modal_component.html.erb | 2 +- .../projects/custom_fields/custom_field_mapping_form.rb | 6 ++---- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/app/components/admin/custom_fields/custom_field_projects/new_custom_field_projects_form_modal_component.html.erb b/app/components/admin/custom_fields/custom_field_projects/new_custom_field_projects_form_modal_component.html.erb index a7596230ea1c..3950d4e83b5b 100644 --- a/app/components/admin/custom_fields/custom_field_projects/new_custom_field_projects_form_modal_component.html.erb +++ b/app/components/admin/custom_fields/custom_field_projects/new_custom_field_projects_form_modal_component.html.erb @@ -37,7 +37,7 @@ See COPYRIGHT and LICENSE files for more details. ) do |form| concat(render(Primer::Alpha::Dialog::Body.new( id: dialog_body_id, test_selector: dialog_body_id, aria: { label: title }, - style: "min-height: 300px" + classes: "Overlay-body_autocomplete_height" )) do render(Projects::CustomFields::CustomFieldMappingForm.new(form, project_mapping: @custom_field_project_mapping)) end) diff --git a/app/forms/projects/custom_fields/custom_field_mapping_form.rb b/app/forms/projects/custom_fields/custom_field_mapping_form.rb index f637ea059934..1a3f71f3dbe6 100644 --- a/app/forms/projects/custom_fields/custom_field_mapping_form.rb +++ b/app/forms/projects/custom_fields/custom_field_mapping_form.rb @@ -31,8 +31,7 @@ class CustomFieldMappingForm < ApplicationForm include OpPrimer::ComponentHelpers form do |form| - form.group(layout: :vertical) do |group| - group.project_autocompleter( + form.project_autocompleter( name: :id, label: Project.model_name.human, visually_hide_label: true, @@ -48,13 +47,12 @@ class CustomFieldMappingForm < ApplicationForm } ) - group.check_box( + form.check_box( name: :include_sub_projects, label: I18n.t(:label_include_sub_projects), checked: false, label_arguments: { class: "no-wrap" } ) - end end def initialize(project_mapping:)