Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify hostname check to not fail on over 26 chars. #140

Open
wants to merge 1 commit into
base: 1.x
Choose a base branch
from

Conversation

swirtSJW
Copy link

The current regex pattern causes an incorrect identification of invalid hostnames as anything longer than 26 characters which is not correct. Handling of this is shifted from regex to a core php function to validate hostnames.

The current regex pattern causes an incorrect identification of invalid hostnames as anything longer than 26 characters which is not correct.
Handling of this is shifted from regex to a core php function to validate hostnames.
@swirtSJW
Copy link
Author

Test cases
// good 62
Passes "s3://pdc-111112222233333444445555566666-s3-dfc-data-extra-long-name/DFC_FACILITY.csv";

//good 63
Passes "s3://pdc-1111122222333334444455555666667-s3-dfc-data-extra-long-name/DFC_FACILITY.csv";

// bad 64
Invalid "s3://pdc-11111222223333344444555556666677-s3-dfc-data-extra-long-name/DFC_FACILITY.csv";

// bad 65
Invalid "s3://pdc-111112222233333444445555566666777-s3-dfc-data-extra-long-name/DFC_FACILITY.csv";

//bad 99
Invalid"s3://pdc-11111222223333344444555556666677777888889999900000abcdefcgijklmnopq-s3-dfc-data-extra-long-name/DFC_FACILITY.csv";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant