From 9eb17fd37fcc3874b7a2241a3216ade82bec51f8 Mon Sep 17 00:00:00 2001 From: Bilal ABBAD Date: Fri, 14 Feb 2025 15:23:03 +0100 Subject: [PATCH] Updated Infrahub global layout (#5749) --- changelog/+new-layout.added.md | 2 + frontend/app/package-lock.json | 10 ++++ frontend/app/package.json | 1 + frontend/app/src/assets/infrahub-logo.svg | 2 +- .../app/src/entities/diff/ui/diff-empty.tsx | 2 +- frontend/app/src/entities/events/ui/event.tsx | 2 +- .../src/entities/events/ui/global-events.tsx | 2 +- .../objects-table/objects-table-manager.tsx | 2 +- .../object/ui/objects-table/objects-table.tsx | 4 +- .../app/src/entities/tasks/ui/task-status.tsx | 2 +- frontend/app/src/pages/graphql/index.tsx | 1 + frontend/app/src/pages/objects/layout.tsx | 2 +- .../app/src/pages/objects/object-details.tsx | 7 +-- .../src/pages/proposed-changes/details.tsx | 2 +- .../app/src/pages/resource-manager/index.tsx | 2 +- .../resource-pool-details.tsx | 2 +- frontend/app/src/pages/schema.tsx | 2 +- .../src/shared/components/account-menu.tsx | 17 +++--- .../src/shared/components/layout/content.tsx | 2 +- .../src/shared/components/layout/header.tsx | 9 +-- .../src/shared/components/layout/layout.tsx | 12 ++-- .../components/menu-section-object.tsx | 3 +- .../menu-navigation/menu-navigation.tsx | 2 +- .../src/shared/components/layout/sidebar.tsx | 56 ++++++++++++++----- .../src/shared/components/time-selector.tsx | 1 + 25 files changed, 89 insertions(+), 60 deletions(-) create mode 100644 changelog/+new-layout.added.md diff --git a/changelog/+new-layout.added.md b/changelog/+new-layout.added.md new file mode 100644 index 0000000000..287cc4c09b --- /dev/null +++ b/changelog/+new-layout.added.md @@ -0,0 +1,2 @@ +- Improved Infrahub app layout for a cleaner look. +- Made the top menu more compact. diff --git a/frontend/app/package-lock.json b/frontend/app/package-lock.json index 5794562bdf..b6d3984777 100644 --- a/frontend/app/package-lock.json +++ b/frontend/app/package-lock.json @@ -47,6 +47,7 @@ "handlebars": "^4.7.8", "jotai": "^2.11.3", "json-to-graphql-query": "^2.2.5", + "lucide-react": "^0.475.0", "openapi-fetch": "^0.13.4", "prismjs": "^1.29.0", "query-string": "^9.0.0", @@ -12249,6 +12250,15 @@ "yallist": "^3.0.2" } }, + "node_modules/lucide-react": { + "version": "0.475.0", + "resolved": "https://registry.npmjs.org/lucide-react/-/lucide-react-0.475.0.tgz", + "integrity": "sha512-NJzvVu1HwFVeZ+Gwq2q00KygM1aBhy/ZrhY9FsAgJtpB+E4R7uxRk9M2iKvHa6/vNxZydIB59htha4c2vvwvVg==", + "license": "ISC", + "peerDependencies": { + "react": "^16.5.1 || ^17.0.0 || ^18.0.0 || ^19.0.0" + } + }, "node_modules/lz-string": { "version": "1.5.0", "resolved": "https://registry.npmjs.org/lz-string/-/lz-string-1.5.0.tgz", diff --git a/frontend/app/package.json b/frontend/app/package.json index 5579425d6e..cec98654c0 100644 --- a/frontend/app/package.json +++ b/frontend/app/package.json @@ -68,6 +68,7 @@ "handlebars": "^4.7.8", "jotai": "^2.11.3", "json-to-graphql-query": "^2.2.5", + "lucide-react": "^0.475.0", "openapi-fetch": "^0.13.4", "prismjs": "^1.29.0", "query-string": "^9.0.0", diff --git a/frontend/app/src/assets/infrahub-logo.svg b/frontend/app/src/assets/infrahub-logo.svg index f5486c1ccd..322c793613 100644 --- a/frontend/app/src/assets/infrahub-logo.svg +++ b/frontend/app/src/assets/infrahub-logo.svg @@ -1,4 +1,4 @@ - + diff --git a/frontend/app/src/entities/diff/ui/diff-empty.tsx b/frontend/app/src/entities/diff/ui/diff-empty.tsx index 0049959a61..33c771522f 100644 --- a/frontend/app/src/entities/diff/ui/diff-empty.tsx +++ b/frontend/app/src/entities/diff/ui/diff-empty.tsx @@ -10,7 +10,7 @@ export interface DiffEmptyProps { export function DiffEmpty({ branchName, lastRefreshedAt }: DiffEmptyProps) { return ( -
+
diff --git a/frontend/app/src/entities/events/ui/event.tsx b/frontend/app/src/entities/events/ui/event.tsx index a2520d2442..bbed2087fa 100644 --- a/frontend/app/src/entities/events/ui/event.tsx +++ b/frontend/app/src/entities/events/ui/event.tsx @@ -55,7 +55,7 @@ export const Event = ({ __typename, ...props }: EventType) => {
-
+
{__typename === NODE_MUTATED_EVENT && } diff --git a/frontend/app/src/entities/events/ui/global-events.tsx b/frontend/app/src/entities/events/ui/global-events.tsx index ea8747c51f..4dc630de5f 100644 --- a/frontend/app/src/entities/events/ui/global-events.tsx +++ b/frontend/app/src/entities/events/ui/global-events.tsx @@ -23,7 +23,7 @@ export const GlobalEvents = () => { }); return ( -
+
{activities?.map((activity) => ( ))} diff --git a/frontend/app/src/entities/nodes/object/ui/objects-table/objects-table-manager.tsx b/frontend/app/src/entities/nodes/object/ui/objects-table/objects-table-manager.tsx index 792dff05b9..f3925ba088 100644 --- a/frontend/app/src/entities/nodes/object/ui/objects-table/objects-table-manager.tsx +++ b/frontend/app/src/entities/nodes/object/ui/objects-table/objects-table-manager.tsx @@ -31,7 +31,7 @@ export function ObjectsTableManager({ schema }: ObjectsTableManagerProps) { return ( <> -
+
{filters.length > 0 && ( diff --git a/frontend/app/src/entities/nodes/object/ui/objects-table/objects-table.tsx b/frontend/app/src/entities/nodes/object/ui/objects-table/objects-table.tsx index 4790410bda..86a5ec75f9 100644 --- a/frontend/app/src/entities/nodes/object/ui/objects-table/objects-table.tsx +++ b/frontend/app/src/entities/nodes/object/ui/objects-table/objects-table.tsx @@ -59,7 +59,7 @@ export const ObjectsTable = ({ return (
fetchMoreOnBottomReached(e.currentTarget)} ref={tableContainerRef} style={{ @@ -89,7 +89,7 @@ export const ObjectsTable = ({ {(isPending || isFetchingNextPage) && ( <> - {[...Array(15)].map((_, rowIndex) => ( + {[...Array(20)].map((_, rowIndex) => ( {[...Array(allHeaders.length)].map((_, colIndex) => ( { return ( { } return ( - + diff --git a/frontend/app/src/pages/objects/object-details.tsx b/frontend/app/src/pages/objects/object-details.tsx index 5b34a77709..d2791475f2 100644 --- a/frontend/app/src/pages/objects/object-details.tsx +++ b/frontend/app/src/pages/objects/object-details.tsx @@ -1,5 +1,4 @@ -import { ARTIFACT_OBJECT, GRAPHQL_QUERY_OBJECT, TASK_OBJECT } from "@/config/constants"; -import ArtifactsDetails from "@/entities/artifacts/ui/artifact-details"; +import { GRAPHQL_QUERY_OBJECT, TASK_OBJECT } from "@/config/constants"; import { useObjectDetails } from "@/entities/nodes/hooks/useObjectDetails"; import ObjectItemDetails from "@/entities/nodes/object-item-details/object-item-details-paginated"; import { genericsState, profilesAtom, schemaState } from "@/entities/schema/stores/schema.atom"; @@ -71,10 +70,6 @@ export const Component = () => { return ; } - if (objectKind === ARTIFACT_OBJECT) { - return ; - } - if (objectKind === GRAPHQL_QUERY_OBJECT) { return ; } diff --git a/frontend/app/src/pages/proposed-changes/details.tsx b/frontend/app/src/pages/proposed-changes/details.tsx index aab6238dc2..750c56ef18 100644 --- a/frontend/app/src/pages/proposed-changes/details.tsx +++ b/frontend/app/src/pages/proposed-changes/details.tsx @@ -178,7 +178,7 @@ export function Component() { } return ( - + { if (!resourcePoolSchema) return ; return ( - + diff --git a/frontend/app/src/pages/resource-manager/resource-pool-details.tsx b/frontend/app/src/pages/resource-manager/resource-pool-details.tsx index a60d88e149..b809ff9361 100644 --- a/frontend/app/src/pages/resource-manager/resource-pool-details.tsx +++ b/frontend/app/src/pages/resource-manager/resource-pool-details.tsx @@ -138,7 +138,7 @@ const ResourcePoolContent = ({ id, schema }: ResourcePoolContentProps) => { } /> -
+