Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Documentation: datafile initialization references wrong window object #222

Closed
1 task done
jcshott opened this issue Nov 3, 2023 · 2 comments
Closed
1 task done
Assignees
Labels
acknowledged bug Something isn't working needs-triage

Comments

@jcshott
Copy link

jcshott commented Nov 3, 2023

Is there an existing issue for this?

  • I have searched the existing issues

SDK Version

current

Current Behavior

The README references initializing the client with a datafile with window.datafile but the docs use the (correct) reference of window.optimizelyDatafile which is what the tags.js file loads the window object in.

https://docs.developers.optimizely.com/feature-experimentation/docs/initialize-sdk-react#instantiate-using-datafile

These should be consistent as users may not know/notice the difference.

Expected Behavior

README should use window.optimizelyDatafile

Steps To Reproduce

see README

React Framework

No response

Browsers impacted

No response

Link

No response

Logs

No response

Severity

No response

Workaround/Solution

No response

Recent Change

No response

Conflicts

No response

@jcshott jcshott added bug Something isn't working needs-triage labels Nov 3, 2023
@mikechu-optimizely
Copy link
Contributor

mikechu-optimizely commented Nov 3, 2023

Thanks @jcshott I've created an internal ticket for this (FSSDK-9745)

@farhan-opti farhan-opti self-assigned this Nov 3, 2023
@farhan-opti
Copy link
Contributor

Hi @jcshott The issue has been resolved in #224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledged bug Something isn't working needs-triage
Projects
None yet
Development

No branches or pull requests

3 participants