Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter user input switch signals #20

Open
unpaid-bill opened this issue May 10, 2023 · 1 comment
Open

Filter user input switch signals #20

unpaid-bill opened this issue May 10, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@unpaid-bill
Copy link

Version Number

1.0.1

Bugfix or Enhancement

Enhancement

Description

The user input switches could use some filtering between the physical switch and the micro. This filters the high frequency content from the switch event from reaching the micro, and debounces the signal.
The schematic symbol for the switches should also be updated to be an actual switch symbol. Right now it is a generic connector.
image

Suggested Solution

An RC filter on each switch signal is pretty easy to add. A simple 100R/100nF would probably do just fine.

@unpaid-bill unpaid-bill added the triage for issues that need a first response and tagging label May 10, 2023
@sphawes
Copy link
Member

sphawes commented May 12, 2023

Thanks for the note @unpaid-bill! I agree, would be good to add this. I believe we're doing some software debouncing in Photon that would be nice to remove. We're very tight on available board space, so ill try to squeeze these in after other board edits are made for this rev. And agreed, a proper symbol should be used for the buttons!

@sphawes sphawes added enhancement New feature or request and removed triage for issues that need a first response and tagging labels May 12, 2023
@sphawes sphawes self-assigned this May 12, 2023
@sphawes sphawes added this to the REV12 Feeder Motherboard milestone May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants