Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OCI Artifact Support #21

Open
Tracked by #24
akashsinghal opened this issue Sep 6, 2022 · 1 comment
Open
Tracked by #24

Add OCI Artifact Support #21

akashsinghal opened this issue Sep 6, 2022 · 1 comment

Comments

@akashsinghal
Copy link

akashsinghal commented Sep 6, 2022 •
edited
Loading

https://github.com/opencontainers/distribution-spec/blob/main/spec.md#listing-referrers

  • Add OCI Artifact manifest type
  • Add OCI Artifact manifest handlers
  • Register v2/<repository>/referrers route
  • Add filtering/paging support based on artifact type and page size

Open questions:

  • do we move the ORAS artifact extended storage functionality into the main storage package?
  • do we implement a separate storage interface for OCI Artifact referrers than the ORAS extension storage implementation?
@akashsinghal akashsinghal mentioned this issue Sep 6, 2022
Open
4 tasks
@wangxiaoxuan273 wangxiaoxuan273 mentioned this issue Oct 17, 2022
Closed
@wangxiaoxuan273
Copy link

wangxiaoxuan273 commented Oct 19, 2022 •
edited
Loading

As I try to implement this feature, I've found the work to greatly exceed the scope of one pull request. Therefore I would like to split this task into multiple, manageable smaller pull requests as follows:

@wangxiaoxuan273 wangxiaoxuan273 mentioned this issue Oct 19, 2022
Merged
shizhMSFT pushed a commit that referenced this issue Oct 19, 2022
@wangxiaoxuan273
feat: add OCI artifact manifest type by updating oci spec (#27)
f71877f 
Add OCI artifact manifest type by updating
`github.com/opencontainers/image-spec` module to `v1.1.0-rc2`. Changes
are made by running `go mod tidy` and `go mod vendor`.

Part 1 of Issue #21 

Signed-off-by: wangxiaoxuan273 <[email protected]>
This was referenced Oct 19, 2022
Closed
Merged
Merged
Merged
shizhMSFT pushed a commit that referenced this issue Oct 27, 2022
@wangxiaoxuan273
feat!: implement artifact manifest type (#29)
0fce2c9 
Implemented ArtifactManifest and related structs and functions. Unit
tests included.

Part 2 of #21 

Signed-off-by: wangxiaoxuan273 <[email protected]>
@wangxiaoxuan273 wangxiaoxuan273 mentioned this issue Oct 31, 2022
Merged
shizhMSFT pushed a commit that referenced this issue Nov 3, 2022
@wangxiaoxuan273
feat!: implement artifact manifest handler in the storage package (#30)
d03813c 
Implemented artifact manifest handler related changes for the storage
package, unit tests included.

Part 3 of #21 

Signed-off-by: wangxiaoxuan273 <[email protected]>
shizhMSFT pushed a commit that referenced this issue Nov 4, 2022
@wangxiaoxuan273
feat!: implement artifact manifest handler in the handler package (#31)
0e64ff7 
Part 4 of #21.

Implemented necessary changes in the handler package.

Signed-off-by: wangxiaoxuan273 <[email protected]>
shizhMSFT pushed a commit that referenced this issue Nov 4, 2022
@wangxiaoxuan273
feat!: implement the referrers route in the v2 package (#32)
6f0e3ea 
Implement the `referrers` route in the `registry/api/v2` package. Path
with filtering on `ArtifactType` is also implemented. Unit tests are
included. The next pr will implement `referrersHandler` but probably
will not implement filtering yet.

Part 5 of #21 

Signed-off-by: wangxiaoxuan273 <[email protected]>
This was referenced Nov 10, 2022
Merged
Merged
This was referenced Nov 23, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akashsinghal @wangxiaoxuan273