Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support --platform in oras push and oras attach #1066

Closed
1 task
qweeah opened this issue Aug 18, 2023 · 9 comments · Fixed by #1500
Closed
1 task

support --platform in oras push and oras attach #1066

qweeah opened this issue Aug 18, 2023 · 9 comments · Fixed by #1500
Assignees
Labels
enhancement New feature or request multi-arch spec required Issues that require specifications
Milestone

Comments

@qweeah
Copy link
Contributor

qweeah commented Aug 18, 2023

What is the version of your ORAS CLI

oras v1.1.0-rc.1

What would you like to be added?

Add a new flag --platform(flag name TBD) to allow baking platform information into config data like

oras push localhost:5000/oras:v1.0.1 --artifact-type "application/vnd.example+type" --platform linux/amd64 oras--1.0.1.arm64_monterey.bottle.tar.gz
oras attach localhost:5000/oras:v1.0.1 --artifact-type "application/vnd.sbom" --platform linux/amd64 oras--1.0.1.arm64_monterey.bottle.tar.gz

The specified platform information will be stored in the config blob like https://oras.land/docs/concepts/artifact#artifacts-with-config

Why is this needed for ORAS?

User can easily build artifact with platform information without composing config blob on their own.

Are you willing to submit PRs to contribute to this feature?

  • Yes, I am willing to implement it.
@amands98
Copy link
Contributor

Should I include support for a platform flag ? // @qweeah

@qweeah
Copy link
Contributor Author

qweeah commented Jan 19, 2024

@amands98 Thanks for volunteering! Please make sure the baked config is following https://github.com/opencontainers/image-spec/blob/main/config.md#properties

@yizha1 yizha1 modified the milestones: future, v1.3.0 Mar 4, 2024
@shizhMSFT
Copy link
Contributor

shizhMSFT commented Mar 14, 2024

What's the media type of the config? Is it artifact-type or the standard config type? How is it supported by multiple cloud providers?

@qweeah
Copy link
Contributor Author

qweeah commented Oct 17, 2024

Still need to apply this to oras attach

@TerryHowe
Copy link
Member

oras atach has a platform option although I haven't tried it

@Wwwsylvia
Copy link
Member

Still need to apply this to oras attach

Do you mean we can add a --artifact-platform flag to the manifest of the config referrers, just like we do for oras push?

oras atach has a platform option although I haven't tried it

That is to control which arch-specific manifest to attach on.


But what are the use cases of adding platform to a referrer?🤔

@FeynmanZhou
Copy link
Member

Still need to apply this to oras attach

Since we lack of the scenario for oras attach, we will keep it in ORAS future milestone.

@TerryHowe
Copy link
Member

I think a new issue for attach would make it easier

@Wwwsylvia
Copy link
Member

I just opened a new issue for oras attach: #1537
I think we are good to close this one.

@qweeah qweeah closed this as completed Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request multi-arch spec required Issues that require specifications
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants