Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reference details to output errors #1156

Closed
1 task done
qweeah opened this issue Oct 31, 2023 · 2 comments · Fixed by #1176
Closed
1 task done

add reference details to output errors #1156

qweeah opened this issue Oct 31, 2023 · 2 comments · Fixed by #1176
Labels
enhancement New feature or request
Milestone

Comments

@qweeah
Copy link
Contributor

qweeah commented Oct 31, 2023

What is the version of your ORAS CLI

oras 1.1.0

What would you like to be added?

Some oras commands like oras copy, oras discover and oras attach require user to specify a tag or digest. If not provided, oras would output error information like:

invalid image reference, expecting name:tag|name@digest

oras should output more specific error info like:

no tag or digest when expecting name:tag|name@digest

Why is this needed for ORAS?

It would make error message more friendly to newbie users who are not familiar with concepts like image reference.

Are you willing to submit PRs to contribute to this feature?

  • Yes, I am willing to implement it.
@qweeah qweeah added the enhancement New feature or request label Oct 31, 2023
@qweeah qweeah added this to the v1.2.0 milestone Oct 31, 2023
@qweeah
Copy link
Contributor Author

qweeah commented Oct 31, 2023

#1152 solves this for remote registry targets, extra work need to be done for OCI layout targets.

@FeynmanZhou
Copy link
Member

Could you change the issue title to add reference details to error messages for OCI layout and registry? I think the major intention of this issue is to improve the error messages for OCI layout as well as some cases that across two targets.

@qweeah qweeah changed the title add reference details to registry errors add reference details to output errors Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants