[Fix] Lazy DI tokens #7

gund · 2019-03-23T19:58:42Z

Allow to provide sub menu component maps from lazy loaded modules

Closes #6

So menu resolution is not lagging

codecov-io · 2019-03-23T20:03:37Z

Codecov Report

❗ No coverage uploaded for pull request base (master@c0819ee). Click here to learn what that means.
The diff coverage is 79.68%.

@@            Coverage Diff            @@
##             master       #7   +/-   ##
=========================================
  Coverage          ?   88.59%           
=========================================
  Files             ?       17           
  Lines             ?      298           
  Branches          ?       36           
=========================================
  Hits              ?      264           
  Misses            ?       23           
  Partials          ?       11

Impacted Files	Coverage Δ
...ult-dynamic-menu/default-dynamic-menu.component.ts	`100% <ø> (ø)`
.../dynamic-menu/src/lib/dynamic-menu/context-item.ts	`100% <ø> (ø)`
...ojects/dynamic-menu/src/lib/dynamic-menu.module.ts	`100% <ø> (ø)`
...namic-menu/src/lib/dynamic-menu/context-wrapper.ts	`100% <ø> (ø)`
...c-menu/src/lib/dynamic-menu/dynamic-menu.module.ts	`100% <ø> (ø)`
...mic-menu-wrapper/dynamic-menu-wrapper.directive.ts	`100% <ø> (ø)`
...u/dynamic-menu-item/dynamic-menu-item.directive.ts	`100% <ø> (ø)`
...ojects/dynamic-menu/src/lib/dynamic-menu-routes.ts	`100% <ø> (ø)`
...namic-menu-toggle/dynamic-menu-toggle.directive.ts	`100% <ø> (ø)`
...ojects/dynamic-menu/src/lib/dynamic-menu-extras.ts	`83.33% <0%> (ø)`
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0819ee...f358d4d. Read the comment docs.

So they are rerendered when context is updated

So menu resolution is not lagging

re #6

…nu into fix-lazy-di

gund added 5 commits March 23, 2019 01:42

chore(package): update lock file

5928691

fix(menu): allow sub menu map to provide lazily

b404d6b

chore(prettier): add RC file

c3b2805

style(app): reformat source code

f072f8a

fix(menu): resolve sub menu map if not provided

f358d4d

So menu resolution is not lagging

Alex Malkevich and others added 16 commits March 28, 2019 12:55

fix(menu): detech changes in items component

9fb523d

So they are rerendered when context is updated

docs(changelog): add changes of 1.5.6 [skip ci]

094b6fc

fix(menu): do not skip children if not generated in prev step

f908039

docs(changelog): add changes of 1.5.7 [skip ci]

17611b2

chore(package): update lock file

e98303e

fix(menu): allow sub menu map to provide lazily

8eb2c77

chore(prettier): add RC file

2b50eea

style(app): reformat source code

16d8a98

fix(menu): resolve sub menu map if not provided

42bc135

So menu resolution is not lagging

feat(menu): allow to lazy-load sub header components mapping

cccb291

re #6

chore(vscode): update window colors scheme

9a89a7e

chore(prettier): enable trailing comma for formatting source code

2e2b114

Merge branch 'fix-lazy-di' of github.com:orchestratora/ngx-dynamic-me…

d2c8c8f

…nu into fix-lazy-di

chore(package): update format

a8883d2

chore(package): fix 8 vulnerabilities from 3rd libs

40a1e2b

docs(demo): adjust when to show submenu comp for feature1

40bb264

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fix] Lazy DI tokens #7

[Fix] Lazy DI tokens #7

gund commented Mar 23, 2019

codecov-io commented Mar 23, 2019

[Fix] Lazy DI tokens #7

Are you sure you want to change the base?

[Fix] Lazy DI tokens #7

Conversation

gund commented Mar 23, 2019

codecov-io commented Mar 23, 2019

Codecov Report