Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement redirect to login on session expiration #289

Open
ArchitectedDev opened this issue Nov 13, 2021 · 1 comment
Open

Implement redirect to login on session expiration #289

ArchitectedDev opened this issue Nov 13, 2021 · 1 comment

Comments

@ArchitectedDev
Copy link
Contributor

Currently a poor UX when a session expires, multiple notifications will spawn as client-side functionality is not prevented after the first indication of session expiry. Would be good to implement this as a global error handler, however with a brief look into this it appears the javascript SDK may be preventing the buyer/seller apps from regaining control over thrown exceptions. Will need to evaluate further.

@crhistianramirez
Copy link
Collaborator

Yep this would be good. At one point we were using the Angular SDK and it was working via this refresh token interceptor which would log the user out if it was unable to refresh the token. At some point however we started using the Javascript SDK for which angular interceptors of course did not work.

I think we can implement a similar pattern with the Javascript SDK as it has its own notion of interceptors via axios (underlying http library).

One thing I'd really like to do is clean up all remaining uses of the angular sdk and replace it with the javascript sdk so that we can drop the angular sdk completely. Right now some parts of the app use the javascript sdk and others the angular, it is not ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants