Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precision Problems #291

Open
MahdiBM opened this issue Oct 13, 2024 · 0 comments
Open

Precision Problems #291

MahdiBM opened this issue Oct 13, 2024 · 0 comments

Comments

@MahdiBM
Copy link
Contributor

MahdiBM commented Oct 13, 2024

I've noticed - without taking a look at the code - that the benchmarks round numbers too much, or have a lower precision than i expect.

For example if a threshold tolerance is set to 3%, and the result is 2.8% above the thresholds, the benchmark will fail because it'll round 2.8 to 3%, then fail the benchmark since 3% == 3%.

Or for the faster of the benchmarks, I'd like to have microsecond precision instead of millisecond, so i don't need to use a 6% threshold tolerance just because the benchmark could move a bit and round it up to the next 10-millisecond.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant