Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

static thresholds cannot be found when benchmark name contains spaces #301

Open
MahdiBM opened this issue Jan 10, 2025 · 0 comments
Open

static thresholds cannot be found when benchmark name contains spaces #301

MahdiBM opened this issue Jan 10, 2025 · 0 comments

Comments

@MahdiBM
Copy link
Contributor

MahdiBM commented Jan 10, 2025 

Benchmark(
        "Serializer Allocations",
        configuration: .init(
            metrics: [.mallocCountTotal]
        )
    ) { benchmark in
        _ = try MultipartSerializer(boundary: "boundary123").serialize(parts: [example])
    }

The json file is saved as: Serializer.Serializer_Allocations.p90.json.

When using thresholds check, the command fails to find the thresholds file, probably because of the _ in Serializer_Allocations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MahdiBM