Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slave Container warns when adding a Gateway with new naming pattern #342

Open
notthetup opened this issue Jan 31, 2025 · 0 comments
Open

Slave Container warns when adding a Gateway with new naming pattern #342

notthetup opened this issue Jan 31, 2025 · 0 comments

Comments

@notthetup
Copy link
Collaborator

notthetup commented Jan 31, 2025 •
edited
Loading

When running the tests I am seeing an error about the name of the Gateway.

org.arl.fjage.test.BasicTests > testGateway STANDARD_ERROR
    1738318035943|INFO|org.arl.fjage.test.BasicTests@1:testGateway|testGateway
    1738318035944|INFO|org.arl.fjage.remote.MasterContainer@1:openTcpServer|Listening on port 52540
    1738318035945|INFO|org.arl.fjage.remote.MasterContainer@1:init|Initializing agents...
    1738318035948|INFO|org.arl.fjage.connectors.TcpServer@188:run|Listening on port 52540
    1738318036051|INFO|org.arl.fjage.remote.MasterContainer@1:init|Agents ready...
    1738318036051|INFO|org.arl.fjage.remote.MasterContainer@1:start|Starting container...
    1738318036053|WARNING|org.arl.fjage.remote.SlaveContainer@1:add|Agent name gateway-915416632 does not meet naming guidelines and may be disallowed in future

This is because Container warns if any Agent being added which has a - in the name.

But the Java Gateway conforms to the gateway naming convention and has a - in it's name. So SlaveContainer complains when the gateway agent is added to it.

We need a mechanism to tell the SlaveContainer to not check if the agent is a subclass of the Gateway.
@notthetup notthetup changed the title Update Java Gateway implementation to use Agent name that conforms to the spec. Java Gateway implementation to use Agent name doesn't conform to spec Jan 31, 2025
@notthetup notthetup changed the title Java Gateway implementation to use Agent name doesn't conform to spec New Agent name requirement check causes a warning when a Gateway connects. Jan 31, 2025
@notthetup notthetup changed the title New Agent name requirement check causes a warning when a Gateway connects. Slave Container logs warning when adding Gateway with new naming pattern Jan 31, 2025
@notthetup notthetup changed the title Slave Container logs warning when adding Gateway with new naming pattern Slave Container warns when adding a Gateway with new naming pattern Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@notthetup