Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit composer.json from CMB2 + packagist #34

Open
slaFFik opened this issue Oct 16, 2016 · 3 comments
Open

Inherit composer.json from CMB2 + packagist #34

slaFFik opened this issue Oct 16, 2016 · 3 comments

Comments

@slaFFik
Copy link

slaFFik commented Oct 16, 2016

https://github.com/WebDevStudios/CMB2/blob/trunk/composer.json

This way I will be able to install as a dependency in my own plugin via composer. Currently your composer.json creates separate wp-content directory inside my plugin.

Also, please add your library to packagist.

@pablo-sg-pacheco
Copy link
Member

I already have a composer.json with
type=wordpress-plugin

Do i have to add something else?

I've just added cmb2-grid to packagist.
Could you try it please? Thanks

@slaFFik
Copy link
Author

slaFFik commented Nov 5, 2016

Assuming I have a composer.json file in own plugin dir.

Currently it's not possible to install your lib in own plugin using composer - instead of wp-content/plugins/own-plugin/vendor/origgami/CMB2-grid it will create wp-content/plugins/own-plugin/wp-content/plugins/CMB2-grid. At least it was so some time ago, when I checked.

@pablo-sg-pacheco
Copy link
Member

I thought that using composer, cmb2-grid would be installed on plugins-folder/cmb2-grid. Wouldn't it be enough?

I think that using a custom install like you want, you'd have to setup a custom folder for cmb2-grid using a package or something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants