Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store directory location. #9

Open
objectisliper opened this issue Apr 17, 2020 · 1 comment
Open

Store directory location. #9

objectisliper opened this issue Apr 17, 2020 · 1 comment

Comments

@objectisliper
Copy link

At https://github.com/orizens/ngrx-styleguide/blob/master/docs/store-single-directory.md you say, and repeat it in next rules, that store directory with reducers, selectors, side-effects and e.t.c. must be at core-dir. But, what's about at least lazy loading (that is accepted as best practice)? If I need that states only at this module, i would look for it there, it's intuitively and popular decision, for component and microservices architecture. And why, if i use many of modules in my project, and have many of reducers and states in it, i should transform my core store module into a trash? That's out of sense at my point of view. I agree, that relying on the SRP we must have a single point of truth, but these are not interconnected things. https://ngrx.io/guide/store/reducers - official guide, that say's about right modules architecture. If you mean store-single-directory only within the module, it is worth clarifying.

@orizens
Copy link
Owner

orizens commented Jun 24, 2020

@objectisliper that's a valid point.
feel free to open a pr with an edit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants