Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug in bp2ncd utility #205

Open
khou2020 opened this issue Oct 14, 2019 · 1 comment
Open

Possible bug in bp2ncd utility #205

khou2020 opened this issue Oct 14, 2019 · 1 comment

Comments

@khou2020
Copy link

Hi:

I found some strange code in the bp2ncd utility. In line 407 of np2ncd.c
if (i==var_dims_count) {
I can't find where variable "i" is initialized. Should it be included in the else clause on line 376?

@pnorbert
Copy link
Contributor

You are right, something is illogical there.
I would assume there should be an i = 0; after line 359 because the true branch starting at line 360 does not set i. The false branch does with the for loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants