Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SupportingDocument upload filename issue #47

Closed
DJWalker42 opened this issue Sep 25, 2024 · 0 comments · Fixed by #50
Closed

SupportingDocument upload filename issue #47

DJWalker42 opened this issue Sep 25, 2024 · 0 comments · Fixed by #50
Assignees
Labels
bug Something isn't working

Comments

@DJWalker42
Copy link
Contributor

  • Uploading a SupportingDocument "requires" that you supply a new filename for the upload; this must include the file extension else problems, which isn't obvious.
  • If the filename field is left blank the filename should default to the current name of the file. It doesn't, the filename is left blank, thus resulting in a save failure.

We need logic to deal with user input for the filename; no file extension provided or an extension provided that does not match the file upload.

NOTICE: you won't see this problem from the GUI as the filename for the upload is (perhaps sensibly) set to the name of the uploaded file, including the file extension. If we exposed the option to set the filename in the GUI then we'd need more robust code in the API.

@DJWalker42 DJWalker42 added the bug Something isn't working label Sep 25, 2024
@AllanEngland AllanEngland self-assigned this Sep 26, 2024
@AllanEngland AllanEngland linked a pull request Oct 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants