From 94fc56a2ffb3bdb2bebe62753dcfba6277095d58 Mon Sep 17 00:00:00 2001
From: Dave Lahn <dave@davelahn.com>
Date: Tue, 14 May 2024 16:36:17 +0100
Subject: [PATCH] fix: remove empty check as helpers do not return an empty
 string

---
 helm/charts/keto/templates/deployment.yaml          | 4 ++--
 helm/charts/keto/templates/job-migration.yaml       | 2 +-
 helm/charts/kratos/templates/cleanup-cron-job.yaml  | 2 +-
 helm/charts/kratos/templates/deployment-kratos.yaml | 4 ++--
 helm/charts/kratos/templates/job-migration.yaml     | 2 +-
 helm/charts/kratos/templates/statefulset-mail.yaml  | 2 +-
 6 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/helm/charts/keto/templates/deployment.yaml b/helm/charts/keto/templates/deployment.yaml
index e6cb37400..70299b752 100644
--- a/helm/charts/keto/templates/deployment.yaml
+++ b/helm/charts/keto/templates/deployment.yaml
@@ -92,7 +92,7 @@ spec:
             {{- toYaml . | nindent 12 }}
           {{- end }}
           env:
-            {{- if not (empty ( include "keto.dsn" . )) }}
+            {{- if not ( include "keto.dsn" . ) }}
             - name: DSN
               valueFrom:
                 secretKeyRef:
@@ -179,7 +179,7 @@ spec:
           resources:
             {{- toYaml $resources | nindent 12 }}
           env:
-            {{- if not (empty ( include "keto.dsn" . )) }}
+            {{- if not ( include "keto.dsn" . ) }}
             - name: DSN
               valueFrom:
                 secretKeyRef:
diff --git a/helm/charts/keto/templates/job-migration.yaml b/helm/charts/keto/templates/job-migration.yaml
index 6446e5e70..a29ecf295 100644
--- a/helm/charts/keto/templates/job-migration.yaml
+++ b/helm/charts/keto/templates/job-migration.yaml
@@ -75,7 +75,7 @@ spec:
           {{- toYaml . | nindent 10 }}
         {{- end }}
         env:
-          {{- if not (empty ( include "keto.dsn" . )) }}
+          {{- if not ( include "keto.dsn" . ) }}
           - name: DSN
             valueFrom:
               secretKeyRef:
diff --git a/helm/charts/kratos/templates/cleanup-cron-job.yaml b/helm/charts/kratos/templates/cleanup-cron-job.yaml
index d369f48bc..2f8197d32 100644
--- a/helm/charts/kratos/templates/cleanup-cron-job.yaml
+++ b/helm/charts/kratos/templates/cleanup-cron-job.yaml
@@ -71,7 +71,7 @@ spec:
                 - --config
                 - /etc/config/kratos.yaml
               env:
-              {{- if not (empty ( include "kratos.dsn" . )) }}
+              {{- if not ( include "kratos.dsn" . ) }}
                 - name: DSN
                   valueFrom:
                     secretKeyRef:
diff --git a/helm/charts/kratos/templates/deployment-kratos.yaml b/helm/charts/kratos/templates/deployment-kratos.yaml
index 92d683995..cdf04966a 100644
--- a/helm/charts/kratos/templates/deployment-kratos.yaml
+++ b/helm/charts/kratos/templates/deployment-kratos.yaml
@@ -78,7 +78,7 @@ spec:
             {{- toYaml . | nindent 12 }}
           {{- end }}
           env:
-            {{- if not (empty ( include "kratos.dsn" . )) }}
+            {{- if not ( include "kratos.dsn" . ) }}
             - name: DSN
               valueFrom:
                 secretKeyRef:
@@ -148,7 +148,7 @@ spec:
             {{- end }}
             {{- end }}
           env:
-            {{- if not (empty ( include "kratos.dsn" . )) }}
+            {{- if not ( include "kratos.dsn" . ) }}
             - name: DSN
               valueFrom:
                 secretKeyRef:
diff --git a/helm/charts/kratos/templates/job-migration.yaml b/helm/charts/kratos/templates/job-migration.yaml
index 92fd2974b..b204196c3 100644
--- a/helm/charts/kratos/templates/job-migration.yaml
+++ b/helm/charts/kratos/templates/job-migration.yaml
@@ -60,7 +60,7 @@ spec:
         args: ["migrate", "sql", "-e", "--yes", "--config", "/etc/config/kratos.yaml"]
         {{- end }}
         env:
-          {{- if not (empty ( include "kratos.dsn" . )) }}
+          {{- if not ( include "kratos.dsn" . ) }}
           - name: DSN
             valueFrom:
               secretKeyRef:
diff --git a/helm/charts/kratos/templates/statefulset-mail.yaml b/helm/charts/kratos/templates/statefulset-mail.yaml
index b62c5e749..c3d5cc558 100644
--- a/helm/charts/kratos/templates/statefulset-mail.yaml
+++ b/helm/charts/kratos/templates/statefulset-mail.yaml
@@ -85,7 +85,7 @@ spec:
               value: {{ .Values.statefulSet.log.format }}
             - name: LOG_LEVEL
               value: {{ .Values.statefulSet.log.level }}
-            {{- if not (empty ( include "kratos.dsn" . )) }}
+            {{- if not ( include "kratos.dsn" . ) }}
             - name: DSN
               valueFrom:
                 secretKeyRef: