Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hydra-maester.adminService.port empty value is passed into child chart, causes error. #675

Merged
merged 1 commit into from
May 9, 2024

Conversation

alangilmor
Copy link
Contributor

Helm chart 0.41.0 requires commenting out the hydra-maester.adminService.port value.

Test:

helm template ory/hydra (port empty in maester Deployment args)

helm template ory/hydra --set hydra-maester.adminService.port=null (child chart's default respected when "unset" in parent chart)

@CLAassistant
Copy link

CLAassistant commented Apr 25, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor Author

@alangilmor alangilmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi apologies if the PR is not conform to standards. Just trying to use the chart and had a failure out-of-the-box. Adjust as needed.

Copy link
Collaborator

@Demonsthere Demonsthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! Sorry for the long delay 😞
I have checked the code, and I think we can merge this as is, the issue was the the value in hydra chart in fact did override the value in the subchart, which caused the error

@Demonsthere Demonsthere merged commit d606ceb into ory:master May 9, 2024
16 checks passed
@alangilmor alangilmor deleted the fix-chart-port-empty branch May 9, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants