Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MFA screen includes OIDC buttons #4278

Open
3 of 5 tasks
jonas-jonas opened this issue Jan 27, 2025 · 2 comments
Open
3 of 5 tasks

MFA screen includes OIDC buttons #4278

jonas-jonas opened this issue Jan 27, 2025 · 2 comments
Assignees
Labels
bug Something is not working.

Comments

@jonas-jonas
Copy link
Member

Preflight checklist

Ory Network Project

No response

Describe the bug

When configuring both MFA via code and OIDC, the MFA login flow contains UI nodes for the OIDC buttons. Since Kratos' OIDC strategy does not support carrying over the MFA status from a third party OIDC provider, there is no reason for the OIDC button to be there.

Reproducing the bug

  1. enable code for mfa and atleast one oidc provider
  2. set session.aal_required to highest_available
  3. obtain a session
  4. see the MFA screen with both the code button and the OIDC button

Image

Relevant log output

Relevant configuration

Version

master

On which operating system are you observing this issue?

None

In which environment are you deploying?

None

Additional Context

No response

@jonas-jonas jonas-jonas added the bug Something is not working. label Jan 27, 2025
@aeneasr
Copy link
Member

aeneasr commented Jan 29, 2025

Is this with identifier first or without?

@aeneasr
Copy link
Member

aeneasr commented Jan 29, 2025

Pretty sure this is a bug in the oidc strategy, specifically here:

https://github.com/ory-corp/cloud/blob/9c6693502d530ae1dd081248b462d8f4a1efb356/kratos/kratos/internal/b2bsso/strategy_login.go#L39-L47

I wasn't aware that the b2b sso strategy completely replaces the kratos native oidc strategy. To fix this, firstfactor should only be populated when b2b sso is enabled + tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working.
Projects
None yet
Development

No branches or pull requests

3 participants