Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly fix patching /credentials sub-paths #4279

Open
hperl opened this issue Jan 28, 2025 · 0 comments
Open

properly fix patching /credentials sub-paths #4279

hperl opened this issue Jan 28, 2025 · 0 comments

Comments

@hperl
Copy link
Contributor

hperl commented Jan 28, 2025

Ideally, for both create, patch, and PUT operations, the following should be implemented with proper
validation:

  1. Passwords:

    • Set or change passwords (with validation ensuring the hash or plaintext password is correct).
    • Delete passwords.
  2. OIDC:

    • Set or change OIDC subject and provider.
    • Delete OIDC subject and provider.
  3. WebAuthn and Passkey Credentials:

    • Set, change, or delete WebAuthn and passkey credentials (e.g., to import passkey users).
  4. Code Credentials:

    • Activate or deactivate code credentials.
  5. TOTP:

    • Set, change, or delete TOTP configurations.
  6. Lookup Secrets:

    • Set, change, or delete lookup secrets.

Restrictions:
What should not be allowed is:

  • Adding arbitrary keys to the config object.
  • Changing identifiers that are typically set by the system.
  • Modifying keys that should only be set by the system.

Originally posted by @aeneasr in #4277 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant