-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure browser redirects per custom domain #374
Comments
Hey Brandon, I think that makes sense! Currently, multi-domain system is making it complicated to do what you're asking. We have it on the backlog to improve this architecture which would allow changes like the one you mentioned. Unfortunately, that's not going to happen soon as it's a quite complicated process to ensure there are no breaking changes. |
No rush @aeneasr, it is not an urgent request. But I had noticed the limitation and wanted to jot it down. |
Hello contributors! I am marking this issue as stale as it has not received any engagement from the community or maintainers for a year. That does not imply that the issue has no merit! If you feel strongly about this issue
Throughout its lifetime, Ory has received over 10.000 issues and PRs. To sustain that growth, we need to prioritize and focus on issues that are important to the community. A good indication of importance, and thus priority, is activity on a topic. Unfortunately, burnout has become a topic of concern amongst open-source projects. It can lead to severe personal and health issues as well as opening catastrophic attack vectors. The motivation for this automation is to help prioritize issues in the backlog and not ignore, reject, or belittle anyone. If this issue was marked as stale erroneously you can exempt it by adding the Thank you for your understanding and to anyone who participated in the conversation! And as written above, please do participate in the conversation if this topic is important to you! Thank you 🙏✌️ |
Wanted to let you know that work is underway which would allow to have configs per domain for multi domain projects. It’s still quite a lot of work but we have it on the radar |
Preflight checklist
Ory Network Project
dazzling-chandrasekhar-msru5m4b1c
Describe your problem
On the Account Experience > Browser redirects page, you can configure the redirect settings for your Ory project.
There are no issues if you use the default project URL or only have a single custom domain.
But if you have multiple custom domains, then configuring the redirects may be problematic.
Path values are limited since, if the redirect value is a path instead of a full URL, the path is relative to the project URL and not the Custom UI base URL. Since you can't host pages under the project URL (even with a custom domain), you'll likely need to set the redirect value using a full URL. But if you have multiple custom domains, then the full URL may not work with all of the custom domains.
Describe your ideal solution
Similar to the Account Experience > UI URLs page where you set the Custom UI Base URL and flow UI values separately for each custom domain, you should be able to set the redirects separately for each custom domain. Or at least be able to set a custom base URL for each custom domain, and then path redirect values should be relative to the base URL.
Workarounds or alternatives
Right now I am setting a
return_to
value in my code when there isn't already one specified, which can be dynamic based on where the code is runningVersion
Ory Network
Additional Context
No response
The text was updated successfully, but these errors were encountered: