bib: switch to use bootc install to-filesystem (HMS-3453) #342
Conversation
mvo5
force-pushed
the
switch-to-bootc-install-to-fs-2
branch
2 times, most recently
from
ce93df7
to
4b7ff47
Compare
mvo5
force-pushed
the
switch-to-bootc-install-to-fs-2
branch
from
4b7ff47
to
5868205
Compare
mvo5
force-pushed
the
switch-to-bootc-install-to-fs-2
branch
from
5868205
to
aeef7e5
Compare
|
Hrm, hrm, this is ready now (including groups) except the cross arch building needs either:
|
mvo5
force-pushed
the
switch-to-bootc-install-to-fs-2
branch
from
f5142fc
to
aeef7e5
Compare
Indeed, sorry that I overlooked this - I reverted this and opened osbuild/images#604 which allows us to make bib a frankenstein to build cross-arch. The bind mount idea is also (briefly) discussed there. |
|
The tests are green now, we should probably still wait until #357 is landed to ensure we do not regress there (I think we will need osbuild/osbuild#1740 and osbuild/images#605). But getting really close - and so is the deadline :( |
|
(let's wait for #357) |
On casual reading `nexp` reads almost like a typo of `next` and it's generally a bit short. Let's make it very explicit instead :)
This reverts commit 99b632c.
This uses the new customization capabilites of the images PR osbuild/images#571
And add a TODO about tweaking the tests in the future.
This is a temporary measure to be able to move to `bootc install to-filesystem` by default. Only for cross arch builds we use the "legacy" pipeline to build an bootc image. This should be removed once either: - containers/bootc#462 or - https://www.mail-archive.com/[email protected]/msg1034508.html are released in the relevant places (centos/rhel).
This includes osbuild/images#605 which will ensure that bib sets the right `--target-imgref` on boot.
We are currently not testing that when the build image has a valid `bootc status` that container the original container reference.
mvo5
force-pushed
the
switch-to-bootc-install-to-fs-2
branch
from
26894e1
to
e4936bf
Compare
|
I updated this now to include #360 and also the latest update in images which brings in osbuild/images#605 - with that and the "legacy" bootc workaround for the cross arch build this should finally be ready. |
|
Hm, the linter is being an idiot again. Let me dig into this a bit. |
|
Ok, I think I fixed it. Probably. |
The Go version in go.mod was updated to 1.20 in cb78e83 but the linter was still on 1.19, which causes _weird_ issues like "unused imports" false positives.
achilleas-k
force-pushed
the
switch-to-bootc-install-to-fs-2
branch
from
7a58516
to
6ee6ae9
Compare
|
Of course, |
[draft as this requires https://github.com/osbuild/images/pull/571 first]
This replaces #304 which did not implement customizations.
With this approach we keep the user customizations we had before (it does drop groups for now mostly because that seems less used and more risky).