Resolve a bunch of issues reported by JET #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #950 +/- ##
=======================================
Coverage 75.70% 75.70%
=======================================
Files 51 51
Lines 4169 4169
=======================================
Hits 3156 3156
Misses 1013 1013
|
src/adapter.jl
Outdated
| join(lines[(end-rows+upper+2):end], "\n") | ||
| stri = join(lines[1:upper], "\n")::String | ||
| stri *= "\n ⋮\n" | ||
| stri *= join(lines[(end-rows+upper+2):end], "\n")::String |
There was a problem hiding this comment.
I do not understand why the old code was problematic:
Doesn't the documentation of join say that a String is returned?
There was a problem hiding this comment.
I've dropped this for now until I understand it properly.
| @@ -254,7 +254,7 @@ function BitVector(obj::GapObj) | |||
| !Wrappers.IsBlist(obj) && throw(ConversionError(obj, BitVector)) | |||
| # TODO: a much better conversion would be possible, at least if `obj` is | |||
| # in IsBlistRep, then we could essentially memcpy data | |||
| len = Wrappers.Length(obj) | |||
| len = Wrappers.Length(obj)::Int | |||
There was a problem hiding this comment.
Ah, I have learned something:
Wrappers.Length defines its return type to be just GapInt (for example because there are infinite lists), but here we know more.
Thus it is worth to think about type annotations also for functions defined in Wrappers.
Specifically I used using JET, GAP ; report_package(GAP) There are some remaining warnings; however, those related to `Downloads.download` and to `REPL.REPLCompletions.completions` seem to be issues in those stdlibs, not in our code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically I used
using JET, GAP ; report_package(GAP)
There are some remaining warnings; however, those related to
Downloads.downloadand toREPL.REPLCompletions.completionsseem to be issues in those stdlibs, not in our code.