Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TAB completion for e.g. 'GAP.Globals.MTX.S' in Julia >= 1.11 #969

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

fingolfin
Copy link
Member

@fingolfin fingolfin commented Feb 19, 2024

Resolves #962

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Merging #969 (b7b3c23) into master (fb0520e) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #969   +/-   ##
=======================================
  Coverage   75.83%   75.83%           
=======================================
  Files          51       51           
  Lines        4183     4183           
=======================================
  Hits         3172     3172           
  Misses       1011     1011           
Files Coverage Δ
src/ccalls.jl 99.19% <100.00%> (ø)

@fingolfin fingolfin force-pushed the mh/repl-tab-completion branch from eb2404f to a9522bc Compare February 22, 2024 13:07
@fingolfin fingolfin marked this pull request as ready for review February 22, 2024 13:07
@fingolfin fingolfin force-pushed the mh/repl-tab-completion branch from a9522bc to b7b3c23 Compare February 22, 2024 13:12
Copy link
Member

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, apparently the hint by @aviatesk works.
(The failure with Julia nightly is due to the fact that 1.12 is not yet supported by GAP.jl.)

@fingolfin fingolfin enabled auto-merge (squash) February 22, 2024 13:52
@fingolfin fingolfin disabled auto-merge February 23, 2024 08:51
@fingolfin fingolfin merged commit 355d751 into oscar-system:master Feb 23, 2024
11 of 14 checks passed
@fingolfin fingolfin deleted the mh/repl-tab-completion branch February 23, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REPL completions again broken in Julia nightly
2 participants