Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add refs for all tables #217

Merged
merged 10 commits into from
Oct 18, 2024
Merged

Add refs for all tables #217

merged 10 commits into from
Oct 18, 2024

Conversation

SoongNoonien
Copy link
Member

These are just the references for the character tables. The Greenfunction tables are still missing.

@SoongNoonien SoongNoonien linked an issue Oct 9, 2024 that may be closed by this pull request
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.99%. Comparing base (22c6dde) to head (a68fb48).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #217      +/-   ##
==========================================
+ Coverage   95.80%   95.99%   +0.19%     
==========================================
  Files          13       13              
  Lines         786      849      +63     
==========================================
+ Hits          753      815      +62     
- Misses         33       34       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SoongNoonien SoongNoonien changed the title Add refs for all character tables Add refs for all tables Oct 11, 2024
docs/src/refs.bib Outdated Show resolved Hide resolved
docs/src/refs.bib Outdated Show resolved Hide resolved
docs/src/refs.bib Outdated Show resolved Hide resolved
docs/src/refs.bib Outdated Show resolved Hide resolved
docs/src/refs.bib Outdated Show resolved Hide resolved
docs/src/refs.bib Outdated Show resolved Hide resolved
docs/src/refs.bib Outdated Show resolved Hide resolved
docs/src/refs.bib Outdated Show resolved Hide resolved
docs/src/refs.bib Outdated Show resolved Hide resolved
docs/src/refs.bib Outdated Show resolved Hide resolved
docs/src/refs.bib Outdated Show resolved Hide resolved
docs/src/refs.bib Outdated Show resolved Hide resolved
docs/src/refs.bib Outdated Show resolved Hide resolved
publisher = {Aachen: Techn. Hochsch. Aachen, Mathematisch-Naturwiss. Fakult{\"a}t},
year = {1990},
language = {German},
zbmath = {51240}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could at least link to https://publications.rwth-aachen.de/record/821447

And then we could have a note or so which says "See also ..." and points to https://link.springer.com/chapter/10.1007/978-3-0348-8658-1_17 (and we should add that to the bib, too -- at the bottom of the page there is citation info, or perhaps zbmath or mathscinet has it, too)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And then we could have a note or so which says "See also ..." and points to https://link.springer.com/chapter/10.1007/978-3-0348-8658-1_17 (and we should add that to the bib, too -- at the bottom of the page there is citation info, or perhaps zbmath or mathscinet has it, too)

I'm sorry, I don't get it. Where could we add a note about what? Something like:

Suggested change
zbmath = {51240}
zbmath = {51240},
note = {See also: https://link.springer.com/chapter/10.1007/978-3-0348-8658-1_17}

@SoongNoonien SoongNoonien marked this pull request as ready for review October 15, 2024 19:34
@fingolfin fingolfin merged commit 33a518d into oscar-system:master Oct 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collect bibliography
2 participants