Optimize computation of least common denominator

[fingolfin]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.93%. Comparing base (833d2c3) to head (441895f).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #241      +/-   ##
==========================================
+ Coverage   95.81%   95.93%   +0.11%     
==========================================
  Files          12       12              
  Lines         836      836              
==========================================
+ Hits          801      802       +1     
+ Misses         35       34       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[fingolfin]

Error with Oscar 1.1: denominator(::AbstractAlgebra.Generic.MPoly{QQFieldElem}) does not exist.

Of course that type of ring should not even be used (it should use QQMPolyRingElem) but that's one of the many things we fixed in Oscar 1.2 (resp. newer AA & Nemo versions). We can probably workaround it by adding a suitable such method when detecting it is needed.

[SoongNoonien]

We can probably workaround it by adding a suitable such method when detecting it is needed.

Can we detect this by checking for a specific AA version? Since we already have a check for the AA version this could be the easiest way.

[fingolfin]

It may depend on the version of AA and Nemo, dunno. I think the easiest would be to check the version of Oscar? if pkgversion(Oscar) < v"1.2" ... ?