Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use some unsave operators #244

Closed
wants to merge 1 commit into from

Conversation

SoongNoonien
Copy link
Member

With the test for 3D4.0 from #238 current master performs like this:

julia> @time scalar_test(g)
 71.137125 seconds (233.27 M allocations: 24.491 GiB, 12.05% gc time)

And this PR:

julia> @time scalar_test(g)
 66.839489 seconds (231.88 M allocations: 24.387 GiB, 11.68% gc time)

@SoongNoonien SoongNoonien force-pushed the addmul branch 2 times, most recently from 7805331 to dfa1e90 Compare January 16, 2025 16:35
@SoongNoonien
Copy link
Member Author

Ok, after getting the tests to work again the improvement has vanished...

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.21%. Comparing base (72c5311) to head (4b114e5).

Files with missing lines Patch % Lines
src/GenericCyclotomics.jl 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #244      +/-   ##
==========================================
- Coverage   95.93%   95.21%   -0.73%     
==========================================
  Files          12       12              
  Lines         837      836       -1     
==========================================
- Hits          803      796       -7     
- Misses         34       40       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant