Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a little closer look at the expressify system. Apart from the obvious fact that the doctests will still fail I see two other problems. The result of an ordinary scalar product is a
GenericCycloFrac
for technical reasons. This leads to scalar product results like1//1
instead of simply1
. Another problem is that obviously expressions likeexp(0)
are not automatically simplified to1
. So without any manual intervention things like0//exp(0)
will be printed.