Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial expressify test #248

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SoongNoonien
Copy link
Member

I took a little closer look at the expressify system. Apart from the obvious fact that the doctests will still fail I see two other problems. The result of an ordinary scalar product is a GenericCycloFrac for technical reasons. This leads to scalar product results like 1//1 instead of simply 1 . Another problem is that obviously expressions like exp(0) are not automatically simplified to 1. So without any manual intervention things like 0//exp(0) will be printed.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.75%. Comparing base (4f3c27c) to head (d3f408a).

Files with missing lines Patch % Lines
src/GenericCyclotomicFractions.jl 0.00% 2 Missing ⚠️
src/GenericCyclotomics.jl 66.66% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (4f3c27c) and HEAD (d3f408a). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (4f3c27c) HEAD (d3f408a)
11 8
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #248       +/-   ##
===========================================
- Coverage   95.98%   68.75%   -27.24%     
===========================================
  Files          12       12               
  Lines         846      816       -30     
===========================================
- Hits          812      561      -251     
- Misses         34      255      +221     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant