-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly detect redundant parameter exceptions #54
Comments
Also it might be worth reconsidering if a set is really the best data structure to store the exceptions. We need to compare the exceptions pairwise anyway to decide if they imply one another. |
With #155 the situation here improves. At least for all pairs of exceptions all cancellation should now be detected. But there are still exceptions which are never an integer but aren't irgnored. For example |
Can we address this similar to what I describe in #177 ? I.e. Then finally, kill anything of the form That said, my instinct would be to close this for now as resolved, and open a new issue for concrete instances as they crop up. Most likely working towards the long-term vision outlined in #28 will yield more relevant examples |
As it has been seen in #51 there are places in the code where parameter exceptions are only returned after a (possibly partial) check for redundancy. It would be much better if there were a nicely documented function which decides if a parameter exception is redundant. And by redundant I mean if it isn't possibly for the exception to apply, so for example an exception
1//2+i ∈ ℤ
can safely be ignored.But it is worth noting that
1//2+i ∈ ℤ
shouldn't occur in the first place as we usually deal with "reduced" polynomials where reduced means without integral part.The text was updated successfully, but these errors were encountered: