Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an options page so that we can disable functionality for some pages/sites #11

Open
chrisuehlinger opened this issue Jul 11, 2017 · 1 comment

Comments

@chrisuehlinger
Copy link

I love this extension for its simplicity, but I've been having a problem recently: When editing text in textareas in Visual Studio Team Services, using Backspace to delete a character now causes me to leave the page I'm on.

It'd be awesome if there was an options page where I can specify a regex blacklist of pages (or even just a list of domains) to not hit with this extension, then have the extension check the URL of the page on load.

I've done work like this before with Chrome extensions, and I'd be down to do the dev work myself, but before I do I just want to make sure you'd be willing to accept a PR.

@oslego
Copy link
Owner

oslego commented Jul 12, 2017

Hi, Chris!

Yes, the option to disable the extension for specific pages is the most requested feature. I wanted to work on this, but never got to it.

I'd be happy to review and accept a PR that adds this. But bear in mind that the code for this extension is intentionally simple. The extension relies on user trust because it requires sensitive permissions (read/write on all pages). I want people to be able to quickly glance over it and convince themselves that it's not malicious.

For that reason, I'd be more inclined to a simple blocking solution per-URL or per-domain, like AdBlock's "Don't run on this page/domain", as opposed to user-supplied RegEx which introduces its own set of complexity (CRUD interface, validation, etc).

Also, this blocking mechanism will be hit on every page load so it has to be fast and not slow down pages in a perceivable way.

What sort of solution architecture do you have in mind?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants