Skip to content
This repository has been archived by the owner on Oct 30, 2020. It is now read-only.

Sphinx: drop attributes for skills, instead show icon on result to indicate flyability #179

Open
Artefact2 opened this issue Jan 15, 2017 · 0 comments

Comments

@Artefact2
Copy link
Member

One Sphinx attribute per skill is terrible design.

Not only is it very memory hungry (and we're starting to see the effects on Tetroxide), it requires a full reindex after each patch (because they usually add new skills).

Another solution instead is to either

  1. Store a list of required skills in ONE Sphinx attribute (not sure if it will reduce the memory usage by a lot)
  2. Don't store skills in Sphinx, instead cache required skills in formatLoadoutGridLayout() (with pehaps a custom attribute, and add a hook to see if current character, as of rendering time, can fly it or not).
@Artefact2 Artefact2 added this to the v0.14.0 milestone Jan 15, 2017
@Artefact2 Artefact2 added the easy label Jan 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant