Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require HrpIbcRecords to not contain the NativeHrp #15

Open
ChristianBorst opened this issue Feb 23, 2022 · 0 comments
Open

Require HrpIbcRecords to not contain the NativeHrp #15

ChristianBorst opened this issue Feb 23, 2022 · 0 comments

Comments

@ChristianBorst
Copy link

It is my understanding the following situation is possible:
0. Osmosis mainnet has incorporated bech32ibc with "osmo" as the NativeHrp

  1. A governance vote initiates and miraculously passes to add a HrpIbcRecord with Hrp = "osmo"
  2. MsgSends are unaffected due to the bech32ics20 msg_server handling native transfers with the default bank handler

There are a couple avenues by which a chain could accept a confusing HrpIbcRecord containing the NativeHrp. It is important to note that the bech32ics20 current msg_server implementation would not allow an IBC transfer from the NativeHrp so this is not a critical issue.

However, the HrpIbcRecordProposalHandler should automatically fail any such proposal containing the NativeHrp to cancel any bad votes, and setHrpIbcRecord() should fail to store any such invalid proposal. The change to setHrpIbcRecord() would also cover the InitGenesis() path to this confusing state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant