-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split buoy_msgs to pure messages and buoy API #21
Comments
So, I was already thinking about splitting to _py and _cpp What do you think about this structure? (omitting the common files like CMakeLists.txt) +-- buoy_interfaces (standard ros2 naming for a package with only messages) |__ +-- msg |__ +-- srv +-- buoy_api_py |__ +-- examples (move python buoy_examples here) |__ +-- buoy_api (the python interface.py package) +-- buoy_api_cpp |__ +-- examples (move cpp buoy_examples here) |__ +-- include | |__ +-- buoy_api (with interface.hpp) |__ +-- src |
I like the new structure! I assume all packages will still live in this repo, right? |
Yeah, I think so. would we need/want a meta package for |
We could add one, those are cheap. |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Ouch I think we'll need to split this package (ros2/ros2_documentation#2882):
Calling
rosidl_generate_interfaces
andament_python_install_package
in the same CMake project does not work.See this Github issue for more info. It is best practice to instead
separate out the message generation into a separate package.
Originally posted by @chapulina in #20 (comment)
The text was updated successfully, but these errors were encountered: