Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The current page is not highlighted #24

Closed
elhmn opened this issue Apr 11, 2022 · 3 comments · Fixed by #34
Closed

The current page is not highlighted #24

elhmn opened this issue Apr 11, 2022 · 3 comments · Fixed by #34
Assignees
Labels
5 Yotas will provide you 5 yotas

Comments

@elhmn
Copy link
Member

elhmn commented Apr 11, 2022

When a user is on page N the pagination does not highlight page N.

We could add a background color to the Nth page button.

Kapture.2022-04-11.at.10.11.51.mp4
@elhmn elhmn added the 5 Yotas will provide you 5 yotas label Apr 11, 2022
@Blanco237
Copy link

Has this issue been solved, considering someone was assigned to it on the 24th of April...

@sikatikenmogne
Copy link
Contributor

Hi @elhmn,

I’m a new contributor from the OSSCameroon group chat and came across this issue via the OSSCameroon bot on Telegram.

I’ve been working on a potential solution and have a branch with the changes. You can check it out here: https://github.com/sikatikenmogne/miniyotas/tree/feat/add-highlightning-on-pagination.

In this branch, I’ve added a background color to the current page button to make it more noticeable and fix an error about yarn dev on windows. I’d appreciate any feedback on this approach and would like to know if it’s okay to create a pull request with these changes.

Looking forward to your feedback!

Best,

@rakici
Copy link
Contributor

rakici commented Aug 22, 2024

Handled by #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 Yotas will provide you 5 yotas
Projects
None yet
5 participants