Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor matplotlib figure tests for lab 4 #52

Open
agoscinski opened this issue Jul 3, 2024 · 0 comments
Open

Refactor matplotlib figure tests for lab 4 #52

agoscinski opened this issue Jul 3, 2024 · 0 comments

Comments

@agoscinski
Copy link
Collaborator

In #45 I disabled the matplotlib figure tests, because they assume that the whole notebook is loaded, but due to issue #50 we cannot load all matplotlib figure like it is currently done. For now the tests are disabled for lab 4, but the figures have to be loaded by scrolling through the notebook. This needs just some extra logic, but is not that much work. To speed the lab 4 integration however I put this as a task for later.

agoscinski added a commit that referenced this issue Jul 3, 2024
The matplotlib test loads all figures at once, but for lab they have to
be loaded and tested when in view. We disable this test for lab 4 and
put this as task for later. See issue #52.
agoscinski added a commit that referenced this issue Jul 3, 2024
The matplotlib test loads all figures at once, but for lab they have to
be loaded and tested when in view. We disable this test for lab 4 and
put this as task for later. See issue #52.
agoscinski added a commit that referenced this issue Jul 3, 2024
The matplotlib test loads all figures at once, but for lab they have to
be loaded and tested when in view. We disable this test for lab 4 and
put this as task for later. See issue #52.
agoscinski added a commit that referenced this issue Jul 4, 2024
The matplotlib test loads all figures at once, but for lab they have to
be loaded and tested when in view. We disable this test for lab 4 and
put this as task for later. See issue #52.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant