Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an error if scale_cost!=1.0 in geometry.Geodesic #480

Open
MUCDK opened this issue Dec 20, 2023 · 2 comments
Open

Throw an error if scale_cost!=1.0 in geometry.Geodesic #480

MUCDK opened this issue Dec 20, 2023 · 2 comments

Comments

@MUCDK
Copy link
Contributor

MUCDK commented Dec 20, 2023

Is your feature request related to a problem? Please describe.
In Geodesic, the scale_cost argument has no effect.

Describe the solution you'd like
To prevent misunderstandings, I suggest to throw an error if scale_cost!=1.0 in geometry.Geodesic.from_graph.

Describe alternatives you've considered
None

Additional context
None

@michalk8
Copy link
Collaborator

This can be a bit problematic, since scale_cost could also be traced, so we cannot throw an error at compile-time and I don't wanna introduce runtime value checks, unless necessary.
The cleanest way would be to:

  1. pass scale_cost=1.0 always to the parent as kwargs['scale_cost'] = 1.0
  2. refactor the geometry and removing scale_cost altogether from Geodesic

The 1st is easily doable, wanna take a stab at it @MUCDK ? Ultimately, I want to do 2., but it will take much longer.

@MUCDK
Copy link
Contributor Author

MUCDK commented Jan 12, 2024

I can do it, but would would prioitize #468 for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants