Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: warnings not shown before stdin interaction #745

Merged
merged 1 commit into from
Nov 18, 2024
Merged

fix: warnings not shown before stdin interaction #745

merged 1 commit into from
Nov 18, 2024

Conversation

marcospb19
Copy link
Member

No description provided.

@marcospb19
Copy link
Member Author

cc @AntoniosBarotsis this log wasn't being shown before the STDIN question:

ouch/src/check.rs

Lines 38 to 45 in c18c6c8

info_accessible(format!(
"Detected file: `{}` extension as `{}`",
path.display(),
detected_format
));
if user_wants_to_continue(path, question_policy, QuestionAction::Decompression)? {
formats.push(detected_format);

that's something we missed

@marcospb19 marcospb19 merged commit 5b78b96 into main Nov 18, 2024
14 of 15 checks passed
@marcospb19 marcospb19 deleted the fix-warnings-not-being-shown-before-stdin-interaction branch November 18, 2024 02:47
marcospb19
marcospb19 commented Nov 18, 2024
View reviewed changes
src/utils/logger.rs
Message::Flush { finished_barrier } => {
flush_logs_to_stderr(&mut buffer);
finished_barrier.wait();
break;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops this "break" shouldn't be here

#748

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marcospb19