From d73079865ebadd961d7af81b235bb34747f7cb6a Mon Sep 17 00:00:00 2001 From: kairenw <44489146+kairenw@users.noreply.github.com> Date: Mon, 3 Apr 2023 13:10:26 -0700 Subject: [PATCH] FW 2.5 Release tweaks (#503) * help message for simple-viz * disable fps warning --- ouster_client/src/client.cpp | 4 ++-- ouster_client/src/types.cpp | 3 ++- python/src/ouster/sdk/simple_viz.py | 5 +++-- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/ouster_client/src/client.cpp b/ouster_client/src/client.cpp index 091b7d5d..c92820b0 100644 --- a/ouster_client/src/client.cpp +++ b/ouster_client/src/client.cpp @@ -413,8 +413,8 @@ bool init_logger(const std::string& log_level, const std::string& log_file_path, std::shared_ptr init_client(const std::string& hostname, int lidar_port, int imu_port) { - logger().info("initializing sensor: {} with ports: {}/{}", hostname, - lidar_port, imu_port); + logger().info("initializing sensor: {} with lidar port/imu port: {}/{}", + hostname, lidar_port, imu_port); auto cli = std::make_shared(); cli->hostname = hostname; diff --git a/ouster_client/src/types.cpp b/ouster_client/src/types.cpp index 947b7c07..a26cfe92 100644 --- a/ouster_client/src/types.cpp +++ b/ouster_client/src/types.cpp @@ -783,7 +783,8 @@ static data_format parse_data_format(const Json::Value& root) { if (root.isMember("fps")) { format.fps = root["fps"].asInt(); } else { - logger().warn("No fps found. Trying to use one from lidar mode (or 0)"); + // logger().warn("No fps found. Trying to use one from lidar mode (or + // 0)"); format.fps = 0; } diff --git a/python/src/ouster/sdk/simple_viz.py b/python/src/ouster/sdk/simple_viz.py index 030d37a8..76c6c7ea 100644 --- a/python/src/ouster/sdk/simple_viz.py +++ b/python/src/ouster/sdk/simple_viz.py @@ -24,11 +24,12 @@ def main() -> None: group.add_argument('--sensor', metavar='HOST', help='sensor hostname') group.add_argument('--pcap', metavar='PATH', help='path to pcap file') parser.add_argument('--meta', metavar='PATH', help='path to metadata json') - parser.add_argument('--lidar-port', type=int, help='lidar port for sensor') + parser.add_argument('--lidar-port', type=int, + help='configure sensor to use specified port for lidar data if running against sensor') parser.add_argument('-x', '--no-auto-dest', action='store_true', - help='do not auto configure udp destination') + help='do not auto configure udp destination if running against sensor') parser.add_argument('--extrinsics', metavar="F", type=float,