Introduce InspectorLifecycleAgent and InspectorTestReporterAgent #15194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ @Jarred-Sumner, your commit f46e3f6 has 1 failures in test/cli/run/require-cache.test.ts - 1 failing on 🪟 x64 |
alii
reviewed
Nov 19, 2024
| for (size_t i = 0; i < exception.stack.frames_len; i++) { | ||
| ZigStackFrame* frame = &exception.stack.frames_ptr[i]; | ||
| lineColumns->addItem(frame->position.line_zero_based + 1); | ||
| lineColumns->addItem(frame->position.column_zero_based + 1); |
There was a problem hiding this comment.
Suggested change
| lineColumns->addItem(frame->position.column_zero_based + 1); | |
| lineColumns->addItem(frame->position.column_zero_based + 1); | |
| urls->addItem(frame->source_url.toWTFString()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds two new APIs to the WebKit Inspector Protocol when used in Bun.
This lets you implement a test reporter on top of the WebKit inspector protocol. This also unlocks reporting runtime errors in editor diagnostic APIs without the debugger attached.
The API will change a little more before this merges. The diagnostics need to already be stacktraced since the client may not have the debugger connected.
How did you verify your code works?
This will need some tests before it merges.