Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove recursion in bun shell interpreter to fix stack overflow #15323

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

Remove recursion in bun shell interpreter to fix stack overflow #15323

wants to merge 21 commits into from
+662 −315

Commits on Nov 19, 2024

  1. add failing test

    @pfgithub
    pfgithub committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    eb15e13 View commit details
    Browse the repository at this point in the history

  2. don't initialize something to undefined that gets immediately used ne… 

    …xt loop?
    @pfgithub
    pfgithub committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    a06d678 View commit details
    Browse the repository at this point in the history

  3. add more failing tests

    @pfgithub
    pfgithub committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    128038d View commit details
    Browse the repository at this point in the history

  4. needsEscape(utf16,ascii) -> single unified needsEscape

    @pfgithub
    pfgithub committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    cc9b371 View commit details
    Browse the repository at this point in the history

  5. fix \b__bunstr_0 reading the next number too even though it was unrel… 

    …ated. fix some errors writing to the str pool, returning their memory, and then invalidating it. fix an error panicing.
    @pfgithub
    pfgithub committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    19ceb43 View commit details
    Browse the repository at this point in the history

  6. another test

    @pfgithub
    pfgithub committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    55a554e View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. another test

    @pfgithub
    pfgithub committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    fa3c7cd View commit details
    Browse the repository at this point in the history

  2. another test

    @pfgithub
    pfgithub committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    18f5b75 View commit details
    Browse the repository at this point in the history

  3. redo ~ expansion & fix it

    @pfgithub
    pfgithub committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    0ae03c7 View commit details
    Browse the repository at this point in the history

  4. debug log shell tokens

    @pfgithub
    pfgithub committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    ed31a48 View commit details
    Browse the repository at this point in the history

  5. add failing tests. string is closer to working than substitution but … 

    …neither work
    @pfgithub
    pfgithub committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    1c6c3d9 View commit details
    Browse the repository at this point in the history

  6. remove the ~ '/' / '\\' logic in interpreter.zig as it's now handled … 

    …in shell.zig
    @pfgithub
    pfgithub committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    8f50ca7 View commit details
    Browse the repository at this point in the history

  7. smoe more tests

    @pfgithub
    pfgithub committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    d714937 View commit details
    Browse the repository at this point in the history

  8. debug log bun shell command ast

    @pfgithub
    pfgithub committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    069b963 View commit details
    Browse the repository at this point in the history

  9. debug log the raw string too

    @pfgithub
    pfgithub committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    12465ef View commit details
    Browse the repository at this point in the history

  10. fix '\' handling, still working on ast of "${""}" and ${""} and then … 

    …have to fix execution of ["echo", "", ""]
    @pfgithub
    pfgithub committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    38c41bc View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. the big array doesn't segfault anymore, but there's lots more to convert

    @pfgithub
    pfgithub committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    b43547b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into pfg/issue-15189-3

    @pfgithub
    pfgithub committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    de1ab94 View commit details
    Browse the repository at this point in the history

  3. more conversions to nextexec

    @pfgithub
    pfgithub committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    41ba9f0 View commit details
    Browse the repository at this point in the history

  4. add more tests and mark failing ones as todo

    @pfgithub
    pfgithub committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    8b2b6fa View commit details
    Browse the repository at this point in the history

  5. more unrecursion progress

    @pfgithub
    pfgithub committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    10ae1c4 View commit details
    Browse the repository at this point in the history