cookiecutter-tutor-plugin codebase Python 3.12 upgrade

[DawoudSheraz]

Ensure cookiecutter-tutor-plugin codebase is compatible with Python 3.12

See overhangio/tutor#1004 for the context.

[CodeWithEmad]

This is fixed in MR #29 -> bcfc62d
I'm waiting for your review there.

[DawoudSheraz]

This is fixed in MR #29 -> bcfc62d I'm waiting for your review there.

Got it. But apart from pkg_resources removal, it would be good to see if there are any other items that need an upgrade to Py312. If not, its good.

[CodeWithEmad]

There are no other parts in the cookie-cutter. it was just pkg_resources which is fixed in #29 .

[DawoudSheraz]

There are no other parts in the cookie-cutter. it was just pkg_resources which is fixed in #29 .

Cool. Does this mean a new plugin that is created in Python 3.12 environment will work without any modification in latest tutor master, right?

[CodeWithEmad]

I just tested it with a python:3.12 image and tutor 17.0.2. the plugin was created, installed, and enabled successfully.

Is there any further steps you have in mind?

[regisb]

I think we can close this as completed by #29.

[Danyal-Faheem]

Hi, shouldn't we also update the workflows here for python 3.12 as well?

cookiecutter-tutor-plugin/{{ cookiecutter.package_name }}/.github/workflows/test.yml

Lines 12 to 15 in 5d5241d

	- name: Set up Python 3.8
	uses: actions/setup-python@v2
	with:
	python-version: 3.8

Similar to what is being done in tutor-forum in this PR.

[DawoudSheraz]

Adding to @Danyal-Faheem 's point, it would be good to have both 3.8 and 3.12 workflows until the redwood release. It would ensure the changes being made are compatible with both Python versions.

[CodeWithEmad]

I have no objection to the idea, however, since it is just a cookiecutter and not a genuine plugin, I think we should provide only the essentials and allow the plugin developers to determine which versions they wish to support. I am interested in hearing @regisb's viewpoint on this.

[DawoudSheraz]

@CodeWithEmad Hi, let's add CI checks and then close this out. I don't think there is any more action needed. CI checks are there only for backup that future changes (until Redwood) are compatible with 38 and 312. Thanks

[CodeWithEmad]

Agree. Have a look at #31

[CodeWithEmad]

I think we can close this as completed by #31