Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors are not displayed correctly in extensions tab #113

Closed
mariajgrimaldi opened this issue Dec 6, 2024 · 2 comments
Closed

Errors are not displayed correctly in extensions tab #113

mariajgrimaldi opened this issue Dec 6, 2024 · 2 comments

Comments

@mariajgrimaldi
Copy link

mariajgrimaldi commented Dec 6, 2024

Description

We believe there's a mishandling of error responses somewhere in the theme, which causes the object [Object] to be displayed instead of the response error message.

Expected behavior

As a course author, I want to know the errors in my input when I try to extend individual due dates or reset extensions.

Actual behavior

As a course author, I cannot see the errors in my input when I try to extend individual due dates or reset extensions.

Steps to reproduce

  1. From Studio create a new Subsection.
  2. Configure it with an assignment type for grading and assign a due date.
  3. Go to the LMS > Instructor > Extensions > Individual Due Date Extensions or Resetting Extensions.

Errors are currently not displaying correctly for the following cases:

  1. Specify an email or username that doesn't exist.
  2. Specify an invalid date format.
  3. Do not specify anything.
TC_INSTRUCTOR_8.mp4

Note

The functionality of Individual Due Date Extensions and Resetting Extensions works.

Additional information

In Redwood this is the behavior (without tutor-indigo):

TC_INSTRUCTOR_8_redwood.mp4

Originally reported here: openedx/wg-build-test-release#422

@DawoudSheraz
Copy link
Contributor

@mariajgrimaldi Hi. If I remember correctly from yesterday's meet, Farhan had suggested this might be parsing issue and not theme issue. Indigo is updating styles and not changing any request patterns. We will investigate this but it does not appear to be a theme issue. Were you able to confirm this does not happen locally without indigo enabled?

cc: @hinakhadim

@DawoudSheraz DawoudSheraz moved this from Pending Triage to Backlog in Tutor project management Dec 6, 2024
@mariajgrimaldi
Copy link
Author

mariajgrimaldi commented Dec 6, 2024

@DawoudSheraz: I misunderstood the discussion we had. I'm not familiar with the theme so I'm not sure whether it modifies how errors are rendered.

I haven't had time to work on this, but I'll take a look again considering what you said. I'll look into it next week when I'm back.

I'm sorry for the misunderstanding. Thank you!

@mariajgrimaldi mariajgrimaldi closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Tutor project management Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants