-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coverage reporting not 100% accurate #471
Comments
Code coverage is not working, so it's misleading. See #471.
Actually, coverage information is not accurate. Coveralls is showing 82% coverage on |
Replicated on local machine. Seems to be related to multiple test files running on same thread. Reports 100% coverage on
Reports 85% coverage:
Reports 85% coverage:
So it looks like the coverage from Maybe related to virtual fixture files. |
Now each test file runs in own worker thread. This has largely fixed the problem. However, it's still not quite right. Coverage report is non-sensical in some places e.g.: https://coveralls.io/builds/55534172/source?filename=lib%2Fshared%2Ffunctions.js#L157 This shows some lines in a function as executed, but the following lines not, even though there's no conditional or |
Since switched to jest-light-runner (#470), code coverage reporting is no longer working.
jest-light-runner's docs say it only supports Istanbul, but this would probably be a bad idea as that heavily instruments the code, which Livepack is also doing. Need to find a way to get V8 coverage working again.
The text was updated successfully, but these errors were encountered: