Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't export client.Cache() #181

Open
dave-tucker opened this issue Jun 28, 2021 · 0 comments
Open

Don't export client.Cache() #181

dave-tucker opened this issue Jun 28, 2021 · 0 comments
Labels
bug good first issue

Comments

@dave-tucker
Copy link
Collaborator

Since the client.Get and client.List API do most of the same thing.
This ensures we don't accidentally expose something dangerous (e.g client.Cache().Purge()) to users.
We'd need to ensure that we could still easily write tests without direct cache access though.
@dave-tucker dave-tucker changed the title Consider Not Exporting client.Cache() Don't export client.Cache() Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dave-tucker