Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong height on iPhone 12s except mini #17

Open
ymc-thzi opened this issue Oct 23, 2020 · 8 comments
Open

Wrong height on iPhone 12s except mini #17

ymc-thzi opened this issue Oct 23, 2020 · 8 comments

Comments

@ymc-thzi
Copy link

On the x iPhones all have the value 44.
iPhone 12, iPhone 12 Pro, iPhone 12 Pro Max fails and still have 20
iPhone 12 mini is correct with 44
@ovr
Copy link
Owner

ovr commented Oct 23, 2020

Can you provide a PR for it?

Thanks

@ymc-thzi ymc-thzi changed the title wron height on iPhone 12 Wrong height on iPhone 12s except mini Oct 23, 2020
@JB1905 JB1905 mentioned this issue Oct 31, 2020
Closed
@ganesh-papola
Copy link

any idea how to fix this?

@kamaal111
Copy link

There is a good working solution in this pull request #19

@ovr
Copy link
Owner

ovr commented Nov 9, 2020

Can anyone test the v2.6.0 release? Thanks

@kamaal111
Copy link

Works perfectly, thank you for releasing

@rukmanary
Copy link

Can anyone test the v2.6.0 release? Thanks

That's works for me, thank you 👍

@rukmanary
Copy link

But wait, have anyone check iPhone XR with iOS 14? it is just me or it has slightly different height compare to iPhone XR with iOS 13?

@crazyone33
Copy link

why not use NativeModules.StatusBarManager.getHeight(...) on ios and StatusBar.currentHeight on android ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@ovr @ymc-thzi @ganesh-papola @rukmanary @kamaal111 @crazyone33