You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As discussed by @csanders-git and @bittner on Slack, and related to #1346 and #1420, we're proposing to simplify the repository structure and branching model of all repositories related to ModSecurity CRS.
flatten the branches in the first 2 repos above into a single branch,
placing the content of the branches in folders in that main branch, and
move the maintenance of the owasp/modsecurity-crs Docker image to a dedicated repository.
We also think it's worth to align the naming/wording with other popular free software projects and common best practices.
1. Refactor owasp-modsecurity-crs
Planned tasks:
Create a new folder tests in the root folder
Move util/regression-tests/ -> tests/regression/, and util/integration/ -> tests/integration
Rename folder documentation/ to docs/
Create folder examples/ and move crs-setup.conf.example -> examples/crs-setup.conf
Inside the rules/ folder create a folder for every version of rules, e.g. rules/v3.1/, rules/v3.2/, rules/v3.3/
Switch from branch-based versioning to folder-based versioning, on a single main branch (e.g. master)
2. Refactor modsecurity-docker
Planned tasks:
Switch from branch-based versioning to folder-based versioning, on a single main branch (e.g. master)
Clean up Dockerfile implementations for all supported combinations of ModSecurity and Apache/Nginx versions (inherit from existing, stable images as much as makes sense)
Automate building images for all supported combinations of ModSecurity and Apache/Nginx versions
3. Refactor modsecurity-crs-docker
Planned tasks:
Move the Docker setup from owasp-modsecurity-crs to the new modsecurity-crs-docker repository
Automate building images for all supported CRS versions on the various flavors of the modsecurity-docker images
Final comments
In essence, this is a flattening of the branching model, moving from a version-based branching to a trunk-based branching where the various versions (and technology combinations) are in subdirectories of the repository. The resulting repository structure should make it easier to overview and manage the code base.
A simple example of how this could look like may be appuio/container-oc. Please take a look at the structure and how we try to make updates easy by fully scripting the adaptions across all supported versions.
Please, let us know your thoughts! When we agree on this approach we would attempt doing the refactoring in a very short time frame, so the disruption is minimal and we can avoid any kind of "transition phase".
The text was updated successfully, but these errors were encountered:
As discussed by @csanders-git and @bittner on Slack, and related to #1346 and #1420, we're proposing to simplify the repository structure and branching model of all repositories related to ModSecurity CRS.
In a nutshell, we propose to:
We also think it's worth to align the naming/wording with other popular free software projects and common best practices.
1. Refactor
owasp-modsecurity-crs
Planned tasks:
tests
in the root folderutil/regression-tests/
->tests/regression/
, andutil/integration/
->tests/integration
documentation/
todocs/
examples/
and movecrs-setup.conf.example
->examples/crs-setup.conf
rules/
folder create a folder for every version of rules, e.g.rules/v3.1/
,rules/v3.2/
,rules/v3.3/
master
)2. Refactor
modsecurity-docker
Planned tasks:
master
)3. Refactor
modsecurity-crs-docker
Planned tasks:
modsecurity-crs-docker
repositorymodsecurity-docker
imagesFinal comments
In essence, this is a flattening of the branching model, moving from a version-based branching to a trunk-based branching where the various versions (and technology combinations) are in subdirectories of the repository. The resulting repository structure should make it easier to overview and manage the code base.
A simple example of how this could look like may be appuio/container-oc. Please take a look at the structure and how we try to make updates easy by fully scripting the adaptions across all supported versions.
Please, let us know your thoughts! When we agree on this approach we would attempt doing the refactoring in a very short time frame, so the disruption is minimal and we can avoid any kind of "transition phase".
The text was updated successfully, but these errors were encountered: