user:sync -u is buggy

[voroyam]

If you try to sync a user, that does not exist, the message is the same as if he existed and does not exist anymore. ownCloud asks what to do and you can delete or disable.

How can you remove something that was not there in the first place???

Who tested this new command flag?

[phil-davis]

Also see issue #511 - user:sync of a user that is actually a local user (never came from LDAP in the first place).

We are adding some/more/better acceptance test coverage of user:sync owncloud/core#36597

We will add test scenarios like this, to demonstrate "bad behaviour"

[voroyam]

I would like to know how this was tested before release?

Or do we just release stuff without testing it?

[phil-davis]

Looks -u was introduced in PR owncloud/core#30485 (backport to stable10 owncloud/core#31025 ) in April 2018. So it is not so "new" - been there sine 10.0.8 by the look of it.

Back then we did not have automated test coverage for occ commands. I can't say exactly what scenarios were manually tested at the time (or if it worked then and now has a problem/regression in behaviour). Over time we are expanding automated test coverage. We have recently been adding scenarios for the user:sync command. The automated test scenarios will ensure that regressions do not easily happen.

[voroyam]

I like what you wrote. I would just write "no idea" but that's unprofessional :)

[phil-davis]

PR #517 has added a test scenario that demonstrates this "feature/bug".

When someone adjusts the behavior, they will need to adjust the test scenario also and remove the issue tag.